Commit Graph

20312 Commits

Author SHA1 Message Date
skia-flutter-autoroll
ab3f3d3e98 Roll Skia from d693b4b9fe5e to ab054a88d7c7 (1 revision) (flutter/engine#37743)
https://skia.googlesource.com/skia.git/+log/d693b4b9fe5e..ab054a88d7c7

2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e1ca9c6a1169 to 07bbe62a610d (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-18 11:37:05 +00:00
skia-flutter-autoroll
da09a26cfe Roll Skia from 9d56e506b4df to d693b4b9fe5e (5 revisions) (flutter/engine#37741)
https://skia.googlesource.com/skia.git/+log/9d56e506b4df..d693b4b9fe5e

2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 9f67b1ec8dca to 5f68de3ef7cd
2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 03e69803f4ca to 386ef2eefe63 (7 revisions)
2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dd35c62aef80 to 6a259c87ef52 (1 revision)
2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4d31683e4bbf to 9f67b1ec8dca (2 revisions)
2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ae483daa63a5 to e956a04dafc3 (22 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-18 10:17:14 +00:00
skia-flutter-autoroll
0a041815a2 Roll Skia from 55f654bf5cff to 9d56e506b4df (13 revisions) (flutter/engine#37739)
https://skia.googlesource.com/skia.git/+log/55f654bf5cff..9d56e506b4df

2022-11-18 herb@google.com Remove missplaced attribute
2022-11-18 kjlubick@google.com Reland "[includes] Enforce IWYU on GrCaps"
2022-11-17 johnstiles@google.com Add immediate_i and immediate_u to the RP builder.
2022-11-17 johnstiles@google.com Remove [[unlikely]] attribute.
2022-11-17 herb@google.com Fix Forward: export sk_report_container_overflow_and_die
2022-11-17 brianosman@google.com Revert "Remove legacy shader context support from SkPictureShader"
2022-11-17 borenet@google.com [infra] Add kubeval CIPD package
2022-11-17 johnstiles@google.com Remove FunctionSlots struct and its additional mask field.
2022-11-17 johnstiles@google.com Add a stack for condition masks.
2022-11-17 johnstiles@google.com Revert "[includes] Enforce IWYU on GrCaps"
2022-11-17 johnstiles@google.com Add load_unmasked op.
2022-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f1b1fd3fc034 to e1ca9c6a1169 (7 revisions)
2022-11-17 kjlubick@google.com [includes] Enforce IWYU on GrCaps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-18 05:33:12 +00:00
Chris Yang
6eb43b7697 iOS PlatformView only sets a maskView when necessary (flutter/engine#37434)
* only clip when necessary

tests

fix tests

format

review

fix

add scenario tset

more scenario tests

add docs and comments

use offset.zero

* remove mistakenly checked-in code
2022-11-18 02:43:50 +00:00
Harry Terkelsen
4b1e065fc6 Fix CanvasKit path tests (flutter/engine#37635) 2022-11-17 17:32:49 -08:00
Chris Bracken
861b1223ec [macOS] Cleanup unnecessary references to Metal (flutter/engine#37733)
Removes a few unncessary references to Metal in the macOS embedder. Now
that Metal is the only supported rendering implementation for the macOS
embedder, specifying a class as a Metal variant is redundant.

Issue: https://github.com/flutter/flutter/issues/108304
Issue: https://github.com/flutter/flutter/issues/114445
2022-11-17 17:00:35 -08:00
Chris Bracken
5a3f2e36e7 [macOS] Merge FlutterBackingStore implementations (flutter/engine#37730)
Now that OpenGL support has been removed from the macOS embedder, we
merge FlutterRenderBackingStore and its only implementing subclass,
FlutterMetalRenderBackingStore, and similarly
FlutterRenderBackingStoreProvider and its only implementing subclass
FlutterMetalRenderBackingStoreProvider.

Issue: https://github.com/flutter/flutter/issues/108304
Issue: https://github.com/flutter/flutter/issues/114445
2022-11-17 17:00:16 -08:00
skia-flutter-autoroll
d4225cee8e Roll Fuchsia Linux SDK from JzUXGxIUUNgr8qJUx... to lnmSnyJi-2H07tBnV... (flutter/engine#37729)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-18 00:17:09 +00:00
Jenn Magder
a40764a08d Only run clang-tidy warning checks reported as errors (flutter/engine#36885) 2022-11-18 00:02:03 +00:00
Chris Bracken
b928888b81 [macOS] Eliminate Vulkan hack for macOS < 10.14 (flutter/engine#37498)
Eliminates an undef of VK_USE_PLATFORM_METAL_EXT that works around some
unguarded `@available` checks for macOS 10.13. Our minimum macOS SDK is
now macOS 10.14 so we can safely assume Metal support since it's a
requirement for macOS 10.14.

Issue: https://github.com/flutter/flutter/issues/114445
2022-11-17 14:54:34 -08:00
Jonah Williams
5ff57f33dc Revert "[Impeller] reuse texture if size and type matches (#37527)" (flutter/engine#37727)
This reverts commit 59db03fb47.
2022-11-17 22:41:30 +00:00
Harry Terkelsen
7bdfae0d6b [web] Check for cached browsers on LUCI (flutter/engine#37721) 2022-11-17 14:17:52 -08:00
skia-flutter-autoroll
83c5026b0d Roll Skia from 89f8ba6f749d to 55f654bf5cff (8 revisions) (flutter/engine#37725)
https://skia.googlesource.com/skia.git/+log/89f8ba6f749d..55f654bf5cff

2022-11-17 bsalomon@google.com Last samples from samplecode/ converted to Slides
2022-11-17 herb@google.com Consolidate capacity overflow error message
2022-11-17 jmbetancourt@google.com [jetski] rename androidkit to jetski
2022-11-17 brianosman@google.com Fully remove legacy clamp-to-gamut logic
2022-11-17 fmalita@chromium.org [skottie] Add shaper cluster info
2022-11-17 brianosman@google.com Add more GMs to test new CSS gradients
2022-11-17 brianosman@google.com Remove legacy dither flag
2022-11-17 bsalomon@google.com Take 10 down, convert them to slides, 8 files of samples on the wall

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-17 21:53:47 +00:00
Jason Simmons
0010be93cd Add semantics constants to the exported symbols list for the embedder library (flutter/engine#37526)
Fixes https://github.com/flutter/flutter/issues/114657
2022-11-17 21:50:04 +00:00
Jenn Magder
3085f214f9 Turn on clang tidy error for underscores in Google tests (flutter/engine#37700) 2022-11-17 21:13:11 +00:00
Siva
7296b2b66d Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
* Add calls to Dart_NotifyDestroyed when the flutter view is destroyed.

* Add unit test case.

* Format.

* Ensure the destroy task runs.

* Address code review comments.
2022-11-17 13:11:21 -08:00
alanwutang11
62002a345b delete fontface polyfill (flutter/engine#37652)
* delete fontface polyfill

* removed fonts clear and factory constructor

* addressed comments
2022-11-17 12:38:34 -08:00
skia-flutter-autoroll
20673c06ab Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723)
https://skia.googlesource.com/skia.git/+log/d90917a1da6b..89f8ba6f749d

2022-11-17 michaelludwig@google.com [skif] Remove SkImageFilters::Paint factory
2022-11-17 borenet@google.com [infra] Make kubectl executable in asset
2022-11-17 robertphillips@google.com [graphite] Make Uniform Graphite-only (take 2)
2022-11-17 herb@google.com SkTArray: Remove count().
2022-11-17 robertphillips@google.com [graphite] Add computation of # of combinations to new precompile API
2022-11-17 jamesgk@google.com Test MSAA on intel Xe gpus.
2022-11-17 bungeman@google.com Remove iOS_Graphite_Dawn jobs
2022-11-17 kjlubick@google.com [includes] Enforce IWYU on GrProcessor.h and GrProcessor.cpp
2022-11-17 kjlubick@google.com [bazel] Small modifications for better Vulkan support
2022-11-17 kjlubick@google.com [bazel] Add skia_filegroup as wrapper around filegroup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-17 20:16:22 +00:00
Tong Mu
d3c69d6108 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593)
* Impl

* Format

* TODO comments

* Fix compile

* Better empty indication

* Change invalid ID to -1

* fix doc

* Change to default view

* Better doc

* Update doc of FlutterFrameInfo

* Change to ID

* Address comment

* Fix comment

* To assertion

* Fix compile
2022-11-17 20:11:53 +00:00
Chris Bracken
0b728cbf70 [macOS] Merge FlutterSurfaceManager and impls (flutter/engine#37701)
Previously, FlutterSurfaceManager was a protocol with two concrete
implementations: FlutterGLSurfaceManager and FlutterMetalSurfaceManager.
Most of the implementation was in a shared superclass,
FlutterIOSurfaceManager, which called into the OpenGL or Metal-specific
subclass when backend-specific operations (such as allocating textures)
was required. It did so via a delegate pattern, wherein the subclasses
both implemented the FlutterIOSurfaceManagerDelegate protocol that
exposed the backend-specific functionality.

Now that only the Metal implementation remains, the delegate code can be
inlined into the calling functions, and the class hierarchy can be
squashed into a single concrete implementation class,
FlutterSurfaceManager, similar to how it was originally implemented in
https://github.com/flutter/engine/pull/21525 before we had two backends.

Issue: https://github.com/flutter/flutter/issues/108304
Issue: https://github.com/flutter/flutter/issues/114445
2022-11-17 11:46:27 -08:00
Jim Graham
2252b6f362 Reland layer state stack 2 (flutter/engine#37394)
* Revert "Revert "Reland layer state stack" (#37178)"

This reverts commit 21cc000359.

* fix double-transform rendering issues in #114359

* adjust recently added unit test to state_stack APIs

* introduce LSS delegates to simplify some code and reduce overhead

* Fix ShellTest.OnServiceProtocolEstimateRasterCacheMemoryWorks

* add unit test for tracker.setTransform(4x4) and fix bug

* fix culling issue in LayerTree::Flatten
2022-11-17 19:34:19 +00:00
Brandon DeRosier
c4f6d6871d Revert "[Impeller] Reland: Refactor color source resolution to use explicit factory types (#37677)" (flutter/engine#37720)
This reverts commit 82b8d83fb8.
2022-11-17 19:23:32 +00:00
Chris Bracken
468e714771 [macOS] Consolidate external texture classes (flutter/engine#37703)
Previously, external textures were modelled in the macOS embedder by a
top-level FlutterMacOSExternalTexture protocol with a single textureID
getter, and two implementations: FlutterExternalTextureGL and
FlutterExternalTextureMetal.

With the removal of OpenGL support from the macOS embedder, the only
remaining external texture implementation is Metal. This patch squashes
this set of types into a single FlutterExternalTexture class.

Issue: https://github.com/flutter/flutter/issues/108304
Issue: https://github.com/flutter/flutter/issues/114445
2022-11-17 10:44:01 -08:00
Chris Bracken
aee7b74c33 [macOS] Merge FlutterRenderer and implementation (flutter/engine#37696) 2022-11-17 09:28:40 -08:00
Jonah Williams
700e2178d6 [ui] reland add docs to FragmentShader (flutter/engine#37699) 2022-11-17 17:12:10 +00:00
Kaushik Iska
942eb15bd9 [Impeller] Fix glyph atlas uploads and renders (flutter/engine#37691)
Fixes https://github.com/flutter/flutter/issues/115461
2022-11-17 08:05:23 -05:00
skia-flutter-autoroll
bde4b65932 Roll Skia from 95ac3b53be37 to d90917a1da6b (1 revision) (flutter/engine#37708)
https://skia.googlesource.com/skia.git/+log/95ac3b53be37..d90917a1da6b

2022-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 4d31683e4bbf to 83450cb8d105

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-17 11:21:30 +00:00
skia-flutter-autoroll
ab54276412 Roll Fuchsia Linux SDK from haqxMhaSf7-4ZeVL8... to JzUXGxIUUNgr8qJUx... (flutter/engine#37707)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-17 10:54:09 +00:00
skia-flutter-autoroll
7f62c6e55e Roll Skia from 68784d303cd6 to 95ac3b53be37 (1 revision) (flutter/engine#37706)
https://skia.googlesource.com/skia.git/+log/68784d303cd6..95ac3b53be37

2022-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2809a099b5e5 to f1b1fd3fc034 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-17 09:34:08 +00:00
Brandon DeRosier
020c7d13ea [Impeller] Add Impeller scene (flutter/engine#37694) 2022-11-17 00:28:51 -08:00
skia-flutter-autoroll
ea44ac6826 Roll Skia from 8589c8ac6ee6 to 68784d303cd6 (4 revisions) (flutter/engine#37705)
https://skia.googlesource.com/skia.git/+log/8589c8ac6ee6..68784d303cd6

2022-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2fa255da8c82 to 03e69803f4ca (10 revisions)
2022-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dbdf74996a2c to dd35c62aef80 (1 revision)
2022-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b3e750a1fe2c to 4d31683e4bbf (7 revisions)
2022-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d0353f342bd4 to ae483daa63a5 (22 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-17 07:38:35 +00:00
skia-flutter-autoroll
be1910c4c2 Roll Skia from 7f385b0ae434 to 8589c8ac6ee6 (1 revision) (flutter/engine#37702)
https://skia.googlesource.com/skia.git/+log/7f385b0ae434..8589c8ac6ee6

2022-11-16 johnstiles@google.com Add support for init-lane-masks to SkRasterPipeline.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-17 06:16:52 +00:00
Siva
8c34a481d0 Migrate const_finder tests to be null safe (flutter/engine#37683)
* Bump language version of package:const_finder_fixtures in preparation of
running with sound null safety be default.

* Fix null safety errors.

* Migrate test files to be null safe.

* Fix analyzer warnings.
2022-11-17 03:16:47 +00:00
Harry Terkelsen
a73618b46a Roll Firefox to CIPD with dev/browser_roller.dart (flutter/engine#37692) 2022-11-16 16:55:08 -08:00
skia-flutter-autoroll
463dae01ed Roll Skia from 1dfecd7cd478 to 7f385b0ae434 (9 revisions) (flutter/engine#37693)
https://skia.googlesource.com/skia.git/+log/1dfecd7cd478..7f385b0ae434

2022-11-16 herb@google.com SkSpan: fix initializer-list confusion
2022-11-16 robertphillips@google.com Revert "[graphite] Make Uniform Graphite-only"
2022-11-16 borenet@google.com [infra] Create kubectl asset
2022-11-16 penghuang@chromium.org [graphite] fix compile error for DawnResourceProvider.cpp
2022-11-16 jcgregorio@google.com Upgrade OS version on Sparky360 devices.
2022-11-16 robertphillips@google.com [graphite] Make Uniform Graphite-only
2022-11-16 kjlubick@google.com [includes] Enforce IWYU on even more base files
2022-11-16 kjlubick@google.com [includes] Enforce IWYU on some base files
2022-11-16 kjlubick@google.com [bazel] Support enforcing IWYU on select headers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-17 00:40:04 +00:00
godofredoc
86f91f085f Move windows engine_v2 to prod. (flutter/engine#37680)
Windows engine_v2 are now generating the expected artifacts and ready to
be moved to the production environment.

Bug: https://github.com/flutter/flutter/issues/81855
2022-11-16 23:34:03 +00:00
Kaushik Iska
5d5a04b2b3 Fix potential null-point references (flutter/engine#37678) 2022-11-16 22:08:04 +00:00
yaakovschectman
adc79c3cf3 Add back tooltip to Embedder (flutter/engine#37676)
* Add back tooltip to Embedder

* Test inclusion of tooltip data

* Change to constexpr

* Lint
2022-11-16 17:02:09 -05:00
skia-flutter-autoroll
182555a690 Roll Fuchsia Linux SDK from T7_W8eoMNuMdG-5R9... to haqxMhaSf7-4ZeVL8... (flutter/engine#37684)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-16 21:36:19 +00:00
Michael Ludwig
8191916a47 Use SkImageFilters::Shader instead of ::Paint (flutter/engine#37682)
* Use SkImageFilters::Shader instead of ::Paint

SkImageFilters::Paint() is deprecated and will be removed in https://skia-review.googlesource.com/c/skia/+/604917

* Fix formatting
2022-11-16 12:56:57 -08:00
skia-flutter-autoroll
075b40413a Roll Skia from 74a57221dfb3 to 1dfecd7cd478 (6 revisions) (flutter/engine#37685)
https://skia.googlesource.com/skia.git/+log/74a57221dfb3..1dfecd7cd478

2022-11-16 penghuang@chromium.org [graphite] implement DawnTexture and DawnSampler
2022-11-16 robertphillips@google.com [graphite] Make KeyContext Graphite-only
2022-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c5e93331a728 to 2809a099b5e5 (6 revisions)
2022-11-16 brianosman@google.com Add a debugger script for CodeLLDB visualizers
2022-11-16 brianosman@google.com Change SkParsePath::ToSVGString to just return the string
2022-11-16 johnstiles@google.com Omit frame pointers in SkOpts code.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-16 20:53:23 +00:00
Brandon DeRosier
82b8d83fb8 [Impeller] Reland: Refactor color source resolution to use explicit factory types (flutter/engine#37677)
* [Impeller] Reland: Refactor color source resolution to use explicit factory types
2022-11-16 11:48:40 -08:00
stuartmorgan
7bbe571f14 Fix resize crash in Android virtual display (flutter/engine#37329)
In the Virtual Display codepath for Android platform views, resize
completes asynchronously. Currently it is attempting to access the
Context in the completion handler, but there is no guarantee that it
is still present at that point, leading to possible null pointer
crashes.

This adds a check for the current state of the Context, and uses a
fallback if it's not available.

Fixes https://github.com/flutter/flutter/issues/114095
2022-11-16 19:06:30 +00:00
Josh Gargus
a1255b6105 [fuchsia] Fix shader warmup. (flutter/engine#37662)
Before, ~VulkanSurface() invokes a potentially empty std::function.
Now, checks if it is empty before invoking it.
2022-11-16 13:35:13 -05:00
skia-flutter-autoroll
d2e763ddb6 Roll Skia from 4b3d36f36bf3 to 74a57221dfb3 (7 revisions) (flutter/engine#37675)
https://skia.googlesource.com/skia.git/+log/4b3d36f36bf3..74a57221dfb3

2022-11-16 herb@google.com Move data pointer for move operator=
2022-11-16 brianosman@google.com Reland "Reland "Fix rect-dashing logic""
2022-11-16 bungeman@google.com Use Vulkan as Dawn test context on Android
2022-11-16 johnstiles@google.com Add basic slot tracking to Raster Pipeline code generation.
2022-11-16 robertphillips@google.com Remove stray ';'
2022-11-16 kjlubick@google.com Reland "[bazel] Fix golang cross-compilation on RBE"
2022-11-16 kjlubick@google.com Manually Roll Dawn from c33d10ae79e5 to d0353f342bd4 (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-16 17:57:08 +00:00
Chris Bracken
c26cb23881 [macOS] Merge FlutterMetalCompositor, superclass (flutter/engine#37648)
Now that OpenGL support in Flutter on macOS has been removed, the only
FlutterCompositor implementation is the Metal-based compositor. This
patch merges it into the FlutterCompositor base class since there's no
longer any reason to keep the interface separate from its implementation.

This patch will be followed by similar patches for the renderer, surface
manager, and external textures.

Issue: https://github.com/flutter/flutter/issues/108304
Issue: https://github.com/flutter/flutter/issues/114445
2022-11-16 09:56:22 -08:00
Zachary Anderson
ea2bc64c4b Revert "[Impeller] Refactor color source resolution to use explicit factory types (#37656)" (flutter/engine#37673)
This reverts commit 6bcc31ed0f.
2022-11-16 08:38:43 -08:00
skia-flutter-autoroll
0df6b02789 Roll Skia from 36efebf14ad8 to 4b3d36f36bf3 (1 revision) (flutter/engine#37668)
https://skia.googlesource.com/skia.git/+log/36efebf14ad8..4b3d36f36bf3

2022-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e9b6c3973911 to 2a3eedab7272

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-16 12:40:33 +00:00
Brandon DeRosier
6bcc31ed0f [Impeller] Refactor color source resolution to use explicit factory types (flutter/engine#37656) 2022-11-16 00:54:47 -08:00
skia-flutter-autoroll
1161c9606b Roll Skia from cdf8348e6fba to 36efebf14ad8 (4 revisions) (flutter/engine#37665)
https://skia.googlesource.com/skia.git/+log/cdf8348e6fba..36efebf14ad8

2022-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from afb6ece77e0c to c5e93331a728 (4 revisions)
2022-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 71c1067c73fe to b3e750a1fe2c (2 revisions)
2022-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 85c98a92bb76 to 2fa255da8c82 (12 revisions)
2022-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from aac11f84562f to dbdf74996a2c (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-16 08:04:33 +00:00