Commit Graph

18842 Commits

Author SHA1 Message Date
Todd Volkert
454db9d47c Re-organize flutter_tools code to better support proper layering. (#12957)
* executable.dart#main() depends on runner.dart#run()
* Refactor code such that non-commands don't depend on commands.

No code was actually changed in this PR - code was merely moved from
point A to point B.
2017-11-09 21:45:31 -08:00
Mikkel Nygaard Ravn
177e99b382 Support unpacking platform error events (#12938) 2017-11-09 17:16:48 +01:00
Alexandre Ardhuin
436aa93086 enable lint avoid_classes_with_only_static_members (#12602) 2017-11-09 07:12:36 +01:00
Greg Spencer
3541ad0a64 Add an UnconstrainedBox and factor out debug overflow indicator. (#12856)
UnconstrainedBox will allow its child to size itself as if it had no constraints, and then attempt to fit around that object, until its own constraints are exceeded, in which case it will clip and display an overflow warning.

I also factored out DebugOverflowIndicator, which will draw overflow indicators on containers which overflow but aren't expected to.
2017-11-08 20:15:06 -08:00
Adam Barth
fb86a0338c Document MaterialApp's _errorTextStyle (#12842) 2017-11-08 19:46:51 -08:00
Devon Carew
30ff005456 fix an issue reported by the public_member_api_docs lint (#12889) 2017-11-08 19:05:12 -08:00
xster
152f5258b0 Let RenderSliverFixedExtentBoxAdapter handle disappearing top items (#12919)
* fix with first part of test

* Test without reshifting

* Let sliver fixed extend list also handle disappearing top items.
2017-11-08 17:06:46 -08:00
Ian Hickson
97b3742f63 Automatically flip material icons in RTL. (#12876)
I'm not really sure how to test this without a reference test, since
eventually we want to move this to a font feature and thus the obvious
test (looking for the Transform widget) isn't really valid.
2017-11-08 14:22:14 -08:00
Devon Carew
b6bd628bcd address unused element issues and new warnings (#12890)
* address unused element issues and new warnings

* add a missing return
2017-11-08 14:06:55 -08:00
Alexandre Ardhuin
15601fe55c Enable lint prefer asserts in initializer lists (#12903)
* enable lint prefer_asserts_in_initializer_lists

* enable --assert-initializer
2017-11-08 22:59:49 +01:00
Yegor
a75f003b9c add within matcher for comparing metric-space values (#12908) 2017-11-08 13:36:16 -08:00
Mikkel Nygaard Ravn
b04b89ac95 Clarify documented semantics of StatefulWidget (#12880) 2017-11-08 20:39:05 +01:00
Ulf Sauer
7837fe6ebb Fix duplicate word in documentation (#12874) 2017-11-08 11:24:16 -08:00
Yegor
d4830fcf1b smoke test VM service connection before returning VMService object (#12914) 2017-11-08 10:43:47 -08:00
Hans Muller
c4cdbf86eb Transform Widget alignment is AlignmentGeometry (#12870)
* a => an
2017-11-07 14:43:57 -08:00
Todd Volkert
16c363ac07 Clarify docs in FlutterDriver.requestData() (#12909) 2017-11-07 14:43:41 -08:00
xster
8f79643680 Error message for unregistered phone (#12911) 2017-11-07 13:23:43 -08:00
Ryan Macnak
cc5902b9d8 Fix some tests to be happy with proper microtask scheduling. (#12900)
(I suspect this accounts the sets of microtasks from scheduleWarmUpFrame now running separately.)

Issue https://github.com/flutter/flutter/issues/9998
2017-11-07 09:26:45 -08:00
Sebastiano Poggi
dfd1ffa7c5 Surface elevation shadow colour on Material (#12881)
* Surface shadowColor from RenderPhysicalModel to Material

* Fix typo in material_test

* Add nullability info to documentation

* Add support for animating elevation shadow color

* Add shadowColor to Material's debugFillProperties()

* Add missing default value for elevation in Material debugFillProperties()

* Add missing non-null asserts for animate flags in AnimatedPhysicalModel

* Add test for shadow color animating smoothly
2017-11-06 17:40:13 -08:00
Yegor
91bd9bc4f8 delay taking screenshot to allow GPU thread to render the frame (#12896)
* delay taking screenshot to allow GPU thread to render the frame

* address comments
2017-11-06 17:33:48 -08:00
amirh
700d7b9da6 Typo fix (ImageProvider) (#12887) 2017-11-06 10:55:01 -08:00
Chris Bracken
4e2e69797a Eliminate MethodCall hashCode and equals (#12277)
Since MethodCall equality checks are limited to test scenarios, this
patch replaces them with an equivalent test matcher. At present
MethodCalls are always used in scenarios where indentity-based
equality/hashing is appropriate.

This change avoids an assertion failure when MethodCall args are
Iterable (possible since args are of type dyanmic), and hashValue() from
dart:ui asserts that its input is not an Iterable.

The alternative of implementing support for deep equality in dart:ui was
rejected on the basis that if we're to encourage performant code,
expensive checks should be obviously-expensive to the author.
2017-11-06 09:52:57 -08:00
Mikkel Nygaard Ravn
354ab0ce7b Add missing word in dartdoc for StatelessWidget (#12879) 2017-11-06 17:16:18 +01:00
Ian Hickson
e064d6cbc9 RenderFlex with MainAxisSize.min RTL (#12875)
There was a left-bias when MainAxisSize.min couldn't be honoured.
2017-11-03 17:50:11 -07:00
Ian Hickson
fa6f9a0341 Various documentation improvements (#12855) 2017-11-03 10:55:26 -07:00
xster
c17099f474 Leave a version tag when creating project (#12846)
* Leave a version tag when creating project

* Generalize .version to .metadata
2017-11-03 10:07:57 -07:00
Jason Simmons
b865b0eb2f Use TextPainter.preferredLineHeight to estimate line height for Cupertino selection handles (#12833)
Fixes https://github.com/flutter/flutter/issues/12046
2017-11-03 09:47:46 -07:00
xster
89405002bc Add an iOS style demo to the gallery (#12651)
* Built first tab

* Small additions

* started tab 3

* Need color arithmetics

* tab 2 built

* finalize

* lint and tests

* review

* Reapply docs after rebase

* use color.computeLuminance

* linter

* nit
2017-11-03 08:50:29 -07:00
xster
015c738318 Remove extracted luminance calculations from Material (#12718)
* remove extracted methods

* lint
2017-11-03 06:14:40 -07:00
amirh
616a2ad6da Move semantics stuff from rendering to a top-level semantics/ library (#12793) 2017-11-02 17:38:28 -07:00
Greg Spencer
79862a7262 Fixing assumption that baseStyle is a complete style. (#12836)
This fixes the assumption that InputDecorator had where it expected baseStyle to be a complete style. Now it merges the baseStyle with the subhead style instead of substituting it entirely.

This fixes #12832.
2017-11-02 16:42:02 -07:00
Michael Goderbauer
67ed7807d4 Add new line after "see also" (#12850) 2017-11-02 15:48:10 -07:00
Ian Hickson
c13ed90c87 TextStyle is not an enum (fixes crash with InputDecorator.toString) (#12835) 2017-11-02 12:19:58 -07:00
Ian Hickson
d402d40aa6 Up a timeout to reduce the number of flakes. (#12837) 2017-11-02 12:19:43 -07:00
Michael Goderbauer
1d4607ff04 Identify text fields as such to a11y (#12804)
* Identify text fields as such to a11y

* focus

* make travis happy

* review comments
2017-11-02 10:08:56 -07:00
Mikkel Nygaard Ravn
005a8e4c8e Add backend texture support (eg video, camera) (#12525) 2017-11-02 14:23:28 +01:00
Adam Barth
3914214641 Fix analyzer warnings (#12840) 2017-11-01 22:31:29 -07:00
5u3it
c608e666ad Material scaffold to have simultaneous left-and-right drawers (#12686)
Adds `Scaffold#endDrawer` property to supply a second drawer to a Scaffold.
2017-11-01 21:35:28 -07:00
Greg Spencer
05e10633f2 Adding proper accommodation for textScaleFactor in chips, and StadiumBorder border. (#12533)
In order to allow chips to be properly drawn when they expand in size (without
using IntrinsicHeight), I needed a BoxDecoration shape that would be dependent
upon the rendered height of the widget. This seemed to be pretty generally
useful, so I added a new ShapeDecoration called StadiumBorder. It uses the
minimum dimension to adjust the BorderRadius of a rounded rect in the shape
decoration.

I also converted some uses of BoxShape to be case statements, updated the
chips to use the StadiumBorder decoration, and updated some of the metrics to match
the Material spec, as well as implementing lerping to and from StadiumBorder.
2017-11-01 19:37:02 -07:00
Michael Goderbauer
e023e89b8e Add sample code for describeSemanticsConfiguration (#12830) 2017-11-01 15:49:28 -07:00
Chris Bracken
83df7bdd0f Update Dart package dependencies (#12829) 2017-11-01 15:28:46 -07:00
Ian Hickson
8fd20b5deb Text Painting Fuzzer (#12813)
Various improvements (in particular a new painting fuzzer) to the text manual test.

Some additional documentation.

A fix to Stack to remove an LTR bias: make unpositioned children apply "alignment".

Some more debugging information on RichText and Text.

A fix to the flutter tool to not crash when an RPC call throws an exception.
2017-11-01 15:04:43 -07:00
Yegor
f4b0ccd9fd Use alwaysUse24HourFormat when formatting time of day (#12517)
* alwaysUse24HourFormat in MediaQuery and time picker

* docs; dead code

* address some comments

* MaterialLocalizations.timeOfDayFormat is the single source of 24-hour-formattedness

* Make TimePickerDialog private again

* wire up MediaQueryData.fromWindow to Window
2017-11-01 14:52:28 -07:00
Michael Goderbauer
15f0146866 Add missing dart docs to semantics-realted members. (#12821)
Other missing dart docs have been added in https://github.com/flutter/flutter/pull/12813.
2017-11-01 12:55:06 -07:00
Roberto Scaramuzzi
80e159d469 Add acceptNotification parameter to RefreshIndicator and OverscrollIn… (#12716)
* Add acceptNotification parameter to RefreshIndicator and OverscrollIndicator

* Various fixes suggested by reviewer

* Fixed lint errors
2017-11-01 10:29:37 -07:00
Hans Muller
7987dfe965 Revised the English translation definitions (#12812) 2017-11-01 10:19:43 -07:00
amirh
6161d54eb6 Move AbstractNode to lib/foundation. (#12789)
(in preparation for moving the semantics stuff out of rendering)
2017-11-01 09:24:30 -07:00
Yegor
41bd66f210 remove locale "sd" (not supported by ICU/CLDR); unify localizations script options (#12803)
* remove locale "sd" (not supported by ICU/CLDR); unify localizations scripts CLI

* address comments
2017-10-31 20:23:58 -07:00
Michael Goderbauer
9184dfba14 Support value announcement for increase/decrease (#12741)
* Support value announcment for increase/decrease

* ++

* review comments about docs
2017-10-31 14:22:33 -07:00
Ian Hickson
e1174eb0f2 TextPainter RTL (#12791) 2017-10-31 10:39:34 -07:00