Commit Graph

18842 Commits

Author SHA1 Message Date
Kevin Moore
c25608d83b Provide more information in PUB_ENVIRONMENT for pub get/upgrade (#13307)
* Provide more information in PUB_ENVIRONMENT for `pub get/upgrade`

Should help diagnose and fix https://github.com/dart-lang/pub-dartlang-dart/issues/636
2017-12-01 16:20:06 -08:00
Hans Muller
8ebd45d3bd Workaround for TextPainter.computeDistanceToActualBaseline when the text is empty (#13305) 2017-12-01 15:06:03 -08:00
Phil Quitslund
acbc16afd4 Swift templates tweaks. (#13291)
Dropped optional semicolons.
2017-12-01 10:54:56 -08:00
Phil Quitslund
a4bc470fa5 Tweak access to linter internals in package validation. (#13297)
A more future-proof approach to accessing internal package name lint rule description details.

See: https://github.com/dart-lang/linter/issues/654
2017-12-01 10:54:24 -08:00
Chris Bracken
1d6bb3ccbf Update quiver dependency to 0.26.2 (#13299)
Updates quiver from 0.26.0 to 0.26.2 to pick up strong-mode fixes.
2017-12-01 10:28:59 -08:00
Jakob Andersen
5174dbaff5 Download our own copy of gradle wrapper. (#13267)
Rather than depending on android.googlesource.com for hosting the gradle
wrapper, host our own copy on storage.googleapis.com (along with our
other artifacts).

Also added a script to repackage AOSP's version into ours, in case we
ever need to update it.

Addresses the gradle wrapper part of #11681.
2017-12-01 09:39:13 +01:00
Mikkel Nygaard Ravn
19136c283e Bump versions following alpha roll (#13284) 2017-12-01 06:20:05 +01:00
Chris Bracken
3efbe00fa6 Correct handling for alwaysUse24HourFormat in MediaQuery (#13287)
1. Ensure that this value is defaulted to the value associated with the
   context rather than re-defaulted to false.
2. Add this value to operator==, hashCode, toString methods.
2017-11-30 18:26:07 -08:00
Chris Bracken
a1b22b17de Don't remove view insets in removePadding ctor (#13286)
This will be followed by a patch that supports independently removing
padding and view insets.
2017-11-30 17:41:09 -08:00
Alexander Aprelev
5a1dcdb427 Fix --preview-dart2 option handling for ios profile/release. (#13285)
* Fix --preview-dart2 option handling for ios profile/release.

* Remove unused parameter
2017-11-30 17:17:39 -08:00
Yegor
e809511682 remove dependency on package:quiver/iterables.dart (#13281) 2017-11-30 15:09:39 -08:00
xster
5c4ffa13a6 Let translucent Cupertino bars have its scaffold children automatically pad their heights (#13194)
* Let lists automatically add sliver padding from media query. Translucent nav and tab bars leave behind media query paddings in scaffolds.

* tests

* const lint

* Rename base abstract class to generalized ObstructingPreferredSizeWidget
2017-11-30 13:55:30 -08:00
Chris Bracken
d957c8f040 Add EdgeInsets, MediaQuery support for view insets (#13272)
* Add MediaQuery support for view insets

Also updates EdgeInsets documentation to reflect WindowPadding's use for
both padding and view insets.

See engine commits:
  flutter/engine#4403
  flutter/engine#4406
2017-11-30 13:29:59 -08:00
Ian Hickson
4a4fa2a7c7 Cupertino RTL (#13273)
Fixes the remaining known issues with widgets supporting RTL.
2017-11-30 12:24:40 -08:00
Michael Goderbauer
6493c8b43d Adapt markNeedsSemanticsUpdate algorithm to new semantics tree compiler (#13274)
* ensures that only semantics boundaries will be added to owner._nodesNeedingSemantics as expected by compiler.
* no longer throws assert if markNeedsSemanticsUpdate is called on non-semantic-boundary render object with a non-semantic-boundary parent.
* Fixes #13109.
* removes onlyLocalUpdates from markNeedsSemanticsUpdate as its no longer needed.
2017-11-30 12:18:33 -08:00
Yegor
a78c9f70da remove the unused dispatchDidChangeDependencies (#13224) 2017-11-30 12:17:25 -08:00
xster
738e62cb2e Let iOS have a minimum scroll movement threshold to break before motion starts (#13166)
* Add a minimum distance that needs breaking on iOS each time scrolls stopped.

* Testing and tests

* tweak docs

* review
2017-11-30 11:11:52 -08:00
Alexander Aprelev
42ca92c756 Hide preview-dart-2 flag. Show only in verbose (#13270) 2017-11-30 10:36:46 -08:00
Alexandre Ardhuin
c358898a76 try lint avoid_unused_constructor_parameters (#13250) 2017-11-30 09:20:53 +01:00
Alexander Aprelev
4447c0aaf3 Add --preview-dart-2 option support for ios builds (#13251) 2017-11-29 18:11:34 -08:00
Yusuke Konishi
a46679f758 Implements FlatButton debugFillProperties (#13217)
* Implements FlatButton debugFillDescription

* Fix doc comment

* Override debugFillProperties instead of debugFillDescription

* Remove child debug property
2017-11-29 15:35:37 -08:00
Mehmet Fidanboylu
b61cbc735e Add capability to print engine dart sdk to flutter doctor (#13085)
* Add capability to print engine dart sdk to flutter doctor

* First round of review comments

* second round of comments

* Final review comments
2017-11-29 11:03:50 -08:00
Hans Muller
7ce486efa2 Updated flutter_localizations (#13229) 2017-11-29 08:27:17 -08:00
Todd Volkert
137f0751b2 Add support for IOS_SIMULATOR_HOME environment variable in IOSSimulat… (#13236)
Add support for IOS_SIMULATOR_HOME environment variable in IOSSimulator.logFilePath

flutter_tools can be run on environments where the user's HOME directory
is not the root of the iOS simulators' configs. This change adds support
for such environments by allowing the caller to set the simulator root
directory via an environment variable.
2017-11-29 08:22:05 -08:00
Alexandre Ardhuin
1d7a22fba0 sort lints to make maintenance easier (#13231) 2017-11-29 07:54:44 +01:00
Greg Spencer
909406ba25 Consolidating .gitignore files. (#13002)
This consolidates all of the non-template .gitignore rules into the top level .gitignore, to ignore common things more broadly, with less maintenance needed for the .gitignore files. Does not touch the templates, so that they still produce needed .gitignores as part of flutter create.
2017-11-28 17:06:57 -08:00
Greg Spencer
02517b8b13 Fix some minor typos/grammar issues (#13230) 2017-11-28 16:27:26 -08:00
Greg Spencer
fc2f3b4f0f Updated run configurations with catalog examples. (#13099) 2017-11-28 16:04:30 -08:00
xster
7ad69b38b0 Update xcode project template to 9.1 (#13193) 2017-11-28 15:49:00 -08:00
Jacob Richman
277001d1a8 Inspector JSON protocol to support Flutter IntelliJ Plugin tree view. (#12932) 2017-11-28 15:06:16 -08:00
Devon Carew
792e7ce872 add an assert to validate the RefreshIndicator.onRefresh result (#13198)
* add an assert to validate the RefreshIndicator.onRefresh result

* add a test for RefreshIndicator.onRefresh assert

* switch to using FlutterError.reportError, FlutterErrorDetails, and FlutterError
2017-11-28 11:00:36 -08:00
Todd Volkert
c182e0e517 Remove unused pushFile methods in ios classes (#13215) 2017-11-27 12:55:59 -08:00
Devon Carew
c25558d426 change 2 print calls to printStatus (#13206) 2017-11-27 08:13:24 -08:00
Devon Carew
d776f64f4e tweaks to the cli args for flutter run (#13207) 2017-11-27 06:56:51 -08:00
Devon Carew
bdbe53be01 remove unused constants (#13199) 2017-11-24 19:13:18 -08:00
Ian Hickson
4c9013b71b BottomNavigationBar RTL (#13167) 2017-11-22 18:55:07 -08:00
Ian Hickson
9afc853f75 Revert "Reenable fade transition for Material page transition (#13048)" (#13172)
This reverts commit e73d406106.

It caused major performance regressions.
2017-11-22 18:54:15 -08:00
Ian Hickson
2bda59a1fe TabBar RTL (#13164) 2017-11-22 18:53:42 -08:00
Chris Bracken
cf37a4721a Reorganise flutter driver implementation sources (#13163)
This patch reorganises flutter_driver's lib/src directory into three
subdirectories:

* driver: sources transitively imported/exported by flutter_driver.dart,
  which defines the API used by driver tests executed on the host machine.

* extension: sources transitively imported/exported by
  driver_extension.dart, which defines the API used to instrument a
  Flutter app running on the target device for use with a driver test.

* common: sources common to both driver and extension code.

This makes rolling Flutter into repositories that use Bazel (or
Bazel-like build systems) significantly more robust, due to the simpler
glob patterns involved.
2017-11-22 17:24:41 -08:00
Chris Bracken
d9bdb76fd2 Eliminate unused retry.dart from flutter_driver (#13161) 2017-11-22 16:54:19 -08:00
amirh
78e044f5ec Cancel the animated image stream timer if all listeners were removed. (#13158)
This is a bug in my previous CL: instead of cancelling the timer if
there are no more listeners, I canceled it if there were listeners (I
can claim I just missed a not :) ).

Not cancelling the timer when removing the last listener was not that bad, as
the timer callback is guarded by a check to see if there are listeners.
So the animation will not continue.

But in the case there were multiple listeners on the same stream, and
one of them is removed, this bug will stop the animation for all other
listeners.
I added a test case for this scenario.
2017-11-22 15:27:26 -08:00
Ian Hickson
2db0c25f82 Dismissible RTL (#13137)
Fix the dismissible demo in the gallery (make it actuall update when you pick something from its menu; give it a better affordance for resetting once you've dismissed everything).

Improve some docs.

Fix various flinging bugs with dismissible. Add tests for those cases.

Add a feature to flutter_test to support a drag-then-fling gesture (used by the flinging tests).
2017-11-22 15:20:15 -08:00
Alex
e6119282b7 feat: add optional headers param to network image (#13128)
* feat: add optional headers params to network image

* fix: addressed comments

* feat: add test

* style: format code
2017-11-22 15:19:52 -08:00
Pascal Welsch
891a218002 Add missing onDragCompleted to LongPressDraggable (#13119)
* Add missing onDragCompleted to LongPressDraggable

* Add test for LongPressDraggable onDragStarted and onDragCompleted
2017-11-22 15:18:28 -08:00
Leonardo Bispo de Oliveira
b3fa055894 ExpansionTile opened - initial state (#13115)
Changed the ExpansionTile widget to have an optional value to
initialize the widget as collapsed or expanded.

The widget will be collapsed by default.
2017-11-22 15:16:27 -08:00
Chris Bracken
d5cb9781e1 Eliminate unused matcher_util in flutter_driver (#13159)
Use of this file was eliminated in e7657b9462.
2017-11-22 15:15:37 -08:00
Ian Hickson
34ba6be93a Popup menus RTL (#13110)
This fixes the popup menu code to do a better job of expanding
smoothly regardless of which side of the screen it's on. It still
results in a bidirection growth when positioned at the bottom of the
screen, so maybe we'll need to animate menus differently, but that's
a problem for another patch.

Also, improve some docs and provide RelativeRect.toSize which I needed
at one point while building this patch (though it didn't survive all
the way to the end).
2017-11-22 15:15:21 -08:00
Yegor
8c902ad479 clear timeline events prior to starting a new action (#12984)
* clear timeline events prior to starting a new action

* trailing commas
2017-11-22 15:08:09 -08:00
Pascal Welsch
e73d406106 Reenable fade transition for Material page transition (#13048)
Fixes #12877 by reverting #9472
2017-11-22 15:07:41 -08:00
Kyle Bradshaw
3dc32873bf AnimationController reset() method (#13044)
* AnimationController reset() method

Just a simple convenience method to fix #13039

* Added `reset()` test

* More test expectations

Per feedback.

* Removed test print

* Improved documentation of reset()

* Add controller.reverse to test
2017-11-22 15:06:43 -08:00