Commit Graph

18842 Commits

Author SHA1 Message Date
Shi-Hao Hong
41ff8408ca Add Actions to AppBar Sample Doc (#32530)
* Add actions to AppBar sample doc
2019-05-13 15:19:14 -07:00
liyuqian
06f86c8b2f Reland matrix check (#32521)
This relands flutter/flutter#31701 with missing const added

This reverts commit 549b412656.
2019-05-13 14:36:09 -07:00
xster
1cd88c3501 Let CupertinoNavigationBarBackButton take a custom onPressed (#32469) 2019-05-13 12:41:24 -07:00
Shi-Hao Hong
9545c5d166 Tab Animation Sample Video (#32177)
* Improve tabs documentation regarding matching lengths

* Add Tabs animation to docs
2019-05-13 09:06:43 -07:00
Danny Tuppeny
b76a1e8312 Comment out .vscode/ in gitignore for templates (#32404) 2019-05-13 09:06:30 +01:00
stuartmorgan
710a0cb9a5 Adjust macOS build flow (#32538)
- Removes SYMROOT from the Generated.xcconfig. Having it causes current
  versions of Xcode to switch the project's build output to "Legacy",
  which causes anything not overridden to use a project-relative build
  directory instead of a shared directory in DerivedData, breaking
  anything with subprojects that it depends on.
  This means that `flutter run` and builds from Xcode will use
  completely different build directories, but that each should be
  internally consistent.
- Moves the FlutterMacOS.framework to $SRCROOT/Flutter. This is
  consistent with the approach we're moving to for all desktop
  platforms, and avoids issues finding it now that SYMROOT doesn't match
  for the two different build modes.

Fixes #32494
2019-05-11 21:12:42 -04:00
Jonah Williams
8b0243f413 Teach Linux to use local engine (#31631) 2019-05-11 00:08:29 -07:00
Kate Lovett
829bdeb426 Fixing accidental merge from WIP branch. (#32520)
Revert "Merge branch 'master' into master"

This reverts commit e3a03c04c4, reversing
changes made to 6474982649.
2019-05-10 15:53:41 -07:00
Kate Lovett
e3a03c04c4 Merge branch 'master' into master 2019-05-10 15:16:40 -07:00
Dan Field
382704ca95 Use precisionErrorTolerance (#32499) 2019-05-10 13:28:19 -07:00
Jonah Williams
549b412656 Revert "Add more asserts to check matrix validity (#31701)" (#32496) 2019-05-10 10:05:15 -07:00
liyuqian
0dc290c023 Add more asserts to check matrix validity (#31701)
## Description

These will help identify where the matrix starts to get wrong. 

Also fixed `RenderFittexBox` to no longer paint with empty child which previously triggered invalid matrix computations (NaN with dividing by 0). See also https://github.com/flutter/flutter/pull/7489

## Related Issues

https://github.com/flutter/flutter/issues/31650
https://github.com/flutter/flutter/issues/31700
https://github.com/flutter/flutter/issues/7431

## Tests

* RenderFittedBox does not paint with empty sizes
2019-05-10 09:33:09 -07:00
Michael Goderbauer
b37c3be0fa Add ancestor and descendant finders to Driver (#32410) 2019-05-10 18:21:19 +02:00
Riccardo Ratta
705143855f Make font semibold when isDefaultAction is true in CupertinoDialogAction (#31308)
Make font semibold when isDefaultAction is true in CupertinoDialogAction
2019-05-10 08:22:56 -07:00
Efthymis Sarmpanis
b24f1f78a7 Add breadcrumbs to TextOverflow (#32328) 2019-05-10 13:29:31 +02:00
Michael Goderbauer
8cf65526e7 everything const (#32380) 2019-05-10 13:29:03 +02:00
xster
87d9c553f4 Revert "Cupertino localization step 12: push translation for all supported languages (#31644)" (#32470)
This reverts commit 10922df68e.
2019-05-10 01:08:59 -07:00
xster
10922df68e Cupertino localization step 12: push translation for all supported languages (#31644) 2019-05-09 23:18:56 -07:00
xster
1ac813a5e6 Cupertino localization step 10: update the flutter_localizations README (#30224) 2019-05-09 23:17:43 -07:00
Hans Muller
6d0e235cf8 Support for replacing the TabController, after disposing the old one (#32434) 2019-05-09 22:02:46 -07:00
Greg Spencer
d2fe08628d Implements FocusTraversalPolicy and DefaultFocusTraversal features. (#30076)
This implements a DefaultFocusTraversal widget to describe the focus traversal policy for its children, defined by a FocusTraversalPolicy object from which custom policies may be created. Pre-defined policies include widget-order traversal, "reading order" traversal and directional traversal.
2019-05-09 20:24:23 -07:00
Sam Rawlins
9c77e8e8a0 Fix missing return statements on function literals (#31825) 2019-05-09 12:43:51 -07:00
Greg Spencer
66a6726306 Fix benchmark regression in layer.find<S>(Offset) (#32425)
This fixes a benchmark regression introduced in #32350. The performance is improved by just reverting the Layer.find<S> routines to use their old definitions, instead of defining them in terms of the findAll<S> lazy iterators.

Fixes #32387
2019-05-09 12:25:52 -07:00
Phil Quitslund
3a6acb8c25 More const conversions (#32408)
* update immutable to const

* => const lists

* revert making list const

* make Centers const
2019-05-09 09:23:30 -07:00
Jonah Williams
4d3b51e284 Allow flutter web to be compiled with flutter (#32360) 2019-05-09 08:57:26 -07:00
stuartmorgan
e8c5c98132 Fix assignment in macos_build_flutter_assets.sh (#32406)
Bash assignment doesn't have spaces around '='.

Fixes #32341
2019-05-09 10:16:30 -04:00
Phil Quitslund
d96c1c88b7 make immutables const (#32340)
* make immutables const
2019-05-09 05:47:01 -07:00
Michael Goderbauer
1621baafc7 Introduce separate HitTestResults for Box and Sliver (#31894) 2019-05-09 10:00:01 +02:00
Michael Goderbauer
ff1dbcdeb6 Add geometry getters to Flutter Driver (#32302) 2019-05-09 09:50:02 +02:00
Greg Spencer
aeccd6a8bc Fix nested listeners so that ancestor listeners can also receive enter/exit/move events. (#32350)
This changes Listener to trigger enter/move/exit in all Listeners below the pointer, not just the leaf region (the first region hit). This is because we need to allow listeners to be nested so that, say, a widget that handles changing color on hover, but also is wrapped in a Tooltip (that handles hover) can trigger both actions, not just one.

To that end, I added a findAll to Layer, similar to the existing find method that was previously used. It returns an iterator over annotated layers which match the given data type.

Since the findAll is implemented as returning an Iterable (and is sync*), I re-implemented the find routines as just returning the first result from findAll, since that should be just as efficient, and would then prevent duplication in the implementation.
2019-05-08 17:57:42 -07:00
Greg Spencer
23baae0e45 Fix RenderPointerListener so that callbacks aren't called at the wrong time. (#32142)
I recently added some code to keep hover events from being propagated when a mouse wasn't attached. While that works, there are times when it can fire callbacks during the building of other components, since they can now be called from detach/attach. This is not ideal, since it will assert then. This changes the code so that it won't update the annotations during attach/detach, but also won't push the annotation layer unless a mouse is connected, achieving the same result as before, but with better semantics.

The basic problem is that in the detach for RenderPointerListener, it would detach the annotation, which could cause onExit to be called on the annotation, since the widget was disappearing under the mouse, and thus needs to receive an onExit, but that onExit might be (and probably will be) calling setState, which marks the owning widget as needing to be built, sometimes when it already has been.

The fix creates a new _ListenerElement that overrides activate and deactivate in order to tell the render object ahead of the detach that it might be detached, and so the onExit gets called before the detach instead of during it.

In addition, I now avoid scheduling more than one check for mouse positions per frame.
2019-05-08 12:20:31 -07:00
Matthew Lloyd
969c6ef1dc Add reference to Runner-Bridging-Header.h to iOS template's profile configuration (#32266) 2019-05-07 23:59:01 -07:00
chunhtai
21efdff8a5 fix issue 32212 Text field keyboard selection crashes (#32256) 2019-05-07 15:07:11 -07:00
xster
aa450d5660 Cupertino localization step 9: add tests (#29954) 2019-05-07 11:47:59 -07:00
Jonah Williams
eb996afaa8 make hotfix use a plus instead of minus (#32060) 2019-05-07 10:11:00 -07:00
Shi-Hao Hong
2f1e7cf662 Added state management docs/sample to SwitchListTile (#32147)
* Added documentation to SwitchListTile
2019-05-07 08:33:22 -07:00
Ian Hickson
f61a2c3907 Clean up flutter_test/test/controller_test.dart (#31333)
Instead of using a custom WidgetController, which is very brittle, we just use the usual infrastructure.

Also, use structured data instead of an array.

This adds offsetMoreOrLessEquals to handle small floating point errors in offsets.
2019-05-06 14:36:30 -07:00
Ian Hickson
b770cdf267 Revert "Add shape property to SliverAppBar (#31662)" (#32155)
This reverts commit 28b58db1f2.
2019-05-06 12:02:02 -07:00
Michael Klimushyn
fecba55888 Remove deprecated decodedCacheRatioCap (#32041) 2019-05-06 11:19:35 -07:00
yaheng
57d6666462 Fix text selection toolbar appearing under obstructions (#29809) 2019-05-06 11:18:09 -07:00
Emmanuel Garcia
cc7ec6d624 Bump multicast_dns version 2019-05-06 11:14:41 -07:00
Tiziano Munegato
28b58db1f2 Add shape property to SliverAppBar (#31662) 2019-05-06 10:34:37 -07:00
Darren Austin
017997b9c1 Increase size of touch regions in the Time Picker header (#32053)
- Increased the AM/PM, minute and hour buttons to at least 48x48
- Added InkWells to all of them
- Adjusted the landscape layout for the AM/PM buttons to be horizontal
- Added a test to ensure the regions are at least 48x48
2019-05-06 10:27:16 -07:00
Darren Austin
2d2edbf70b Date picker layout exceptions (#31514)
Fixed several layout issues with the material date picker. Mostly just removed hard coded sizes to allow the grid view to scroll instead of overflowing.
2019-05-06 10:26:26 -07:00
Zachary Anderson
61236c873e [flutter_tool] In 'attach' use platform dill and patched sdk dir from the Fuchsia SDK (#32071) 2019-05-06 09:26:58 -07:00
Jonah Williams
dd5d0d6c36 rename foreground and background to light and dark (#32070) 2019-05-06 08:02:08 -07:00
Jonah Williams
99e7b0a0ff dont NPE with empty pubspec (#32072) 2019-05-06 08:01:45 -07:00
Antti Ahti
526113db32 Fix tab indentation (#31798)
Code indentation was done with tabs in some places. Replaced with spaces.
2019-05-06 14:09:54 +02:00
Michael Goderbauer
cc239580d3 Make Hover Listener respect transforms (#32025) 2019-05-06 13:36:13 +02:00
Michael Goderbauer
ea03ac2b84 Revert "Sliver animated list (#28834)" (#32135)
This reverts commit d2de911d50.
2019-05-06 11:53:32 +02:00