Commit Graph

18842 Commits

Author SHA1 Message Date
Zachary Anderson
c7c8a6c498 [flutter_tools] Add more info to pub get failure event (#41652) 2019-10-03 11:08:42 -07:00
Jonah Williams
517c08e801 Make output directory a build input (#41862) 2019-10-03 11:07:53 -07:00
Gary Qian
fa7340a328 Return WidgetSpans from getSpanForPosition (#40635) 2019-10-02 19:04:50 -04:00
Shi-Hao Hong
27a12efabf Update DefaultTabController to allow for zero tabs (#41625)
* Update DefaultTabController to allow for zero tabs
2019-10-03 06:42:22 +08:00
Shi-Hao Hong
913aca22b3 [Material] Fix Tooltip to respect ambient Directionality (#41629)
* Fix Tooltip Directionality

* Add regression test comment for tooltip directionality fix
2019-10-03 06:41:23 +08:00
Shi-Hao Hong
e7947c3e92 DropdownButton.style API doc example for differing button and menu item text styles (#41650)
* Add dropdown button style doc example for unique text styles
2019-10-03 06:41:00 +08:00
gaaclarke
75c07ef1a6 Updated the docstring for SystemNavigator.pop.
It had an Android bias and was incorrect for iOS.
2019-10-02 15:36:07 -07:00
Josh
8b9e144e6a Added notice to docs that setPreferredOrientations does not always work on iPad (#40743) 2019-10-02 15:32:52 -07:00
Ori Schwartz
f8310d89e8 Use EdgeInsetsGeometry instead of EdgeInsets (#40775) 2019-10-02 15:31:39 -07:00
Tong Mu
0b0942a60c Refactor: Base tap gesture recognizer (#41329)
* Extracts the logic of TapGestureRecognizer into an abstract class BaseTapGestureRecognizer
* Fixes ModalBarrier unable to dismiss when competing
2019-10-02 15:28:55 -07:00
Greg Spencer
bedf46d06e Add shortcuts and actions for default focus traversal (#40186)
This adds the default shortcuts and actions for keyboard-based focus traversal of apps.

This list of shortcuts includes shortcuts for TAB, SHIFT TAB, RIGHT_ARROW, LEFT_ARROW, UP_ARROW, DOWN_ARROW, and the four DPAD keys for game controllers (because the DPAD produces arrow key events).

It doesn't yet include functionality for triggering a control (e.g. SPACE, ENTER, or controller buttons), because that involves restructuring some of the Flutter controls to trigger animations differently, and so will be done in another PR (#41220)
2019-10-02 15:21:45 -07:00
Jonah Williams
aeede20785 Handle missing .packages file in the flutter tool for prebuilt artifacts (#41697) 2019-10-02 15:18:34 -07:00
Yegor
33f4f8e6df run services tests on the Web (#41806) 2019-10-02 15:11:22 -07:00
Ian Hickson
8c6d60bcfd Move commands into their own shard (#39140) 2019-10-02 12:46:51 -07:00
Jonah Williams
39f85f94ec Reland: don't update last compile time when compilation is rejected. (#41580)
* dont update last compiled time when compilation is rejected

* lets try flushing, thats a neat trick

* windows man

* Update hot_reload_test.dart

* Update hot_reload_test.dart

* Update devfs.dart

* Update hot_reload_test.dart

* Update hot_reload_test.dart

* add test that verifies when compile is good that time is updated

* Update devfs_test.dart
2019-10-02 12:46:33 -07:00
Greg Spencer
4512a1c1b7 Add an ActivateAction to controls that use InkWell. (#41220)
Adds an ActivateAction to controls that use InkWell. Make InkWell host the Focus for those controls, and add the top level binding to the ENTER key. This will make it possible to trigger a button using the enter key, and to get an ink response when the button is triggered.

This is a breaking change because it moves the Focus widget into the InkWell. If you have a component that uses the InkWell directly and you used to wrap that InkWell in a Focus widget to give it its notion of focus, it will now not look for that Focus ancestor for its focus state anymore. In order to control focus on the InkWell, you need to give it a FocusNode directly, via the new focusNode parameter. This should not affect users of widgets like OutlineButton or FloatingActionButton and the like, since those have been modified in this PR.
2019-10-02 12:46:02 -07:00
Jonah Williams
0af2a84cbb Handle empty entry in asset list and add more explicit validation (#41735) 2019-10-02 12:45:51 -07:00
Jonah Williams
b1a6aa3ab8 Add support for downloading x86 Android JIT release artifact (#41751) 2019-10-02 12:45:35 -07:00
Jonah Williams
a9f385bbff Reduce log verbosity by removing individual used files (#41788) 2019-10-02 12:45:04 -07:00
Mouad Debbar
e045ef2969 Keymap for Web (#41397) 2019-10-01 14:10:53 -07:00
Slade Capasso
a9c28d5f6c range_slider_test.dart diagnostics property tests (#40291)
* Updates to slider_test.dart

Fixed error that required onChanged.

* Updated slider.dart and slider_test.dart debugFillProperties

Updated slider.dart debugFillProperties to include all properties and slider_test debugFillProperties to test all properties

* Updated Slider onChanged property

* Updated debugFillProperties to ignore testing methods that are null in test

Per feedback from Hans/Anthony on Flutter Material

* Updated spacing in debugFillProperties

Per feedback from Hans

* Updated range_slider.dart and range_slider_test.dart to have DiagnosticProperties tests for all properties

* Updated range_slider.dart and range_slider_test.dart per feedback

Preventing null labels from creating an error.

Added made RangeLabels and RangeValues constants in instantiation of Range Slider.

Fixed spacing.

* Updates to start and end labels in diagnostic property tests

Updated per feedback from @clocksmith
2019-10-01 17:06:34 -04:00
Jonah Williams
6714baab41 Download Android x64 release artifacts (#41698) 2019-10-01 14:04:37 -07:00
Jonah Williams
b2f38396f4 Reland: Switch to assemble API for dart2js (#41659)
* Stop using build_runner for dart2js

* fixes to yield when computing hashes and to imports

* add missing await

* Update filecache_test.dart

* Fix paths in filecache test

* use file uri for import

* add test cases and configurable override

* remove test dep

* fix filepaths for windows

* test no longer failing

* fix paths for test cases

* fix typo

* address comments

* make a constant

* make filehash async and use constant

* fix silly logic error
2019-10-01 14:03:42 -07:00
Jonah Williams
ce2c708a90 Add more information to cannot find Chrome message (#41695) 2019-10-01 14:03:12 -07:00
Yegor
8246785f3f Spawn no more than 1 iframe in web tests. Using multiple iframes in DDK mode times out tests. Also set concurrency to 1 to guarantee that the test runner does not even attempt to parallelize tests. (#40630)
Spawn no more than 1 iframe in web tests. Using multiple iframes in DDK mode times out tests. Also set concurrency to 1 to guarantee that the test runner does not even attempt to parallelize tests.
2019-10-01 13:58:05 -07:00
Jonah Williams
06a6fdbf23 Revert "Switch to assemble API for dart2js (#41447)" (#41658) 2019-09-30 18:35:01 -07:00
Jonah Williams
ccc3dd968c Switch to assemble API for dart2js (#41447) 2019-09-30 18:26:28 -07:00
Christopher Fujino
11d0235121 change printStatus calls to printTrace inside MDnsObservatoryDiscovery (#41621) 2019-09-30 14:15:17 -07:00
Jenn Magder
1eb1e2226b Skip pod initialization if version >= 1.8.0. (#41491) 2019-09-30 13:14:42 -07:00
Jonah Williams
e8517a434d Add analytics tracking for compile and refresh times for Flutter Web (#41545) 2019-09-30 12:45:03 -07:00
Jacob MacDonald
94993055f2 track unused inputs in build_runner (#41610) 2019-09-30 12:20:00 -07:00
Jonah Williams
06864e445c Rename Server/web device to Headless Server/headless-server (#41618) 2019-09-30 12:19:45 -07:00
Jonah Williams
41b87255f5 Add support for depfile dependency in assemble (#41530) 2019-09-30 12:17:45 -07:00
Alexandre Ardhuin
f0553ba58e Missing trailing commas (#41473)
* add missing trailing commas

* add more missing trailing commas

* add more and more missing trailing commas
2019-09-30 18:48:23 +02:00
stuartmorgan
d1761f1072 Pass Linux build mode on command line (#41551)
Currently Linux builds override the default BUILD mode by putting it in
the generated config. That makes it sticky for manual runs of make,
which is inconsistent with how other platforms work.

Instead, pass the build mode as a command-line override, the same way
someone would if building directly with make. This makes the flow of
controlling the mode less confusing.

Fixes #41528
2019-09-30 09:36:40 -07:00
Justin McCandless
67ea92cbca Fix exception when selecting in TextField (#41326) 2019-09-30 09:24:30 -07:00
Erick Ghaumez
d122f09959 Fix the ThemeData.copyWith toggleButtonsTheme argument type (#40994)
* set the copyWith toggleButtonsTheme argument type to ToggleButtonsThemeData

* add a ThemeData.copyWith test
2019-09-30 23:52:35 +08:00
Jonah Williams
c8b3c9b727 use IOOverrides to allow inject file system, write test, find bug (#40066) 2019-09-30 08:41:12 -07:00
Zachary Anderson
45f3c8d060 [flutter_tool] Report to analytics when the tool is killed by a signal (#41493)
* [flutter_tool] Report to analytics when the tool is killed by a signal

* Fix analyzer lint
2019-09-30 07:38:11 -07:00
Danny Tuppeny
7e73cd74b1 Fix visibility of web server device when Chrome is not available (#40757)
* Fix visbility of web server device when Chrome is not available

* Add tests

* Update workflow test

* Fix tests to not rely on Chrome being on the underlying machine
2019-09-30 14:45:30 +01:00
Alexander Aprelev
839fdbd2ed Retry devfs uploads in case they fail. (#41406)
* Retry devfs uploads in case they fail.

Fixes #34959.
2019-09-29 21:32:06 -07:00
Jonah Williams
69af9adeac Update minimum build_runner version and enable incremental builder (#41499) 2019-09-29 13:01:33 -07:00
Greg Spencer
0223565fd5 Reland changes to Intent.doNothing to avoid analyzer issue (#41477)
This re-lands #41417 with a slight change that will hopefully not tickle the analyzer as it did before. The last time I tried to land this, the analyzer succeeded for the analyze step in Cirrus, and locally, but failed in an integration test.
2019-09-28 08:55:47 -07:00
MH Johnson
f4ba8d1a93 [Material] Remove text ripple from TextFields (#41320)
* remove splash logic

* update tests
2019-09-28 11:47:17 -04:00
Jonah Williams
07e5cf005c Reland: Exit resident web runner on compilation failure (#41505) 2019-09-27 18:54:58 -07:00
Jonah Williams
7a487b2cbf Ensure we find dart.exe on local engines (#41514) 2019-09-27 18:54:24 -07:00
LongCatIsLooong
5f9c262e66 Revert "CupertinoDatePicker & CupertinoTimerPicker dark mode (#39919)" (#41521) 2019-09-27 17:46:15 -07:00
LongCatIsLooong
97b27fafd4 CupertinoDatePicker & CupertinoTimerPicker dark mode (#39919) 2019-09-27 16:03:51 -07:00
Jonah Williams
d968b7cfd6 Revert "Dont update last compiled time when compilation is rejected (#41424)" (#41515) 2019-09-27 15:18:06 -07:00
Zachary Anderson
feaaa5d738 [flutter_tool] Add analytics events for ios-mdns fallback success/failure (#41482) 2019-09-27 12:18:59 -07:00