Commit Graph

18842 Commits

Author SHA1 Message Date
Edman P. Anjos
28b5cc3825 Pad CupertinoAlertDialog with MediaQuery viewInsets (#42967)
Fixes #42049.
2019-11-05 11:50:30 +01:00
Taufiq Rahman
3390e162cf Adjust and refactor all FlatButton tests into its respective file (#43742)
* Adjust and refactor all FlatButton tests into its respective file
2019-11-04 18:22:01 -08:00
umevoshi
d96afee888 Fix comment typo in tabs.dart (#44068) 2019-11-04 17:33:23 -08:00
Thalles Santos
0431c8a64d Typo in TextFormField comments (#44076)
initalValue should be initialValue
2019-11-04 17:32:41 -08:00
Kate Lovett
11e1c24069 SliverAppBar - Configurable overscroll stretch with callback feature & FlexibleSpaceBar support (#42250) 2019-11-04 17:10:26 -08:00
Jonah Williams
0f6c093d68 Remove Source.behavior, fix bug in depfile invalidation (#43945)
* remove Source.behavior, fix bug in depfile invalidation

* more cleanup of assets

* Add skip

* address comments

* Update build_system.dart
2019-11-04 16:37:43 -08:00
LongCatIsLooong
bbb2a0f837 Update cupertino demos in gallery (#43841) 2019-11-04 16:31:52 -08:00
Emmanuel Garcia
76957c9da8 build aar prints how to consume the artifacts (#44127) 2019-11-04 16:28:27 -08:00
Dan Field
7957c56997 Respond to TextInputClient.reattach messages. (#43959) 2019-11-04 16:28:03 -08:00
Emmanuel Garcia
b94c1a41ca Exit tool if a plugin supports the embedding v2 but the app doesn't (#44026) 2019-11-04 13:37:51 -08:00
Nurhan Turgut
97cf355b9d Adding handling of TextInputClient.onConnectionClosed messages handli… (#43466)
* Adding handling of TextInputClient.onConnectionClosed messages handling to Framework

* Adding more test cases for closing connection to editable_text_test

* fixing analyze error.

* Fixing analyze error in the test file

* Fixing comments on the new method

* Adding more closing connection examples.

* Indentation change

* Remove auto-add white space

* Changing the oncloseconnection behaviour to stop editing. Updating the tests

* Addressing PR comments. Added explicit log for method channnels to the tests. Added comments to the interfaces.

* add more documentation
2019-11-04 13:35:18 -08:00
Jonah Williams
3422540bc4 copy chrome preferences to seeded data dir (#44032) 2019-11-04 09:09:20 -08:00
Jonah Williams
df0501c7d3 remove services code (#44052) 2019-11-04 09:08:57 -08:00
Jonah Williams
5e1bb20c83 support --no-resident on the web (#44028) 2019-11-04 09:08:40 -08:00
Emmanuel Garcia
ee032f67c7 flutter build aar should also build plugins as AARs (#43994) 2019-11-02 09:46:25 -07:00
Jonah Williams
f1186b0758 Asset server fix for sourcemaps (#44017) 2019-11-01 22:33:52 -07:00
Emmanuel Garcia
ade8dfac3d Move the plugin registrant to io.flutter.plugins and add the @Keep annotation (#44011) 2019-11-01 16:58:26 -07:00
NikitaZhelonkin
fbabb264e0 Add enableFeedback param to MaterialButton, RawMaterialButton and IconButton (#41972)
* Wire enableFeedback parameter through MaterialButton, RawMaterialButton, and IconButton.

Co-Authored-By: Shi-Hao Hong <shihaohong@google.com>
2019-11-01 15:36:07 -07:00
Jenn Magder
2e7d9130b2 Observe logging from VM service on iOS 13 (#43915) 2019-11-01 14:37:17 -07:00
Shi-Hao Hong
bf45897f13 Revert "Implement AlertDialog title/content overflow scroll #43226" (#44003) 2019-11-01 11:30:58 -07:00
Brian Egan
2e41483384 Add "navigator" option to "showDialog" and "showGeneralDialog" (#42842) 2019-11-01 11:16:32 -07:00
Jonah Williams
71740bef74 remove listDartSources (#43950) 2019-11-01 11:06:24 -07:00
Jonah Williams
7d4a968f0c make more spinner tests not flaky (#43955) 2019-11-01 10:55:15 -07:00
Jonah Williams
0cd8cef8f5 require awaiting Testbed.run (#43952) 2019-11-01 10:55:04 -07:00
creativecreatorormaybenot
8d5caf3df2 Fix typo in app_bar.dart comment (#43981) 2019-11-01 10:16:11 -07:00
Emmanuel Garcia
dea35da040 Log additional Android build failures (#43941) 2019-11-01 10:06:23 -07:00
Justin McCandless
924e48eeb9 Increase TextField's minimum height from 40 to 48 (#42449)
This is being done to match the Material spec. It will likely break many visual diff tests.
2019-11-01 12:36:15 -04:00
LongCatIsLooong
3cd8c3142c Update CupertinoSlidingSegmentedControl control/feedback mechanism (#43932) 2019-10-31 19:35:52 -07:00
Jonah Williams
a192e29603 check for instanceof instead of runtimeType and wait for testbed (#43870) 2019-10-31 19:31:42 -07:00
Greg Spencer
3a30722fda Add convenience accessor for primaryFocus (#43859)
This adds accessors for WidgetsBinding.instance.focusManager and WidgetsBinding.instance.focusManager.primaryFocus so that they can be more easily found in IDEs and accessed.

This adds a top level getter for WidgetsBinding.instance.focusManager.primaryFocus called primaryFocus, and a static accessor FocusManager.instance that returns WidgetsBinding.instance.focusManager.
2019-10-31 18:02:31 -07:00
Jonah Williams
a60a47ae2c Serve correct mime type on release dev server (#43907) 2019-10-31 14:57:34 -07:00
Gary Qian
f9b8d688cf Reorder show and setEditingState calls to the IMM (#43865) 2019-10-31 13:28:48 -07:00
Emmanuel Garcia
175b37247d Refactor gradle.dart (#43479) 2019-10-31 13:19:15 -07:00
Greg Spencer
0028887a69 Don't allow Disabled InkWells to be focusable (#43848)
Makes sure that disabled InkWell/InkResponse and widgets that use them don't allow themselves to be focused.

ListTile, PopupMenu, and Stepper were not setting canRequestFocus properly on the InkWell, and InkWell was allowing focus even if it was disabled (it was basically just relying on the containing widget to set canRequestFocus properly). Now InkWell must both be enabled (have an onTap or similar) and have canRequestFocus set to true.
2019-10-31 12:58:14 -07:00
Kaushik Iska
f798cb6d29 Revert "[flutter_runner] Use sky_engine from the topaz tree (#43684)" (#43913)
This reverts commit e091d724f6.
2019-10-31 11:59:45 -07:00
Kate Lovett
26d09f1ab4 Gold Performance improvements (#43748) 2019-10-31 11:44:07 -07:00
Michael Goderbauer
07a09c4b70 Mark routes as opaque when added without animation (#43756) 2019-10-31 11:32:19 -07:00
Jonah Williams
79323f7c13 Ensure target platform is passed is always passed to assemble (#43862) 2019-10-30 19:40:19 -07:00
liyuqian
40670c09dc Allow multiple TimingsCallbacks (#43676)
This fixes https://github.com/flutter/flutter/issues/39277

The following tests cover this change:
- packages/flutter/test/foundation/service_extensions_test.dart
- packages/flutter/test/scheduler/scheduler_test.dart
2019-10-30 19:02:13 -07:00
Michael Goderbauer
99fd65e79a Remove print and fix code formatting (#43843) 2019-10-30 17:15:52 -07:00
Jonah Williams
79bc6cafc5 implement build aot with assemble for Android target platforms (#43282) 2019-10-30 15:23:25 -07:00
Erick (CptBlackPixel)
8b09a53252 Fixing focus traversal when the node options are empty (#43238)
Fixes directional focus traversal when there are no available nodes to traverse to.
2019-10-30 14:54:29 -07:00
Zachary Anderson
d0d8e6edcb [flutter_tool] Teach the tool about local engine Fuchsia artifacts (#43759) 2019-10-30 14:11:18 -07:00
Jonah Williams
417449e2f3 Deflake flutter tool logger test (#43800) 2019-10-30 13:09:26 -07:00
Jonah Williams
349d694fb7 Revert "Added a null check for ranges in the sourceReport map. (#43667)" (#43827)
This reverts commit 0dc5ea4a95.
2019-10-30 10:57:35 -07:00
LongCatIsLooong
9ea0ecc33b CupertinoSlidingSegmentedControl (#42775) 2019-10-30 10:42:48 -07:00
Efthymis Sarmpanis
c5b3b3ac26 Flutter doctor should require java 1.8+ (#41989) 2019-10-30 10:40:27 -07:00
Nate Bosch
7cf362fc31 Handle onError callback with optional argument (#43436)
Check for a binary callback first since a function with an optional
second argument will match both typedefs.

Remove documentation around a synchronous error following some other
error or value - a synchronous error can never follow a value or an
asynchronous error. If there is a synchronous error it will _always_ be
the first thing to happen.

Add a test for a unary error handler and an error handler with an
optional stack trace argument.
2019-10-30 10:39:50 -07:00
Larry McKenzie
0dc5ea4a95 Added a null check for ranges in the sourceReport map. (#43667) 2019-10-30 10:35:45 -07:00
Shi-Hao Hong
207135cd04 Separate DropdownButton and DropdownButtonFormField tests (#43738)
* Separate DropdownButtonFormField and DropdownButton test files
2019-10-30 10:27:43 -07:00