Commit Graph

18842 Commits

Author SHA1 Message Date
Greg Spencer
6e10719dc5 FocusableActionDetector widget (#44867)
This adds a FocusableActionDetector, a widget which combines the functionality of Actions, Shortcuts, MouseRegion and a Focus widget to create a detector that defines actions and key bindings, and will notify that the focus or hover highlights should be shown or not. This widget can be used to give a control the required detection modes for focus and hover handling on desktop and web platforms.

I replaced a bunch of similar code in many of our widgets with this widget, and found that pretty much any control that wants to be focusable wants all of these features as well: focus highlights, hover highlights, and actions to activate it.

Also eliminated an extra _hasFocus variable in FocusState that wasn't being used.
2019-11-18 17:23:30 -08:00
Jonah Williams
58438fca3f Provide specific field to accept depfiles in target class (#44481)
* add depfile slot to Target class

* Update source.dart

* Update source.dart
2019-11-18 14:09:40 -08:00
Greg Spencer
d026f2d948 Properly interpret modifiers on GLFW key events (#44844)
GLFW key events set modifier flags based on what the modifier state was before the event, unlike every other platform. This modifies the GLFW key support to take that into account.

As a small cleanup, I fixed a documentation macro reference for the modifier flags that was duplicate
2019-11-18 14:07:08 -08:00
Greg Spencer
21158d8337 Add command key bindings to macOS text editing and fix selection. (#44130)
This adds support for the command key for text selection/editing on macOS. I had ported the text editing code (in #42879), but forgot to add support for the command key itself. This also adds a test that tests the text editing on multiple platforms instead of just testing Android.

There appears to still be a bug (filed #44135) where we're losing key events sometimes on macOS, leaving some keys "stuck" on, but this PR at least allows the right key combinations to be used.
2019-11-18 14:06:37 -08:00
Jonah Williams
a7367b650b Don't log stack traces to console on build failures (#44966) 2019-11-18 14:04:11 -08:00
Christopher Fujino
ff84b3e66d catch IOSDeviceNotFoundError in IOSDevice.startApp() (#45011) 2019-11-18 13:53:55 -08:00
chunhtai
7e1920b817 revert added lifecycle enum (#45119) 2019-11-18 13:38:47 -08:00
Danny Tuppeny
81f6ba84b9 Switch from using app.progress to app.webLaunchUrl for passing web launch urls (#44268)
* Switch from using app.progress to app.url for passing web launch urls

* Update daemon.md

* Change app.url -> app.webLaunchUrl

* Add tests for app.webLaunchUrl event

* Update tests with recent changes after rebasing
2019-11-18 18:10:15 +00:00
chunhtai
af48f71497 reland add new enum change (#45012)
This reverts commit 75f310791f.
2019-11-18 10:04:09 -08:00
Bartosz Wiśniewski
5c15b270b3 Remove duplicated expect from text field test (#45081) 2019-11-18 09:51:16 -08:00
Ian Hickson
62e4ab87b3 Update our deprecation style. (#44618) 2019-11-15 19:21:53 -08:00
Jonah Williams
2a576b774c remove no-gen-bytecode flag (#43908) 2019-11-15 13:15:05 -08:00
Kate Lovett
ae62a3cf1b Error Message for createState assertion (#44610)
* Init

* Added error message to assert

* Removing unrelated changes
2019-11-15 13:05:18 -08:00
Kate Lovett
b1ca7f419e Update Gold to fallback on skipping comparator when offline (#44619) 2019-11-15 13:04:59 -08:00
Ben Konyi
e3ae7fab62 Manual engine roll to b2640d97e7e8034f28b4e7b92c15b0824e433897 (#45000)
Fixes failures in some tests which used regular expressions to compare
stack traces which had instances of "<asynchronous suspension>".
2019-11-15 12:13:59 -08:00
Zachary Anderson
29c026fac4 [flutter_tool] Don't crash when failing to delete downloaded artifacts (#44933)
* [flutter_tool] Don't crash when failing to delete downloaded artifacts

* Add space

* Add more spaces.
2019-11-15 10:05:45 -08:00
LongCatIsLooong
851d6996e7 Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)" (#44778)
* Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)"

This reverts commit 9aea03f4af.
2019-11-14 17:14:26 -08:00
Kaushik Iska
f48f457350 [flutter_runner] Use sky_engine from the topaz tree (#44935) 2019-11-14 17:09:45 -08:00
Kaushik Iska
75f310791f Revert "reland add new enum change (#44281) (#44487)" (#44947)
This reverts commit f0794917fc.
2019-11-14 16:49:43 -08:00
chunhtai
f0794917fc reland add new enum change (#44281) (#44487)
* reland add new enum change (#44281)

This reverts commit ed82bb821c.
2019-11-14 13:27:38 -08:00
Ian Hickson
96fbbdc3e0 Fix "node._relayoutBoundary == _relayoutBoundary" crash (#44490) 2019-11-14 13:19:55 -08:00
Zachary Anderson
afe4830a9d [flutter_tool] Various fixes for 'run' for Fuchisa. (#44920) 2019-11-14 12:39:48 -08:00
Jenn Magder
55530d905a Add -runFirstLaunch hint text (#44870) 2019-11-14 10:45:47 -08:00
Danny Tuppeny
5376e90fda Print a message when modifying settings that you may need to reload IDE/editor (#44574)
* Print a message when modifying settings that you may need to reload IDEs/editors

* Add a test for `flutter config` output

* Remove blank line
2019-11-14 17:54:22 +00:00
Casey Hillers
5506cc5b15 Remove no longer needed clean up code (#44408) 2019-11-14 09:38:12 -08:00
Jonah Williams
e77c24ef91 Update package test (#44882) 2019-11-14 09:31:36 -08:00
Zachary Anderson
a4cc799d15 [flutter_tool] Update Fuchsia SDK (#44457) 2019-11-14 09:11:26 -08:00
Jenn Magder
25b33a8c3b Fake locale in doctor_test (#44878) 2019-11-13 19:08:10 -08:00
Jenn Magder
e57ab1f263 Add module to create template help text (#44638) 2019-11-13 18:28:45 -08:00
Jenn Magder
6498f64399 Catch and display version check errors during doctor (#44868) 2019-11-13 18:23:05 -08:00
Jonah Williams
e3cb2c3fcf Reland: Allow specifying device-vmservice-port and host-vmservice-port (#44853) 2019-11-13 16:02:46 -08:00
Jonah Williams
985da83139 Revert "Allow specifying device-vmservice-port and host-vmservice-port (#44027)" (#44843)
This reverts commit c0af77bf87.
2019-11-13 14:35:07 -08:00
Emmanuel Garcia
0019599411 Build AAR for all build variants by default (#44797) 2019-11-13 13:27:10 -08:00
Jonah Williams
c0af77bf87 Allow specifying device-vmservice-port and host-vmservice-port (#44027) 2019-11-13 13:01:41 -08:00
Michael Goderbauer
bcc93bca23 Make disposing a ScrollPosition with pixels=null legal (#44617) 2019-11-13 11:31:20 -08:00
Emmanuel Garcia
f766871eb9 Forward ProcessException to error handlers (#44783) 2019-11-13 10:02:46 -08:00
Tong Mu
01f4f1ac55 ModalBarrier and Drawer barrier prevents mouse events (#44296)
* Add opaque to barriers
* Detect opaque and test
2019-11-12 18:25:53 -08:00
Jenn Magder
2d42b43a50 Turn on bitcode for integration tests and add-to-app templates (#44633) 2019-11-12 18:00:31 -08:00
Jonah Williams
7caef218b5 refactorings to testbed.run and testbed.test (#44488) 2019-11-12 15:35:59 -08:00
Jonah Williams
2779361b38 Ensure web-server does not force usage of dwds (#44744) 2019-11-12 15:24:45 -08:00
Jonah Williams
3383b564a1 Always link desktop platforms (#44753) 2019-11-12 15:24:18 -08:00
Jenn Magder
47f71ba3c3 Release startup lock during long-lived build ios framework (#44625) 2019-11-12 15:14:29 -08:00
Jonah Williams
a901b650b6 Update meta to 1.1.8 (#44584) 2019-11-12 13:48:42 -08:00
Shi-Hao Hong
2b498567a4 Sort Localization generation output (#44743)
* Sort Localization generation output

- When creating locales that were assumed from existing locales, the
file that is used is non-deterministic. This adds a sort to the iterator
to ensure that the same existing locale is used to generate the assumed
locale
- When generating material, cupertino and date localizations, the generated getters were not sorted. This
introduces an alphabetic sort

* remove main.dart.snapshot
2019-11-12 12:50:51 -08:00
Greg Spencer
d39e2bb776 Check in new diffs to material localizations (#44736)
Updates localizations to match what is now generated. It's unclear what caused the change: it didn't happen because of a flutter PR change, so we're still looking for where the source of the non-determinism is.  In the meantime, this will fix the build.
2019-11-12 10:27:58 -08:00
xster
9e0df259df Show a warning when a module uses a v1 only plugin (#44499) 2019-11-11 15:56:43 -08:00
Mouad Debbar
9307a83f7c Changing RenderEditable.textAlign doesn't break hot reload anymore (#44605) 2019-11-11 14:35:15 -08:00
Greg Spencer
23d1ae0ff7 Convert to TextPosition for getWordBoundary (#44611)
Convert the call to getWordBoundary to use a TextPosition, in preparation for landing flutter/engine#13727, which switches the desired API to the final desired API.
2019-11-11 14:27:06 -08:00
Sam Rawlins
86c91b12d8 Remove new unused elements (#44551) 2019-11-11 13:29:46 -08:00
Yegor
e7073f9a1f add --dart-defines option (#44083) 2019-11-09 17:08:53 -08:00