firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
43,581 Commits 1 Branch 0 Tags
a4be7cd70a0c503f0b29d8d2585d3d442862b4d7
Commit Graph

43581 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mohammed CHAHBOUN
a4be7cd70a Added Mohammed Chahboun to authors (#160311) 
Adds [Mohammed
Chahboun](https://github.com/flutter/flutter/pulls/M97Chahboun) to
authors
 2024-12-15 17:46:19 +00:00
engine-flutter-autoroll
7877a076a6 Roll Flutter Engine from 4e4a430bcd0d to a9f7fa8ca613 (1 revision) (#160294) 
4e4a430bcd...a9f7fa8ca6

2024-12-14 goderbauer@google.com Adjust some ignores for 'dart format'
(flutter/engine#57208)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-14 03:46:08 +00:00
engine-flutter-autoroll
fc9124cb4f Roll Flutter Engine from c4e3cc27afef to 4e4a430bcd0d (2 revisions) (#160291) 
c4e3cc27af...4e4a430bcd

2024-12-14 goderbauer@google.com Fix include path in fuchsia's
analysis_options.yaml files (flutter/engine#57203)
2024-12-13 goderbauer@google.com Delete stale package_config.json in
gclient sync hook (flutter/engine#57195)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-14 02:47:38 +00:00
engine-flutter-autoroll
e7fcd0d6e6 Roll Flutter Engine from f0ff4f25bda8 to c4e3cc27afef (5 revisions) (#160290) 
f0ff4f25bd...c4e3cc27af

2024-12-13 jason-simmons@users.noreply.github.com [skwasm] Fix
implementation of SkwasmPath.relativeLineTo (flutter/engine#57201)
2024-12-13 30870216+gaaclarke@users.noreply.github.com Made compilation
error colors come through et. (flutter/engine#57174)
2024-12-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
iWMEbVYaNdH8RJmXZ... to iYz_WkWk1uPr8BLSZ... (flutter/engine#57198)
2024-12-13 yjbanov@google.com [web] allow imports to line-break
(flutter/engine#57170)
2024-12-13 41930132+hellohuanlin@users.noreply.github.com [ios]limit web
view not tappable workaround to a limited depth (flutter/engine#57193)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from iWMEbVYaNdH8 to iYz_WkWk1uPr

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-14 01:47:26 +00:00
Matan Lurey
0875988f5f Migrate flutter_command_test.dart to explicit-package-dependencies. (#160274) 
Work towards https://github.com/flutter/flutter/issues/160257.
 2024-12-14 00:08:28 +00:00
Matan Lurey
5e7c856d5b Migrate test/general.shard/*plugin* tests to explicit-package-dependencies. (#160279) 
Towards https://github.com/flutter/flutter/issues/160257.
 2024-12-13 23:18:07 +00:00
Matan Lurey
14177eaa7c Migrate the rest of general.shard to explicit-package-dependencies. (#160280) 
Towards https://github.com/flutter/flutter/issues/160257.
 2024-12-13 23:14:22 +00:00
Matan Lurey
b008e5b60c Migrate resident_web_runner_test.dart to explicit-package-dependencies. (#160278) 
Work towards https://github.com/flutter/flutter/issues/160257.
 2024-12-13 22:56:05 +00:00
Matan Lurey
15517f0569 Migrate hot_test.dart to explicit-package-dependencies. (#160277) 
Work towards https://github.com/flutter/flutter/issues/160257.
 2024-12-13 22:43:21 +00:00
Matan Lurey
6bcb15db63 Migrate cocoapods_test.dart to explicit-package-dependencies. (#160264) 
Work towards https://github.com/flutter/flutter/issues/160257.
 2024-12-13 22:37:08 +00:00
Matan Lurey
96aeed4591 Migrate test/general.shard/build_system to explicit-package-dependencies. (#160275) 
Work towards https://github.com/flutter/flutter/issues/160257.
 2024-12-13 22:30:38 +00:00
Matan Lurey
61025ca2dd Migrate test/general.shard/web to explicit-package-dependencies. (#160273) 
Work towards https://github.com/flutter/flutter/issues/160257.
 2024-12-13 22:22:21 +00:00
Matan Lurey
5332e696a4 Migrate generate_synthetic_packages_test.dart to explicit-package-dependencies. (#160267) 
Work towards https://github.com/flutter/flutter/issues/160257.

Unlike some of the other PRs, this test explicitly _opts-out_ of the
flag, as the test itself is testing whether the now deprecated feature
works.
 2024-12-13 22:22:12 +00:00
Matan Lurey
47403e351e Migrate test_compiler_test.dart to explicit-package-dependencies. (#160265) 
Work towards https://github.com/flutter/flutter/issues/160257.
 2024-12-13 22:21:58 +00:00
Matan Lurey
1e2322c080 Enable explicit-package-dependencies (resident_web_runner_cold_test.dart) (#160258) 
Example of option (2) for
https://github.com/flutter/flutter/issues/160257.
 2024-12-13 21:14:20 +00:00
Gray Mackall
2948917a47 [Reland] Force automatic ndk download when building for Android (#160260) 
Relands https://github.com/flutter/flutter/pull/159756.

The original caused some stderr because
1. the configurable `ndkVersion` value that AGP provides used to be null
by default.
2. Now it is not, instead it has a default value
3. `integration_test` doesn't actually use the NDK, but default for
`integration_test` was higher that `flutter.ndkVersion`
4. We have code that checks if a plugin uses a higher ndk version and
tells you to consider upgrading
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy#L921

This reverts the revert, and then aligns `integration_test`'s NDK
version (which again, it doesn't actually use, so I'm not too concerned
about the downgrade) with `flutter.ndkVersion`.

It also starts using the `flutter.min/compile/ndkVersion` values in
`integration_test`, which was unrelated to the original pr. Can remove
if you think it should land separately.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
 2024-12-13 20:27:23 +00:00
Christopher Fujino
29a6c648ca precompile generate_gradle_lockfile script BEFORE updating pub dependencies (#160059) 
Avoid situations like https://github.com/flutter/flutter/issues/160055
 2024-12-13 19:43:25 +00:00
chunhtai
82ecbb5cbd Refactor gradle task runner to share error handler code (#159452) 
fixes https://github.com/flutter/flutter/issues/153893

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
 2024-12-13 18:51:20 +00:00
engine-flutter-autoroll
08b2e23e2e Roll Flutter Engine from 3c263a38f56b to f0ff4f25bda8 (1 revision) (#160254) 
3c263a38f5...f0ff4f25bd

2024-12-13 sstrickl@google.com Add entry-point annotations for test-only
code. (flutter/engine#57158)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-13 18:31:29 +00:00
Nate Wilson
7aa4d2d3ec Fix Stepper connector not being properly displayed (#160193) 
@ayyoub-coder gave a fantastic summary of the problem in #160177: if a
`Container` doesn't have a child or unbounded constraints, it will
expand to fill its parent, whereas a `ColoredBox` defaults to zero size.

I also noticed that in the main branch, the `PositionedDirectional`
widget has an unused `width` parameter, and instead builds a `SizedBox`
child for it.

This pull request cleans up the `Stepper` subtree a bit and allows the
connector to display properly.

fixes #160156
 2024-12-13 16:26:26 +00:00
engine-flutter-autoroll
335300d9da Roll Packages from cbdb48a0bcee to 56886ffe11ad (6 revisions) (#160245) 
cbdb48a0bc...56886ffe11

2024-12-13 rjs580@usask.ca [webview_flutter_android] Allow configuration
of WebView file access through `setAllowFileAccess`
(flutter/packages#8228)
2024-12-13 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Activate leak testing (flutter/packages#8059)
2024-12-12 ultraon83@gmail.com [go_router] Fix a typo in a comment in
the shell_route.dart (flutter/packages#8235)
2024-12-12 stuartmorgan@google.com [ci] Update for 3.27 stable release
(flutter/packages#8284)
2024-12-12 engine-flutter-autoroll@skia.org Manual roll Flutter from
f559e16010 to 6966a2eef1 (5 revisions) (flutter/packages#8283)
2024-12-12 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
dec2ee5c1f98 to 8495dee1fd4a (1318 revisions) (flutter/packages#8280)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-13 15:44:27 +00:00
Bruno Leroux
eaf74bdd11 Fix NavigationDrawerDestination backgroundColor obscures interactions (#160239) 
## Description

This PR fixes `NavigationDrawerDestination.backgroundColor` obscuring
ink well splashes and overlay.
Before this PR the destination background color was renderer in a
`ColoredBox` which hides the ink well effects. This PR replaces the
`ColorsBox` with an `Ink`.

## Related Issue

Fixes [NavigationDrawerDestination backgroundColor obscures interaction
states](https://github.com/flutter/flutter/issues/160109)

## Tests

Updates 1 test.
 2024-12-13 12:06:28 +00:00
engine-flutter-autoroll
26ea690af8 Roll Flutter Engine from b9df033311cc to 3c263a38f56b (1 revision) (#160238) 
b9df033311...3c263a38f5

2024-12-13 skia-flutter-autoroll@skia.org Roll Skia from 0aec6f7bfbc8 to
8c1e2bf9492c (26 revisions) (flutter/engine#57183)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-13 09:26:25 +00:00
engine-flutter-autoroll
56d26118d6 Roll Flutter Engine from 5eedfefe38c1 to b9df033311cc (1 revision) (#160233) 
5eedfefe38...b9df033311

2024-12-13 flar@google.com Migrate DlRTree and DlRegion to
DisplayList/Impeller geometry classes (flutter/engine#57175)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-13 06:41:22 +00:00
engine-flutter-autoroll
6a5445833b Roll Flutter Engine from 9b51e30a4d37 to 5eedfefe38c1 (12 revisions) (#160220) 
9b51e30a4d...5eedfefe38

2024-12-13 flar@google.com Normalize round rect bounds when coming from
Flutter (flutter/engine#57171)
2024-12-13 41930132+hellohuanlin@users.noreply.github.com [ios]enable
the webview non tappable workaround by checking subviews recursively
(flutter/engine#57168)
2024-12-12 30870216+gaaclarke@users.noreply.github.com removed c style
casts and enabled the lint (flutter/engine#57162)
2024-12-12 jonahwilliams@google.com [Impeller] exploit perfect hash for
SamplerDescriptor. (flutter/engine#57036)
2024-12-12 30870216+gaaclarke@users.noreply.github.com Reenabled
labelling test with a capabilities check. (flutter/engine#57160)
2024-12-12 jonahwilliams@google.com [Impeller] dont print format strings
for blend filter and snapshots. (flutter/engine#57105)
2024-12-12 robert.ancell@canonical.com Make fl_engine_send_key_event
into a standard async function. (flutter/engine#57112)
2024-12-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
HJ57Y3zxqDamI8qkY... to iWMEbVYaNdH8RJmXZ... (flutter/engine#57163)
2024-12-12 robert.ancell@canonical.com Migrate FlPlatformChannel tests
to FlMockBinaryMessenger (flutter/engine#57140)
2024-12-12 robert.ancell@canonical.com Migrate FlBasicMessageChannel
tests to FlMockBinaryMessenger (flutter/engine#57115)
2024-12-12 flar@google.com Migrate layers and layer_tree to
DisplayList/Impeller geometry classes (flutter/engine#57153)
2024-12-12 mdebbar@google.com [web] Use CanvasKit to run tests under
engine/ (flutter/engine#54786)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from HJ57Y3zxqDam to iWMEbVYaNdH8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-13 03:53:26 +00:00
Mohammed CHAHBOUN
9742656610 Adds splashBorderRadius property to TabBarTheme (#160046) 
Adds splashBorderRadius property to TabBarTheme

Fix #159845 


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
 2024-12-12 23:52:19 +00:00
auto-submit[bot]
5cd440f6ec Reverts "Force automatic ndk download when building for Android (#159756)" (#160205) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#159756
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gmackall
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Made the tree red due to some std out.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gmackall
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {reidbaker}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
In preparation for changing engine builds to be unstripped by default
https://github.com/flutter/engine/pull/52852, which will allow us to
make progress towards resolving
https://github.com/flutter/flutter/issues/60240.

Tricks AGP in to downloading the NDK when building a flutter app (that
uses the FGP, which to my knowledge is all ways of building flutter
apk/aab/aar).

I want to follow this up by modifying the tool to search for the log
line that the NDK is missing (making it throw an error in that case) as
a safeguard, because that would be the last line of defense before we
accidentally build a bloated app. The safeguard won't work for add to
app, from what I understand, because while they use the FGP (so they
should be forced to be download the NDK) they don't invoke the flutter
tool, and therefore won't invoke the custom error handling of
[`gradle_errors.dart`](https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/gradle_errors.dart)

Some details

1. Respects existing values for `externalNativeBuild.cmake.path` for
apps that actually use it.
2. Silences some warnings that would otherwise appear for add to app
builds or builds that manually invoke gradle:
```
C/C++: CMake Warning (dev) in CMakeLists.txt:
C/C++:   No project() command is present.  The top-level CMakeLists.txt file must
C/C++:   contain a literal, direct call to the project() command.  Add a line of
C/C++:   code such as
C/C++:     project(ProjectName)
C/C++:   near the top of the file, but after cmake_minimum_required().
C/C++:   CMake is pretending there is a "project(Project)" command on the first
C/C++:   line.
C/C++: This warning is for project developers.  Use -Wno-dev to suppress it.
C/C++: CMake Warning:
C/C++:   Manually-specified variables were not used by the project:
C/C++:     CMAKE_EXPORT_COMPILE_COMMANDS
C/C++:     CMAKE_LIBRARY_OUTPUT_DIRECTORY
C/C++:     CMAKE_RUNTIME_OUTPUT_DIRECTORY
```
3. Our ci installs the NDK at an abnormal place that AGP can't find
without help. I've modified all the `build.gradle`s that we have checked
in to point to the pre-installed path. **But some of our tests make a
new app from the templates, and those tests will now start downloading
the NDK** (as they won't be able to find it at it's current path from
templates). We could resolve this by actually fixing
https://github.com/flutter/flutter/issues/136666. This would be a very
significant lift from what I understand - we rely on this hardcoding in
a lot of places in our infra.


Fixes https://github.com/flutter/flutter/issues/155576

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2024-12-12 23:44:26 +00:00
Gray Mackall
99786b413f Force automatic ndk download when building for Android (#159756) 
In preparation for changing engine builds to be unstripped by default
https://github.com/flutter/engine/pull/52852, which will allow us to
make progress towards resolving
https://github.com/flutter/flutter/issues/60240.

Tricks AGP in to downloading the NDK when building a flutter app (that
uses the FGP, which to my knowledge is all ways of building flutter
apk/aab/aar).

I want to follow this up by modifying the tool to search for the log
line that the NDK is missing (making it throw an error in that case) as
a safeguard, because that would be the last line of defense before we
accidentally build a bloated app. The safeguard won't work for add to
app, from what I understand, because while they use the FGP (so they
should be forced to be download the NDK) they don't invoke the flutter
tool, and therefore won't invoke the custom error handling of
[`gradle_errors.dart`](https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/gradle_errors.dart)

Some details

1. Respects existing values for `externalNativeBuild.cmake.path` for
apps that actually use it.
2. Silences some warnings that would otherwise appear for add to app
builds or builds that manually invoke gradle:
```
C/C++: CMake Warning (dev) in CMakeLists.txt:
C/C++:   No project() command is present.  The top-level CMakeLists.txt file must
C/C++:   contain a literal, direct call to the project() command.  Add a line of
C/C++:   code such as
C/C++:     project(ProjectName)
C/C++:   near the top of the file, but after cmake_minimum_required().
C/C++:   CMake is pretending there is a "project(Project)" command on the first
C/C++:   line.
C/C++: This warning is for project developers.  Use -Wno-dev to suppress it.
C/C++: CMake Warning:
C/C++:   Manually-specified variables were not used by the project:
C/C++:     CMAKE_EXPORT_COMPILE_COMMANDS
C/C++:     CMAKE_LIBRARY_OUTPUT_DIRECTORY
C/C++:     CMAKE_RUNTIME_OUTPUT_DIRECTORY
```
3. Our ci installs the NDK at an abnormal place that AGP can't find
without help. I've modified all the `build.gradle`s that we have checked
in to point to the pre-installed path. **But some of our tests make a
new app from the templates, and those tests will now start downloading
the NDK** (as they won't be able to find it at it's current path from
templates). We could resolve this by actually fixing
https://github.com/flutter/flutter/issues/136666. This would be a very
significant lift from what I understand - we rely on this hardcoding in
a lot of places in our infra.


Fixes https://github.com/flutter/flutter/issues/155576

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
 2024-12-12 23:23:29 +00:00
Tong Mu
c16aa2d232 Make animation and router support simulation, and use Spring for Cupertino (#155575) 
This PR makes `TransitionRoute` support driving the animation with
`Simulation`. This is needed for Cupertino widgets, since iOS use
"spring simulations" for a majority of their animations.

This PR also applies the standard spring animation to
`CupertinoDialogRoute` (alert dialogs) and `CupertinoModalPopupRoute`
(action sheets). (This PR does not yet support customizing the spring
parameters or conveniently using the springs for custom routes, which
are left for future PRs.)

### Comparison

I tried to create a comparison video for action sheets, however the
difference is far less noticeable than I expected. (All clips are
precisely aligned at the moment the pointer is lifted.) I guess the
original curve _is_ good enough. Nevertheless, the spring simulation is
the correct one and we should support it.

Edit: [The
comment](https://github.com/flutter/flutter/pull/155575#issuecomment-2489303282)
below also mentioned that supporting spring animation will improve the
fidelity when the animation is caused by a user gesture. I assume this
requires initial speed, which is not supported by this PR but we can add
it in the future.


https://github.com/user-attachments/assets/06d2f684-ad1c-4a4d-8663-a561895f45e9

Also, Flutter's response seems to be always a moment slower than
SwiftUI, possibly because Flutter requiring two frames to start the
animation (one frame to add the transition widget, one frame for the
animation to actually progress.) We probably want to solve it in the
future.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-12-12 21:56:11 +00:00
Mouad Debbar
dd437c7a60 [web] Enable platform view benchmarks in Skwasm (#160186) 
Skwasm has support for platform views already. Let's enable those
benchmarks.
 2024-12-12 20:32:27 +00:00
engine-flutter-autoroll
688dee4c61 Roll Flutter Engine from 0bcea845cd31 to 9b51e30a4d37 (4 revisions) (#160190) 
0bcea845cd...9b51e30a4d

2024-12-12 chris@bracken.jp iOS: Reduce engine/view controller coupling
(flutter/engine#57151)
2024-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
770ff2b085fc to 02aa27c6a075 (1 revision) (flutter/engine#57161)
2024-12-12 goderbauer@google.com Format _empty.dart
(flutter/engine#57144)
2024-12-12 jason-simmons@users.noreply.github.com [Impeller] Fix a race
in the ReactorGLES.PerThreadOperationQueues test (flutter/engine#57147)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-12 20:19:55 +00:00
Andrew Kolos
6b12651419 Fix analytics enabled/disabled event not being sent when the user enables/disables analytics (#160060) 
Fixes https://github.com/flutter/flutter/issues/160058.

In addition, only send an event when the enabled-state of analytics
actually gets flipped.


<details>

<summary> Pre-launch checklist </summary> 


- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

</details>


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-12-12 19:59:50 +00:00
engine-flutter-autoroll
6966a2eef1 Roll Packages from 16616ad588d7 to cbdb48a0bcee (4 revisions) (#160170) 
16616ad588...cbdb48a0bc

2024-12-12 engine-flutter-autoroll@skia.org Manual roll Flutter from
918b2b9ddb to f559e16010 (4 revisions) (flutter/packages#8277)
2024-12-12 tarrinneal@gmail.com disable maps test and manual roll
(flutter/packages#8275)
2024-12-11 sinyuper@gmail.com [quick_actions] add localizedSubtitle for
iOS (flutter/packages#8038)
2024-12-11 napoleon.na1120@gmail.com [video_player_avfoundation] Support
the audio-only HLS (.m3u8) on iOS (flutter/packages#7890)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-12 16:52:10 +00:00
engine-flutter-autoroll
d085381da9 Roll Flutter Engine from 4d8488f02cd8 to 0bcea845cd31 (1 revision) (#160171) 
4d8488f02c...0bcea845cd

2024-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
70062c353404 to 770ff2b085fc (2 revisions) (flutter/engine#57159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-12 16:44:26 +00:00
Tess Strickland
efa109d405 Add entry-point annotations for test-only code. (#160158) 
This change adds entry-point annotations to methods and classes accessed
by native code during Flutter tests. Currently, entry point annotations
are not checked by the Dart VM when running in JIT mode, only in AOT
mode. In order to also enforce entry point annotations in JIT mode,
first tests in Flutter must be appropriately annotated to avoid roll
failures.

Related issues:
* https://github.com/flutter/flutter/issues/118608
* https://github.com/dart-lang/sdk/issues/50649

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-12-12 13:46:38 +00:00
engine-flutter-autoroll
2d3ff85559 Roll Flutter Engine from 847deb2089a3 to 4d8488f02cd8 (2 revisions) (#160165) 
847deb2089...4d8488f02c

2024-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
96022397c58d to 70062c353404 (1 revision) (flutter/engine#57155)
2024-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
aa03dca5beb2 to 96022397c58d (2 revisions) (flutter/engine#57149)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-12 13:45:10 +00:00
engine-flutter-autoroll
3a4b07bf52 Roll Flutter Engine from 92de3d0f8830 to 847deb2089a3 (2 revisions) (#160134) 
92de3d0f88...847deb2089

2024-12-12 bryanoltman@gmail.com Cast ::GetLastError to int
(flutter/engine#57113)
2024-12-12 jonahwilliams@google.com Manual Skia roll from 79a7b95e32fe
to 0aec6f7bfbc8 (flutter/engine#57134)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-12 03:13:39 +00:00
engine-flutter-autoroll
f559e16010 Roll Flutter Engine from e3524615fb69 to 92de3d0f8830 (1 revision) (#160132) 
e3524615fb...92de3d0f88

2024-12-11 30870216+gaaclarke@users.noreply.github.com Removed heap
allocations for conical, radial and sweep gradients
(flutter/engine#57143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-12 02:04:26 +00:00
engine-flutter-autoroll
e433e08cbe Roll Flutter Engine from b8034f152711 to e3524615fb69 (2 revisions) (#160128) 
b8034f1527...e3524615fb

2024-12-11 jonahwilliams@google.com [Impeller] remove std::vector usage
in render pass vk. (flutter/engine#57132)
2024-12-11 43723477+RBT22@users.noreply.github.com [Linux] Add
Multi-Touch Support for Linux (flutter/engine#54214)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-12 00:46:26 +00:00
engine-flutter-autoroll
846cbcd35b Roll Flutter Engine from ba7ad8719733 to b8034f152711 (3 revisions) (#160126) 
ba7ad87197...b8034f1527

2024-12-11 skia-flutter-autoroll@skia.org Roll Dart SDK from
be9c98daf9df to aa03dca5beb2 (1 revision) (flutter/engine#57136)
2024-12-11 jason-simmons@users.noreply.github.com Make Felt unzip Chrome
into a temporary directory next to the final location of the files
(flutter/engine#57109)
2024-12-11 jonahwilliams@google.com [engine] changes to
DlVertices::Builder and Stopwatch visualizer. (flutter/engine#57031)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 23:41:31 +00:00
engine-flutter-autoroll
34c0f5221e Roll Flutter Engine from 3cdd84160baa to ba7ad8719733 (1 revision) (#160117) 
3cdd84160b...ba7ad87197

2024-12-11 jonahwilliams@google.com [Impeller] avoid expensive texture
labeling w/ no validation layers. (flutter/engine#57130)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 22:37:23 +00:00
Jackson
918b2b9ddb Added spellCheckConfiguration to the constructor of CupertinoTextFormFieldRow (#159385) 
Before: No way to set the _spellCheckConfiguration_ property of a
CupertinoTextFormFieldRow, meaning no spellcheck/highlighting of
incorrect words is present. This can be done on the standard
CupertinoTextField widget, but not the CupertinoTextFormFieldRow widget.

![image](https://github.com/user-attachments/assets/891721c4-020b-4a3f-9492-e2ba7a475bd5)

After: Adding this property allows the _spellCheckConfiguration_ to be
configured and spellcheck/highlighting of incorrect words working as
expected.

![image](https://github.com/user-attachments/assets/7b20692d-9444-4ce6-9b43-54bda7de2552)

![image](https://github.com/user-attachments/assets/3e86c901-4954-4ac2-9f63-bcdddfa3b43c)

Fixes #159382 by adding the _ spellCheckConfiguration_ field to the
constructor of CupertinoTextFormFieldRow and passing the value through
to CupertinoTextField.borderless internally.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-12-11 20:38:00 +00:00
engine-flutter-autoroll
25ab2e0bda Roll Flutter Engine from 7941d7801b08 to 3cdd84160baa (5 revisions) (#160110) 
7941d7801b...3cdd84160b

2024-12-11 jonahwilliams@google.com [Impeller] set UniformBlockBinding
once. (flutter/engine#57094)
2024-12-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
5taAI9-tnFN84ZJvr... to HJ57Y3zxqDamI8qkY... (flutter/engine#57125)
2024-12-11 30870216+gaaclarke@users.noreply.github.com Removed linear
gradient heap allocation for color conversions between dart and display
list (flutter/engine#57108)
2024-12-11 jason-simmons@users.noreply.github.com Dispose pictures
created in HtmlViewEmbedder.submitFrame (flutter/engine#57102)
2024-12-11 skia-flutter-autoroll@skia.org Roll Dart SDK from
4789a86f4d3f to be9c98daf9df (1 revision) (flutter/engine#57124)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 5taAI9-tnFN8 to HJ57Y3zxqDam

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 20:29:57 +00:00
Ben Konyi
292695e7c1 Don't throw StateError when listing core devices during tool shutdown (#160094) 
The previous attempt at this fix was assuming that the tool's file
system was a `LocalFileSystem`, but in reality it's a `LocalFileSystem`
wrapped in an `ErrorHandlingFileSystem`. This change takes this into
account.

Fixes https://github.com/flutter/flutter/issues/160082 
Fixes https://github.com/flutter/flutter/issues/156962

---------

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
 2024-12-11 20:12:48 +00:00
Christopher Fujino
8cdb333b47 Update changelog with 3.27 changes (#160105) 2024-12-11 19:40:06 +00:00
Michael Goderbauer
c4dc2c9890 Add script to check format of changed dart files (#160007) 
The script is modeled after a similar script in the engine (see engine's
[format.dart](https://github.com/flutter/engine/blob/main/ci/bin/format.dart)).

It identifies the files that have been changed and checks if their
formatting is correct. It also offers an option to correct formatting
(`--fix`) and an option to check the formatting of all files in the
repro (not just changed ones, `--all-files`).

When we are enforcing dart format this script will be called as part of
presubmit.
 2024-12-11 19:38:24 +00:00
Mairramer
2f9e2d9bc9 Fix false positive validation result on form submission with AutovalidateMode.onUnfocus (#159394) 
Fixes #159378
Resolved an issue where focused TextFormField was bypassed during form
validation
when using AutovalidateMode.onUnfocus on mobile devices. Validation is
now correctly
triggered for all fields, including those that are focused.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-12-11 19:20:22 +00:00
engine-flutter-autoroll
7c3c60b598 Roll Flutter Engine from e4316b8bc5f2 to 7941d7801b08 (1 revision) (#160092) 
e4316b8bc5...7941d7801b

2024-12-11 skia-flutter-autoroll@skia.org Roll Skia from 830bc24e0b98 to
79a7b95e32fe (2 revisions) (flutter/engine#57122)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 19:16:45 +00:00
engine-flutter-autoroll
6f917c92f6 Roll Packages from 0f1fd493b893 to 16616ad588d7 (2 revisions) (#160099) 
0f1fd493b8...16616ad588

2024-12-10 engine-flutter-autoroll@skia.org Manual roll Flutter from
ab5b20c16d to 456366232a (10 revisions) (flutter/packages#8264)
2024-12-10 sinyuper@gmail.com [quick_action_ios] add localizedSubtitle
for iOS (flutter/packages#8149)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 19:16:45 +00:00
Christopher Fujino
8aaec3a093 Conductor output updates (#160054) 
Update some outdated, obsolete text output from the conductor.
 2024-12-11 19:15:12 +00:00