82c8c78739 Make StreamTransformer(..) transformed stream mimic original's isBroadcast.
022adc5bc3 Implement using suggestion sets for LSP completions
0f24e4b277 Wire up LSP completion resolution provider + sendWorkspaceEdit command
b6ce27a141 Add LSP tests for suggestion sets (marked failing)
7be23977f1 Minor LSP tweaks in preperation for included suggestionSets
435066d194 [infra] Increase number of shards for debug precomp builder.
09b46aa084 Support in-memory CodegenResult serialization/deserialization
c69d0c6e30 Flatten DynamicUse and StaticUse class hierarchies
6757d0c6d9 Use ModularNamer/ModularEmitter to generate code separate from codegen enqueuing
a9827a0c05 Refactor OneShotInterceptorData to prepare for modular codegen
c0b967d7da Refactor Namer and ConstantEmitter to prepare for modular compilation
670ac1aca8 Prepare js_ast for more advanced use of DeferredExpression
e13b1b6e0c Build summary2 for SDK.
58cf83df4d Don't crash on during indexing references to named parameters of a generic function types.
5e5b03881c Fix for exporting setters.
234103f9d4 Fix for hasImplicitReturnType.
2d8fc016b9 Sort declarations in resynthesize_common.dart
ed169c4bb0 Revert "[vm/ffi] FFI callbacks on X64."
f930d674ca Restore old nullability behavior of TypeParameterElement.type.
ce62987c9d Remove DynamicState and make NumState an abstract class
be209f7846 [vm/ffi] FFI callbacks on X64.
9e30fbaea4 [vm] Unify function prologue generation across all backends.
9b1c8fca91 More fixes for GenericFunctionType.
cf15dc17e0 With summary2 FunctionTypedFormalParameter has type parameters.
7983fac33b add "extension" built-in keyword for extension methods
475f55d46b Add dart2js modular test suite under a unit test.
1f409716d6 Add packageBase to simplify how we build packages files and how we process package import uris
c6f6713de1 [vm,exception] notify debugger to stop for ReThrow
8d52c0d08e Store library nullability status in LibraryElement; adjust TypeParameterElement.type based on it.
c33f1a079e revise scanner api so that error tokens are always prepended
42334a7f67 Infer when the bound of a type parameter needs to be nullable.
5ffff98440 Add `autoUncompress` to _HttpClientResponse
86c7165969 [tests] Avoid use of `$strong` because it is always true now
8209013be3 Fix DartDoc section in Diagnostics server for LSP
57c970d87a [dart/vm] Fix inconsistencies in intermediate representation
034fce1e39 [dart:io] unbreak build
7f323feefe [dart:io] Fix iOS https leaks
1c469617c5 TypeParameter.declaredElement is guaranteed to be a TypeParameterElement
14d21859e7 Make assertConnection failures easier to debug
ea9b0cd0f5 [ VM / FFI ] Fixed imports in ffi.h which were invalid for Flutter iOS build
af2d02f9c8 fix lint code reporting
f6d3466856 Work around DDC with summary2 for now.
6805bb52ea Add implementation/tests for textDocument/Implementation
3a7ce7a646 Enable declarations tracker for LSP to support dart doc macros
cdcc387084 Add LSP custom notifications for analyzing status
6ac6d3ae7d Fix FileState refresh2 to allow caching.
a3073fc581 check null condition in assert
ebaf0ad8b1 Record GenericFunctionType nodes separately in the unit.
bc34b65a13 cleanup tests
bd840b93cb [package:vm] Account for package map comments.
c855b9bfa3 move error token processing to parser
a50dcd8fe6 remove unused field
f440f77dd3 Store the nullability graph in the nullability nodes rather than in maps.
3ecb89ba8c Move NullabilityGraph into nullability_node.dart.
6080e546c9 Rearrange NullabilityNode class hierarchy.
6d5f763952 [vm] Eliminate Mutex/Monitor indirection where possible
bed74d6e97 Remove NullabilityGraph._upstream.
b0727bd661 [dart/vm] enhanced graph checker
228df22dbf Remove the old constraint variable based nullability migration logic.
83607564ea Switch nullability migration over to the new algorithm based on the new nullability graph.
354bfb5bab Remove a few more usages of NullabilityNode._nullable.
eba45291fb [observatory] Cleanup unused imports, fix warning about SDK version
933ad32baa Add logic to assertNonNullIntent to check the nullability graph.
b05190499d Add new nullability propagation logic based on the NullabilityGraph.
f3aca11478 Record not-supplied named parameters in the nullability graph
2fbc446d23 Record information about guards in the nullability graph.
0ce9cb7267 Encode unconditional control flow information in nullability graph.
8a8a700336 Fix nullability of inferred dynamic types
9bbc06fddb Add the ability to do a debug dump of a nullability graph.
a779db0813 Update LSP spec to latest
b7521f5e1b Fix lints not appearing when using LSP Server
9472745446 Change error code for server shutting down
ef971f3787 [infra] Bump version file on master to 2.3.1
27df933bd1 Fix some hints in the analyzer package.
f7e288e3ad Return empty responses instead of errors for non-Dart files in LSP server
d0869386f6 More optimizations for summary2 storage format.
6dd7007b48 Tweak CONVERT_TO_PACKAGE_IMPORT assist.
ca92a30299 Reuse LibraryScope in MetadataResolver.
140822aebd [dartdevc] Allow multiple summaries and experiments in ddb tool
42c35d7bd6 Optimize summary2.
54a541706d [vm] Simplify IsolateSpawnState
3bc0ad4ee3 Revert "Use the full URI for DDK library debug names"
b8050f9322 Make NullabilityNode.nullable private.
d47c31da48 Remove NullabilityNode.isNeverNullable.
b91a4f5423 [analyzer] Resolve methodName staticType when Function to check Function?
11b59bec8d Store compilation unit NNBD status in unlinked summary.
dac5a56422 Fix workspace/package identification for package:build packages
370b393ac5 Remove redundant optimization from callers of `withNullability`.
d2ddf644fa Ignore deprecated analyzer import warnings
0edab8264a Support steps that only run on the main module
8aa2c13c9f Exclude parents when initializing visible data
5de409bfa1 Ensure subfolders in input sources paths are created first
05a9cdc3d5 Fix type parameter in pipeline subclasses
fb29d0e96d Move async_minitest to package:async_helper.
1a9d38be41 Fix improper unchecked_nullable test cases
b0b6a289ec [vm, compiler] Make IA32 megamorphic calls match the other architectures.
5cffcd9e2c Add the class NonNullableTypeProvider to access SDK classes in opted-in context
b1f6c1d092 [vm] Fix -O0 build after CL 101222
8a3a9dc588 [fuchsia] Migrate to zx_clock_get_new
36d8e3a9ba Fix more places where hardcoded types need to be made non-nullable under NNBD
63001295c0 optionally report scanner errors before parsing
7e0b680851 [dart/vm] minor test refactoring
8754351283 [CFE] Run widget transformer before constant evaluation.
1179467a5e Move widget transformer to kernel package
638ebcab97 Directly check for subclass-of without using a class hierarchy.
2a32cdda6d [vm/compiler] Replace LoadClassId for known cids.
0db620a2a5 Decouple Namer from RuntimeTypesEncoder and Tracer
2c86872a5f Store isAsynchronous and isGenerator in executables.
4a058a3773 Check for hasDefaultValue / hasInitializer directly, without reding the initializer.
c532458e09 [vm/compiler] Fix for flaky crash in CallSpecializer::ReplaceWithInstanceOf
2736dab879 [VM/tests] Use appropriate type when invoking Isolate.spawn
869cb683d8 [dart/fuzzer] rename exception parameter
477ad3c0ea [vm/bytecode] Eliminate asserts from bytecode unless --enable-asserts
0069beb7ed [vm/interpreter] Cleanup stack slot in Interpreter::InterfaceCall
536ecbac7b Add language 2 tests for null access errors
130ad1bcf9 Stop reporting some errors when constant evaluation produces a valid object with an unknown state (issue 36873)
d1a5eb5900 Fix the special casing of binary operators with primitive types when NNBD is enabled
b4e2c0246c update parser to handle leading error tokens
be6bbfc06b Remove redundant error notifications from LSP server
f261f8a526 bump to linter 0.1.88
4c2b9f1d91 Don't send LSP error notifications for files in dot-folders
0450462503 Improve sending/flushing of errors for files in dot folders
c1e2df8f36 [infra] Update checked in SDKs to 2.3.0
b2949d3436 fix Flutter build for "[vm/ffi] DBC support on x64 Linux/MacOS hosts"
a8b93d9e78 [vm/ffi] DBC support on x64 Linux/MacOS hosts
6d5f763952 [vm] Eliminate Mutex/Monitor indirection where possible
bed74d6e97 Remove NullabilityGraph._upstream.
b0727bd661 [dart/vm] enhanced graph checker
228df22dbf Remove the old constraint variable based nullability migration logic.
83607564ea Switch nullability migration over to the new algorithm based on the new nullability graph.
354bfb5bab Remove a few more usages of NullabilityNode._nullable.
eba45291fb [observatory] Cleanup unused imports, fix warning about SDK version
933ad32baa Add logic to assertNonNullIntent to check the nullability graph.
b05190499d Add new nullability propagation logic based on the NullabilityGraph.
f3aca11478 Record not-supplied named parameters in the nullability graph
2fbc446d23 Record information about guards in the nullability graph.
0ce9cb7267 Encode unconditional control flow information in nullability graph.
8a8a700336 Fix nullability of inferred dynamic types
9bbc06fddb Add the ability to do a debug dump of a nullability graph.
a779db0813 Update LSP spec to latest
b7521f5e1b Fix lints not appearing when using LSP Server
9472745446 Change error code for server shutting down
ef971f3787 [infra] Bump version file on master to 2.3.1
27df933bd1 Fix some hints in the analyzer package.
f7e288e3ad Return empty responses instead of errors for non-Dart files in LSP server
d0869386f6 More optimizations for summary2 storage format.
6dd7007b48 Tweak CONVERT_TO_PACKAGE_IMPORT assist.
ca92a30299 Reuse LibraryScope in MetadataResolver.
140822aebd [dartdevc] Allow multiple summaries and experiments in ddb tool
42c35d7bd6 Optimize summary2.
54a541706d [vm] Simplify IsolateSpawnState
3bc0ad4ee3 Revert "Use the full URI for DDK library debug names"
b8050f9322 Make NullabilityNode.nullable private.
d47c31da48 Remove NullabilityNode.isNeverNullable.
b91a4f5423 [analyzer] Resolve methodName staticType when Function to check Function?
11b59bec8d Store compilation unit NNBD status in unlinked summary.
dac5a56422 Fix workspace/package identification for package:build packages
370b393ac5 Remove redundant optimization from callers of `withNullability`.
d2ddf644fa Ignore deprecated analyzer import warnings
0edab8264a Support steps that only run on the main module
8aa2c13c9f Exclude parents when initializing visible data
5de409bfa1 Ensure subfolders in input sources paths are created first
05a9cdc3d5 Fix type parameter in pipeline subclasses
fb29d0e96d Move async_minitest to package:async_helper.
1a9d38be41 Fix improper unchecked_nullable test cases
b0b6a289ec [vm, compiler] Make IA32 megamorphic calls match the other architectures.
5cffcd9e2c Add the class NonNullableTypeProvider to access SDK classes in opted-in context
b1f6c1d092 [vm] Fix -O0 build after CL 101222
8a3a9dc588 [fuchsia] Migrate to zx_clock_get_new
36d8e3a9ba Fix more places where hardcoded types need to be made non-nullable under NNBD
63001295c0 optionally report scanner errors before parsing
7e0b680851 [dart/vm] minor test refactoring
8754351283 [CFE] Run widget transformer before constant evaluation.
1179467a5e Move widget transformer to kernel package
638ebcab97 Directly check for subclass-of without using a class hierarchy.
2a32cdda6d [vm/compiler] Replace LoadClassId for known cids.
0db620a2a5 Decouple Namer from RuntimeTypesEncoder and Tracer
2c86872a5f Store isAsynchronous and isGenerator in executables.
4a058a3773 Check for hasDefaultValue / hasInitializer directly, without reding the initializer.
c532458e09 [vm/compiler] Fix for flaky crash in CallSpecializer::ReplaceWithInstanceOf
2736dab879 [VM/tests] Use appropriate type when invoking Isolate.spawn
869cb683d8 [dart/fuzzer] rename exception parameter
477ad3c0ea [vm/bytecode] Eliminate asserts from bytecode unless --enable-asserts
0069beb7ed [vm/interpreter] Cleanup stack slot in Interpreter::InterfaceCall
536ecbac7b Add language 2 tests for null access errors
130ad1bcf9 Stop reporting some errors when constant evaluation produces a valid object with an unknown state (issue 36873)
d1a5eb5900 Fix the special casing of binary operators with primitive types when NNBD is enabled
b4e2c0246c update parser to handle leading error tokens
be6bbfc06b Remove redundant error notifications from LSP server
f261f8a526 bump to linter 0.1.88
4c2b9f1d91 Don't send LSP error notifications for files in dot-folders
0450462503 Improve sending/flushing of errors for files in dot folders
c1e2df8f36 [infra] Update checked in SDKs to 2.3.0
b2949d3436 fix Flutter build for "[vm/ffi] DBC support on x64 Linux/MacOS hosts"
a8b93d9e78 [vm/ffi] DBC support on x64 Linux/MacOS hosts
6d5f763952 [vm] Eliminate Mutex/Monitor indirection where possible
bed74d6e97 Remove NullabilityGraph._upstream.
b0727bd661 [dart/vm] enhanced graph checker
228df22dbf Remove the old constraint variable based nullability migration logic.
83607564ea Switch nullability migration over to the new algorithm based on the new nullability graph.
354bfb5bab Remove a few more usages of NullabilityNode._nullable.
eba45291fb [observatory] Cleanup unused imports, fix warning about SDK version
933ad32baa Add logic to assertNonNullIntent to check the nullability graph.
b05190499d Add new nullability propagation logic based on the NullabilityGraph.
f3aca11478 Record not-supplied named parameters in the nullability graph
2fbc446d23 Record information about guards in the nullability graph.
0ce9cb7267 Encode unconditional control flow information in nullability graph.
8a8a700336 Fix nullability of inferred dynamic types
9bbc06fddb Add the ability to do a debug dump of a nullability graph.
a779db0813 Update LSP spec to latest
b7521f5e1b Fix lints not appearing when using LSP Server
9472745446 Change error code for server shutting down
ef971f3787 [infra] Bump version file on master to 2.3.1
27df933bd1 Fix some hints in the analyzer package.
f7e288e3ad Return empty responses instead of errors for non-Dart files in LSP server
d0869386f6 More optimizations for summary2 storage format.
6dd7007b48 Tweak CONVERT_TO_PACKAGE_IMPORT assist.
ca92a30299 Reuse LibraryScope in MetadataResolver.
140822aebd [dartdevc] Allow multiple summaries and experiments in ddb tool
42c35d7bd6 Optimize summary2.
54a541706d [vm] Simplify IsolateSpawnState
3bc0ad4ee3 Revert "Use the full URI for DDK library debug names"
b8050f9322 Make NullabilityNode.nullable private.
d47c31da48 Remove NullabilityNode.isNeverNullable.
b91a4f5423 [analyzer] Resolve methodName staticType when Function to check Function?
11b59bec8d Store compilation unit NNBD status in unlinked summary.
dac5a56422 Fix workspace/package identification for package:build packages
370b393ac5 Remove redundant optimization from callers of `withNullability`.
d2ddf644fa Ignore deprecated analyzer import warnings
0edab8264a Support steps that only run on the main module
8aa2c13c9f Exclude parents when initializing visible data
5de409bfa1 Ensure subfolders in input sources paths are created first
05a9cdc3d5 Fix type parameter in pipeline subclasses
fb29d0e96d Move async_minitest to package:async_helper.
1a9d38be41 Fix improper unchecked_nullable test cases
b0b6a289ec [vm, compiler] Make IA32 megamorphic calls match the other architectures.
5cffcd9e2c Add the class NonNullableTypeProvider to access SDK classes in opted-in context
b1f6c1d092 [vm] Fix -O0 build after CL 101222
8a3a9dc588 [fuchsia] Migrate to zx_clock_get_new
36d8e3a9ba Fix more places where hardcoded types need to be made non-nullable under NNBD
63001295c0 optionally report scanner errors before parsing
7e0b680851 [dart/vm] minor test refactoring
8754351283 [CFE] Run widget transformer before constant evaluation.
1179467a5e Move widget transformer to kernel package
638ebcab97 Directly check for subclass-of without using a class hierarchy.
2a32cdda6d [vm/compiler] Replace LoadClassId for known cids.
0db620a2a5 Decouple Namer from RuntimeTypesEncoder and Tracer
2c86872a5f Store isAsynchronous and isGenerator in executables.
4a058a3773 Check for hasDefaultValue / hasInitializer directly, without reding the initializer.
c532458e09 [vm/compiler] Fix for flaky crash in CallSpecializer::ReplaceWithInstanceOf
2736dab879 [VM/tests] Use appropriate type when invoking Isolate.spawn
869cb683d8 [dart/fuzzer] rename exception parameter
477ad3c0ea [vm/bytecode] Eliminate asserts from bytecode unless --enable-asserts
0069beb7ed [vm/interpreter] Cleanup stack slot in Interpreter::InterfaceCall
536ecbac7b Add language 2 tests for null access errors
130ad1bcf9 Stop reporting some errors when constant evaluation produces a valid object with an unknown state (issue 36873)
d1a5eb5900 Fix the special casing of binary operators with primitive types when NNBD is enabled
b4e2c0246c update parser to handle leading error tokens
be6bbfc06b Remove redundant error notifications from LSP server
f261f8a526 bump to linter 0.1.88
4c2b9f1d91 Don't send LSP error notifications for files in dot-folders
0450462503 Improve sending/flushing of errors for files in dot folders
c1e2df8f36 [infra] Update checked in SDKs to 2.3.0
b2949d3436 fix Flutter build for "[vm/ffi] DBC support on x64 Linux/MacOS hosts"
a8b93d9e78 [vm/ffi] DBC support on x64 Linux/MacOS hosts
At a quick glance, one could easily think of the "engine_time" as the
GPU thread time and the "frame_time" as the UI thread time because the
GPU thread time is mainly spent on the engine while the UI thread time
is mainly spent on the Dart framework to generate the frame.
But it's actually the other way. The "engine_time" is UI thread time and
the "frame_time" is the GPU thread time.
To avoid the confusion, rename them to "ui_time" and "raster_time"
respectively. I avoided the "gpu_time" because the rasterization may be
purely on a CPU backed software Skia backend.