firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
31,993 Commits 1 Branch 0 Tags
79a02292fbdfd243e2a9af2e1dda50754e25fec6
Commit Graph

31993 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
79a02292fb Roll Dart SDK from 0732be6b823a to db2465f106ad (8 revisions) (flutter/engine#46797) 
https://dart.googlesource.com/sdk.git/+log/0732be6b823a..db2465f106ad

2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-14.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-13.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-12.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-11.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-10.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-9.0.dev
2023-10-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-8.0.dev
2023-10-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-7.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 22:43:38 +00:00
Brandon DeRosier
a91d13dd87 [Impeller] Use triangle strips to dedupe rectangle vertices. (flutter/engine#46610) 
Remove a couple of duplicate verts in a bunch of situations.

Pedantic improvements: "Brandon, why are you like this" edition.
 2023-10-11 15:42:10 -07:00
Brandon DeRosier
f5191e99c1 [Impeller] Bump impeller-cmake (flutter/engine#46764) 
Bump with build fixes.
 2023-10-11 15:42:03 -07:00
skia-flutter-autoroll
b064072eef Roll Skia from 2459d71707e0 to 924df8d87766 (7 revisions) (flutter/engine#46798) 
https://skia.googlesource.com/skia.git/+log/2459d71707e0..924df8d87766

2023-10-11 robertphillips@google.com [graphite] Add PipelineDataGatherer to the precompilation path
2023-10-11 johnstiles@google.com Fix comment.
2023-10-11 kjlubick@google.com Minor fixes for buffet build
2023-10-11 lovisolo@google.com Reland "[bazel] Move test runners under //tools/testrunners.".
2023-10-11 egdaniel@google.com When waiting on client provided semaphores, only block fragment stage work.
2023-10-11 johnstiles@google.com Disallow layout(builtin=xxx) in non-module code.
2023-10-11 kjlubick@google.com Deploy CanvasKit 0.39.0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 22:40:52 +00:00
Jason Simmons
9f6f5d03cf Run the binary size treemap script from the buildroot directory (flutter/engine#46740) 
This will produce a treemap where navigation starts from the buildroot
and the flutter and third_party source directories are shown as
siblings.
 2023-10-11 15:18:39 -07:00
Dan Field
1e318d57d4 [Impeller] flutter_tester --enable-impeller (flutter/engine#46389) 
This patch does the following:

- Updates `flutter_tester` to set up an Impeller rendering context and surface if `--enable-impeller` is set to true, using the Vulkan backend with Swiftshader.
- Updates `run_tests.py` to run all tests except the smoke test (that one really has no rendering impact whatsoever) with and without `--enable-impeller`.
- Updates a few tests to work that were trivial:
  - A couple tests needed updated goldens for very minor rendering differences. Filed https://github.com/flutter/flutter/issues/135684 to track using Skia gold for this instead.
  - Disabled SKP screenshotting if Impeller is enabled, and updated the test checking that to verify an error is thrown if an SKP is requested.
  - The Dart GPU based test now asserts that the gpu context is available if Impeller is enabled, and does not deadlock if run in a single threaded mode.
  - We were missing some trace events around `Canvas::SaveLayer` for Impeller as compared to Skia.
  - A couple other tests had strict checks about exception messages that are slightly different between Skia and Impeller.
- I've filed bugs for other tests that may require a little more work, and skipped them for now. For FragmentProgram on Vulkan I reused an existing bug.

This is part of my attempt to address https://github.com/flutter/flutter/issues/135693, although @chinmaygarde and I had slightly different ideas about how to do this.

The goals here are:

- Run the Dart unit tests we already have with Impeller enabled.
- Enable running more of the framework tests (including gold tests) with Impeller enabled.
- Run all of these tests via public `dart:ui` API rather than mucking around in C++ internals in the engine.
 2023-10-11 21:42:24 +00:00
Jackson Gardner
99de03845c Switch to Chrome For Testing instead of Chromium (flutter/engine#46683) 
This switches over to using Chrome for Testing instead of Chromium. This requires some changes from the recipes repo (https://flutter-review.googlesource.com/c/recipes/+/51482) in order to coordinate the change in filestructure on the mac versions.
 2023-10-11 21:24:11 +00:00
Gray Mackall
0d5c0a660f Revert "[Android] Add support for text processing actions (#44579)" (flutter/engine#46788) 
This reverts commit 01345c3ce8.

This change is causing integration tests to fail on attempts to roll the latest master version of flutter into the packages repo.

See a sample failure here: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8767521956894285553/+/u/Run_package_tests/native_integration_tests/stdout

The root cause seems to be that we are getting request codes in `onActivityResult` that we never added to the `requestsByCode` map, so the call to remove returns null (and we then call success getting a NPE).

More info: 
1. There is a [discussion in discord here](https://discord.com/channels/608014603317936148/1161718667566919761/1161721935927980052)
2. And the failure can be reproduced by running `dart run script/tool/bin/flutter_plugin_tools.dart native-test --android --packages file_selector` from the root of the packages repo (with a flutter checkout that contains these changes).

cc @bleroux 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-11 20:49:51 +00:00
Daniel Chevalier
94df47fedc [web] Adds Noto Music fallback font (flutter/engine#46720) 
Adds `Noto Music` font as a fallback font, and updates DEPS and font definitions after running the font roller script.

### Issues

Fixes: https://github.com/flutter/devtools/issues/6149

----

![](https://media.giphy.com/media/3ohzAv6kdQ4tukSNK8/giphy-downsized.gif)

I used [the developer API](https://developers.google.com/fonts/docs/developer_api?apix_params=%7B%22family%22%3A%5B%22Noto%20Music%22%5D%7D) to make sure the api works with this font.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-11 20:46:16 +00:00
Jason Simmons
3dcce9d779 Fix some image_external_texture entries in the license golden file (flutter/engine#46790) 2023-10-11 13:31:39 -07:00
John McCutchan
3bd2efe1d3 Rename HardwareBufferExternalTexture* to ImageExternalTexture* (flutter/engine#46786) 
Image is the more accurate name and we will eventually have a
HardwareBufferExternalTexture in the future (see
https://developer.android.com/reference/android/graphics/HardwareBufferRenderer
available on Android >= 34).
 2023-10-11 12:35:36 -07:00
skia-flutter-autoroll
50c5e1a989 Roll Skia from 6cc9f73ea54e to 2459d71707e0 (1 revision) (flutter/engine#46787) 
https://skia.googlesource.com/skia.git/+log/6cc9f73ea54e..2459d71707e0

2023-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bd2d26113aa7 to baab66a8258b (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 19:16:06 +00:00
John McCutchan
da447b9297 Fix 303652511 and add a regression test (flutter/engine#46743) 
Fixes internal bug b/303652511 and includes a regression test.

The TL;DR of the bug is that when re-launching a singleton-cached-engine
Flutter activity using FLAG_ACTIVITY_CLEAR_TASK, the teardown of the
previous Flutter activity interleaves with the creation of the new
Flutter activity, resulting in the Flutter engine ending up incorrectly
in the AppLifecycleState.detached state. This then results in the app
being completely unresponsive because Flutter doesn't draw frames in
this state. I don't know if the issue is reproducible in production
under normal user operation, but I'm concerned it very easily could be.
There's also nothing stopping other apps or Android system code from
launching an app using this flag.
 2023-10-11 11:29:04 -07:00
skia-flutter-autoroll
dc0c2f4503 Roll Skia from bfd9af01b785 to 6cc9f73ea54e (1 revision) (flutter/engine#46784) 
https://skia.googlesource.com/skia.git/+log/bfd9af01b785..6cc9f73ea54e

2023-10-11 johnstiles@google.com Avoid symbol-shadowing when inlining functions.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 18:21:49 +00:00
Brandon DeRosier
739db9f5b5 [Impeller] Avoid invalid GL depth calls on macOS desktop. (flutter/engine#46758) 
The macOS desktop driver doesn't support ES profiles, and
`glClearDepthf` + `glDepthRangef` are throwing `GL_INVALID_OPERATION`
and doing nothing. Noticed this while updating impeller-cmake past
@matanlurey's recent changes to make `GL_INVALID_OPERATION` fatal.
Impeller-cmake-example uses a depth buffer, whereas Impeller's 2D
renderer currently does not.

Added a follow-up bug to make these calls work on macOS desktop:
https://github.com/flutter/flutter/issues/136322.
Both Impeller Scene and the impeller-cmake-example currently just rely
on the default state for clearing depth.
 2023-10-11 10:47:51 -07:00
skia-flutter-autoroll
1c8922904e Roll Fuchsia Mac SDK from mLc-VlVTg-p18HjiP... to Qjz4zE4Oe0AO_7T3f... (flutter/engine#46778) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 16:45:19 +00:00
Zachary Anderson
0a20e6f0f6 Roll goldctl forward (flutter/engine#46771) 
For https://github.com/flutter/flutter/issues/135620
 2023-10-11 16:10:05 +00:00
skia-flutter-autoroll
0cff2cdf88 Roll Skia from 60d51fd2c6bd to bfd9af01b785 (2 revisions) (flutter/engine#46774) 
https://skia.googlesource.com/skia.git/+log/60d51fd2c6bd..bfd9af01b785

2023-10-11 johnstiles@google.com Revert "[bazel] Move test runners under //tools/testrunners."
2023-10-11 jvanverth@google.com [graphite] Move RasterPathAtlas into AtlasProvider.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 16:02:00 +00:00
skia-flutter-autoroll
f6855a9d3e Roll Skia from c05effecb081 to 60d51fd2c6bd (3 revisions) (flutter/engine#46772) 
https://skia.googlesource.com/skia.git/+log/c05effecb081..60d51fd2c6bd

2023-10-11 jvanverth@google.com [graphite] Fix bugs in RasterPathAtlas caching.
2023-10-11 kjlubick@google.com Annotate third_party imports
2023-10-11 bclayton@chromium.org [tint][gn] Disable GLSL validation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 15:17:47 +00:00
skia-flutter-autoroll
a8f70c8b16 Roll Skia from e00577618d81 to c05effecb081 (1 revision) (flutter/engine#46770) 
https://skia.googlesource.com/skia.git/+log/e00577618d81..c05effecb081

2023-10-11 lokokung@google.com [webgpu-headers] Removes macros for "count" fields.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 14:21:30 +00:00
skia-flutter-autoroll
2b02969f48 Roll Skia from 11e41e0e2f9f to e00577618d81 (1 revision) (flutter/engine#46763) 
https://skia.googlesource.com/skia.git/+log/11e41e0e2f9f..e00577618d81

2023-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0afc3ec95439 to ea332c715575 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 09:50:23 +00:00
skia-flutter-autoroll
fc4a70902e Roll Fuchsia Linux SDK from FX5YzwP_ZEnPP0b3v... to hMA99PoacaRZVXHgr... (flutter/engine#46762) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 09:44:17 +00:00
Bruno Leroux
01345c3ce8 [Android] Add support for text processing actions (flutter/engine#44579) 
## Description

This Android related PR adds a channel buffer and a plugin to interact with Android 'process text' feature. It makes it possible to query text processing actions and to run those actions (for instance 'calling' Google translate).
Text actions that outputs a processed text are supported.

The implementation is based on the great sample provided by @gualse , see https://github.com/flutter/flutter/issues/107603#issuecomment-1646629158. 

In order to return a non empty list of text actions, the implementation will require adding a section to the Android manifest file (see https://github.com/flutter/flutter/issues/107603#issuecomment-1683487087).
Adding this section automatically to new or existing Flutter apps is not part of this PR but will be tackled in a future PR.

## Related Issue

Android engine side for https://github.com/flutter/flutter/issues/107603

## Tests

Adds 3 tests.
 2023-10-11 09:33:00 +00:00
skia-flutter-autoroll
95538e3760 Roll Skia from 4935bed4260d to 11e41e0e2f9f (3 revisions) (flutter/engine#46759) 
https://skia.googlesource.com/skia.git/+log/4935bed4260d..11e41e0e2f9f

2023-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ab3b6d0185b0 to bed7bfb7376c
2023-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 457fc7591f3c to bd2d26113aa7 (10 revisions)
2023-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f9f3328bcef8 to ab3b6d0185b0 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 06:13:22 +00:00
skia-flutter-autoroll
b01cbc4b59 Roll Fuchsia Mac SDK from oTiMPVe_PvyCYnlqR... to mLc-VlVTg-p18HjiP... (flutter/engine#46754) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 04:06:22 +00:00
Brandon DeRosier
3e50aae2f7 [Impeller] Allow pipeline variant sets to have differing defaults. (flutter/engine#46751) 
Track default prototype options along side pipeline variant sets, allowing differing defaults to be assigned during ContentContext construction.
 2023-10-11 02:22:10 +00:00
Matan Lurey
2b54d1a9e6 Remove support for Paint.enableDithering=false in dart:ui. (flutter/engine#46745) 
Work towards https://github.com/flutter/flutter/issues/112498.

No behavioral changes to existing code, except `Paint.enableDithering = false` will no longer be an option.
 2023-10-11 01:24:16 +00:00
Chris Bracken
ee313fa40f Move //third_party/glfw to //flutter/third_party/glfw (flutter/engine#46733) 
As part of eliminating the Flutter buildroot (#67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

This is the engine-side follow-up to flutter/buildroot#777.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

Issue: https://github.com/flutter/flutter/issues/136284

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
 2023-10-10 18:21:54 -07:00
skia-flutter-autoroll
e433db253c Roll Skia from 06145491fd17 to 4935bed4260d (3 revisions) (flutter/engine#46748) 
https://skia.googlesource.com/skia.git/+log/06145491fd17..4935bed4260d

2023-10-11 lovisolo@google.com [bazel] Move test runners under //tools/testrunners.
2023-10-10 vigneshv@google.com SkAvifCodec: Do not use libavif internal headers
2023-10-10 johnstiles@google.com Move SwizzleComponent::Type into Swizzle header.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 00:58:16 +00:00
Brandon DeRosier
e8e13de094 [Impeller] Guard calls to extension proc DebugMessageControlKHR. (flutter/engine#46747) 
Quick fix to unblock the `impeller-cmake-example` build. Calls to ES3 and extension procs need to be guarded.
 2023-10-11 00:53:33 +00:00
Jonah Williams
e76a91f169 [Impeller] log specific framebuffer incomplete error. (flutter/engine#46692) 
This is much easier to debug if we know the actual error code.
 2023-10-10 23:04:13 +00:00
skia-flutter-autoroll
3a2326174c Roll Fuchsia Linux SDK from dCjN58uZQBmAFWSxN... to FX5YzwP_ZEnPP0b3v... (flutter/engine#46734) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 20:59:08 +00:00
Brandon DeRosier
30fe68f402 [Impeller] Don't cull readbacks outside the damage rect. (flutter/engine#46705) 
Resolves https://github.com/flutter/flutter/issues/136058.

The damage rect properly expands to include the backdrop filter readback area to a certain extent, but it suddenly gets excluded once it no longer partially overlaps with the damage rect. This caused the illusion of EntityPass improperly culling the backdrop entity, leading me into a bit of a wild goose chase.

Before:

https://github.com/flutter/engine/assets/919017/94b8c077-0945-4a2c-96e0-27230d980c38

After:

https://github.com/flutter/engine/assets/919017/f1c78365-6e9b-46cb-9e69-33472d488831
 2023-10-10 20:55:05 +00:00
John McCutchan
d9469ed169 Fix high FPS screen flicker of Platform Views when using ImageReaderPlatformViewRenderTarget (flutter/engine#46724) 
The root bug (b/300627634) was that we were holding onto HardwareBuffers
after the owning Image was closed. This CL refactors the C++ code to
properly hold a reference to the Image until it is safe to dispose of.

This CL also refactors the Impeller GL and Skia GL code paths to share
more code.
 2023-10-10 13:36:56 -07:00
Matan Lurey
be5446426c Prepare to move new folders into third_party/ by adding a .gitignore. (flutter/engine#46729) 
As part of https://github.com/flutter/flutter/issues/67373, we'll be
adding, for example `third_party/glfw`.

This PR will by default ignore folders, except for ones that have
internal repo-sourced code (which are unlikely to change much, if at all
during this transition).

_/cc @Hixie, @chinmaygarde FYI only_.
 2023-10-10 13:36:43 -07:00
godofredoc
0a8ed0b821 Use x86 machines for ios builds. (flutter/engine#46726) 
This is to workaround rosetta not being installed in dart-internal machines and to unblock beta releases.

Bug: https://github.com/flutter/flutter/issues/136219

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-10 20:28:52 +00:00
Chinmay Garde
b66daf88a6 Remove workaround for older versions of MSVC. (flutter/engine#46689) 
We don't use the MSVC frontend now anyway. And haven't for a while.
 2023-10-10 13:11:51 -07:00
skia-flutter-autoroll
252a54ac58 Roll Skia from 475286f0f6f1 to 06145491fd17 (1 revision) (flutter/engine#46728) 
https://skia.googlesource.com/skia.git/+log/475286f0f6f1..06145491fd17

2023-10-10 jvanverth@google.com [graphite] Add caching for RasterPathAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 19:31:20 +00:00
Jonah Williams
724d1ae6fc [Impeller] Implement framebuffer fetch support for OpenGLES. (flutter/engine#46585) 
https://github.com/flutter/flutter/issues/120223 for OpenGLES. Checks for support of the framebuffer fetch extension: https://registry.khronos.org/OpenGL/extensions/EXT/EXT_shader_framebuffer_fetch.txt . This is supported on a Pixel 6 at least, we should double check the distribution of the extension.

![d3c](https://github.com/flutter/engine/assets/8975114/d2392dc8-e1b1-4084-ac5d-c5744c651a39)
 2023-10-10 19:10:11 +00:00
skia-flutter-autoroll
5acb13d768 Roll Skia from f0653c4a2df5 to 475286f0f6f1 (2 revisions) (flutter/engine#46721) 
https://skia.googlesource.com/skia.git/+log/f0653c4a2df5..475286f0f6f1

2023-10-10 nigeltao@google.com SkWuffsCodec: add another "Roll third_party/wuffs" workaround
2023-10-10 johnstiles@google.com Fix fuzzer-discovered assertion in WGSL code generator.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 18:22:49 +00:00
Jim Graham
b2234c9c0c use TextFrame calls for Impeller in rendertests (flutter/engine#46696) 
Switch the impeller testing in rendertests to use TextFrame objects rather than TextBlob objects when drawing to an Impeller-managed destination.

Previously the DrawText tests would generate over 200 errors because none of the attribute variants would render anything at all. After this fix the number of failures in the DrawText calls is down to 1 which points out that wrapping a DrawTextFrame call in a nothing saveLayer somehow affects the glyph positioning (in a not very appealing manner).
 2023-10-10 17:12:48 +00:00
skia-flutter-autoroll
425f0ce670 Roll Skia from c634411c51e6 to f0653c4a2df5 (1 revision) (flutter/engine#46716) 
https://skia.googlesource.com/skia.git/+log/c634411c51e6..f0653c4a2df5

2023-10-10 johnstiles@google.com Remove GMVerifier class from DM.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 16:52:59 +00:00
gaaclarke
de5300d6df [Impeller] made window size parametric in playground/golden tests (flutter/engine#46682) 
In https://github.com/flutter/flutter/issues/136058#issuecomment-1751507094 it was seen that some bugs manifest only with viewports of certain sizes.  This allows writers of tests to adjust the window size for playgrounds and golden image tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-10 16:10:12 +00:00
skia-flutter-autoroll
d04f82ecb8 Roll Skia from c497dae2fedb to c634411c51e6 (1 revision) (flutter/engine#46714) 
https://skia.googlesource.com/skia.git/+log/c497dae2fedb..c634411c51e6

2023-10-10 lokokung@google.com [webgpu-headers] Add macros to prepare for removing signalValue arg.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 16:10:09 +00:00
skia-flutter-autoroll
780d9f0a2f Roll Fuchsia Mac SDK from EYr1hCR6hxkSGhtis... to oTiMPVe_PvyCYnlqR... (flutter/engine#46713) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 15:26:25 +00:00
skia-flutter-autoroll
8440da53fc Roll Skia from 6cfbb3a0809e to c497dae2fedb (2 revisions) (flutter/engine#46711) 
https://skia.googlesource.com/skia.git/+log/6cfbb3a0809e..c497dae2fedb

2023-10-10 johnstiles@google.com Fix filename spelling.
2023-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d3e7b9b7ad6a to 3b1bca8c657b (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 14:30:25 +00:00
skia-flutter-autoroll
ff360adbf3 Roll Skia from ea839690b97d to 6cfbb3a0809e (2 revisions) (flutter/engine#46710) 
https://skia.googlesource.com/skia.git/+log/ea839690b97d..6cfbb3a0809e

2023-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4039a4c6188f to 457fc7591f3c (6 revisions)
2023-10-10 kjlubick@google.com Remove SkBase64 from public API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 13:53:23 +00:00
skia-flutter-autoroll
4391e99b2b Roll Dart SDK from 0023fc324ff0 to 0732be6b823a (1 revision) (flutter/engine#46709) 
https://dart.googlesource.com/sdk.git/+log/0023fc324ff0..0732be6b823a

2023-10-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-6.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 13:23:10 +00:00
skia-flutter-autoroll
3ba450b17e Roll Skia from c969e4aff32c to ea839690b97d (1 revision) (flutter/engine#46708) 
https://skia.googlesource.com/skia.git/+log/c969e4aff32c..ea839690b97d

2023-10-10 kjlubick@google.com Remove GrSurfaceInfo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 12:52:22 +00:00
skia-flutter-autoroll
1c58571461 Roll Dart SDK from a471147f6237 to 0023fc324ff0 (1 revision) (flutter/engine#46704) 
https://dart.googlesource.com/sdk.git/+log/a471147f6237..0023fc324ff0

2023-10-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-5.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 09:23:22 +00:00