firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
30,035 Commits 1 Branch 0 Tags
6900920705da2eb15c0b16818a3e962c4cb2000d
Commit Graph

30035 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
6900920705 Roll Dart SDK from 3701605e0abf to d1fcadf22aad (1 revision) (flutter/engine#43692) 
https://dart.googlesource.com/sdk.git/+log/3701605e0abf..d1fcadf22aad

2023-07-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-312.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 18:12:05 +00:00
Jason Simmons
9196510ed8 More fixes for the new clang-tidy roll on iOS targets (flutter/engine#43688) 
See https://github.com/flutter/engine/pull/43661
 2023-07-14 17:44:52 +00:00
Kevin Lubick
27192d3743 Add missing Skia #includes (flutter/engine#43680) 
When trying to land
https://skia-review.googlesource.com/c/skia/+/721978, I ran into some
issues where Flutter was transitively depending on some Skia headers.
This adds those explicitly to the necessary files.

I noticed a few of these were missing from dl_sk_types.h (i.e. they were
referenced in dl_sk_conversions.h, but not included in dl_sk_types.h),
so I added them in.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-07-14 13:29:39 -04:00
skia-flutter-autoroll
72ed127c92 Roll Skia from de6099518f90 to c14fda1cb615 (1 revision) (flutter/engine#43689) 
https://skia.googlesource.com/skia.git/+log/de6099518f90..c14fda1cb615

2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e1b8f324086e to fcbe6bbcf4a8 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 17:23:06 +00:00
Jim Graham
d4c1a9b6ee Fix DisplayListMatrixClipTracker handling of diff clips (flutter/engine#43664) 
Fixes root cause for https://github.com/flutter/flutter/issues/129816

Logic for reducing the cull_rect for a diff clip had a number of errors. The new test should cover all cases.
 2023-07-14 17:14:15 +00:00
skia-flutter-autoroll
fd24060357 Roll Skia from b4b9c76206f3 to de6099518f90 (4 revisions) (flutter/engine#43687) 
https://skia.googlesource.com/skia.git/+log/b4b9c76206f3..de6099518f90

2023-07-14 robertphillips@google.com Roll Vulkan Memory Allocator to v3.0.1
2023-07-14 johnstiles@google.com Fix format specifier for backend enum.
2023-07-14 jvanverth@google.com [graphite] Add Vulkan semaphore support.
2023-07-14 kjlubick@google.com Move most of the Ganesh-specific logic out of SkSpecialImage.cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 16:45:53 +00:00
skia-flutter-autoroll
a5be79cd52 Roll Fuchsia Mac SDK from J0oxaSt651gKgDreU... to Z-1lzZAOYHvVrdjQ8... (flutter/engine#43685) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 16:12:18 +00:00
skia-flutter-autoroll
b66abab13c Roll Skia from 7990401d716a to b4b9c76206f3 (1 revision) (flutter/engine#43681) 
https://skia.googlesource.com/skia.git/+log/7990401d716a..b4b9c76206f3

2023-07-14 johnstiles@google.com Reland "Fix swizzled compound assignment with lvalue side-effects in Metal."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 14:41:10 +00:00
skia-flutter-autoroll
5bbfa363d3 Roll Dart SDK from 8e4eac435b49 to 3701605e0abf (1 revision) (flutter/engine#43679) 
https://dart.googlesource.com/sdk.git/+log/8e4eac435b49..3701605e0abf

2023-07-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-311.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 14:20:07 +00:00
skia-flutter-autoroll
037ef5f81e Roll Skia from 8192de1efc1b to 7990401d716a (1 revision) (flutter/engine#43678) 
https://skia.googlesource.com/skia.git/+log/8192de1efc1b..7990401d716a

2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 845e8105edb3 to e8bb3adbe077

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 12:31:31 +00:00
Martin Kustermann
0e369e0e4e Use utf8.encode() instead of longer const Utf8Encoder.convert() (flutter/engine#43675) 
The change in [0] has propagated now everywhere, so we can use 
`utf8.encode()` instead of the longer `const Utf8Encoder.convert()`.

Also it cleans up code like

```
  Uint8List bytes;
  bytes.buffer.asByteData();
```

as that is not guaranteed to be correct, the correct version would be

```
  Uint8List bytes;
  bytes.buffer.asByteData(bytes.offsetInBytes, bytes.length);
```

a shorter hand for that is:

```
  Uint8List bytes;
  ByteData.sublistView(bytes);
```

[0] https://github.com/dart-lang/sdk/issues/52801
 2023-07-14 13:44:54 +02:00
skia-flutter-autoroll
53b9d2172b Roll Skia from 2848267f631d to 8192de1efc1b (1 revision) (flutter/engine#43672) 
https://skia.googlesource.com/skia.git/+log/2848267f631d..8192de1efc1b

2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8ae9f28d7af2 to 6ffd0d20684d (22 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 06:20:02 +00:00
skia-flutter-autoroll
7c472f4779 Roll Dart SDK from 8f49edfb6989 to 8e4eac435b49 (1 revision) (flutter/engine#43671) 
https://dart.googlesource.com/sdk.git/+log/8f49edfb6989..8e4eac435b49

2023-07-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-310.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 05:49:04 +00:00
skia-flutter-autoroll
f686a37e84 Roll Skia from ffed127e8974 to 2848267f631d (3 revisions) (flutter/engine#43670) 
https://skia.googlesource.com/skia.git/+log/ffed127e8974..2848267f631d

2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7a6604d0564b to eb355bb3edcf (21 revisions)
2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c7cba4b06eab to 845e8105edb3 (8 revisions)
2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ad8a66bf7d69 to e1b8f324086e (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 05:41:04 +00:00
skia-flutter-autoroll
3cc1a574a4 Roll Fuchsia Linux SDK from -csWUV7Dv3hETOoDw... to LZPMbHnVPFdbXndcX... (flutter/engine#43669) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 05:37:22 +00:00
skia-flutter-autoroll
f2b24ac444 Roll Fuchsia Mac SDK from rRUd41Mv9NI0n3Iyc... to J0oxaSt651gKgDreU... (flutter/engine#43667) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 03:21:49 +00:00
skia-flutter-autoroll
b360d27007 Roll Skia from 9e4f5cc3aeb4 to ffed127e8974 (1 revision) (flutter/engine#43666) 
https://skia.googlesource.com/skia.git/+log/9e4f5cc3aeb4..ffed127e8974

2023-07-14 johnstiles@google.com Revert "Fix swizzled compound assignment with lvalue side-effects in Metal."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 03:15:01 +00:00
skia-flutter-autoroll
3c72cf65d9 Roll Dart SDK from 9506d0c9f5ef to 8f49edfb6989 (1 revision) (flutter/engine#43665) 
https://dart.googlesource.com/sdk.git/+log/9506d0c9f5ef..8f49edfb6989

2023-07-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-309.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 02:10:51 +00:00
Ian Hickson
34c0f686c5 Add more points to [MediaQuery]. (flutter/engine#43649) 
See https://github.com/flutter/flutter/issues/11697
 2023-07-14 00:34:14 +00:00
Ian Hickson
1ca3a2c32a Remove unimplemented API call saveCompilationTrace (flutter/engine#43656) 
Fixes https://github.com/flutter/flutter/issues/59205
 2023-07-14 00:34:12 +00:00
Jason Simmons
db4c5360bf Fix a clang-tidy warning about a potentially nil value in the editingState dictionary (flutter/engine#43660) 2023-07-13 23:09:26 +00:00
skia-flutter-autoroll
417cee5b50 Roll Skia from 52613fcc0780 to 9e4f5cc3aeb4 (1 revision) (flutter/engine#43659) 
https://skia.googlesource.com/skia.git/+log/52613fcc0780..9e4f5cc3aeb4

2023-07-13 johnstiles@google.com Fix WGSL codegen for compound assignment with swizzles.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 22:53:48 +00:00
Jonah Williams
70c3a7f8d3 [Impeller] no-op fragment program on Android until it works. (flutter/engine#43657) 
The framework has switched into mat3 by default, which means the fragment program ink sparkle has replaced the default ink splash. Since this is not implemented, all of the impeller benchmarks are crashign.

No-op this so we at least get benchmark numbers until its implemented.
 2023-07-13 22:43:16 +00:00
LongCatIsLooong
b7472f9a45 Reland #43118 "Add a flag to ParagraphBuilder for rounding hack migration" (flutter/engine#43647) 
real diff: aedc37a3e0

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-13 22:30:32 +00:00
Chris Yang
4e696fc84d Unmerge threads if the current merger is the only one that's merged. (flutter/engine#43652) 
`UnMergeNowIfLastOne` is called during shell destruction. When there are other shells with threads unmerged and the current destroying shell with thread merged. `UnMergeNowIfLastOne` should unmerge the threads. 

This PR Make `UnMergeNowIfLastOne` not only unmerge if the current merger is the last merger, but also unmerge if the current merger is the last merger that is merged.

Fixes https://github.com/flutter/flutter/issues/127168

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-13 22:17:21 +00:00
Dan Field
6fdde7e901 Revert https://github.com/flutter/engine/pull/43533 (flutter/engine#43654) 
Reverts  https://github.com/flutter/engine/pull/43533
Cause of https://github.com/flutter/flutter/issues/130476

I was trying to add a test for this but it's taking me a while to get a working test so here's the revert.
 2023-07-13 22:13:45 +00:00
skia-flutter-autoroll
b69b3b6f9e Roll Skia from 743ad92f5de2 to 52613fcc0780 (9 revisions) (flutter/engine#43655) 
https://skia.googlesource.com/skia.git/+log/743ad92f5de2..52613fcc0780

2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for GL/Ganesh.
2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for specifying a config via --config.
2023-07-13 johnstiles@google.com Fix swizzled compound assignment with lvalue side-effects in Metal.
2023-07-13 johnstiles@google.com Ensure index-substitution expressions are initialized before use.
2023-07-13 brianosman@google.com Remove SkOpts_skx.cpp completely
2023-07-13 ayzhao@google.com Fix some missing C++ standard library includes
2023-07-13 robertphillips@google.com Merge Ganesh and Graphite TiledTextureUtils::DrawImageRect implementations
2023-07-13 robertphillips@google.com Switch DrawImageRect_Ganesh to work at the SkCanvas level
2023-07-13 johnstiles@google.com Add unit test for lvalue side-effects in swizzled compound assignment.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 22:05:37 +00:00
Jason Simmons
4f384979af Fix a Fuchsia formatter type mismatch flagged by the pending Clang roll (flutter/engine#43651) 2023-07-13 20:13:55 +00:00
skia-flutter-autoroll
036fbf256d Roll Dart SDK from 16ddfe8d08e0 to 9506d0c9f5ef (1 revision) (flutter/engine#43646) 
https://dart.googlesource.com/sdk.git/+log/16ddfe8d08e0..9506d0c9f5ef

2023-07-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-308.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 18:41:54 +00:00
Jonah Williams
f64d4f6eb7 [Impeller] Switch back to using explicit flush for device buffers. (flutter/engine#43644) 
Not all devices support the host_coherent + host_visible + device_local combo (though most do). I believe this change was associated with a slight regression in performance, so back it out and go back to flush to see if that improves things.

https://flutter-flutter-perf.skia.org/e/?begin=1687535096&end=1689267073&queries=device_type%3DSM-G973U1%26test%3Dnew_gallery_impeller__transition_perf&requestType=0&selected=commit%3D35596%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DSM-G973U1%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D99th_percentile_frame_rasterizer_time_millis%252Ctest%253Dnew_gallery_impeller__transition_perf%252C

Specifically:

![image](https://github.com/flutter/engine/assets/8975114/fedabc18-9091-45c0-b7b3-ee9945c2239c)
 2023-07-13 18:13:03 +00:00
Victoria Ashworth
1a078f8091 Add logs to debug VM Service Publication (flutter/engine#43616) 
Adding logs to help debug why VM Service is being published when it shouldn't (https://github.com/flutter/flutter/issues/129987 and https://github.com/flutter/flutter/issues/129836).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-13 17:55:48 +00:00
LongCatIsLooong
64c139e98a Revert "Add a flag to ParagraphBuilder for rounding hack migration" (flutter/engine#43642) 
Reverts flutter/engine#43118

The incorrect default value (`true` instead of  `false`) was used in the PR and that caused internal test failures. I'll add a test before trying to reland.
 2023-07-13 17:54:33 +00:00
chunhtai
8f5fb30a7f [web] TextField a11y focus should call didGain/didLose a11y focus action (flutter/engine#43279) 
fixes https://github.com/flutter/flutter/issues/128709

requires https://github.com/flutter/flutter/pull/129652

The issue is that when textfield focus in framework and web engine a11y are out of sync, the framework keep sending update with textfield focus = true and causes web engine to keep refocusing the textfield.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-13 17:43:53 +00:00
John McCutchan
d2e61e5689 Improve Stencil Playground test (flutter/engine#43641) 
- Add UI to select front and back face comparision functions.
- Fix back face.
 2023-07-13 10:21:52 -07:00
skia-flutter-autoroll
d7c244c593 Roll Skia from c2d28b15c246 to 743ad92f5de2 (4 revisions) (flutter/engine#43640) 
https://skia.googlesource.com/skia.git/+log/c2d28b15c246..743ad92f5de2

2023-07-13 herb@google.com Use the correct signatures for functions
2023-07-13 kjlubick@google.com Add staging gni filegroup for files which need SKSL from core
2023-07-13 robertphillips@google.com Add label output to GrGpuResource::dumpMemoryStatisticsPriv
2023-07-13 johnstiles@google.com Revert "Disable render-task reordering on Iris Xe on OpenGL."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 16:56:52 +00:00
skia-flutter-autoroll
ee096091da Roll Fuchsia Linux SDK from xBJq6PsO5ebblODMe... to -csWUV7Dv3hETOoDw... (flutter/engine#43639) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 16:48:59 +00:00
skia-flutter-autoroll
a224a4e19f Roll Skia from 56b68ce6196c to c2d28b15c246 (1 revision) (flutter/engine#43638) 
https://skia.googlesource.com/skia.git/+log/56b68ce6196c..c2d28b15c246

2023-07-13 wcandillon@gmail.com matchFamilyStyle to the external definition and refine the TypefaceFontProvide type

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 16:08:46 +00:00
skia-flutter-autoroll
ee1740e4b8 Roll Fuchsia Mac SDK from 3C7P0w8ySmtqpyi3S... to rRUd41Mv9NI0n3Iyc... (flutter/engine#43635) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 14:41:05 +00:00
skia-flutter-autoroll
0128353886 Roll Dart SDK from ade4dae923f3 to 16ddfe8d08e0 (1 revision) (flutter/engine#43634) 
https://dart.googlesource.com/sdk.git/+log/ade4dae923f3..16ddfe8d08e0

2023-07-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-307.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 14:39:19 +00:00
Jason Simmons
49813d1e77 Apply the transform of an image filter layer to paint bounds in the CanvasKit backend (flutter/engine#43353) 
Fixes https://github.com/flutter/flutter/issues/128788
 2023-07-13 14:26:04 +00:00
skia-flutter-autoroll
358a708968 Roll Skia from e5ec341bc3ca to 56b68ce6196c (1 revision) (flutter/engine#43633) 
https://skia.googlesource.com/skia.git/+log/e5ec341bc3ca..56b68ce6196c

2023-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3b2c55a1bc2b to ad8a66bf7d69 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 13:10:04 +00:00
skia-flutter-autoroll
ca5c161496 Roll Dart SDK from f499e91e8cb2 to ade4dae923f3 (1 revision) (flutter/engine#43632) 
https://dart.googlesource.com/sdk.git/+log/f499e91e8cb2..ade4dae923f3

2023-07-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-306.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 10:45:21 +00:00
skia-flutter-autoroll
4394a5f8d9 Roll Skia from 811b046c673b to e5ec341bc3ca (1 revision) (flutter/engine#43631) 
https://skia.googlesource.com/skia.git/+log/811b046c673b..e5ec341bc3ca

2023-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ebaadc6c2cba to 8ae9f28d7af2 (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 07:12:13 +00:00
Ian Hickson
93a21790b4 Make GOMA state automatic by default (flutter/engine#43584) 
We used to default to force-enabled, which would fail on non-GOMA setups.
 2023-07-13 06:34:51 +00:00
skia-flutter-autoroll
ea4c2b7268 Roll Skia from c8da0c657c4e to 811b046c673b (3 revisions) (flutter/engine#43630) 
https://skia.googlesource.com/skia.git/+log/c8da0c657c4e..811b046c673b

2023-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c7cba4b06eab to bd8a6b1b3547
2023-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c60298c2b806 to c7cba4b06eab (5 revisions)
2023-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 75bc633f02db to 7a6604d0564b (28 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 06:21:33 +00:00
Chinmay Garde
359fbbb34c [Impeller] Remove unactionable error logs and use structure chains for instance creation. (flutter/engine#43629) 
I didn't know this when I wrote it initially but structure chains will throw a compile time error if a chain member violates the Vulkan spec. pNext chaining is easy to mess up otherwise and we should use structure chains where possible. We are already doing this during pipeline construction.
 2023-07-13 05:54:00 +00:00
skia-flutter-autoroll
7c62caaf5e Roll Skia from 7f391ea9164e to c8da0c657c4e (1 revision) (flutter/engine#43628) 
https://skia.googlesource.com/skia.git/+log/7f391ea9164e..c8da0c657c4e

2023-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dda70a3ef9fe to 151fa797ee3e (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 05:28:04 +00:00
Chinmay Garde
88df88c3ff [Impeller] Add RAII wrappers for VMA objects. (flutter/engine#43626) 
Uses `fml::UniqueObject<T>`.
 2023-07-13 05:18:06 +00:00
skia-flutter-autoroll
a9fe0fd8ac Roll Fuchsia Linux SDK from 1STsUj0X5YgpiSNEb... to xBJq6PsO5ebblODMe... (flutter/engine#43627) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 03:52:19 +00:00
skia-flutter-autoroll
1be57144b4 Roll Skia from 6ed93436d57c to 7f391ea9164e (1 revision) (flutter/engine#43625) 
https://skia.googlesource.com/skia.git/+log/6ed93436d57c..7f391ea9164e

2023-07-13 michaelludwig@google.com [skif] Replace SkTileImageFilter with nested crops

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 02:55:04 +00:00