Commit Graph

2979 Commits

Author SHA1 Message Date
Devon Carew
5ee1cba149 fix a regression in the android manifest 2016-02-24 23:40:00 -08:00
Adam Barth
6af4492773 Merge pull request #2147 from abarth/static_arena
Remove PointerRouter and GestureArena arguments
2016-02-24 22:32:26 -08:00
Adam Barth
4b1a9ff14c Remove PointerRouter and GestureArena arguments
There's no reason to make clients supply a PointerRounter and a
GestureArena when constructing gesture recognizers. These objects are
statics and the gesture recognizers can just grab them directly.

Also, remove the callback constructor arguments. Almost no code used
them. Instead, people seem to prefer using the `..` operator to set
callbacks on the recognizers. Removing the arguments removes a bunch of
boilerplate.
2016-02-24 22:23:00 -08:00
Devon Carew
dc0e97e51a Merge pull request #2139 from devoncarew/doctor_create
run flutter doctor as part of create
2016-02-24 19:21:27 -08:00
Devon Carew
bc8e560779 run flutter doctor as part of create 2016-02-24 19:07:19 -08:00
Adam Barth
9d4e0e8551 Merge pull request #2142 from abarth/interactive_text
Add the ability to recognize gestures on text spans
2016-02-24 17:32:30 -08:00
Hixie
512b2e1972 Fix move() to call markNeedsLayout().
Otherwise, changing the order of your children (e.g. shuffling a list of
children) will have no visible effect.
2016-02-24 17:10:59 -08:00
Adam Barth
8e326d724a Add the ability to recognize gestures on text spans
Currently the interface for recognizing gestures on text spans is pretty ugly,
but hopefully we can improve it with time.

Fixes #156
2016-02-24 17:07:35 -08:00
Adam Barth
62609669d8 Merge pull request #2141 from abarth/text_span_equals
Fix TextSpan's operator==
2016-02-24 17:04:45 -08:00
Adam Barth
25219277f6 Fix TextSpan's operator==
We forgot to compare the lengths of the lists.
2016-02-24 16:53:22 -08:00
Hixie
0df3730d3e Just-in-time mutations of GestureDetector
This allows us to adjust exactly which gestures we're listening for
during layout, which I'll use to kill a SizeObserver.
2016-02-24 16:18:05 -08:00
Eric Seidel
fbe4cdf5c6 Merge pull request #2129 from eseidelGoogle/space_per_flex
Don't give children negative sizes when overconstrained
2016-02-24 15:30:16 -08:00
Eric Seidel
4e7a9de578 Fix two bugs in Flex exposed by the Game in landscape mode
One bug was masking the other, hence they both needed to be fixed
and tested separately.

@Hixie
2016-02-24 15:30:05 -08:00
Adam Barth
2514d8a663 Merge pull request #2135 from abarth/improve_text_span
Improve TextSpan
2016-02-24 14:16:41 -08:00
Adam Barth
fb4dbf4584 Improve TextSpan
Now we just have one TextSpan class that handles both simple strings, trees of
children, and styling both. This approach simplifies the interface for most
clients.

This patch also removes StyledText, which was weakly typed and tricky to use
correctly. The replacement is RichText, which is strongly typed and uses
TextSpan.
2016-02-24 14:07:10 -08:00
yjbanov
d2c94990fa deflake retry_test.dart (using FakeAsync) 2016-02-24 13:58:59 -08:00
yjbanov
54194a9075 wait for text to change in the sample driver test 2016-02-24 13:58:31 -08:00
Chinmay Garde
ccc9a25a47 Merge pull request #2134 from chinmaygarde/develop
Disable flaky retry_test
2016-02-24 13:41:38 -08:00
Chinmay Garde
54daeaa252 Disable flaky retry_test 2016-02-24 13:40:31 -08:00
Adam Barth
755a180af2 Merge pull request #2128 from abarth/animation_bounds
Keep AnimationController's _value in bounds
2016-02-24 13:05:44 -08:00
Devon Carew
dc4830b0fa Merge pull request #2123 from devoncarew/device_commands
additional validation for device commands
2016-02-24 12:54:28 -08:00
Chinmay Garde
21057de9ae Merge pull request #2118 from chinmaygarde/develop
Remove all inline templates and provide a way to specify templates as resources
2016-02-24 12:47:37 -08:00
Adam Barth
9e45b85e72 Keep AnimationController's _value in bounds
Rather than clamping _value on read, we now clamp the value when writing it,
which simplifies reasoning about _value.
2016-02-24 12:15:57 -08:00
Chinmay Garde
038367ad24 Remove all inline templates and provide a way to specify templates as resources 2016-02-24 11:33:07 -08:00
Yegor
1acdfb7933 Merge pull request #2120 from yjbanov/driver-wait-on-reads
support waiting for things to happen in Flutter Driver
2016-02-24 11:13:40 -08:00
Devon Carew
37290d866e additional validation for device commands 2016-02-24 11:11:23 -08:00
yjbanov
7f39703759 support waiting for things to happen in Flutter Driver 2016-02-24 10:01:00 -08:00
Hans Muller
ba93987c6e Added bottom_sheet_rebuild_test 2016-02-24 07:49:08 -08:00
Phil Quitslund
1062c44f4a Merge pull request #2094 from flutter/analyze_fixes
Enumerate lints for analysis in synthesized options file.
2016-02-23 16:36:09 -08:00
Hans Muller
25e22f5648 List Gallery Demo 2016-02-23 15:24:41 -08:00
pq
b69d249460 Enumerate lints for analysis in synthesized options file.
This enables us to exclude `library_names` pending a new stable SDK push (see notes: https://github.com/flutter/flutter/pull/1996).  Also excluded are a few lints who's feedback was just getting regexp'ed out.  Moving forward, this will allow us to selectively enable specific lints of interest as well.
2016-02-23 15:07:55 -08:00
Hixie
16e7c3a61c Trivial cleanup of getDistanceToBaseline
Turns out we don't need 'parent' outside the assert at all.
2016-02-23 12:56:07 -08:00
Ian Hickson
8a53753427 Merge pull request #2107 from Hixie/flutter-tool
Fix --debug
2016-02-23 12:55:15 -08:00
Ian Hickson
81df765d21 Merge pull request #2108 from Hixie/scroll
Clean up scroll behaviour.
2016-02-23 12:38:39 -08:00
Collin Jackson
263e2e7ff3 Merge pull request #2109 from collinjackson/no_material
Remove redundant Material from start project
2016-02-23 12:33:14 -08:00
Hixie
98d47c3544 Clean up scroll behaviour.
This makes ScrollBehavior agnostic about the kind of scroll.
This also means ExtentScrollBehavior's comment about being linear is
more relevant (previously it was true of all scroll behaviours).
2016-02-23 11:56:37 -08:00
Collin Jackson
8ab9a8fe03 Remove redundant Material from project created by flutter create 2016-02-23 11:29:55 -08:00
Hixie
71c8a96fb9 Fix --debug
...and some style nits.
2016-02-23 11:10:52 -08:00
Devon Carew
9367b86abe add a validator for Atom 2016-02-23 10:25:14 -08:00
Ian Hickson
3f8fdb661f Merge pull request #2098 from Hixie/animation-cleanup
Some trivial animation library cleanup.
2016-02-22 22:45:58 -08:00
Yegor
3301ae7d09 Merge pull request #2097 from yjbanov/flutter-driver-create
"flutter create" can generate a basic driver test; "flutter drive" gains new options
2016-02-22 17:18:54 -08:00
yjbanov
278630e688 "flutter create" can generate a basic driver test
"flutter create" adds option `--with-driver-test` that adds
dependencies to `flutter_driver` in `pubspec.yaml` and creates
a basic driver test runnable via `flutter drive
--target=test_driver/e2e.dart`

"flutter drive" new options:

- `--keep-app-running` tells the driver to not stop the app after tests
  are done
- `--use-existing-app` tells the driver to not start a new app but use
  an already running instance
2016-02-22 17:10:31 -08:00
Ian Hickson
7b0e7ee38e Some trivial animation library cleanup. 2016-02-22 14:18:17 -08:00
Devon Carew
a49e45106d fix a checked mode assertion 2016-02-22 13:09:22 -08:00
Devon Carew
3463d89cf6 remove iosSimulator field from ApplicationPackageStore 2016-02-22 12:37:08 -08:00
Devon Carew
896246ad14 Merge pull request #2079 from devoncarew/more_specific_logging
log for specific adb devices
2016-02-22 12:12:05 -08:00
Chinmay Garde
2b70fda196 Merge pull request #2081 from chinmaygarde/master
Address issues raised in PR #2047
2016-02-22 12:10:54 -08:00
Chinmay Garde
d299b05ab3 Fix linter error regarding extra braces in string interpolation in devices.dart 2016-02-22 11:51:35 -08:00
Chinmay Garde
7e59a9e82e Address issues raised in PR #2047 2016-02-22 11:43:52 -08:00
Chinmay Garde
6ab25977c5 Merge pull request #2080 from chinmaygarde/master
Update status messages when unsupported devices are detected by the tools
2016-02-22 11:33:47 -08:00