firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Keep AnimationController's _value in bounds

Browse Source 
Rather than clamping _value on read, we now clamp the value when writing it,
which simplifies reasoning about _value.
This commit is contained in:
Adam Barth
2016-02-24 12:15:57 -08:00
parent df52a77ffd
commit 9e45b85e72
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter/lib/src/animation/animation_controller.dart
View File

@@ -88,7 +88,7 @@ class AnimationController extends Animation<double>
/// The current value of the animation.
///
/// Setting this value stops the current animation.
double get value => _value.clamp(lowerBound, upperBound);
double get value => _value;
double _value;
void set value(double newValue) {
assert(newValue != null);
@@ -174,7 +174,7 @@ class AnimationController extends Animation<double>
assert(simulation != null);
assert(!isAnimating);
_simulation = simulation;
_value = simulation.x(0.0);
_value = simulation.x(0.0).clamp(lowerBound, upperBound);
return _ticker.start();
}
@@ -200,7 +200,7 @@ class AnimationController extends Animation<double>
void _tick(Duration elapsed) {
double elapsedInSeconds = elapsed.inMicroseconds.toDouble() / Duration.MICROSECONDS_PER_SECOND;
_value = _simulation.x(elapsedInSeconds);
_value = _simulation.x(elapsedInSeconds).clamp(lowerBound, upperBound);
if (_simulation.isDone(elapsedInSeconds))
stop();
notifyListeners();