firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
28,900 Commits 1 Branch 0 Tags
5cbbce3e7e5de76a771ec4fe2a177bf635f45205
Commit Graph

28900 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonah Williams
5cbbce3e7e [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054) 
This fixes the correctness issues observed in https://github.com/flutter/flutter/issues/126701 . The missing stencil descriptor meant that the clips were always ignored.

Have not yet investigated the reported debug performance issues.
 2023-05-15 23:04:05 +00:00
skia-flutter-autoroll
27b261266a Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058) 
https://skia.googlesource.com/skia.git/+log/4becb53e3c21..24bebce2d9a1

2023-05-15 johnstiles@google.com Remove arrayification support from Variable::Convert.
2023-05-15 jamesgk@google.com [graphite] Use dual-src blending when available
2023-05-15 michaelludwig@google.com Remove legacy bounds layer staging code
2023-05-15 michaelludwig@google.com [skif] Skip saving a layer for image filters that don't use source image
2023-05-15 johnstiles@google.com Simplify logic in DSLWriter::Var.
2023-05-15 johnstiles@google.com Replace dsl::Struct with StructDefinition::Convert.
2023-05-15 johnstiles@google.com Reduce DSLModifiers to a simple struct.
2023-05-15 johnstiles@google.com Remove swap and assign from DSLExpression.
2023-05-15 johnstiles@google.com Move struct error checks into MakeStructType.
2023-05-15 johnstiles@google.com Remove DSLLayout type.
2023-05-15 jlavrova@google.com Return an unordered_set of unresolved codepoints
2023-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a356ab97987 to f3e8446466d8 (1 revision)
2023-05-15 lovisolo@google.com [bazel] Android build: Add missing Android-specific GPU dependency.
2023-05-15 robertphillips@google.com Add Protected tracking to Ganesh's OpenGL backend
2023-05-15 kjlubick@google.com Fix legacy SkSurface::MakeNull call
2023-05-15 lovisolo@google.com [bazel] Android build: Remove hard dependency on a GPU backend.
2023-05-15 johnstiles@google.com Remove unused DSLExpression ctors.
2023-05-15 johnstiles@google.com Reland "Enable OutParamsFunctionCallInArgument test on GPU."
2023-05-15 johnstiles@google.com Eliminate DSLType::StructType.
2023-05-15 kjlubick@google.com Enforce IWYU on src/core/SkB*

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-15 22:28:57 +00:00
skia-flutter-autoroll
177c8441ff Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-15 22:24:57 +00:00
Brandon DeRosier
f1806da5b1 [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055) 
Oopsies.
 2023-05-15 21:40:18 +00:00
Jackson Gardner
4daa0909c2 Compile skwasm at -Oz. (flutter/engine#42002) 
We want to start from a place of small size, and optimize from there with skwasm. Since there is no baseline expectation of performance at `-O3`, let's start with the smallest possible binary.
 2023-05-15 19:59:14 +00:00
godofredoc
3f21c6d213 Use release_build and os dimension consistently. (flutter/engine#42012) 
Release_build property is used to signal that this build produces release artifacts that will eventually be SLSA compliant and will need to run from dart_internal.

The os property is used to select the correct drone based on the platform the build should run on.

Bug: https://github.com/flutter/flutter/issues/126118
Bug: https://github.com/flutter/flutter/issues/125983
Bug: https://github.com/flutter/flutter/issues/126116

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-15 19:57:00 +00:00
Brandon DeRosier
b9521559b7 [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031) 
Made this to help debugging clear color problems and I've had it sitting
around in my stage for a few days. Today, it ended up leading me to
discover several other issues.
 2023-05-15 12:48:12 -07:00
Brandon DeRosier
7c0bad1009 [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039) 
Part of https://github.com/flutter/flutter/issues/126696.

* Generalize the FilterContents coverage hint as a Contents property.
* Incorporates the stencil coverage when creating subpass textures.
* Set a coverage hint for backdrop filters.
* Incorporate the coverage hint in the 2-pass Gaussian blur.
 2023-05-15 12:18:08 -07:00
skia-flutter-autoroll
06b709ff52 Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051) 
https://dart.googlesource.com/sdk.git/+log/c302a0252785..d2b2ac829842

2023-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-113.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-15 19:09:22 +00:00
Chris Yang
8d07db38c5 Upload xcresults to LUCI cloud storage (flutter/engine#41647) 
Taking over from https://github.com/flutter/engine/pull/41644

fixes: https://github.com/flutter/flutter/issues/125823

Steps to verify

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-15 19:05:10 +00:00
gaaclarke
7d5f571373 Include SkRect in rtree. (flutter/engine#42050) 
fixes https://github.com/flutter/flutter/issues/126864

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-15 18:55:11 +00:00
gaaclarke
47b14888c5 [Impeller] switches the wide gamut surface to f16 (flutter/engine#41994) 
**requires https://github.com/flutter/flutter/pull/126712 to land
first**

fixes https://github.com/flutter/flutter/issues/126620
integration test at: https://github.com/flutter/flutter/pull/126715

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-15 10:25:43 -07:00
Kevin Lubick
0946d27add Migrate uses of SkSurface factories (flutter/engine#41978) 
In http://review.skia.org/687639, many SkSurface static methods were moved and one was deleted (SkSurface::MakeRasterN32Premul). (SkSurface::MakeNull was omitted accidentally and http://review.skia.org/696537glesource.com/c/skia/+/696537 has not rolled into Flutter yet)

This changes the calls in Flutter to match those moved functions. There should be no functional difference and everything was done pretty mechanically (e.g. find and replace)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-15 16:41:10 +00:00
skia-flutter-autoroll
308a224ee9 Roll Fuchsia Mac SDK from A3thcPNgxVcKzR-da... to JCoP2Fekj3MBIqskE... (flutter/engine#42041) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-15 15:59:11 +00:00
skia-flutter-autoroll
817bdf2426 Roll Dart SDK from c777d54743e1 to c302a0252785 (1 revision) (flutter/engine#42040) 
https://dart.googlesource.com/sdk.git/+log/c777d54743e1..c302a0252785

2023-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-112.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-15 15:01:07 +00:00
skia-flutter-autoroll
ea96c9f22d Roll Dart SDK from 7d6324d5488b to c777d54743e1 (1 revision) (flutter/engine#42038) 
https://dart.googlesource.com/sdk.git/+log/7d6324d5488b..c777d54743e1

2023-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-111.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-15 11:02:23 +00:00
Brandon DeRosier
83813f6f12 [Impeller] Fix DrawPaint advanced blends on iOS. (flutter/engine#42032) 
Resolves https://github.com/flutter/flutter/issues/126790.

Adds an optional coverage limit when taking a snapshot contents, used by
FramebufferBlendContents.
Also makes advanced blends more efficient in cases where blended object
lies partially outside the pass.
 2023-05-15 03:44:59 -07:00
dependabot[bot]
322bcc2734 Bump google/mirror-branch-action from 1.0 to 2.0 (flutter/engine#42037) 
Bumps [google/mirror-branch-action](https://github.com/google/mirror-branch-action) from 1.0 to 2.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="30c52ee21f"><code>30c52ee</code></a> Update dependencies.</li>
<li><a href="4544d8a090"><code>4544d8a</code></a> Update deprecated action environment</li>
<li><a href="884625cd18"><code>884625c</code></a> Bump node-fetch from 2.6.0 to 2.6.1</li>
<li><a href="d9fb13d47a"><code>d9fb13d</code></a> Bump <code>@​actions/core</code> from 1.2.4 to 1.2.6</li>
<li><a href="4083f5d474"><code>4083f5d</code></a> Unify placeholders in README.md</li>
<li><a href="394f8d4604"><code>394f8d4</code></a> Bump lodash from 4.17.15 to 4.17.19 (<a href="https://redirect.github.com/google/mirror-branch-action/issues/3">#3</a>)</li>
<li><a href="5d7016e8e9"><code>5d7016e</code></a> The sample <code>uses:</code> line should reference <a href="https://github.com/v1"><code>@​v1</code></a>.0 (<a href="https://redirect.github.com/google/mirror-branch-action/issues/1">#1</a>)</li>
<li>See full diff in <a href="c6b07e441a...30c52ee21f">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google/mirror-branch-action&package-manager=github_actions&previous-version=1.0&new-version=2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2023-05-15 09:36:23 +00:00
skia-flutter-autoroll
cf74bb17c7 Roll Skia from 0c2083a60b66 to 4becb53e3c21 (2 revisions) (flutter/engine#42036) 
https://skia.googlesource.com/skia.git/+log/0c2083a60b66..4becb53e3c21

2023-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from cbe6e1312c42 to a747357f3132
2023-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0d899fb75655 to cbe6e1312c42 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-15 07:23:23 +00:00
skia-flutter-autoroll
eeec4e8e08 Roll Fuchsia Linux SDK from jXrn0SP_MnSmhkz_P... to EweLgJoiYUDok2vyU... (flutter/engine#42035) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-15 05:41:34 +00:00
skia-flutter-autoroll
27478f6013 Roll Skia from 0410e5d9ec03 to 0c2083a60b66 (1 revision) (flutter/engine#42034) 
https://skia.googlesource.com/skia.git/+log/0410e5d9ec03..0c2083a60b66

2023-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6d50a49da6d0 to 89a3dac88297 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-15 05:33:24 +00:00
Casey Hillers
c77155e442 [Impeller] Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#42033) 
Fixes b/282290672

Google Testing currently does not support vulkan, and constructors like
this need to be behind a flag.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2023-05-14 22:29:19 -07:00
Casey Hillers
f0c9869019 Reland "Remove GN staging flag for save layer bounds" (flutter/engine#42029) 
Reverts flutter/engine#42026

After investigating, this is a bug fix for the scubas.
 2023-05-15 04:34:28 +00:00
skia-flutter-autoroll
0b71b21824 Roll Fuchsia Mac SDK from qnNU5eQaox06ejpSE... to A3thcPNgxVcKzR-da... (flutter/engine#42030) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-15 03:10:30 +00:00
skia-flutter-autoroll
3d03285242 Roll Dart SDK from 005648f027a3 to 7d6324d5488b (1 revision) (flutter/engine#42027) 
https://dart.googlesource.com/sdk.git/+log/005648f027a3..7d6324d5488b

2023-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-110.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-14 18:40:49 +00:00
Casey Hillers
e331048fc7 Revert "Remove GN staging flag for save layer bounds" (flutter/engine#42026) 
Reverts flutter/engine#41940

See b/282115120

This caused a golden failure on Google Testing where a rectangular avatar became circular.
 2023-05-14 17:01:17 +00:00
skia-flutter-autoroll
c2634ce31d Roll Fuchsia Linux SDK from hEJzgtSberqdXmLnk... to jXrn0SP_MnSmhkz_P... (flutter/engine#42025) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-14 16:49:24 +00:00
skia-flutter-autoroll
452da0c73c Roll Skia from 35d8ac3ced75 to 0410e5d9ec03 (1 revision) (flutter/engine#42024) 
https://skia.googlesource.com/skia.git/+log/35d8ac3ced75..0410e5d9ec03

2023-05-14 brianosman@google.com Revert "Enable OutParamsFunctionCallInArgument test on GPU."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-14 14:54:31 +00:00
skia-flutter-autoroll
f4d9ef9a6e Roll Fuchsia Mac SDK from hXcPXU_V5nVeGkEbt... to qnNU5eQaox06ejpSE... (flutter/engine#42023) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-14 14:24:21 +00:00
skia-flutter-autoroll
41f36ba364 Roll Skia from 1c00432c2a85 to 35d8ac3ced75 (1 revision) (flutter/engine#42022) 
https://skia.googlesource.com/skia.git/+log/1c00432c2a85..35d8ac3ced75

2023-05-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-14 08:22:34 +00:00
skia-flutter-autoroll
fd47e42c2a Roll Fuchsia Linux SDK from mAQy_vMru3cTWSoBl... to hEJzgtSberqdXmLnk... (flutter/engine#42021) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-14 04:00:35 +00:00
Jim Graham
820d1dbbde add non-rendering operation culling to DisplayListBuilder (flutter/engine#41463) 
This optimization avoids recording unnecessary render operations that will not affect the output and also eliminates the need for "draw detection" mechanisms like `DlOpSpy` and `CanvasSpy` by remembering if any non-transparent operations were included. The `DlOpSpy` unit tests were updated to check if the results from that object match the new `DisplayList::affects_transparent_surface()` method.

Fixes https://github.com/flutter/flutter/issues/125338

In addition, this change will unblock some other Issues:

- https://github.com/flutter/flutter/issues/125318
- https://github.com/flutter/flutter/issues/125403
 2023-05-14 02:14:33 +00:00
skia-flutter-autoroll
06105c34ab Roll Fuchsia Mac SDK from wxolyLvEWZ9IMOCU_... to hXcPXU_V5nVeGkEbt... (flutter/engine#42020) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-14 01:38:36 +00:00
skia-flutter-autoroll
7161aeef66 Roll Dart SDK from 48d09a6216a8 to 005648f027a3 (1 revision) (flutter/engine#42017) 
https://dart.googlesource.com/sdk.git/+log/48d09a6216a8..005648f027a3

2023-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-109.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-13 15:32:22 +00:00
skia-flutter-autoroll
d6720aa1f3 Roll Fuchsia Linux SDK from bddx8p5907poNnZTq... to mAQy_vMru3cTWSoBl... (flutter/engine#42016) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-13 15:10:13 +00:00
skia-flutter-autoroll
a3eb37a286 Roll Fuchsia Mac SDK from oc2gdx4PWYT-K7XQ9... to wxolyLvEWZ9IMOCU_... (flutter/engine#42015) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-13 12:51:24 +00:00
skia-flutter-autoroll
b6bc2c83d4 Roll Dart SDK from 2a285d87f5d7 to 48d09a6216a8 (1 revision) (flutter/engine#42014) 
https://dart.googlesource.com/sdk.git/+log/2a285d87f5d7..48d09a6216a8

2023-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-108.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-13 10:03:29 +00:00
skia-flutter-autoroll
4c6d847954 Roll Skia from 872787e7595c to 1c00432c2a85 (1 revision) (flutter/engine#42013) 
https://skia.googlesource.com/skia.git/+log/872787e7595c..1c00432c2a85

2023-05-13 sallyqi@google.com Fix the way of Alpha8 gainmap support in Skia.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-13 06:57:15 +00:00
Bruno Leroux
80c4704ddf [macOS - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#41977) 
## Description

This PR updates the macOS text input plugin to avoid adding a new line on a multiline text field when action is not set to `TextInputAction.newline`.

## Related Issue

macOS implementation for https://github.com/flutter/flutter/issues/125879.
(similar to the Linux implementation in https://github.com/flutter/engine/pull/41895).

## Tests

Adds 2 tests.
 2023-05-13 06:48:14 +00:00
skia-flutter-autoroll
d182d2be80 Roll Skia from cfdfc039b848 to 872787e7595c (1 revision) (flutter/engine#42010) 
https://skia.googlesource.com/skia.git/+log/cfdfc039b848..872787e7595c

2023-05-13 michaelludwig@google.com [skif] Fix inset=0 case for new Magnifier

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-13 05:04:16 +00:00
skia-flutter-autoroll
8056ac6066 Roll Skia from 6a4e29cbd73b to cfdfc039b848 (2 revisions) (flutter/engine#42004) 
https://skia.googlesource.com/skia.git/+log/6a4e29cbd73b..cfdfc039b848

2023-05-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0d737f701865 to 3a356ab97987 (1 revision)
2023-05-12 johnstiles@google.com Add null guard to intrinsic evaluation of normalize().

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-13 03:10:26 +00:00
skia-flutter-autoroll
b165713640 Roll Fuchsia Linux SDK from HMLNsG7w9sTDpW2Ge... to bddx8p5907poNnZTq... (flutter/engine#42003) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-13 01:22:11 +00:00
skia-flutter-autoroll
0e6a5e2723 Roll Fuchsia Mac SDK from rO5qs4MpN6WfJcu64... to oc2gdx4PWYT-K7XQ9... (flutter/engine#42000) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-13 00:05:14 +00:00
skia-flutter-autoroll
638a24666a Roll Skia from 64bdd87fadfe to 6a4e29cbd73b (2 revisions) (flutter/engine#41999) 
https://skia.googlesource.com/skia.git/+log/64bdd87fadfe..6a4e29cbd73b

2023-05-12 johnstiles@google.com Allow convertArraySize to take an integer size.
2023-05-12 lokokung@google.com Updates webgpu C++ Release call to use MoveToCHandle.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-12 23:48:18 +00:00
Jason Simmons
d3132f8e6a [Impeller] Remove a debug log from the Vulkan render pass (flutter/engine#41987) 2023-05-12 16:42:03 -07:00
skia-flutter-autoroll
37cc77c5e7 Roll Dart SDK from 858f83d6d993 to 2a285d87f5d7 (2 revisions) (flutter/engine#41997) 
https://dart.googlesource.com/sdk.git/+log/858f83d6d993..2a285d87f5d7

2023-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-107.0.dev
2023-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-106.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-12 23:10:32 +00:00
Brandon DeRosier
54d5c489c2 [Impeller] Ignore the Z basis when scaling text (flutter/engine#41995) 
Fixes https://github.com/flutter/flutter/issues/126510.

`GetMaxBasisLength()` includes the Z basis vector, which happens to not
be getting scaled down along with the X and Y for this reproduction
case. And so given the 2D nature of text and the intent of this scale
parameter, it's returning a value that's too large here.
 2023-05-12 15:28:19 -07:00
skia-flutter-autoroll
b46ff342f3 Roll Skia from 539fb10d7cfb to 64bdd87fadfe (18 revisions) (flutter/engine#41993) 
https://skia.googlesource.com/skia.git/+log/539fb10d7cfb..64bdd87fadfe

2023-05-12 johnstiles@google.com Remove unused methods from DSLFunction.
2023-05-12 michaelludwig@google.com [skif] Re-arrange static functions in SkImageFilterTypes.cpp
2023-05-12 robertphillips@google.com Add default for Mock backend types' 'isProtected' parameters
2023-05-12 kjlubick@google.com Manually Roll Dawn from 776a762c9a4d to 6d50a49da6d0 (19 revisions)
2023-05-12 johnstiles@google.com Enable OutParamsFunctionCallInArgument test on GPU.
2023-05-12 kjlubick@google.com Decouple SkImage and Graphite backend
2023-05-12 jamesgk@google.com [graphite] Account for primitive blending depending on dst
2023-05-12 jamesgk@google.com [graphite] Incorporate coverage into blending
2023-05-12 jvanverth@google.com [graphite] Set up snippetID and data for YUV shader
2023-05-12 brianosman@google.com Disallow SkSL in glyph drawables
2023-05-12 johnstiles@google.com Update SkSLTest to use SkEnumBitMask.
2023-05-12 brianosman@google.com Remove some unused SkPicture code
2023-05-12 kjlubick@google.com Make IWYU build skip linking
2023-05-12 robertphillips@google.com Adjust Mock backend's Protected implementation
2023-05-12 johnstiles@google.com Remove SkVM from the SkSL test matrix.
2023-05-12 johnstiles@google.com Remove DSLField type.
2023-05-12 johnstiles@google.com Rename SkSL::Type::Field and SkSL::Field.
2023-05-12 michaelludwig@google.com Handle zero-scale factors in InverseMapRect

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-12 21:56:02 +00:00
Mouad Debbar
7b3b362623 [web] Cleaner output on LUCI (flutter/engine#41989) 
Using ansi colors in LUCI results in output that looks like:
```
00:00 +0: loading flutter_tester_emulation_golden_test.dart                                                                                                                                            
00:01 +0: loading flutter_tester_emulation_golden_test.dart                                                                                                                                            
00:02 +0: loading flutter_tester_emulation_golden_test.dart
```

This PR disables colors on LUCI so that we get clean output that's easily scannable and searchable.
 2023-05-12 21:50:22 +00:00
Bruno Leroux
fea415faa0 [Web+Linux] Fix pressing Meta keys throws (flutter/engine#41694) 
## Description

This PR fixes Meta keys throwing exception on Chrome Linux.

The assertions throws because the DOM event sent when Meta keys is pressed is not coherent when Meta is the only pressed key.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/125672

## Tests

Adds 1 test.
 2023-05-12 21:46:17 +00:00