firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
30,178 Commits 1 Branch 0 Tags
4da623eefc464a25d08fba1550e3c67705f4dd5e
Commit Graph

23059 Commits

Author SHA1 Message Date
skia-flutter-autoroll
4da623eefc Roll Skia from 981146e6305d to 6f2b2e94ebbd (3 revisions) (flutter/engine#43871) 
https://skia.googlesource.com/skia.git/+log/981146e6305d..6f2b2e94ebbd

2023-07-20 aeubanks@google.com Fix newly warned -Wconstant-logical-operand
2023-07-20 johnstiles@google.com Add WGSL support for uniforms inside interface blocks.
2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e1c3b16d5aa5 to 13599b120a68 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 23:20:04 +00:00
skia-flutter-autoroll
0f60dcbbf0 Roll Skia from 100d0f858f02 to 981146e6305d (3 revisions) (flutter/engine#43866) 
https://skia.googlesource.com/skia.git/+log/100d0f858f02..981146e6305d

2023-07-20 jmbetancourt@google.com add typeface setting to SkottieSlide's slot manager interface
2023-07-20 brianosman@google.com Convert recently added GM to unit test
2023-07-20 jvanverth@google.com [graphite] Get Vulkan present working.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 21:37:13 +00:00
Jonah Williams
949e91bbba [Impeller] Provide fragment uniform data through varyings for solid color, glyph atlas, texture shaders. (flutter/engine#43838) 
From experimentation, providing these values through varyings runs substantially faster on Pixel devices. Alternative solutions to use f16 or push constants did not improve things substantially.

These subset of shaders are used very heavily and so they benefit from this change more substantially. I don't think this is applicable to all shaders as there is going to be an additional varying interpolation cost.

See also: [go/impeller-slow-fragment-shader](http://goto.google.com/impeller-slow-fragment-shader)
 2023-07-20 20:47:16 +00:00
skia-flutter-autoroll
f4fb229fe4 Roll Skia from 18e834916f47 to 100d0f858f02 (7 revisions) (flutter/engine#43863) 
https://skia.googlesource.com/skia.git/+log/18e834916f47..100d0f858f02

2023-07-20 penghuang@chromium.org dawn: remove a annoying spammy log from DawnCaps
2023-07-20 brianosman@google.com Remove reference to (obsolete/deleted) T8888 config
2023-07-20 armansito@google.com [graphite][vello] Adjust rough buffer size reduction
2023-07-20 armansito@google.com [graphite][AtlasShapeRenderStep] Implement boundsOutset
2023-07-20 robertphillips@google.com [graphite] Implement SkImage::textureSize
2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 6140cf9c51a5 to 1323db7bd0b4 (2 revisions)
2023-07-20 cmumford@google.com [infra] Reland "Add rule to build final debugger-app image"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 20:19:12 +00:00
skia-flutter-autoroll
614d825cd6 Roll Skia from a3aca7ae523e to 18e834916f47 (1 revision) (flutter/engine#43860) 
https://skia.googlesource.com/skia.git/+log/a3aca7ae523e..18e834916f47

2023-07-20 johnstiles@google.com Fix Overflow test in WGSL codegen.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 19:02:23 +00:00
Mouad Debbar
a9896d3b98 Add url to get GoogleFonts API key (flutter/engine#43857) 2023-07-20 18:34:06 +00:00
Dan Field
f28f9ca32c More validation logs for CommandEncoderVK submission (flutter/engine#43859) 
Helps while investigating https://github.com/flutter/flutter/issues/131001
 2023-07-20 18:29:56 +00:00
skia-flutter-autoroll
ceb3365839 Roll Dart SDK from 857c9a2ae14a to 1df95f328d0c (1 revision) (flutter/engine#43858) 
https://dart.googlesource.com/sdk.git/+log/857c9a2ae14a..1df95f328d0c

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-332.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 18:25:43 +00:00
Mouad Debbar
d205cf6af6 [web] Preserve correct CanvasKit Variant during test initialization (flutter/engine#43854) 
At some point, we started setting `useColorEmoji` to true in our tests, but we were doing it in a way that resets all other configurations to their defaults. This caused the `canvasKitVariant` config to be lost and always set to the default `auto`.

This PR fixes the issue and adds tests to:

1. Make sure that the CanvasKit suite always runs with a specific variant (not `auto`).
2. Make sure the given CanvasKit variant makes it all the way through to the tests.

The test harness uses a backdoor (a global JS property on `window`) to communicate which canvaskit variant it's using. The test then compares that with `configuration.canvasKitVariant` to make sure they match. If they don't match, then the configuration was lost somewhere on the way.

Fixes https://github.com/flutter/flutter/issues/130993
 2023-07-20 18:06:24 +00:00
skia-flutter-autoroll
102c2eda87 Roll Skia from b8133dda3a8c to a3aca7ae523e (1 revision) (flutter/engine#43855) 
https://skia.googlesource.com/skia.git/+log/b8133dda3a8c..a3aca7ae523e

2023-07-20 mike@reedtribe.org Remove unneeded generateAdvance() from SkScalerContext

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 17:40:14 +00:00
skia-flutter-autoroll
7ce5bd6366 Roll Skia from 401c85ab1e21 to b8133dda3a8c (4 revisions) (flutter/engine#43853) 
https://skia.googlesource.com/skia.git/+log/401c85ab1e21..b8133dda3a8c

2023-07-20 johnstiles@google.com Refactor GetConstantValueOrNullForVariable logic.
2023-07-20 brianosman@google.com Remove kBGR_888x_SkColorType
2023-07-20 johnstiles@google.com Remove inaccurate comment in YUVA pixmaps.
2023-07-20 ramasamy.si@zohocorp.com Fix crash in skparagraph's visit function

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 16:22:22 +00:00
skia-flutter-autoroll
e2371670ad Roll Dart SDK from 603aacd8400f to 857c9a2ae14a (1 revision) (flutter/engine#43851) 
https://dart.googlesource.com/sdk.git/+log/603aacd8400f..857c9a2ae14a

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-331.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 14:36:03 +00:00
skia-flutter-autoroll
272e54908f Roll Skia from b238c09fe959 to d09e9869f84c (1 revision) (flutter/engine#43842) 
https://skia.googlesource.com/skia.git/+log/b238c09fe959..d09e9869f84c

2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c10b5129407a to a1951225a465 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 06:25:22 +00:00
John McCutchan
b3945f7706 Add a PlatformViewRenderTarget abstraction (flutter/engine#43813) 
- Introduce PlatformViewRenderTarget interface.
- Refactor VirtualDisplayController and PlatformViewWrapper to extract
SurfaceTexturePlatformViewRenderTarget into a separate class.

In a future CL I will add an ImageReaderPlatformViewRenderTarget which
will enable Platform Views on Impeller/Vulkan.

Tracking issue: https://github.com/flutter/flutter/issues/130892
 2023-07-19 20:26:21 -07:00
skia-flutter-autoroll
4cb94272fd Roll Dart SDK from 677bbf64d4d7 to 368a205aa1d4 (1 revision) (flutter/engine#43841) 
https://dart.googlesource.com/sdk.git/+log/677bbf64d4d7..368a205aa1d4

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-329.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-20 02:27:33 +00:00
skia-flutter-autoroll
6998929456 Roll Skia from 8413c82dea43 to b238c09fe959 (1 revision) (flutter/engine#43835) 
https://skia.googlesource.com/skia.git/+log/8413c82dea43..b238c09fe959

2023-07-19 johnstiles@google.com Add a WGSL testbed file to dm tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 23:03:57 +00:00
skia-flutter-autoroll
f7b39000fd Roll Dart SDK from 936824d49aa7 to 677bbf64d4d7 (1 revision) (flutter/engine#43833) 
https://dart.googlesource.com/sdk.git/+log/936824d49aa7..677bbf64d4d7

2023-07-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-328.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 22:29:14 +00:00
Jim Graham
6f48af53e9 Reland "Add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#43831) 
Fixes: https://github.com/flutter/flutter/issues/129862

This reverts commit 6237207218.

The framework test that was blocking the previous reland has been [fixed](https://github.com/flutter/flutter/pull/130751) to not rely on non-visible (cullable) operations.
 2023-07-19 22:26:01 +00:00
skia-flutter-autoroll
c880af72b7 Roll Skia from bf75ae2f6eec to 8413c82dea43 (1 revision) (flutter/engine#43832) 
https://skia.googlesource.com/skia.git/+log/bf75ae2f6eec..8413c82dea43

2023-07-19 johnstiles@google.com Fix overflow in matrix-multiply constant folding.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 22:13:10 +00:00
skia-flutter-autoroll
4334052623 Roll Skia from b1d6eab1f590 to bf75ae2f6eec (2 revisions) (flutter/engine#43829) 
https://skia.googlesource.com/skia.git/+log/b1d6eab1f590..bf75ae2f6eec

2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 616ec95a04fe to f3c508b81760 (4 revisions)
2023-07-19 johnstiles@google.com Fix assertion in inliner when makeSampler2D is used.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 21:25:36 +00:00
Loïc Sharma
5509e3b51f Add the 'affects: desktop' label to labeler.yml (flutter/engine#43827) 
The desktop team uses the [`affects: desktop`](https://github.com/flutter/engine/pulls?q=is%3Aopen+label%3A%22affects%3A+desktop%22+sort%3Aupdated-desc) label to [triage](https://github.com/flutter/flutter/wiki/Triage#desktop-platforms-team-team-desktop) pull requests.
 2023-07-19 21:01:57 +00:00
skia-flutter-autoroll
34106734af Roll Skia from 30d458aea0b9 to b1d6eab1f590 (2 revisions) (flutter/engine#43826) 
https://skia.googlesource.com/skia.git/+log/30d458aea0b9..b1d6eab1f590

2023-07-19 jmbetancourt@google.com [skottie] plumb vec2 support to SlotManager
2023-07-19 jmbetancourt@google.com [skottie] move color slot tracking to bind call

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 20:36:13 +00:00
Jim Graham
8d73d38291 fix handling of clipped rendering inside a layer that applies a filter (flutter/engine#43787) 
When a saveLayer is rendered with an ImageFilter that modifies the bounds of the rendered pixels, and some of the content of that saveLayer did not intersect the clip, but the filtered output of that content did intersect the clip, we might not accumulate the bounds of those rendering operations into the DisplayList bounds.

This bug was not encountered during practical testing, but showed up on some testing with the new NOP culling code.

For now, this bug only affects the accuracy of the reported bounds of the DisplayList, but that can affect raster caching and potentially the layer culling done in the LayerTree. It might also affect the accuracy of the RTree associated with the DisplayList, which would only show up in rare circumstances when the indicated operation was used in the presence of an embedded view.
 2023-07-19 18:40:31 +00:00
skia-flutter-autoroll
017f0f9085 Roll Skia from 8d19d04472e1 to 650c980daa72 (6 revisions) (flutter/engine#43821) 
https://skia.googlesource.com/skia.git/+log/8d19d04472e1..650c980daa72

2023-07-19 jvanverth@google.com [GL] Restrict setMaxLevel mipmap fix
2023-07-19 michaelludwig@google.com Consolidate SkImage::makeWithFilter implementations
2023-07-19 cmumford@google.com Revert "[infra] Add rule to build final debugger-app image"
2023-07-19 aeubanks@google.com Fix newly warned -Wconstant-logical-operand
2023-07-19 bungeman@google.com Roll FreeType from e4586d96 to 5769f13a (9 commits)
2023-07-19 brianosman@google.com Remove gltestthreading config

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 18:38:54 +00:00
skia-flutter-autoroll
8eb6250802 Roll Skia from 4728980564b1 to a352521a3a7c (3 revisions) (flutter/engine#43816) 
https://skia.googlesource.com/skia.git/+log/4728980564b1..a352521a3a7c

2023-07-19 nigeltao@google.com Roll third_party/wuffs to version 0.3.3
2023-07-19 johnstiles@google.com Enable inlining for runtime effects using SkRP.
2023-07-19 johnstiles@google.com Add instruction count to the top of SkRP dumps.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 16:57:53 +00:00
Brandon DeRosier
6bb9c99a11 [Impeller] Disable color attachment on clip pipelines for Metal & Vulkan. (flutter/engine#43781) 
Remove the color attachment completely in Metal and Vulkan clips.

When the color write mask is set to all false, Metal is smart about not
executing the fragment shader at all, but some Vulkan and GL drivers may
not be. GL requires binding shader objects to draw, and so a cap check
is needed here.

In the future, we could add minimal no-op shaders to use with the GL
clip pipeline to shave off a few flops on drivers that aren't smart
about the color write mask.
 2023-07-19 09:57:50 -07:00
Jason Simmons
a4e0000a77 Apply the offset to the child bounds of an ImageFilterLayer with no filter (flutter/engine#43783) 
Fixes https://github.com/flutter/flutter/issues/130318
 2023-07-19 15:15:02 +00:00
skia-flutter-autoroll
0013a53d42 Roll Skia from e9409b832799 to 1f175b7a2155 (1 revision) (flutter/engine#43811) 
https://skia.googlesource.com/skia.git/+log/e9409b832799..1f175b7a2155

2023-07-19 robertphillips@google.com [graphite] Add initial precompilation fuzzer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 14:32:04 +00:00
skia-flutter-autoroll
a2ab2e8980 Roll Fuchsia Linux SDK from ZABO4Om1vToxhI394... to -SNz0augjLKFVsUWn... (flutter/engine#43810) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 12:44:27 +00:00
Kevin Lubick
c4494c9718 Update legacy call to SkImage::makeSubset (flutter/engine#43786) 
In https://skia-review.googlesource.com/c/skia/+/671679 Skia updated the
calls to SkImage::makeSubset() to always need a `GrDirectContext*`. This
updates Flutter's one call that needed it.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-07-19 08:26:05 -04:00
Jason Simmons
a4d8601b57 Fix the rules for determining whether a blur image filter is valid (flutter/engine#43791) 
See https://github.com/flutter/flutter/issues/130318
 2023-07-19 07:14:06 +00:00
skia-flutter-autoroll
d1866abd24 Roll Skia from 9062ca6a691c to 035b12a03918 (3 revisions) (flutter/engine#43801) 
https://skia.googlesource.com/skia.git/+log/9062ca6a691c..035b12a03918

2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c10b5129407a to 55a98e279ec6
2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0733bf3a7728 to c10b5129407a (7 revisions)
2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 151fa797ee3e to 4e401427f8dd (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 06:16:11 +00:00
skia-flutter-autoroll
2a77fee2f6 Roll Dart SDK from c184cac2d22f to 9f5e86b4c108 (1 revision) (flutter/engine#43798) 
https://dart.googlesource.com/sdk.git/+log/c184cac2d22f..9f5e86b4c108

2023-07-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-325.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 05:12:12 +00:00
skia-flutter-autoroll
ce0e083536 Roll Skia from 280fb8391187 to d1d2b623799e (1 revision) (flutter/engine#43795) 
https://skia.googlesource.com/skia.git/+log/280fb8391187..d1d2b623799e

2023-07-19 michaelludwig@google.com [skif] Implement image delegate for graphite

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 02:04:06 +00:00
Zachary Anderson
d84cf41f4f Increase engine v2 orchestrator timeouts (flutter/engine#43788) 
This PR increases orchestrator timeouts to avoid the case where subjobs that are making progress after a long queue time may be needlessly cancelled if the orchestrator runs over a too-small timeout.
 2023-07-18 23:44:11 +00:00
Zachary Anderson
562a5764b0 Remove obsolete legacy engine builds from staging (flutter/engine#43790) 
These builds have had engine v2 variants running for nearly a quarter or
more in most cases, and they are now not serving much of a purpose.
Additionally, during MTV peak hours, queue times and therefore overall
cycle times are getting too long, and we should be freeing up these
resources.
 2023-07-18 15:22:11 -07:00
Brandon DeRosier
0d61edb7a7 [Impeller] Fix GL_NUM_EXTENSIONS check for desktop GL (flutter/engine#43785) 
Follow-up fix for https://github.com/flutter/engine/pull/43727.

Fixes the GL playground on MacOS.
 2023-07-18 14:52:13 -07:00
skia-flutter-autoroll
5b1d0f082f Roll Skia from 9a0f6d82a6f5 to dcc56df202cc (1 revision) (flutter/engine#43784) 
https://skia.googlesource.com/skia.git/+log/9a0f6d82a6f5..dcc56df202cc

2023-07-18 johnstiles@google.com Remove swizzle-parsing logic from SkSL parser.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 21:11:05 +00:00
skia-flutter-autoroll
b1b3995153 Roll Skia from 4e518e65fea0 to 0adae44dd9cd (6 revisions) (flutter/engine#43779) 
https://skia.googlesource.com/skia.git/+log/4e518e65fea0..0adae44dd9cd

2023-07-18 armansito@google.com [graphite][PathAtlas]: Apply correct subpixel offset
2023-07-18 cmumford@google.com [canvaskit] Add error check when loading SKP
2023-07-18 cmumford@google.com [debugger] only serialize audit trail when enabled
2023-07-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cb22d697262b to f0752efcbdb2 (7 revisions)
2023-07-18 herb@google.com Fix data going empty for fuzz
2023-07-18 brianosman@google.com Remove obsolete MSKP corpus information

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 19:50:03 +00:00
Mouad Debbar
6d0be04af3 [web] sync => isSync , scuba => golden (flutter/engine#43699) 
This PR addresses some of the items in https://github.com/flutter/flutter/issues/100394
 2023-07-18 18:28:13 +00:00
skia-flutter-autoroll
2e1160d33e Roll Skia from 219ca2581ab2 to 4e518e65fea0 (2 revisions) (flutter/engine#43777) 
https://skia.googlesource.com/skia.git/+log/219ca2581ab2..4e518e65fea0

2023-07-18 brianosman@google.com CPU backend: Don't ignore paint alpha with opaque shader + color filter
2023-07-18 jvanverth@google.com [graphite] Fill out semaphore support for Vulkan swapchain.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 18:28:10 +00:00
skia-flutter-autoroll
2ada763995 Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions) (flutter/engine#43776) 
Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions)

113f847be6..52fe3116ea

2023-07-18 syoussefi@chromium.org Vulkan: Deduplicate share group's context set tracking
2023-07-18 phanquangminh217@gmail.com Reland "Vulkan: Remove platform restriction of EGL_ANDROID_native_fence_sync"
2023-07-18 cnorthrop@google.com Android: Update script with sync progress
2023-07-18 hitawala@chromium.org Angle: Copy multiplanar d3d11 texture for readPixels
2023-07-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 48a8f73f303f to 8806dade91f0 (572 revisions)
2023-07-17 bsheedy@chromium.org Start Mac Intel 13.4.1 experiment
2023-07-17 syoussefi@chromium.org Move ShareGroup to its own files
2023-07-17 geofflang@chromium.org Metal: Require MSL 2.1.
2023-07-17 geofflang@chromium.org Android: Use ALooper_pollOnce instead of ALooper_pollAll
2023-07-17 romanl@google.com Android: Simplify power metrics collection
2023-07-17 syoussefi@chromium.org Translator: Limit variable sizes vs uint overflow
2023-07-17 m.maiya@samsung.com Vulkan: Bugfix in gl_FragData array redeclaration
2023-07-17 syoussefi@chromium.org Fix deadlock on device loss
2023-07-17 ynovikov@chromium.org Retry angle_deqp_gles2_metal_tests
2023-07-17 cnorthrop@google.com Docs: Add a couple of Android pointers
2023-07-17 romanl@google.com Use VK_EXT_legacy_dithering when available instead of emulation
2023-07-17 ynovikov@chromium.org Skip WebGL2CompatibilityTest.DrawWithZeroSizedBuffer on iOS GL
2023-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 68d783529187 to 48a8f73f303f (690 revisions)
2023-07-14 dtapuska@chromium.org Fix cfi issue with Angle invoking worker pool
2023-07-14 romanl@google.com Ensure settings get cleaned up on exceptions
2023-07-14 romanl@google.com Revert "Add minimal setup for Go codegen in Android.bp."
2023-07-14 ynovikov@chromium.org Skip dEQP-EGL.functional.native_[color|coord]_mapping.native_window.*
2023-07-14 geofflang@chromium.org Reject program binaries when the renderer string changes
2023-07-14 geofflang@chromium.org Sync all framebuffer attachments when checking completeness.
2023-07-14 syoussefi@chromium.org Translator: Unconditionally limit variable sizes
2023-07-14 ynovikov@chromium.org Remove obsolete VUID suppressions
2023-07-14 geofflang@chromium.org Metal: Call terminate if display initialization fails.
2023-07-14 geofflang@chromium.org Metal: Use the pipeline cache for RenderUtils compute shaders
2023-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ad8a66bf7d69 to aa35b58fce7d (7 revisions)
2023-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from de1153f640b8 to 68d783529187 (590 revisions)
2023-07-14 m.maiya@samsung.com Update input color in YUVSampleLinearFiltering test
2023-07-14 lexa.knyazev@gmail.com Restrict color writemasks for RGB9_E5 color buffers
2023-07-14 cclao@google.com Vulkan: Clean up depth stencil feedback mode part 2
2023-07-14 cclao@google.com Vulkan: Clean up depthStencil feedback loop implementation Part1
2023-07-14 zzyiwei@chromium.org Vulkan: disable explicitlyCastMediumpFloatTo16Bit for Venus
2023-07-13 syoussefi@chromium.org Ensure lockless entry point validations only access private data
2023-07-13 geofflang@chromium.org Metal: Cache compute pipelines for provoking vertex emulation
2023-07-13 syoussefi@chromium.org Prevent accidental misuse of ANGLE_ENABLED
2023-07-13 geofflang@chromium.org Metal: Cache compute pipelines with render pipelines.
2023-07-13 dtapuska@chromium.org Fix Angle creating its own worker pool.
2023-07-13 syoussefi@chromium.org Make insertion/retrieval of Debug messages thread-safe
2023-07-13 lexa.knyazev@gmail.com Skip component type validation of non-existent draw buffers
2023-07-13 geofflang@chromium.org Metal: Use the per-context pipeline cache for RenderUtils
2023-07-13 cnorthrop@google.com Revert "Android: Assert that CFI is disabled"
2023-07-13 syoussefi@chromium.org Make validation make straight calls to ErrorSet
2023-07-13 syoussefi@chromium.org Make error handling and debug messages thread safe
...
 2023-07-18 18:05:19 +00:00
skia-flutter-autoroll
03c2dff540 Roll Skia from b7103fe086c1 to 219ca2581ab2 (1 revision) (flutter/engine#43774) 
https://skia.googlesource.com/skia.git/+log/b7103fe086c1..219ca2581ab2

2023-07-18 herb@google.com Simplify bounds checks for collections

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 17:34:15 +00:00
Casey Hillers
94513cf483 [ci.yaml] Skip windows arm on releases (flutter/engine#43771) 
This is blocking the beta release as the builder is running unnecessarily.
 2023-07-18 17:31:44 +00:00
Greg Spencer
5fa39ff142 Check FlutterAppDelegate selector support before calling (flutter/engine#43425) 
## Description

This adds checks for the app delegate to make sure that it supports the Flutter-specific selectors before calling them, so that a non `FlutterAppDelegate` can be used for the `NSApplicationDelegate` on `NSApp`.

## Related Issues
 - https://github.com/flutter/flutter/issues/124829
 - https://github.com/flutter/flutter/issues/127476

## Tests
 - Added a test to make sure things don't crash if the app delegate isn't a `FlutterAppDelegate`.
 2023-07-18 17:31:43 +00:00
Zachary Anderson
2fc2fa8503 Reset Dart VM optimization level to 2 (flutter/engine#43770) 
Partial revert of https://github.com/flutter/engine/pull/43743

Setting the optimization level to `-Oz` reduced compressed binary size by 200KB, but regressed performance by 10-15% across the board (frame build time, gen_snapshot runtime, hot reload time, etc.)
 2023-07-18 17:21:45 +00:00
Jonah Williams
02bee3abf0 [Impeller] Avoid inserting additional save layers based on clip configuration. (flutter/engine#43759) 
Fixes https://github.com/flutter/flutter/issues/130775

On the Skia backend, antiAliasWithSaveLayer is the highest fidelity clipping option. In the Impeller backend, there isn't any difference in how we clip, since the stencil buffer is always used. Nevertheless we were still inserting the save layer, which results in an extra offscreen texture and is wasteful.

Track if impeller is enabled in the diff/preroll/paint context and avoid inserting a save layer.
 2023-07-18 17:21:42 +00:00
skia-flutter-autoroll
cd349ca222 Roll Skia from 8d3e00a1f25f to b33cc7da1e23 (1 revision) (flutter/engine#43768) 
https://skia.googlesource.com/skia.git/+log/8d3e00a1f25f..b33cc7da1e23

2023-07-18 herb@google.com Centralize bounds checking code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 14:40:07 +00:00
skia-flutter-autoroll
d64ac24130 Roll Skia from a4df72ba04bb to 8d3e00a1f25f (1 revision) (flutter/engine#43766) 
https://skia.googlesource.com/skia.git/+log/a4df72ba04bb..8d3e00a1f25f

2023-07-18 kjlubick@google.com Allow legacy mesh APIs in CPU-only build too

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 13:40:10 +00:00
skia-flutter-autoroll
24972e64e9 Roll Dart SDK from 979375f92109 to b83a63e0181a (1 revision) (flutter/engine#43762) 
https://dart.googlesource.com/sdk.git/+log/979375f92109..b83a63e0181a

2023-07-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-322.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 07:53:36 +00:00