firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

More validation logs for CommandEncoderVK submission (flutter/engine#43859)

Browse Source 
Helps while investigating https://github.com/flutter/flutter/issues/131001
This commit is contained in:
Dan Field
2023-07-20 11:29:56 -07:00
committed by GitHub
parent ceb3365839
commit f28f9ca32c
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
engine/src/flutter/impeller/renderer/backend/vulkan/command_encoder_vk.cc
View File

@@ -161,6 +161,7 @@ bool CommandEncoderVK::Submit(SubmitCallback callback) {
// Make sure to call callback with `false` if anything returns early.
bool fail_callback = !!callback;
if (!IsValid()) {
VALIDATION_LOG << "Cannot submit invalid CommandEncoderVK.";
if (fail_callback) {
callback(false);
}
@@ -179,22 +180,28 @@ bool CommandEncoderVK::Submit(SubmitCallback callback) {
auto command_buffer = GetCommandBuffer();
if (command_buffer.end() != vk::Result::eSuccess) {
auto status = command_buffer.end();
if (status != vk::Result::eSuccess) {
VALIDATION_LOG << "Failed to end command buffer: " << vk::to_string(status);
return false;
}
std::shared_ptr<const DeviceHolder> strong_device = device_holder_.lock();
if (!strong_device) {
VALIDATION_LOG << "Device lost.";
return false;
}
auto [fence_result, fence] = strong_device->GetDevice().createFenceUnique({});
if (fence_result != vk::Result::eSuccess) {
VALIDATION_LOG << "Failed to create fence: " << vk::to_string(fence_result);
return false;
}
vk::SubmitInfo submit_info;
std::vector<vk::CommandBuffer> buffers = {command_buffer};
submit_info.setCommandBuffers(buffers);
if (queue_->Submit(submit_info, *fence) != vk::Result::eSuccess) {
status = queue_->Submit(submit_info, *fence);
if (status != vk::Result::eSuccess) {
VALIDATION_LOG << "Failed to submit queue: " << vk::to_string(status);
return false;
}