Reid Baker
40f763aeaa
Update changelog from 3.24.2 to master ( #154625 )
...
Following go/flutter-release-workflow#notify update changelog in master from latest stable release.
2024-09-04 17:22:05 +00:00
Amal Krishna
4a54ca8285
Add static of accessor methods to ColorScheme and TextTheme ( #154073 )
...
The most common use case to lookup a `ThemeData` instance using `Theme.of(context)` is to access either the `ColorScheme`, the `TextTheme`, or both.
Before this change:
```dart
final colors = Theme.of(context).colorScheme;
final textTheme = Theme.of(context).textTheme;
final primaryTextTheme = Theme.of(context).primaryTextTheme;
```
or
```dart
final ThemeData(
:colorScheme,
:textTheme,
:primaryTextTheme,
) = Theme.of(context);
```
After this change:
```dart
final colors = ColorScheme.of(context);
final textTheme = TextTheme.of(context);
final primaryTextTheme = TextTheme.primaryOf(context);
```
### Primary Changes
This PR adds static `of` convenience methods to `ColorScheme` and `TextTheme` that delegate to the `ThemeData`'s respective properties. The methods added are:
* `ColorScheme.of(context)` that returns `Theme.of(context).colorScheme`.
* `TextTheme.of(context)` that returns `Theme.of(context).textTheme`.
* `TextTheme.primaryOf(context)` that returns `Theme.of(context).primaryTextTheme`.
### Side-effects
To allow the above changes to function, this PR adds:
* A `theme.dart` import to `color_scheme.dart` to access to `Theme`.
* A `theme.dart` import to `text_theme.dart` to access to `Theme`.
* A `package:flutter/widgets.dart` import to `text_theme.dart` to access `BuildContext`.
* The above import allowed getting rid of the same `@docImport` from `text_theme.dart`.
### Documentation updates
This PR also updates the following documentation elements:
* Adds docs to the newly added members.
* Updates `TextTheme`'s docs to instruct using `TextTheme.of(context)` instead of `Theme.of(context).textTheme`.
* Updates `Theme.of` to add a "See also" section to `ColorScheme.of` and `TextTheme.of` since these use cases are among the most common ones for `Theme.of(context)`.
Fixes #72201 .
2024-09-04 16:27:48 +00:00
engine-flutter-autoroll
a5ca16ea94
Roll Flutter Engine from 3a235702c499 to d6be2ac8ec01 (1 revision) ( #154621 )
...
3a235702c4...d6be2ac8ecskia-flutter-autoroll@skia.org Roll Skia from dd985e9faf6c to d1121ff583c4 (1 revision) (flutter/engine#54956 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-04 14:50:40 +00:00
engine-flutter-autoroll
80e7e4e1d2
Roll Flutter Engine from 68214414d327 to 3a235702c499 (1 revision) ( #154617 )
...
68214414d3...3a235702c4skia-flutter-autoroll@skia.org Roll Skia from 32ab535755d2 to dd985e9faf6c (1 revision) (flutter/engine#54955 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-04 13:54:18 +00:00
engine-flutter-autoroll
ab143f147e
Roll Flutter Engine from 14a8b542e074 to 68214414d327 (1 revision) ( #154604 )
...
14a8b542e0...68214414d3skia-flutter-autoroll@skia.org Roll Skia from 04d973ac4f26 to 32ab535755d2 (5 revisions) (flutter/engine#54954 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-04 09:12:25 +00:00
Bruno Leroux
dce20c97dd
Fix duplicate MaterialApp in api example test ( #154550 )
...
This PR fixes two tests that created a nested `MaterialApp` (and it simplifies another test).
2024-09-04 06:38:33 +00:00
engine-flutter-autoroll
6caae154a9
Roll Flutter Engine from f78a77086dc5 to 14a8b542e074 (1 revision) ( #154599 )
...
f78a77086d...14a8b542e0skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BaO2fyTu4jhvdTtdE... to qS4FRrP_KI7czLMKv... (flutter/engine#54951 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from BaO2fyTu4jhv to qS4FRrP_KI7c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-04 06:06:13 +00:00
engine-flutter-autoroll
4b944e4544
Roll Flutter Engine from 8d7d5ff693c6 to f78a77086dc5 (1 revision) ( #154598 )
...
8d7d5ff693...f78a77086dskia-flutter-autoroll@skia.org Roll Skia from f53e13c84498 to 04d973ac4f26 (5 revisions) (flutter/engine#54950 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-04 04:27:24 +00:00
Qun Cheng
182c266961
Update tokens to v6.1 ( #153722 )
...
This PR is to update the token version to v6.1.
* This version fixes https://github.com/flutter/flutter/issues/153271
* Change the chip default border color from `ColorScheme.outline` to `ColorScheme.outlineVariant`. The Chips' border color is softened to improve visual hierarchy between chips and buttons
2024-09-04 00:20:16 +00:00
engine-flutter-autoroll
67a75d240e
Roll Flutter Engine from 1e74e9ab10ce to 8d7d5ff693c6 (1 revision) ( #154588 )
...
1e74e9ab10...8d7d5ff693skia-flutter-autoroll@skia.org Roll Skia from 0d9333e72a39 to f53e13c84498 (4 revisions) (flutter/engine#54947 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-03 23:08:31 +00:00
dependabot[bot]
a495ac5ca1
Bump peter-evans/create-pull-request from 6.1.0 to 7.0.0 ( #154587 )
...
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request ) from 6.1.0 to 7.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases ">peter-evans/create-pull-request's releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v7.0.0</h2>
<p>✨ Now supports commit signing with bot-generated tokens! See "What's new" below. ✍️ 🤖 </p>
<h3>Behaviour changes</h3>
<ul>
<li>Action input <code>git-token</code> has been renamed <code>branch-token</code>, to be more clear about its purpose. The <code>branch-token</code> is the token that the action will use to create and update the branch.</li>
<li>The action now handles requests that have been rate-limited by GitHub. Requests hitting a primary rate limit will retry twice, for a total of three attempts. Requests hitting a secondary rate limit will not be retried.</li>
<li>The <code>pull-request-operation</code> output now returns <code>none</code> when no operation was executed.</li>
<li>Removed deprecated output environment variable <code>PULL_REQUEST_NUMBER</code>. Please use the <code>pull-request-number</code> action output instead.</li>
</ul>
<h3>What's new</h3>
<ul>
<li>The action can now sign commits as <code>github-actions[bot]</code> when using <code>GITHUB_TOKEN</code>, or your own bot when using <a href="https://github.com/peter-evans/create-pull-request/blob/HEAD/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens ">GitHub App tokens</a>. See <a href="https://github.com/peter-evans/create-pull-request/blob/HEAD/docs/concepts-guidelines.md#commit-signature-verification-for-bots ">commit signing</a> for details.</li>
<li>Action input <code>draft</code> now accepts a new value <code>always-true</code>. This will set the pull request to draft status when the pull request is updated, as well as on creation.</li>
<li>A new action input <code>maintainer-can-modify</code> indicates whether <a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork ">maintainers can modify</a> the pull request. The default is <code>true</code>, which retains the existing behaviour of the action.</li>
<li>A new output <code>pull-request-commits-verified</code> returns <code>true</code> or <code>false</code>, indicating whether GitHub considers the signature of the branch's commits to be verified.</li>
</ul>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.36 to 18.19.39 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3000 ">peter-evans/create-pull-request#3000</a></li>
<li>build(deps-dev): bump ts-jest from 29.1.5 to 29.2.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3008 ">peter-evans/create-pull-request#3008</a></li>
<li>build(deps-dev): bump prettier from 3.3.2 to 3.3.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3018 ">peter-evans/create-pull-request#3018</a></li>
<li>build(deps-dev): bump ts-jest from 29.2.0 to 29.2.2 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3019 ">peter-evans/create-pull-request#3019</a></li>
<li>build(deps-dev): bump eslint-plugin-prettier from 5.1.3 to 5.2.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3035 ">peter-evans/create-pull-request#3035</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.39 to 18.19.41 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3037 ">peter-evans/create-pull-request#3037</a></li>
<li>build(deps): bump undici from 6.19.2 to 6.19.4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3036 ">peter-evans/create-pull-request#3036</a></li>
<li>build(deps-dev): bump ts-jest from 29.2.2 to 29.2.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3038 ">peter-evans/create-pull-request#3038</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.41 to 18.19.42 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3070 ">peter-evans/create-pull-request#3070</a></li>
<li>build(deps): bump undici from 6.19.4 to 6.19.5 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3086 ">peter-evans/create-pull-request#3086</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.42 to 18.19.43 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3087 ">peter-evans/create-pull-request#3087</a></li>
<li>build(deps-dev): bump ts-jest from 29.2.3 to 29.2.4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3088 ">peter-evans/create-pull-request#3088</a></li>
<li>build(deps): bump undici from 6.19.5 to 6.19.7 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3145 ">peter-evans/create-pull-request#3145</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.43 to 18.19.44 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3144 ">peter-evans/create-pull-request#3144</a></li>
<li>Update distribution by <a href="https://github.com/actions-bot "><code>@âactions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3154 ">peter-evans/create-pull-request#3154</a></li>
<li>build(deps): bump undici from 6.19.7 to 6.19.8 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3213 ">peter-evans/create-pull-request#3213</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.44 to 18.19.45 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3214 ">peter-evans/create-pull-request#3214</a></li>
<li>Update distribution by <a href="https://github.com/actions-bot "><code>@âactions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3221 ">peter-evans/create-pull-request#3221</a></li>
<li>build(deps-dev): bump eslint-import-resolver-typescript from 3.6.1 to 3.6.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3255 ">peter-evans/create-pull-request#3255</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.45 to 18.19.46 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3254 ">peter-evans/create-pull-request#3254</a></li>
<li>build(deps-dev): bump ts-jest from 29.2.4 to 29.2.5 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3256 ">peter-evans/create-pull-request#3256</a></li>
<li>v7 - signed commits by <a href="https://github.com/peter-evans "><code>@âpeter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3057 ">peter-evans/create-pull-request#3057</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/rustycl0ck "><code>@ârustycl0ck</code></a> made their first contribution in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3057 ">peter-evans/create-pull-request#3057</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v6.1.0...v7.0.0 ">https://github.com/peter-evans/create-pull-request/compare/v6.1.0...v7.0.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="4320041ed3https://redirect.github.com/peter-evans/create-pull-request/issues/3057 ">#3057</a>)</li>
<li><a href="0c2a66fe4ahttps://redirect.github.com/peter-evans/create-pull-request/issues/3256 ">#3256</a>)</li>
<li><a href="17121bc5b5https://redirect.github.com/peter-evans/create-pull-request/issues/3254 ">#3254</a>)</li>
<li><a href="87b5d6d564https://redirect.github.com/peter-evans/create-pull-request/issues/3255 ">#3255</a>)</li>
<li><a href="00897e0bc2https://redirect.github.com/peter-evans/create-pull-request/issues/3221 ">#3221</a>)</li>
<li><a href="4cfc1fc717https://redirect.github.com/peter-evans/create-pull-request/issues/3214 ">#3214</a>)</li>
<li><a href="cb4ed6491ahttps://redirect.github.com/peter-evans/create-pull-request/issues/3213 ">#3213</a>)</li>
<li><a href="4eb90b7bc75308ecb864ba864ad40chttps://redirect.github.com/peter-evans/create-pull-request/issues/3154 ">#3154</a>)</li>
<li>Additional commits viewable in <a href="c5a7806660...4320041ed3https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=6.1.0&new-version=7.0.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-09-03 22:24:18 +00:00
RamonFarizel
7eb07c983c
Improve Documentation for ResizeImage Dimensions and Usage ( #154212 )
...
This pull request enhances the documentation for the ResizeImage widget to provide clearer guidance on the use of the `width` and `height` parameters.
Fixes #136508
2024-09-03 22:18:21 +00:00
engine-flutter-autoroll
8c54efd0c3
Roll Flutter Engine from e04220209943 to 1e74e9ab10ce (2 revisions) ( #154583 )
...
e042202099...1e74e9ab1041930132+hellohuanlin@users.noreply.github.com [ios][platform_view] fix platform view clipping path intersection (flutter/engine#54820 )
2024-09-03 jason-simmons@users.noreply.github.com [Impeller] Add all requested glyphs if TypographerContextSkia needs to create a new atlas (flutter/engine#54912 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-03 22:12:36 +00:00
Matan Lurey
f070ffc53b
Get reasonable output when a stream test fails. ( #154377 )
...
Debugging https://github.com/flutter/flutter/issues/154268 was hard; when I removed `--disable-dart-dev` I would get the following error from this test:
<img width="627" alt="Screenshot 2024-08-29 at 4 25 43â¯PM" src="https://github.com/user-attachments/assets/2cc3266e-cc6e-425f-b909-12d7556ff110 ">
After my change, this is what the error looks like:
<img width="1055" alt="Screenshot 2024-08-29 at 4 26 50â¯PM" src="https://github.com/user-attachments/assets/8b0ecccc-a7c9-4da7-bf22-15cef24c4cc7 ">
In general we should embrace more of the test package and matchers when appropriate.
2024-09-03 21:36:24 +00:00
Konstantin Scheglov
284d289425
Prepare bots for not reporting UNUSED_IMPORT in presence of unresolved identifiers. ( #154514 )
...
With https://dart-review.googlesource.com/c/sdk/+/383022 the analyzer does not report `unused_import` when there are compilation errors potentially related to imports.
https://github.com/flutter/flutter/issues/154413
2024-09-03 21:16:48 +00:00
engine-flutter-autoroll
3fd27bdb58
Roll Flutter Engine from 872cbe8ff279 to e04220209943 (2 revisions) ( #154581 )
...
872cbe8ff2...e042202099skia-flutter-autoroll@skia.org Roll Skia from 5515c08c2e44 to 0d9333e72a39 (8 revisions) (flutter/engine#54944 )
2024-09-03 jonahwilliams@google.com [Impeller] disable Adreno 630 vulkan and add mechanism for android driver denylisting. (flutter/engine#54920 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-03 21:14:58 +00:00
Tirth
3ff7da2305
Tiny Fix in Docs for SliverList.separated & SliverList.builder ( #154551 )
...
Tiny Fix in Docs for `SliverList.separated` & `SliverList.builder`
Fixes #154538
2024-09-03 21:05:19 +00:00
Tirth
4d552e913e
Tiny Fix in Docs for SliverFixedExtentList & SliverVariedExtentList ( #154557 )
...
Tiny Fix in Docs for `SliverFixedExtentList` & `SliverVariedExtentList`
Fixes #154554
2024-09-03 21:05:16 +00:00
engine-flutter-autoroll
cf47702e5f
Roll Flutter Engine from 537343143275 to 872cbe8ff279 (1 revision) ( #154578 )
...
5373431432...872cbe8ff2skia-flutter-autoroll@skia.org Roll Skia from 2d5a75027691 to 5515c08c2e44 (3 revisions) (flutter/engine#54941 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-03 20:10:25 +00:00
gaaclarke
52bb0c4cee
Switched CupertinoDynamicColor to implements Color ( #153938 )
...
issue: https://github.com/flutter/flutter/issues/127855
This was an impediment to [changing the Color class](https://github.com/flutter/engine/pull/54415 ).
2024-09-03 20:00:04 +00:00
Mohsin Raza
76955826ae
set onChangedField function to only update options with new results ( #150776 )
...
Added function and result identifiers into the RawAutocomplete onChangedField method, now the options value will not be updated if the data is from an optionsBuilder call older than the last call which updated the options
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Issue #150774 is fixed by this PR
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-09-03 19:55:12 +00:00
Kate Lovett
72ebfc7dc0
Update customer test logging ( #154577 )
...
Reverts flutter/flutter#154356 , and updates logging so that the test suite's name and runtime is always logged, not just on failure.
The issue is resolved in https://github.com/flutter/tests/pull/406
Related to https://github.com/flutter/flutter/issues/154251
2024-09-03 19:51:08 +00:00
Kate Lovett
132dc8f82d
Revert #154339 , remove bringup on linux customer testing ( #154372 )
...
Reverts increased timeouts on customer testing from #154339 , also removes bringup state from https://github.com/flutter/flutter/issues/154293 .
This was related to https://github.com/flutter/flutter/issues/154251 , which will be fixed by https://github.com/flutter/tests/pull/406 (so we should land that first).
2024-09-03 19:36:56 +00:00
engine-flutter-autoroll
f508d0a10c
Roll Flutter Engine from a3504c2f347d to 537343143275 (17 revisions) ( #154569 )
...
a3504c2f34...5373431432skia-flutter-autoroll@skia.org Roll Skia from ab2317b94853 to 2d5a75027691 (3 revisions) (flutter/engine#54940 )
2024-09-03 skia-flutter-autoroll@skia.org Roll Skia from 041fd378d332 to ab2317b94853 (3 revisions) (flutter/engine#54937 )
2024-09-03 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-python from 5.1.1 to 5.2.0 (flutter/engine#54933 )
2024-09-03 skia-flutter-autoroll@skia.org Roll Skia from 49ea0f383706 to 041fd378d332 (1 revision) (flutter/engine#54932 )
2024-09-03 robert.ancell@canonical.com Make FlApplication class (flutter/engine#54637 )
2024-09-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ksNJVM5ZoBB74rba_... to BaO2fyTu4jhvdTtdE... (flutter/engine#54931 )
2024-09-02 skia-flutter-autoroll@skia.org Roll Skia from 3d0c9bf48176 to 49ea0f383706 (1 revision) (flutter/engine#54928 )
2024-09-02 skia-flutter-autoroll@skia.org Roll Skia from 03bdb5c60304 to 3d0c9bf48176 (1 revision) (flutter/engine#54925 )
2024-09-02 skia-flutter-autoroll@skia.org Roll Skia from c873eb5f38d5 to 03bdb5c60304 (1 revision) (flutter/engine#54924 )
2024-09-02 skia-flutter-autoroll@skia.org Roll Skia from 514feab300b4 to c873eb5f38d5 (1 revision) (flutter/engine#54923 )
2024-09-02 skia-flutter-autoroll@skia.org Roll Skia from 15641c0df7e8 to 514feab300b4 (1 revision) (flutter/engine#54922 )
2024-09-01 skia-flutter-autoroll@skia.org Roll Skia from 80f2cd706443 to 15641c0df7e8 (1 revision) (flutter/engine#54919 )
2024-09-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uDdFN_cZC6F9BVTzz... to ksNJVM5ZoBB74rba_... (flutter/engine#54918 )
2024-09-01 skia-flutter-autoroll@skia.org Roll Skia from 5477dbb533bb to 80f2cd706443 (1 revision) (flutter/engine#54916 )
2024-09-01 skia-flutter-autoroll@skia.org Roll Skia from 95ef9caae482 to 5477dbb533bb (1 revision) (flutter/engine#54915 )
2024-08-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from JKPo9G1NaAdstrimW... to uDdFN_cZC6F9BVTzz... (flutter/engine#54914 )
2024-08-31 jonahwilliams@google.com [Impeller] separate algorithm for computing render target size. (flutter/engine#54604 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from JKPo9G1NaAds to BaO2fyTu4jhv
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-03 19:14:06 +00:00
John McDole
6035698acb
Really make the seed stable to YYYY-MM-DD ( #154568 )
...
`hashCode` is stable for the same inputs of `DateTime`; those inputs should be to the day only (oops).
2024-09-03 19:10:18 +00:00
Christopher Fujino
28a9124304
Add Android SDK to Linux packages_autoroller ( #154462 )
...
Fixes https://github.com/flutter/flutter/issues/154151
This target now requires the Android toolchain because it may
re-generate gradle lockfiles.
2024-09-03 11:23:49 -07:00
Darniel Rumple
7b71d9f493
Fix typing error in AutofillGroup docs ( #154405 )
...
Fixes a small typing error in the AutofillGroup docs
2024-09-03 18:22:00 +00:00
Nate Wilson
c2a2b13e0c
Refactor CircularNotchedRectangle.getOuterPath() ( #154036 )
...
This PR makes a notched rectangle method a bit more readable.
- The circular notched rectangle's `getOuterPath()` method no longer
uses any null-asserts.
- It also used to have 2 variables (`r` and `notchRadius`) that held the
same value, but that's no longer the case.
2024-09-03 12:17:00 -06:00
Shreyans Pathak
6f19403eb6
Replace ListTile usage with CupertinoListTile ( #154473 )
...
This PR replaces the `ListTile` usage in the cupertino switch example with `CupertinoListTile`.
Fixes #154450
2024-09-03 18:14:53 +00:00
engine-flutter-autoroll
7abeeb196b
Roll Flutter Engine from 2d56e448887f to a3504c2f347d (1 revision) ( #154464 )
...
2d56e44888...a3504c2f34skia-flutter-autoroll@skia.org Roll Skia from 9d0039785ebd to
95ef9caae482 (1 revision) (flutter/engine#54911 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-03 10:24:27 -07:00
gaaclarke
d1385a4827
Adds wide gamut framework test ( #153319 )
...
issue: https://github.com/flutter/flutter/issues/127855
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-03 09:41:30 -07:00
Phil Quitslund
29af4a174c
sort part directives ( #154456 )
...
A pending change to the `directives_ordering` lint will enforce part
sorting.
See: https://github.com/dart-lang/linter/issues/4945
And `flutter-analyze` failure:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8738142237425031297/+/u/analyze_flutter_flutter/stdout
Related to change: https://dart-review.googlesource.com/c/sdk/+/383023
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-03 09:21:37 -07:00
Konstantin Scheglov
74a31399e1
Remove unnecessary imports. ( #154527 )
...
With https://dart-review.googlesource.com/c/sdk/+/382901 we will start checking it differently, and find more unnecessary imports.
2024-09-03 16:14:44 +00:00
engine-flutter-autoroll
700ce065ea
Roll Packages from c9c000430163 to 848d7e915e21 (3 revisions) ( #154510 )
...
c9c0004301...848d7e915emhvdijk@gmail.com [flutter_adaptive_scaffold] Compare breakpoints (flutter/packages#7531 )
2024-08-30 tarrinneal@gmail.com [pigeon] adds support for collections of enums and classes (flutter/packages#7476 )
2024-08-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes bug where ad can replay during content playback (flutter/packages#7537 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-03 16:11:02 +00:00
John McDole
95c3292623
Improve microbenchmarks a smidge ( #154461 )
...
1. Allow for selective benchmarks to run locally (see README.md)
2. Shuffle the tests; the seed being rotated daily or specified (see
README.md)
2024-09-03 09:10:13 -07:00
Daco Harkes
6a47cdb6b5
[native assets] Roll dependencies ( #154507 )
...
Roll the dependencies from dart-lang/native.
2024-09-03 16:07:08 +00:00
Zachary Anderson
164ff46f7c
Revert "improve trace logging in packages autoroller" ( #154555 )
...
Reverts flutter/flutter#154441
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20packages_autoroller/11826/overview
I can't see how this change would be causing the specific failure on the
tree, but the failure is consistent after this commit, so speculatively
reverting.
The revert label isn't working since we're out of the window, so this is
a manual revert.
2024-09-03 08:59:11 -07:00
engine-flutter-autoroll
6fe09872b1
Roll Flutter Engine from 4f1de98aa0c8 to 2d56e448887f (1 revision) ( #154459 )
...
4f1de98aa0...2d56e44888yjbanov@google.com [web:canvaskit] switch to temporary SkPaint objects (flutter/engine#54818 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 23:53:11 +00:00
Christopher Fujino
54c886b716
improve trace logging in packages autoroller ( #154441 )
...
Add debugging to diagnose:
https://github.com/flutter/flutter/issues/154151
2024-08-30 16:26:14 -07:00
engine-flutter-autoroll
881f86943c
Roll Flutter Engine from eff1b76cf297 to 4f1de98aa0c8 (4 revisions) ( #154451 )
...
eff1b76cf2...4f1de98aa0skia-flutter-autoroll@skia.org Roll Skia from 0182585d38dd to 9d0039785ebd (4 revisions) (flutter/engine#54910 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Skia from 2727e4e5d7ec to 0182585d38dd (1 revision) (flutter/engine#54908 )
2024-08-30 30870216+gaaclarke@users.noreply.github.com Reland: Hooks up framework wide gamut to engine wide gamut (flutter/engine#54906 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ohUS2y1HixZYziUtX... to JKPo9G1NaAdstrimW... (flutter/engine#54907 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ohUS2y1HixZY to JKPo9G1NaAds
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 22:21:33 +00:00
Yegor
9502cb1576
increase Linux build_test shard count from 3 to 5 ( #154444 )
...
Fixes https://github.com/flutter/flutter/issues/154443
2024-08-30 15:05:55 -07:00
John McDole
7aace1c5f9
Run all microbenchmarks (part trois) ( #154446 )
...
**Three things**
Re-lands #154374
New: fix `platform_channels_benchmarks` to print the "done" key. Updated notes for the microbenchmark parser. There are no other users of `microbenchmarks.readJsonResults`.
Re-Re-land: Uninstall microbenchmarks before running them.
Flakes in https://github.com/flutter/flutter/issues/153828 stem from adb saying the app isn't installed, but then failing to install wtih -r. Several other tests uninstall the app before trying to run it. Previous fix called uninstall between tests, but iOS takes 12 to 13 seconds to perform uninstall / install, which timed out the test. Just uninstall the one time since we only care about any lingering apps with different keys.
Potential solution https://github.com/flutter/flutter/issues/153828
Re-land Make things go fast
Instead of installing 21 different compilations of the same app to get results; compile and run them together. Locally on Mac+iOS, this should takes ~3 minutes instead of ~15 minutes.
2024-08-30 20:55:16 +00:00
engine-flutter-autoroll
8c1a93508b
Roll Flutter Engine from 94487cc5765b to eff1b76cf297 (2 revisions) ( #154435 )
...
94487cc576...eff1b76cf230870216+gaaclarke@users.noreply.github.com Reland: Framework wide color (#54415 ) (#54737 ) (flutter/engine#54905 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Skia from f3811180e7df to 2727e4e5d7ec (3 revisions) (flutter/engine#54904 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 20:17:12 +00:00
auto-submit[bot]
8c264775bf
Reverts "Run all microbenchmarks ( #154374 )" ( #154440 )
...
Reverts: flutter/flutter#154374
Initiated by: jtmcdole
Reason for reverting: A different benchmark was using the microbenchmark parser and timing out.
Original PR Author: jtmcdole
Reviewed By: {zanderso}
This change reverts the following previous change:
Two things:
**Re-land**: Uninstall microbenchmarks before running them.
Flakes in #153828 stem from adb saying the app isn't installed, but then failing to install wtih `-r`. Several other tests uninstall the app before trying to run it. Previous fix called uninstall between tests, but iOS takes 12 to 13 seconds to perform uninstall / install, which timed out the test. Just uninstall the one time since we only care about any lingering apps with different keys.
Potential solution #153828
**Make things go fast**
Instead of installing 21 different compilations of the same app to get results; compile and run them together. Locally on Mac+iOS, this should takes ~3 minutes instead of ~15 minutes.
2024-08-30 19:44:19 +00:00
Dimil Kalathiya
620d1ea729
Expose long press in ``CupertinoButton`` ( #154052 )
...
Adds long press as per https://github.com/flutter/flutter/issues/153956 request
Fixes #153956
2024-08-30 18:56:00 +00:00
John McDole
9fc160b11c
Run all microbenchmarks ( #154374 )
...
Two things:
**Re-land**: Uninstall microbenchmarks before running them.
Flakes in #153828 stem from adb saying the app isn't installed, but then failing to install wtih `-r`. Several other tests uninstall the app before trying to run it. Previous fix called uninstall between tests, but iOS takes 12 to 13 seconds to perform uninstall / install, which timed out the test. Just uninstall the one time since we only care about any lingering apps with different keys.
Potential solution #153828
**Make things go fast**
Instead of installing 21 different compilations of the same app to get results; compile and run them together. Locally on Mac+iOS, this should takes ~3 minutes instead of ~15 minutes.
2024-08-30 18:22:06 +00:00
hangyu
0d8247eb7d
Add a RegExp for iOS domain when reading domains from xcodeProject ( #154201 )
...
Append the string `?mode=<alternate mode>` to the associated domain to
enable alternate mode in some use cases is recommended in apple
developer guide
(https://developer.apple.com/documentation/xcode/configuring-an-associated-domain#Enable-alternate-mode-for-unreachable-servers )
So when reading these domains from xcode settings, we should consider
this case and trim it.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-08-30 11:17:29 -07:00
Dishank Jindal
01e8ecaea6
Added support for elevation on refresh indicator ( #154182 )
...
Refresh Indicator Elevation:
- Added elevation to the refresh indicator using elevation attribute.
- This change improves the indicator's visibility against various background colors and enhances overall UI consistency.
- If we want to get rid of shadow effect from the indicator itself.
The refresh indicator did not provide the control over depth of the progress indicator. This change addresses that issue by adding elevation to the indicator, creating a subtle depth effect that makes it more visually prominent and provides better feedback to the user.
No breaking changes.
| Before | After |
| --- | --- |
|  |  |
Pre-launch Checklist
2024-08-30 17:50:08 +00:00
engine-flutter-autoroll
e48a45ff5e
Roll Flutter Engine from c851c58019e9 to 94487cc5765b (2 revisions) ( #154427 )
...
c851c58019...94487cc576skia-flutter-autoroll@skia.org Roll Skia from 2b633f7626ea to f3811180e7df (2 revisions) (flutter/engine#54900 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from DtxLvjJOVzo_oZGui... to p5MYp7o9Tt0sossYJ... (flutter/engine#54899 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 17:15:21 +00:00
Justin McCandless
995a1da104
Android predictive back should work after returning to the app from a notification ( #154313 )
...
Fixes a bug where the app would exit on a back gesture when there were still routes in the navigation stack after returning to the app from a notification.
2024-08-30 09:36:10 -07:00
