Commit Graph

25462 Commits

Author SHA1 Message Date
Swiftaxe
2f46d36bf4 Fixed leak and removed no-shuffle tag in test/gestures/tap_test.dart (#88342) 2021-08-17 10:07:05 -07:00
engine-flutter-autoroll
1079136fde c52ae9fdf [flutter_plugin_tool] Don't allow NEXT on version bumps (flutter/plugins#4246) (#88360) 2021-08-17 09:42:05 -07:00
Todd Volkert
a2e33dec7c l10n updates for August beta (#88328) 2021-08-16 22:51:16 -07:00
Jonah Williams
060e4608b1 clean up stale or unnecessary TODOS (#88308) 2021-08-16 21:37:03 -07:00
Emmanuel Garcia
d39d542691 Revert "Reland: Bump to Gradle 7 and use Open JDK 11 (#88319)" (#88326)
This reverts commit b586695c82.
2021-08-16 20:38:32 -07:00
Emmanuel Garcia
b586695c82 Reland: Bump to Gradle 7 and use Open JDK 11 (#88319)
* Bump to Gradle 7 and use Open JDK 11

* Add caches

* Fixes

* Remove org.gradle.java.home
2021-08-16 18:40:39 -07:00
engine-flutter-autoroll
a7e831855d 954041d5b Add unit tests to quick_actions plugin (flutter/plugins#4245) (#88317) 2021-08-16 17:32:05 -07:00
Christopher Fujino
1f1065d5f8 [flutter_conductor] fix pushing local working branch to mirror remote (#88057) 2021-08-16 16:44:32 -07:00
Dan Field
c91a298249 Take DPR into account for image inversion (#88309) 2021-08-16 15:35:10 -07:00
Gary Qian
a562b3cb3d Deferred components integration test app (#88030) 2021-08-16 15:32:05 -07:00
Dan Field
a4f5a5871a Avoid retaining routes when subscriptions are cleared (#88310) 2021-08-16 14:47:03 -07:00
Jason Simmons
ddb8bfb72b Fix URL construction in the test entry point generated by the web bootstrap script (#88201) 2021-08-16 14:12:05 -07:00
Kate Lovett
e761e64983 Add theme support for choosing android overscroll indicator (#88295) 2021-08-16 13:42:02 -07:00
engine-flutter-autoroll
51353b5a0a Roll Engine from 9d33093d6b6a to 7dc8eba6aeaa (4 revisions) (#88307) 2021-08-16 13:37:02 -07:00
xubaolin
a4b724d944 fix a scrollbar updating bug (#88152) 2021-08-16 12:17:02 -07:00
LongCatIsLooong
c49eba6c3f [TextInput] minor fixes (#87973) 2021-08-16 12:12:04 -07:00
Kaushik Iska
af4faf48dd Microtasks Animations isn't flaky (#88297) 2021-08-16 12:09:35 -07:00
engine-flutter-autoroll
3216e9f169 Roll Engine from 1af0a207932d to 9d33093d6b6a (8 revisions) (#88292) 2021-08-16 10:42:04 -07:00
YeungKC
a40c5c29e6 Migration text selection manipulation. (#86986)
Consolidate duplicated cut/copy/paste/selectall code so it can be done via Actions in the future.
2021-08-16 10:38:49 -07:00
Flutter GitHub Bot
4d4f3372b6 Marks Linux test_ownership to be unflaky (#88282) 2021-08-16 10:32:04 -07:00
Jenn Magder
57efbd5310 Rename IOSDeviceInterface to IOSDeviceConnectionInterface (#88144) 2021-08-16 10:27:03 -07:00
Tong Mu
31d0787d20 Revert "Revert "Revert "Restores surface size in the postTest of test binding (#87240)" (#87258)" (#87297)" (#88293)
This reverts commit 91f8b6be51.
2021-08-16 09:38:25 -07:00
Swiftaxe
e7f9bcba2d Removed no-shuffle tag and fixed leak in debug_test.dart (#88268)
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se>

The TapGestureRecognizer in the test named 'TapGestureRecognizer _sentTapDown toString' was not disposed, which was breaking a couple of other tests.
This worked fine when not shuffling the tests as the test was executed last.
2021-08-16 09:29:19 -07:00
Swiftaxe
fe337dcaf5 Animation controller test (#88251)
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se>

Fixes test/animation/animation_controller_test.dart in #85160

Problem:
The test 'animateTo can deal with duration == Duration.Zero' was failing with the following error:

Expected: <0>
Actual: <5>
Expected no animation.
package:test_api expect
package:flutter_test/src/widget_tester.dart 484:3 expect
test/animation/animation_controller_test.dart 511:5 main.

Following line finds 5 transientCallbacks scheduled, while expecting zero, if shuffled with seed 123:

expect(SchedulerBinding.instance!.transientCallbackCount, equals(0), reason: 'Expected no animation.');

This is caused by some other test leaving transientCallbacks scheduled.

Fix:
By disposing the AnimationController after each test, the transientCallbacks get cleaned up.
I chose to dispose all controllers in every test, to make sure there is no risk of leaks.
2021-08-16 09:28:11 -07:00
engine-flutter-autoroll
06be7e5392 99c5f6139 Move test packages from dependencies to dev_dependencies (flutter/plugins#4231) (#88244) 2021-08-15 11:37:02 -07:00
Pierre-Louis
85ffa8ce18 [Fonts] Improved icons update script (#88153)
* Improved update_icons.dart

* Handle _

* Update dartdoc

* Rename function

* formatting

* fix type

* Refactor ID generation

* rename

* cleanup

* update comment

* replace typedef with type
2021-08-15 12:56:58 +02:00
engine-flutter-autoroll
338ade81da Roll Engine from a447901bc58b to 1af0a207932d (4 revisions) (#88216)
* c388bfab7 Roll Skia from 1049d8206120 to abe39f5cb932 (6 revisions) (flutter/engine#28090)

* 5ba9ed516 [web] Clean up legacy Paragraph implementation (flutter/engine#28050)

* b1ccc4175 Revert "Sets focus before sending a11y focus event in Android (#27992)" (flutter/engine#28092)

* 1af0a2079 Roll Fuchsia Linux SDK from WoiEzs7XB... to 54i7Z2kLS... (flutter/engine#28093)
2021-08-14 12:50:50 -07:00
engine-flutter-autoroll
1422bfa723 Roll Engine from b3248764e4dd to a447901bc58b (30 revisions) (#88213) 2021-08-14 01:02:06 -07:00
engine-flutter-autoroll
eb1d1ceb95 Roll Plugins from c8570fc681d8 to 3ae3a027e40d (3 revisions) (#88203) 2021-08-13 20:42:02 -07:00
Zachary Anderson
195e7de0d2 Revert "Roll Engine from b3248764e4dd to 6227940c3a06 (17 revisions) (#88186)" (#88204)
This reverts commit bfe47591fa.
2021-08-13 19:44:55 -07:00
engine-flutter-autoroll
949f4f0bb0 Roll Plugins from 60100908443f to c8570fc681d8 (17 revisions) (#88195) 2021-08-13 17:27:04 -07:00
engine-flutter-autoroll
bfe47591fa Roll Engine from b3248764e4dd to 6227940c3a06 (17 revisions) (#88186) 2021-08-13 17:22:06 -07:00
LongCatIsLooong
b3d12ebd77 Revert "[EditableText] call onSelectionChanged only when there're actual selection/cause changes (#87971)" (#88183) 2021-08-13 17:17:04 -07:00
yusufm
72a1e65a0e Adding vs_build dependency to Windows hot_mode_dev_cycle_win_target__benchmark (#88196)
* Adding a timeout and retry to upload results step.

* Adding tests for retries and timeout.

* Adding async to call

* Fixing sleep to trigger the timeout, and adding addition timeout test.

* Fixing minor typo.

* Fixing some minor flutter style issues.

* Adding vs_build dependency to Windows hot_mode_dev_cycle_win_target__benchmark

Co-authored-by: yusufm <mohsinally@google.com>
2021-08-13 17:14:29 -07:00
Zachary Anderson
c5d5463c30 [flutter_tools] Fix hang in DesktopLogReader (#88178) 2021-08-13 17:12:04 -07:00
Jenn Magder
325cfb0f4c Make doctor Xcode version requirement clearer (#88137) 2021-08-13 17:07:03 -07:00
Abhishek Ghaskata
10aad08a34 add ? (#88019) 2021-08-13 17:02:09 -07:00
Michael Goderbauer
79ff8a5cb6 Revert "Bump to Gradle 7 and use Open JDK 11 (#88133)" (#88189)
This reverts commit 91e0759b72.
2021-08-13 12:42:58 -07:00
Emmanuel Garcia
91e0759b72 Bump to Gradle 7 and use Open JDK 11 (#88133) 2021-08-13 11:12:05 -07:00
engine-flutter-autoroll
85297c07c1 b3248764e Roll Skia from ec07af1279ec to 1fc789943486 (8 revisions) (flutter/engine#28048) (#88132) 2021-08-13 11:07:05 -07:00
zuvola
93d69544a1 Fix AnimatedCrossFade would focus on a hidden widget (#87618)
Moving the focus with the tab key on the external keyboard will move the focus to the widget that is hidden by AnimatedCrossFade.
2021-08-13 08:49:43 -07:00
嘟囔
bf3ff7ec71 feat: migrate fuchsia/application_package.dart to null-safe (#88095) 2021-08-13 00:22:07 -07:00
Justin McCandless
4bd8b288bb ScaleUpDetails focalPointDelta (#85718)
Corrects the exact definition in code and docs of ScaleUpDetails delta.
2021-08-12 18:02:02 -07:00
Greg Spencer
2a42069b2a Bump snippets to 0.2.3, fix redundant global activate in docs.sh (#88123) 2021-08-12 17:37:05 -07:00
chunhtai
b860982938 remove _AbortingSemanticsFragment (#88067) 2021-08-12 17:32:03 -07:00
LongCatIsLooong
6e224ee0e6 [EditableText] call onSelectionChanged only when there're actual selection/cause changes (#87971) 2021-08-12 17:27:03 -07:00
Michael Goderbauer
fbc4e9bcc5 Revert "Update MaterialScrollBehavior.buildScrollbar for horizontal axes (#87740)" (#88129) 2021-08-12 16:12:06 -07:00
keyonghan
5b5eaf0ea1 add platform tags (#88117) 2021-08-12 16:02:03 -07:00
Anurag Roy
758c28b813 [flutter_tools] Reland "Make upgrade only work with standard remotes" (#87731) 2021-08-12 15:52:07 -07:00
Ian Hickson
7bedd0f122 Fix incorrect logging. (#88042) 2021-08-12 15:32:06 -07:00