skia-flutter-autoroll
2db17d72bc
Roll Dart SDK from d2b2ac829842 to dbbb8a6d79a3 (3 revisions) ( flutter/engine#42082 )
...
https://dart.googlesource.com/sdk.git/+log/d2b2ac829842..dbbb8a6d79a3
2023-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-116.0.dev
2023-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-115.0.dev
2023-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-114.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 23:27:23 +00:00
Brandon DeRosier
88c5ed3106
[Impeller] Use 32 bit Gaussian function in the 2-pass blur ( flutter/engine#42069 )
...
Resolves https://github.com/flutter/flutter/issues/126487 .
Increases the 2-pass blur quality and distribution limit.
It turns out sigma was breaking down beyond ~255 (moderately high, but
not unreasonable for users to rely on). The Gaussian function computes
sigma^2, and half precision floats only have 5 bit exponents and
overflow for numbers above 65k.
Coincidentally, this also returns us to a state where we look a lot more
like Skia's blurs for larger blur sigmas. Medium blurs have much less
visual banding (although it's still there if you look closely). I
suspect half precision isn't really enough for tracking the integral.
Unfortunately, this means our SIMD pipelining isn't going to be as good.
I'll be interested in watching the blur-driven benchmarks for the perf
hit.
2023-05-16 15:56:03 -07:00
skia-flutter-autoroll
ec7495484c
Roll Skia from 9b0e912a1cb9 to 88d7a68694d9 (13 revisions) ( flutter/engine#42081 )
...
https://skia.googlesource.com/skia.git/+log/9b0e912a1cb9..88d7a68694d9
2023-05-16 brianosman@google.com Revert "Reland "Add third_party/cityhash""
2023-05-16 johnstiles@google.com Switch parameter list from vector<> to TArray and SkSpan.
2023-05-16 brianosman@google.com Move ProxyHash implementation to cpp
2023-05-16 sunnyps@chromium.org graphite: Implement drawSlug
2023-05-16 johnstiles@google.com Remove unused DSLExpression ctors.
2023-05-16 penghuang@chromium.org Fix link errors in component build
2023-05-16 brianosman@google.com Reland "Add third_party/cityhash"
2023-05-16 brianosman@google.com Remove SkDrawable::newPictureSnapshot entirely
2023-05-16 johnstiles@google.com Reduce usage of ThreadContext when easy alternatives exist.
2023-05-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f3e8446466d8 to 32a999c86b9c (2 revisions)
2023-05-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e0fb1f506c8b to c9c8d1cba3dc
2023-05-16 kjlubick@google.com Add include to fix client
2023-05-16 johnstiles@google.com Remove DSLCore handling of Interface Blocks.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 22:49:07 +00:00
Jackson Gardner
9d87a21795
Use client ICU data with skwasm. ( flutter/engine#42018 )
...
This implements https://github.com/flutter/flutter/issues/126340
For now, I am keeping this implementation simple without any extra caching. I may add caching later based on profiling results.
2023-05-16 22:07:16 +00:00
Zachary Anderson
df51526b1d
Revert "[ios_platform_view] only recycle maskView when the view is applying mutators" ( flutter/engine#42080 )
...
Reverts flutter/engine#41573
Crashing on Framework CI
2023-05-16 14:32:18 -07:00
Greg Spencer
f4ac622197
[macOS] Wait for binding to be ready before requesting exits from framework ( flutter/engine#41753 )
...
Similar to https://github.com/flutter/engine/pull/41733 and
https://github.com/flutter/engine/pull/41782 , this causes the macos
embedding to wait until it hears that the scheduler binding has
registered itself before proceeding to send termination requests to the
framework.
This allows applications that don't use the framework (just use
`dart:ui` directly) to exit automatically when the last window is
closed. Without this change, the last window closes, but the app does
not exit.
Depends on framework PR https://github.com/flutter/flutter/pull/126075
landing first.
2023-05-16 14:29:32 -07:00
Greg Spencer
4eebfb2246
[linux] Wait for binding to be ready before requesting exits from framework ( flutter/engine#41782 )
...
## Description
Similar to https://github.com/flutter/engine/pull/41733 and https://github.com/flutter/engine/pull/41753 this causes the linux embedding to wait until it hears that the scheduler binding has registered itself before proceeding to send termination requests to the framework.
This allows applications that don't use the framework (just use `dart:ui` directly) to exit automatically when the last window is closed. Without this change, the app does not exit when the window is closed.
Depends on framework PR https://github.com/flutter/flutter/pull/126075 landing first.
## Related PRs
- https://github.com/flutter/engine/pull/41733
- https://github.com/flutter/engine/pull/41753
## Related Issues
- https://github.com/flutter/flutter/issues/126033 .
## Tests
- Added a test to make sure that it doesn't send a termination request if the binding hasn't notified that it is ready yet.
2023-05-16 20:34:05 +00:00
Jackson Gardner
d159d6cfc8
Initial support for images in Skwasm ( flutter/engine#42019 )
...
This partially implements https://github.com/flutter/flutter/issues/126341
It does not implement image codecs, because they are going to get complicated with transferring video frames to the web worker and so on. I am going to deal with image codecs in a subsequent change.
2023-05-16 18:35:17 +00:00
Jackson Gardner
148b626638
Use new unresolvedCodePoints API from skia. ( flutter/engine#41991 )
...
NOTE: this works off of a skia CL that is not merged yet, so we shouldn't merge this until it actually lands in skia and rolls into the engine. See https://skia-review.googlesource.com/c/skia/+/695716
2023-05-16 18:33:12 +00:00
Jason Simmons
6d1e5ca312
Convert public API NativeFieldWrapper classes to abstract interfaces ( flutter/engine#41945 )
...
See https://github.com/flutter/flutter/issues/123756
2023-05-16 18:13:07 +00:00
Loïc Sharma
ac25948dcc
[Windows] Add force redraw to the C++ client wrapper ( flutter/engine#42061 )
...
This change adds a C++ client wrapper to Windows's "force redraw" C API. This API can be used to schedule a frame.
Part of https://github.com/flutter/flutter/issues/119415
## Background
The Windows runner has a race at startup:
1. **Platform thread**: creates a hidden window
2. **Platform thread**: launches the Flutter engine
3. **UI/Raster threads**: renders the first frame
4. **Platform thread**: Registers a callback to show the window once the next frame has been rendered.
Steps 3 and 4 happen in parallel and it is possible for step 3 to complete before step 4 starts. In this scenario, the next frame callback is never called and the window is never shown.
The Windows runner will be updated to call the "force redraw" API after it registers the next frame callback. If step 3 hasn't completed yet, the "force redraw" will no-op as a frame is already scheduled. If step 3 has already completed, the "force redraw" will schedule another frame, which will call the next frame callback and show the window.
See this discussion below on why we cannot avoid changing the Windows runner to fix this issue: https://github.com/flutter/engine/pull/42061#issuecomment-1550080722
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-16 18:07:15 +00:00
godofredoc
61d8ffe27c
Fix drone_dimension host_engine_builder. ( flutter/engine#42068 )
...
The host engine was using a top level dimension instead of a drone dimension and was causing the dart-internal build to fail.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-16 17:12:12 +00:00
godofredoc
530243affb
Add linux_clang_tidy builder. ( flutter/engine#41990 )
...
This builder run android and host clang tidy in an engine v2 build.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-16 16:37:36 +00:00
Chris Yang
259217c7aa
[ios_platform_view] only recycle maskView when the view is applying mutators ( flutter/engine#41573 )
...
A mistake was introduced in https://github.com/flutter/engine/pull/39498 where the maskViews are already recycles each frame.
Sometimes a PlatformView does not need to be re-composite: (https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm#L398-L401 ), so the mask view for such PlatformView should not be recycled.
This PR changed the `recycleMaskViews` API to allow individual maskviews to be recycled. `ApplyMutator` then only recycle the maskView for that particular PlatformView.
The MaskViewPool is also reworked to be simpler.
- The pool now contains a single set of mask views, there is no index counter needed.
- When a maskView is needed, try to get it from the pool.
- If pool is empty, create a new view.
- If pool has an available maskview, remove it from the pool.
- When a PlatformView starts to `applyMutator`, it removes current the maskView, insert the maskView to the pool.
- When the above PlatformView needs to a maskView, it grabs one from the pool.
fixes: https://github.com/flutter/flutter/issues/125620
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-16 16:24:05 +00:00
skia-flutter-autoroll
2752fe57eb
Roll Skia from 24bebce2d9a1 to 9b0e912a1cb9 (12 revisions) ( flutter/engine#42072 )
...
https://skia.googlesource.com/skia.git/+log/24bebce2d9a1..9b0e912a1cb9
2023-05-16 michaelludwig@google.com Turn on flushBeforeWritePixels for PowerVR B-Series on ANGLE
2023-05-16 johnstiles@google.com Revert "Add third_party/cityhash"
2023-05-16 johnstiles@google.com Revert "[bazel] Android build: Remove hard dependency on a GPU backend."
2023-05-16 lovisolo@google.com Revert "[bazel] Android build: Add missing Android-specific GPU dependency."
2023-05-16 johnstiles@google.com Revert "[g3] Fix broken build."
2023-05-16 michaelludwig@google.com Match legacy start index for directly drawn dashed RRects
2023-05-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 9e876585de8c to 6140cf9c51a5 (2 revisions)
2023-05-16 brianosman@google.com Add third_party/cityhash
2023-05-16 kjlubick@google.com Remove one more legacy SkSurface factory
2023-05-15 lovisolo@google.com [g3] Fix broken build.
2023-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from eca6699311e8 to 9e876585de8c (1 revision)
2023-05-15 drott@chromium.org Implement font name calls for Fontations-backed typeface
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 15:00:17 +00:00
skia-flutter-autoroll
d67e595f1e
Roll Fuchsia Linux SDK from 38Oyy28qgYCdt7fEV... to D_EOM3rJ8AMk3-Wex... ( flutter/engine#42071 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 14:58:24 +00:00
skia-flutter-autoroll
9b8245910f
Roll Fuchsia Mac SDK from JCoP2Fekj3MBIqskE... to N4LwCRxg0oIevhQ_O... ( flutter/engine#42070 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 13:32:28 +00:00
ColdPaleLight
b2846ca26e
[Impeller] Fix issue about saveLayer ignoring opacity of paint with advanced blend mode ( flutter/engine#41972 )
...
fix https://github.com/flutter/flutter/issues/126532
without patch
with patch
2023-05-16 08:05:16 +00:00
Chris Yang
9640e89255
[ios_platform_view] Only remove platform views from flutter view in reset. ( flutter/engine#41709 )
...
Add a class type check during reset when removing the PlatformViews.
Fixes: https://github.com/flutter/flutter/issues/125999
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-16 04:21:04 +00:00
godofredoc
1befe22a0a
Add drone_dimensions as top level target property. ( flutter/engine#42064 )
...
This is to make the configs easier to use for builders running from a drone.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-16 03:13:23 +00:00
Chris Yang
e82760c0ff
Fix upload xcresult script in run_tests.py ( flutter/engine#42056 )
...
The original PR https://github.com/flutter/engine/pull/41647 forgot to add try-except-raise
fixes https://github.com/flutter/flutter/issues/125823
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-15 23:11:04 +00:00
Jonah Williams
5cbbce3e7e
[Impeller] set stencil attachment descriptor for runtime effect. ( flutter/engine#42054 )
...
This fixes the correctness issues observed in https://github.com/flutter/flutter/issues/126701 . The missing stencil descriptor meant that the clips were always ignored.
Have not yet investigated the reported debug performance issues.
2023-05-15 23:04:05 +00:00
skia-flutter-autoroll
27b261266a
Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) ( flutter/engine#42058 )
...
https://skia.googlesource.com/skia.git/+log/4becb53e3c21..24bebce2d9a1
2023-05-15 johnstiles@google.com Remove arrayification support from Variable::Convert.
2023-05-15 jamesgk@google.com [graphite] Use dual-src blending when available
2023-05-15 michaelludwig@google.com Remove legacy bounds layer staging code
2023-05-15 michaelludwig@google.com [skif] Skip saving a layer for image filters that don't use source image
2023-05-15 johnstiles@google.com Simplify logic in DSLWriter::Var.
2023-05-15 johnstiles@google.com Replace dsl::Struct with StructDefinition::Convert.
2023-05-15 johnstiles@google.com Reduce DSLModifiers to a simple struct.
2023-05-15 johnstiles@google.com Remove swap and assign from DSLExpression.
2023-05-15 johnstiles@google.com Move struct error checks into MakeStructType.
2023-05-15 johnstiles@google.com Remove DSLLayout type.
2023-05-15 jlavrova@google.com Return an unordered_set of unresolved codepoints
2023-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a356ab97987 to f3e8446466d8 (1 revision)
2023-05-15 lovisolo@google.com [bazel] Android build: Add missing Android-specific GPU dependency.
2023-05-15 robertphillips@google.com Add Protected tracking to Ganesh's OpenGL backend
2023-05-15 kjlubick@google.com Fix legacy SkSurface::MakeNull call
2023-05-15 lovisolo@google.com [bazel] Android build: Remove hard dependency on a GPU backend.
2023-05-15 johnstiles@google.com Remove unused DSLExpression ctors.
2023-05-15 johnstiles@google.com Reland "Enable OutParamsFunctionCallInArgument test on GPU."
2023-05-15 johnstiles@google.com Eliminate DSLType::StructType.
2023-05-15 kjlubick@google.com Enforce IWYU on src/core/SkB*
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com ,johnstiles@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 22:28:57 +00:00
skia-flutter-autoroll
177c8441ff
Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... ( flutter/engine#42057 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 22:24:57 +00:00
Brandon DeRosier
f1806da5b1
[Impeller] Remove debug print statement from EntityPass ( flutter/engine#42055 )
...
Oopsies.
2023-05-15 21:40:18 +00:00
Jackson Gardner
4daa0909c2
Compile skwasm at -Oz. ( flutter/engine#42002 )
...
We want to start from a place of small size, and optimize from there with skwasm. Since there is no baseline expectation of performance at `-O3`, let's start with the smallest possible binary.
2023-05-15 19:59:14 +00:00
godofredoc
3f21c6d213
Use release_build and os dimension consistently. ( flutter/engine#42012 )
...
Release_build property is used to signal that this build produces release artifacts that will eventually be SLSA compliant and will need to run from dart_internal.
The os property is used to select the correct drone based on the platform the build should run on.
Bug: https://github.com/flutter/flutter/issues/126118
Bug: https://github.com/flutter/flutter/issues/125983
Bug: https://github.com/flutter/flutter/issues/126116
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-15 19:57:00 +00:00
Brandon DeRosier
b9521559b7
[Impeller] Add interactive DrawPaint blend test ( flutter/engine#42031 )
...
Made this to help debugging clear color problems and I've had it sitting
around in my stage for a few days. Today, it ended up leading me to
discover several other issues.
2023-05-15 12:48:12 -07:00
Brandon DeRosier
7c0bad1009
[Impeller] Limit subpass textures and backdrop blurs to the current clip ( flutter/engine#42039 )
...
Part of https://github.com/flutter/flutter/issues/126696 .
* Generalize the FilterContents coverage hint as a Contents property.
* Incorporates the stencil coverage when creating subpass textures.
* Set a coverage hint for backdrop filters.
* Incorporate the coverage hint in the 2-pass Gaussian blur.
2023-05-15 12:18:08 -07:00
skia-flutter-autoroll
06b709ff52
Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) ( flutter/engine#42051 )
...
https://dart.googlesource.com/sdk.git/+log/c302a0252785..d2b2ac829842
2023-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-113.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 19:09:22 +00:00
Chris Yang
8d07db38c5
Upload xcresults to LUCI cloud storage ( flutter/engine#41647 )
...
Taking over from https://github.com/flutter/engine/pull/41644
fixes: https://github.com/flutter/flutter/issues/125823
Steps to verify
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-15 19:05:10 +00:00
gaaclarke
7d5f571373
Include SkRect in rtree. ( flutter/engine#42050 )
...
fixes https://github.com/flutter/flutter/issues/126864
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-15 18:55:11 +00:00
gaaclarke
47b14888c5
[Impeller] switches the wide gamut surface to f16 ( flutter/engine#41994 )
...
**requires https://github.com/flutter/flutter/pull/126712 to land
first**
fixes https://github.com/flutter/flutter/issues/126620
integration test at: https://github.com/flutter/flutter/pull/126715
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-15 10:25:43 -07:00
Kevin Lubick
0946d27add
Migrate uses of SkSurface factories ( flutter/engine#41978 )
...
In http://review.skia.org/687639 , many SkSurface static methods were moved and one was deleted (SkSurface::MakeRasterN32Premul). (SkSurface::MakeNull was omitted accidentally and http://review.skia.org/696537glesource.com/c/skia/+/696537 has not rolled into Flutter yet)
This changes the calls in Flutter to match those moved functions. There should be no functional difference and everything was done pretty mechanically (e.g. find and replace)
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-15 16:41:10 +00:00
skia-flutter-autoroll
308a224ee9
Roll Fuchsia Mac SDK from A3thcPNgxVcKzR-da... to JCoP2Fekj3MBIqskE... ( flutter/engine#42041 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 15:59:11 +00:00
skia-flutter-autoroll
817bdf2426
Roll Dart SDK from c777d54743e1 to c302a0252785 (1 revision) ( flutter/engine#42040 )
...
https://dart.googlesource.com/sdk.git/+log/c777d54743e1..c302a0252785
2023-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-112.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 15:01:07 +00:00
skia-flutter-autoroll
ea96c9f22d
Roll Dart SDK from 7d6324d5488b to c777d54743e1 (1 revision) ( flutter/engine#42038 )
...
https://dart.googlesource.com/sdk.git/+log/7d6324d5488b..c777d54743e1
2023-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-111.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 11:02:23 +00:00
Brandon DeRosier
83813f6f12
[Impeller] Fix DrawPaint advanced blends on iOS. ( flutter/engine#42032 )
...
Resolves https://github.com/flutter/flutter/issues/126790 .
Adds an optional coverage limit when taking a snapshot contents, used by
FramebufferBlendContents.
Also makes advanced blends more efficient in cases where blended object
lies partially outside the pass.
2023-05-15 03:44:59 -07:00
dependabot[bot]
322bcc2734
Bump google/mirror-branch-action from 1.0 to 2.0 ( flutter/engine#42037 )
...
Bumps [google/mirror-branch-action](https://github.com/google/mirror-branch-action ) from 1.0 to 2.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="30c52ee21f4544d8a090884625cd18d9fb13d47a4083f5d474394f8d4604https://redirect.github.com/google/mirror-branch-action/issues/3 ">#3</a>)</li>
<li><a href="5d7016e8e9https://github.com/v1 "><code>@âv1</code></a>.0 (<a href="https://redirect.github.com/google/mirror-branch-action/issues/1 ">#1</a>)</li>
<li>See full diff in <a href="c6b07e441a...30c52ee21fhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google/mirror-branch-action&package-manager=github_actions&previous-version=1.0&new-version=2.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-05-15 09:36:23 +00:00
skia-flutter-autoroll
cf74bb17c7
Roll Skia from 0c2083a60b66 to 4becb53e3c21 (2 revisions) ( flutter/engine#42036 )
...
https://skia.googlesource.com/skia.git/+log/0c2083a60b66..4becb53e3c21
2023-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from cbe6e1312c42 to a747357f3132
2023-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0d899fb75655 to cbe6e1312c42 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com ,johnstiles@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 07:23:23 +00:00
skia-flutter-autoroll
eeec4e8e08
Roll Fuchsia Linux SDK from jXrn0SP_MnSmhkz_P... to EweLgJoiYUDok2vyU... ( flutter/engine#42035 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 05:41:34 +00:00
skia-flutter-autoroll
27478f6013
Roll Skia from 0410e5d9ec03 to 0c2083a60b66 (1 revision) ( flutter/engine#42034 )
...
https://skia.googlesource.com/skia.git/+log/0410e5d9ec03..0c2083a60b66
2023-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6d50a49da6d0 to 89a3dac88297 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com ,johnstiles@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 05:33:24 +00:00
Casey Hillers
c77155e442
[Impeller] Include AndroidSurfaceVulkanImpeller behind a flag ( flutter/engine#42033 )
...
Fixes b/282290672
Google Testing currently does not support vulkan, and constructors like
this need to be behind a flag.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
2023-05-14 22:29:19 -07:00
Casey Hillers
f0c9869019
Reland "Remove GN staging flag for save layer bounds" ( flutter/engine#42029 )
...
Reverts flutter/engine#42026
After investigating, this is a bug fix for the scubas.
2023-05-15 04:34:28 +00:00
skia-flutter-autoroll
0b71b21824
Roll Fuchsia Mac SDK from qnNU5eQaox06ejpSE... to A3thcPNgxVcKzR-da... ( flutter/engine#42030 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 03:10:30 +00:00
skia-flutter-autoroll
3d03285242
Roll Dart SDK from 005648f027a3 to 7d6324d5488b (1 revision) ( flutter/engine#42027 )
...
https://dart.googlesource.com/sdk.git/+log/005648f027a3..7d6324d5488b
2023-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-110.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 18:40:49 +00:00
Casey Hillers
e331048fc7
Revert "Remove GN staging flag for save layer bounds" ( flutter/engine#42026 )
...
Reverts flutter/engine#41940
See b/282115120
This caused a golden failure on Google Testing where a rectangular avatar became circular.
2023-05-14 17:01:17 +00:00
skia-flutter-autoroll
c2634ce31d
Roll Fuchsia Linux SDK from hEJzgtSberqdXmLnk... to jXrn0SP_MnSmhkz_P... ( flutter/engine#42025 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 16:49:24 +00:00
skia-flutter-autoroll
452da0c73c
Roll Skia from 35d8ac3ced75 to 0410e5d9ec03 (1 revision) ( flutter/engine#42024 )
...
https://skia.googlesource.com/skia.git/+log/35d8ac3ced75..0410e5d9ec03
2023-05-14 brianosman@google.com Revert "Enable OutParamsFunctionCallInArgument test on GPU."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com ,johnstiles@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 14:54:31 +00:00
skia-flutter-autoroll
f4d9ef9a6e
Roll Fuchsia Mac SDK from hXcPXU_V5nVeGkEbt... to qnNU5eQaox06ejpSE... ( flutter/engine#42023 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-14 14:24:21 +00:00
