Commit Graph

42987 Commits

Author SHA1 Message Date
Reid Baker
23274284a7 Add 3.24.4 changelog to master (#157600)
https://github.com/flutter/flutter/pull/157596/files
2024-10-25 15:36:01 +00:00
Mohellebi abdessalem
7e2a06657c Update flutter.groovy to catch unknown task exception when finding api task (#157282)
see #147122 for context
and [this](https://github.com/flutter/flutter/pull/157221) for more
2024-10-25 14:51:12 +00:00
engine-flutter-autoroll
fb8d938e6e Roll Flutter Engine from c4b0184c8783 to b413d9996c86 (1 revision) (#157580)
c4b0184c87...b413d9996c

2024-10-25 skia-flutter-autoroll@skia.org Roll Skia from 53c9663c3b83 to cc75472dedc2 (10 revisions) (flutter/engine#56121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 08:24:40 +00:00
engine-flutter-autoroll
3cd12f2c06 Roll Flutter Engine from b1c2ba8c4d52 to c4b0184c8783 (1 revision) (#157578)
b1c2ba8c4d...c4b0184c87

2024-10-25 flar@google.com [DisplayList] Remove legacy size fields in DLOp records (flutter/engine#56101)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 07:27:26 +00:00
Valentin Vignal
086c07cc05 Add test for build_owner.0.dart (#157499)
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/widgets/framework/build_owner.0.dart`
2024-10-25 07:13:22 +00:00
Valentin Vignal
ffb1239801 Add tests for focusable_action_detector.0.dart (#157575)
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/widgets/actions/focusable_action_detector.0.dart`
2024-10-25 07:05:26 +00:00
Valentin Vignal
29eee6ac16 Add test for navigator.restorable_push_and_remove_until.0.dart (#157487)
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/widgets/navigator/navigator.restorable_push_and_remove_until.0.dart`
2024-10-25 06:39:33 +00:00
engine-flutter-autoroll
41b362b12c Roll Flutter Engine from 29440ed1e225 to b1c2ba8c4d52 (1 revision) (#157572)
29440ed1e2...b1c2ba8c4d

2024-10-25 chinmaygarde@google.com [Impeller] libImpeller: Respect the paragraph style line height specification. (flutter/engine#56066)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 02:59:25 +00:00
engine-flutter-autoroll
b97f3d2752 Roll Flutter Engine from 88716d804aef to 29440ed1e225 (1 revision) (#157569)
88716d804a...29440ed1e2

2024-10-24 jason-simmons@users.noreply.github.com [web] Do not copy invalid images in the Skia test image collection (flutter/engine#56102)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 01:44:24 +00:00
engine-flutter-autoroll
287f6392e7 Roll Flutter Engine from b8b28c80a737 to 88716d804aef (2 revisions) (#157567)
b8b28c80a7...88716d804a

2024-10-24 devoncarew@google.com [deps] update deps and pubspecs for the new locations of package:matcher, package:collection, and package:boolean_selector (flutter/engine#56107)
2024-10-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 7d218a25e8bf to 3067d697ae26 (3 revisions) (flutter/engine#56106)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 00:43:17 +00:00
engine-flutter-autoroll
2ae16a2373 Roll Flutter Engine from 48ff670d256b to b8b28c80a737 (2 revisions) (#157564)
48ff670d25...b8b28c80a7

2024-10-24 jonahwilliams@google.com [android] make failing to acquire a java image non-fatal. (flutter/engine#56105)
2024-10-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from NxrFCTty8wV4-6Cpl... to Y4TdnTpLdkI107K42... (flutter/engine#56096)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from NxrFCTty8wV4 to Y4TdnTpLdkI1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 23:36:33 +00:00
Matan Lurey
f2e907acdd Use discenrable characters (replace ' 🙙 🙛 ' in error logs) (#157548)
Fixes an annoyance of mine where I stare at two boxes in the logs and have to guess if they are part of the real output:

<img width="795" alt="Screenshot 2024-10-24 at 12 47 58 PM" src="https://github.com/user-attachments/assets/a986f71c-5533-4899-aeb8-126dc82794fb">

Related to https://github.com/flutter/flutter/issues/157542#issuecomment-2436083676.
2024-10-24 22:05:52 +00:00
Matan Lurey
a4167b7cf2 Remove unused PubDependenciesProjectValidator. (#157516)
Closes https://github.com/flutter/flutter/issues/157479.

This came up while I was looking at parsing the results of `dart pub deps --json`, turns out it isn't used.
2024-10-24 22:05:50 +00:00
auto-submit[bot]
b98d9a37ac Reverts "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (#157032)" (#157559)
Reverts: flutter/flutter#157032
Initiated by: gmackall
Reason for reverting: https://github.com/flutter/flutter/pull/157032#issuecomment-2436336078
Original PR Author: gmackall

Reviewed By: {reidbaker, bartekpacia}

This change reverts the following previous change:
I recently noticed the following log when building an app in verbose mode:
```
This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox").
You are strongly encouraged to update your project to use a newer
Android Gradle plugin that has been tested with compileSdk = 35.
```

It looks like AGP would like us to use a newer AGP version if we want to use compileSdk 35 (which we do). This pr upgrades the tests, in advance of updating the templates.
2024-10-24 21:06:16 +00:00
Jonah Williams
b36a1316c3 Mark mac impeller as bringup. (#157551)
These started flaking and I don't know why. Mark as bringup until we can
investigate.
2024-10-24 13:18:18 -07:00
Taha Tesser
cdf4a2d109 Deprecate ThemeData.dialogBackgroundColor in favor of DialogThemeData.backgroundColor (#155072)
Related to [☂️ Material Theme System Updates](https://github.com/flutter/flutter/issues/91772)
2024-10-24 20:12:21 +00:00
Gray Mackall
5ca6350a06 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (#157032)
I recently noticed the following log when building an app in verbose mode:
```
This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox").
You are strongly encouraged to update your project to use a newer
Android Gradle plugin that has been tested with compileSdk = 35.
```

It looks like AGP would like us to use a newer AGP version if we want to use compileSdk 35 (which we do). This pr upgrades the tests, in advance of updating the templates.
2024-10-24 20:08:45 +00:00
engine-flutter-autoroll
866f36293c Roll Flutter Engine from 246344f26edc to 48ff670d256b (2 revisions) (#157544)
246344f26e...48ff670d25

2024-10-24 magder@google.com Remove 'Linux mac_clangd' in favor of 'Mac clangd' (flutter/engine#56082)
2024-10-24 30870216+gaaclarke@users.noreply.github.com Added thread name to pipeline validation error. (flutter/engine#56074)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 20:03:22 +00:00
Matan Lurey
dc13c3bfb7 Allow opting out of .flutter-plugins, opt-out in refreshPluginsList. (#157527)
Work towards https://github.com/flutter/flutter/issues/48918.

Workaround for https://github.com/flutter/flutter/issues/157391 (see https://github.com/flutter/flutter/pull/157393#issuecomment-2434336047).

I'll run all post-submit tasks as well on this PR using `test: all`.
2024-10-24 20:01:45 +00:00
auto-submit[bot]
73f66a7ea4 Reverts "Reverts "Added a warning if flutter.groovy uses a .flutter-plugins file. (#157388)" (#157541)" (#157549)
Reverts: flutter/flutter#157541
Initiated by: matanlurey
Reason for reverting: Was _not_ the cause of failure, see https://github.com/flutter/flutter/issues/157542.
Original PR Author: auto-submit[bot]

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
Reverts: flutter/flutter#157388
Initiated by: matanlurey
Reason for reverting: We have `--fatal-warnings` on postsubmit and this breaks the tree.
Original PR Author: matanlurey

Reviewed By: {reidbaker}

This change reverts the following previous change:
Work towards https://github.com/flutter/flutter/issues/48918.

This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).
2024-10-24 19:52:25 +00:00
Mairramer
8cc862c727 Changes the offset computation to first item for RenderSliverMainAxisGroup (#154688)
Fixes https://github.com/flutter/flutter/issues/154615
When scrolling back to the top, the position of the first visible item should have its scrollExtent subtracted. Otherwise, the accumulated position may be retained, which may result in the first visible item being hidden in some cases.
2024-10-24 19:23:07 +00:00
engine-flutter-autoroll
19296abf85 Roll Packages from 5e03bb1da411 to a556f0f52825 (7 revisions) (#157539)
5e03bb1da4...a556f0f528

2024-10-24 10687576+bparrishMines@users.noreply.github.com [camera] Manual roll and skip failing tests (flutter/packages#7891)
2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/image_picker/image_picker_android/android (flutter/packages#7898)
2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7906)
2024-10-23 48524817+wamynobe@users.noreply.github.com [pigeon] Allows swift generator to skip error class generation (flutter/packages#7849)
2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7903)
2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/file_selector/file_selector_android/android (flutter/packages#7900)
2024-10-23 43054281+camsim99@users.noreply.github.com [video_player_android] Give `can pause` integration test range to test for (flutter/packages#7913)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 18:55:08 +00:00
Loïc Sharma
bf319d6213 Add partial test for flutter build ios-framework on non-module (#157482)
Add a partial test for running `flutter build ios-framework` on a regular app project (not a module).

Follow-up to this conversation: https://github.com/flutter/flutter/pull/157393/files#r1811810540

Part of https://github.com/flutter/flutter/issues/146957
2024-10-24 18:53:09 +00:00
Loïc Sharma
fe95b2e225 Add example to SafeArea docs (#157228) 2024-10-24 18:53:07 +00:00
auto-submit[bot]
ef99fcbd60 Reverts "Added a warning if flutter.groovy uses a .flutter-plugins file. (#157388)" (#157541)
Reverts: flutter/flutter#157388
Initiated by: matanlurey
Reason for reverting: We have `--fatal-warnings` on postsubmit and this breaks the tree.
Original PR Author: matanlurey

Reviewed By: {reidbaker}

This change reverts the following previous change:
Work towards https://github.com/flutter/flutter/issues/48918.

This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).
2024-10-24 18:20:47 +00:00
Matan Lurey
25b55b9f2d Added a warning if flutter.groovy uses a .flutter-plugins file. (#157388)
Work towards https://github.com/flutter/flutter/issues/48918.

This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).
2024-10-24 16:25:09 +00:00
engine-flutter-autoroll
cc86b703ce Roll Flutter Engine from be56084344d1 to 246344f26edc (2 revisions) (#157504)
be56084344...246344f26e

2024-10-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 024c9570fae4 to 7d218a25e8bf (1 revision) (flutter/engine#56085)
2024-10-24 skia-flutter-autoroll@skia.org Roll Dart SDK from dd06a1e3002c to 024c9570fae4 (1 revision) (flutter/engine#56079)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 15:57:22 +00:00
Huy
fa5254331f Add ability to disable CupertinoSegmentedControl (#152813)
### Summary

Add the ability to configure enabled or disabled segments in CupertinoSegmentedControl. The idea is to pass a `segmentStates` map, where the user can set the state according to segment key. User can also set background and text colors when the segment is disabled.

### Demo

https://github.com/user-attachments/assets/4a02da02-a0fb-4ded-a271-033a8dc79ac3

### Related issue
Fixes https://github.com/flutter/flutter/issues/52105
2024-10-24 12:05:35 +00:00
Taha Tesser
0167f02e90 Update Tab.height parameter doc for tab height lower than default (#157443)
Fixes [TabBar.height adds a gap between the AppBar.toolbar and AppBar.bottom](https://github.com/flutter/flutter/issues/156200)
2024-10-24 09:43:36 +00:00
Valentin Vignal
6bef61a454 Add test for star_border.0.dart (#157401)
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/test/painting/star_border/star_border.0_test.dart`
2024-10-24 05:14:19 +00:00
engine-flutter-autoroll
89ba3ba013 Roll Flutter Engine from 0b56cb8de79e to be56084344d1 (1 revision) (#157488)
0b56cb8de7...be56084344

2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[display_list] grow display list backing store by power of two. (#56004)" (flutter/engine#56078)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 04:42:39 +00:00
engine-flutter-autoroll
79ae42790f Roll Flutter Engine from 5d7caf771022 to 0b56cb8de79e (5 revisions) (#157486)
5d7caf7710...0b56cb8de7

2024-10-24 31859944+LongCatIsLooong@users.noreply.github.com Bare-bones iOS FKA implementation (flutter/engine#55964)
2024-10-23 chinmaygarde@google.com [Impeller] libImpeller: Allow appending to the transformation stack. (flutter/engine#56072)
2024-10-23 magder@google.com Add standalone 'Mac clangd' builder to replace 'Linux mac_clangd' orchestrator (flutter/engine#56014)
2024-10-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 75c42f30af7a to dd06a1e3002c (2 revisions) (flutter/engine#56070)
2024-10-23 skia-flutter-autoroll@skia.org Roll Skia from 42f9070e6625 to 53c9663c3b83 (1 revision) (flutter/engine#56069)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 03:23:26 +00:00
engine-flutter-autoroll
2ba425ec98 Roll Flutter Engine from 73c54fadf5ee to 5d7caf771022 (5 revisions) (#157478)
73c54fadf5...5d7caf7710

2024-10-23 34871572+gmackall@users.noreply.github.com Delete v1 android engine embedding (flutter/engine#52022)
2024-10-23 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view]force reset forwarding recognizer state when its stuck (flutter/engine#55958)
2024-10-23 jason-simmons@users.noreply.github.com Allow running the YAPF formatter using Python version 3.11 (flutter/engine#56062)
2024-10-23 jonahwilliams@google.com [Impeller] optimize clip rects by checking if integral coverage is sufficient. (flutter/engine#56041)
2024-10-23 a-siva@users.noreply.github.com Switch the web compilation step to use an AOT snapshot (flutter/engine#56040)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 01:43:34 +00:00
LouiseHsu
bade5591bf Prevent flutter build ios-framework --xcframework from copying Flutter.xcframework.dSYM into the App.framework folder. (#157394)
Fixes https://github.com/flutter/flutter/issues/157359

Prevents Flutter.xcframework.dSYM from being copied into the App.framework folder. I am not 100% positive if there are cases where it's valid to have multiple dSYMs in that folder, so I'm just string matching and filtering out `Flutter.xcframework.dSYM`
2024-10-23 23:35:10 +00:00
Andrew Kolos
dad3fea650 docs: Rework "Making changes to the flutter tool" to include flutter-dev (#157480)
Follow-up to https://github.com/flutter/flutter/pull/153599. This updates the tool readme, suggesting `bin/flutter-dev` as the primary way to run the flutter tool locally from source.

<details>

<summary> Pre-launch checklist </summary> 

</details>
2024-10-23 23:28:57 +00:00
Flutter GitHub Bot
1f257cbc52 Marks Windows build_android_host_app_with_module_aar to be unflaky (#157419)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_android_host_app_with_module_aar"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_android_host_app_with_module_aar%22).
This test can be marked as unflaky.
2024-10-23 23:27:05 +00:00
LongCatIsLooong
2d3697216b Turn brieflyShowPassword back on on iOS (#157466)
Fixes https://github.com/flutter/flutter/issues/115359

This patch should restore the `brieflyShowPassword` behavior on iOS before https://github.com/flutter/flutter/pull/104335.

On iOS new characters are still temporarily revealed if the user is entering using the software keyboard (potentially because it's easy to fat finger using on screen keyboards?).
2024-10-23 23:22:15 +00:00
Flutter GitHub Bot
0fd477d7f8 Marks Mac build_android_host_app_with_module_aar to be unflaky (#157411)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac build_android_host_app_with_module_aar"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20build_android_host_app_with_module_aar%22).
This test can be marked as unflaky.
2024-10-23 22:05:54 +00:00
Flutter GitHub Bot
8c978e9c23 Marks Linux build_android_host_app_with_module_aar to be unflaky (#157409)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux build_android_host_app_with_module_aar"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_android_host_app_with_module_aar%22).
This test can be marked as unflaky.
2024-10-23 22:02:00 +00:00
Flutter GitHub Bot
2a074311be Marks Windows build_tests_3_8 to be unflaky (#157414)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_3_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_3_8%22).
This test can be marked as unflaky.
2024-10-23 22:00:54 +00:00
Flutter GitHub Bot
8c36518372 Marks Windows build_tests_4_8 to be unflaky (#157415)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_4_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_4_8%22).
This test can be marked as unflaky.
2024-10-23 22:00:51 +00:00
Flutter GitHub Bot
c8a285870f Marks Windows build_tests_5_8 to be unflaky (#157416)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_5_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_5_8%22).
This test can be marked as unflaky.
2024-10-23 21:59:26 +00:00
Flutter GitHub Bot
fbfda5aeb2 Marks Windows build_tests_7_8 to be unflaky (#157418)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_7_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_7_8%22).
This test can be marked as unflaky.
2024-10-23 21:59:23 +00:00
Flutter GitHub Bot
d1d7496e53 Marks Windows build_tests_6_8 to be unflaky (#157417)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_6_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_6_8%22).
This test can be marked as unflaky.
2024-10-23 21:40:14 +00:00
engine-flutter-autoroll
d7c8cd1038 Roll Flutter Engine from 19f9c5ad2d86 to 73c54fadf5ee (2 revisions) (#157464)
19f9c5ad2d...73c54fadf5

2024-10-23 skia-flutter-autoroll@skia.org Roll Skia from 721bbd7c0340 to 42f9070e6625 (1 revision) (flutter/engine#56064)
2024-10-23 devoncarew@google.com Update the engine deps to track new SoT git locations for several packages (flutter/engine#56028)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 20:59:21 +00:00
Mohellebi abdessalem
c155e30467 small update in regex in flutter.groovy (#156484)
see #147122 for more context
`/(\\ |[^\s])+/ ` and `/(\\ |\S)+/` are basically equivalant but the
last one won't trigger android Studio warnings
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
2024-10-23 16:31:07 -04:00
engine-flutter-autoroll
cedd859c44 Roll Flutter Engine from 6b022dfbc8ea to 19f9c5ad2d86 (3 revisions) (#157460)
6b022dfbc8...19f9c5ad2d

2024-10-23 skia-flutter-autoroll@skia.org Roll Skia from ad09ab099fe4 to 721bbd7c0340 (10 revisions) (flutter/engine#56063)
2024-10-23 aam@google.com Reland copy gen snapshot (flutter/engine#56061)
2024-10-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 2a4b728f6a03 to 75c42f30af7a (1 revision) (flutter/engine#56060)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 20:02:20 +00:00
Andrew Kolos
eccf4ee226 fix test sharding (#156768)
Also cleans up https://github.com/flutter/flutter/issues/156762

<details>

<summary> Pre-launch checklist </summary> 

</details>
2024-10-23 19:36:09 +00:00
Elliott Brooks
802bae0111 Allow requesting a reduced widget tree with getRootWidgetTree service extension (#157309) 2024-10-23 12:30:55 -07:00
engine-flutter-autoroll
99ddbc308f Roll Flutter Engine from ec6e28ac8b49 to 6b022dfbc8ea (1 revision) (#157455)
ec6e28ac8b...6b022dfbc8

2024-10-23 30870216+gaaclarke@users.noreply.github.com Fixes crash in testTrackpadGesturesAreSentToFramework (flutter/engine#55990)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 18:49:59 +00:00