firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
29,920 Commits 1 Branch 0 Tags
21bb71b627c53e3675999d0aba4c663cb5ebc2df
Commit Graph

29920 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan Field
21bb71b627 [Impeller] Improve resolution of text scaling. (flutter/engine#43533) 
This patch does a few things:

- Changes ownership of the LazyGlyphAtlas to ContentContext from Canvas. This means that drawings with multiple canvases (e.g. calls to DrawPicture) share the same lazy atlas.
- Moves the scale property from Font::Metrics to FontGlyphPair. Font::Metrics contains properties related to the font, whereas scale has to do with the properties of the drawing at render time and is independent of the font.
- Makes the lazy atlas manage FontGlyphPair::Set rather than vectors of TextFrames.
- Makes the determination of font scaling at EntityPass::Render rather than Canvas::DrawTextFrame. The scaling may be altered by calls to Canvas::DrawPicture by render time and otherwise get missed. This is done via a new method: Contents::PopulateGlyphAtlas, which is only implemented by TextContents in this patch.
- Fixes up some miscelleaneous bugs in Font::Metrics hashing and unused/dead code.

This improves over prior attempts: LazyGlyphAtlas ownership is now unambiguous, and glyph scaling happens correctly for all rendered glyphs regardless of the order of canvas operations in Aiks.

Fixes flutter/flutter#130142
 2023-07-11 04:57:07 +00:00
skia-flutter-autoroll
e939f38a85 Roll Skia from d0991c6af2d6 to 6a5c4b0c0fcb (1 revision) (flutter/engine#43544) 
https://skia.googlesource.com/skia.git/+log/d0991c6af2d6..6a5c4b0c0fcb

2023-07-11 penghuang@chromium.org graphite/dawn: support RGB_888x ct and BGRA8Unorm format combination

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-11 03:55:13 +00:00
Chinmay Garde
5400db6492 [Impeller] Refactor barriers and add documentation. (flutter/engine#43540) 
Calling a pipeline barrier a transition seemed odd. Also, the members of the layout transition weren't documented and I always had a tough time remembering how barriers worked. It's hopefully clearer now.
 2023-07-11 03:29:13 +00:00
skia-flutter-autoroll
d89d2d5631 Roll Skia from bbe71d71e576 to d0991c6af2d6 (1 revision) (flutter/engine#43543) 
https://skia.googlesource.com/skia.git/+log/bbe71d71e576..d0991c6af2d6

2023-07-11 michaelludwig@google.com Revert "Experimental SkParagraph API"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-11 03:05:03 +00:00
skia-flutter-autoroll
733495c5a4 Roll Skia from 76daa2a33fa5 to bbe71d71e576 (1 revision) (flutter/engine#43541) 
https://skia.googlesource.com/skia.git/+log/76daa2a33fa5..bbe71d71e576

2023-07-11 michaelludwig@google.com [skif] Add SkTileMode to FilterResult::applyCropRect

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-11 02:17:01 +00:00
Jim Graham
77514c4f43 Use full 4x4 matrix transforms in TransformLayer (flutter/engine#43536) 
Fixes: https://github.com/flutter/flutter/issues/82961
Fixes: https://github.com/flutter/flutter/issues/113346

The fix was a simple fallout from the previous work to add support for SkM44 throughout the DL and Diff mechanisms (see https://github.com/flutter/flutter/issues/82955, https://github.com/flutter/flutter/issues/116198, https://github.com/flutter/engine/pull/37394)

Tested with its own existing and new unit tests as well as the test case from https://github.com/flutter/flutter/issues/113346
 2023-07-11 01:55:07 +00:00
Jonah Williams
f64349bfa8 [Impeller] Unconditionally cache swapchain msaa texture. (flutter/engine#43529) 
Even on the Pixel 6 pro device which supports memoryless textures, I can observe creating the memoryless texture sometimes takes a few hundred microseconds, possibly due to stalls in the driver allocating the texture metadata. Lets just unconditionally cache this texture to avoid making the driver do more work.

Here is an example of this happening:

![image](https://github.com/flutter/engine/assets/8975114/a2d0fed7-7a25-4652-9932-2464b272d80c)

https://github.com/flutter/flutter/issues/129392
 2023-07-11 01:44:08 +00:00
skia-flutter-autoroll
dbf987a9f5 Roll Skia from c3d39bed2830 to 76daa2a33fa5 (1 revision) (flutter/engine#43539) 
https://skia.googlesource.com/skia.git/+log/c3d39bed2830..76daa2a33fa5

2023-07-11 jmbetancourt@google.com [skottie] expose SlotManager to public APIs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-11 01:23:04 +00:00
skia-flutter-autoroll
b2bdde8d20 Roll Fuchsia Linux SDK from 4fmJ_PQoaE2L9vdx0... to cgcxIe8D4wb8hQWCV... (flutter/engine#43538) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-11 00:42:10 +00:00
skia-flutter-autoroll
eb3d259a2a Roll Skia from 2db628aa1181 to c3d39bed2830 (1 revision) (flutter/engine#43537) 
https://skia.googlesource.com/skia.git/+log/2db628aa1181..c3d39bed2830

2023-07-10 jvanverth@google.com [graphite] First pass at Vulkan support for Viewer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-11 00:36:18 +00:00
skia-flutter-autoroll
894af61059 Roll Fuchsia Mac SDK from raXixVs2pKxD9ZasB... to bb8HXP6JZ60Unjk-W... (flutter/engine#43532) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 23:06:23 +00:00
skia-flutter-autoroll
1dcf6974b7 Roll Dart SDK from 3778952664e0 to f9d33db51927 (1 revision) (flutter/engine#43531) 
https://dart.googlesource.com/sdk.git/+log/3778952664e0..f9d33db51927

2023-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-292.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 22:46:12 +00:00
skia-flutter-autoroll
9435b49a27 Roll Skia from aad8fbb17d69 to 2db628aa1181 (1 revision) (flutter/engine#43530) 
https://skia.googlesource.com/skia.git/+log/aad8fbb17d69..2db628aa1181

2023-07-10 kjlubick@google.com Revert "Make SkParagraph tests run on the CI"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 22:38:05 +00:00
Chinmay Garde
18c0aeccd3 [Impeller] Fix Vulkan validation error when there is a blit directed at a swapchain image. (flutter/engine#43527) 
This shows up in the the aiks test harness in the color wheel with advanced blends.

Fixes https://github.com/flutter/flutter/issues/129853
 2023-07-10 22:02:52 +00:00
skia-flutter-autoroll
260a9213b8 Roll Skia from 89313a8cadab to aad8fbb17d69 (3 revisions) (flutter/engine#43526) 
https://skia.googlesource.com/skia.git/+log/89313a8cadab..aad8fbb17d69

2023-07-10 jlavrova@google.com Experimental SkParagraph API
2023-07-10 robertphillips@google.com Revert "[graphite] Reenable tiled image cache size heuristic (take 2)"
2023-07-10 robertphillips@google.com Add a tiled-image cache test (take 2)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 21:48:53 +00:00
skia-flutter-autoroll
d80f868c7e Roll Skia from c06d7ef5c276 to 89313a8cadab (2 revisions) (flutter/engine#43521) 
https://skia.googlesource.com/skia.git/+log/c06d7ef5c276..89313a8cadab

2023-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bcff94480451 to a77b0584c241 (6 revisions)
2023-07-10 kjlubick@google.com Make SkParagraph tests run on the CI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 20:59:35 +00:00
Jonah Williams
83ba0cd2d0 [Impeller] Don't decompress into device buffer for Vulkan/GLES. (flutter/engine#43493) 
My observations on the Pixel 6 device are that performing device allocations from multiple threads can dramatically slow down the raster task workload. As a stopgap solution, we can adjust image upload to only touch the device allocator on the IO thread which reduces the parallel access.

This doesn't have any impact on the S10, but locally on the Pixel 6 it is a night and day difference. I am testing using jonahwilliams/forked_gallery and navigating to the Reply demo. This demo has a large number of images, several of which are quite large.

Work towards https://github.com/flutter/flutter/issues/129392

### Before

Page transition is ~4 frames.

![image](https://github.com/flutter/engine/assets/8975114/b6d1c225-060b-4a20-9737-ad668423799a)

### After

Page transition is ~20 frames.

![image](https://github.com/flutter/engine/assets/8975114/5ff1f857-8327-4d04-b40a-3da4a5fc91a4)
 2023-07-10 20:48:18 +00:00
Brandon DeRosier
3537a13e39 [Impeller] Add matrix backdrop filter golden. (flutter/engine#43484) 
Adds an Aiks golden to demonstrate issues with using
MatrixFilterContents as a backdrop filter.
 2023-07-10 13:09:12 -07:00
skia-flutter-autoroll
d93cb5e817 Roll Skia from 03e689a0fa32 to c06d7ef5c276 (1 revision) (flutter/engine#43520) 
https://skia.googlesource.com/skia.git/+log/03e689a0fa32..c06d7ef5c276

2023-07-10 robertphillips@google.com [graphite] Reenable tiled image cache size heuristic (take 2)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 20:06:23 +00:00
Robert Ancell
1f3d51dca5 Use better method of ensuring that *_get_type() functions are exported (flutter/engine#43395) 
As discovered in https://stackoverflow.com/a/63264068/1950237
 2023-07-11 07:58:34 +12:00
skia-flutter-autoroll
cfe72602b8 Roll Skia from 7e45a9fbca5f to 03e689a0fa32 (2 revisions) (flutter/engine#43517) 
https://skia.googlesource.com/skia.git/+log/7e45a9fbca5f..03e689a0fa32

2023-07-10 herb@google.com Pass up insert failure for SkTriangulator
2023-07-10 johnstiles@google.com Demonstrate Metal codegen error with sk_VertexID.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 18:51:08 +00:00
skia-flutter-autoroll
434a873979 Roll Dart SDK from 4998bf65f91c to 3778952664e0 (6 revisions) (flutter/engine#43516) 
https://dart.googlesource.com/sdk.git/+log/4998bf65f91c..3778952664e0

2023-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-291.0.dev
2023-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-290.0.dev
2023-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-289.0.dev
2023-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-288.0.dev
2023-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-287.0.dev
2023-07-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-286.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 18:08:05 +00:00
skia-flutter-autoroll
0571a24585 Roll Skia from 320f01ac1de7 to 7e45a9fbca5f (3 revisions) (flutter/engine#43515) 
https://skia.googlesource.com/skia.git/+log/320f01ac1de7..7e45a9fbca5f

2023-07-10 robertphillips@google.com [graphite] Add support for SkBitmap-subset-backed images to TestingImageProvider
2023-07-10 michaelludwig@google.com [skif] Skip Dawn/ANGLE GPU backends in FilterResultTest
2023-07-10 johnstiles@google.com Allow Graphite shaders to be inspected in Viewer.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 18:04:08 +00:00
skia-flutter-autoroll
608a75b020 Roll Skia from 1c9e2588b577 to 320f01ac1de7 (6 revisions) (flutter/engine#43514) 
https://skia.googlesource.com/skia.git/+log/1c9e2588b577..320f01ac1de7

2023-07-10 johnstiles@google.com Save shaders in GraphicsPipeline when test-utils are enabled.
2023-07-10 robertphillips@google.com Switch Ganesh tiled image drawing over to using drawEdgeAAImageSet
2023-07-10 johnstiles@google.com Reland "Avoid crash in Viewer when viewing shaders in Graphite."
2023-07-10 kjlubick@google.com Clean up some example fiddles
2023-07-10 robertphillips@google.com [graphite] Add some documentation for SkTiledImageUtils
2023-07-10 johnstiles@google.com Remove extra semicolons around SK_MAKE_BITMASK_OPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 17:15:22 +00:00
luckysmg
4248f33948 [iOS][Keyboard] Reland wait vsync on UI thread and update viewport inset to avoid jitter (flutter/engine#43463) 
*List which issues are fixed by this PR. You must list at least one issue.*
- https://github.com/flutter/flutter/issues/120555
- https://github.com/flutter/flutter/issues/130028

### New test for crash case: 
`testKeyboardAnimationWillNotCrashWhenEngineDestroyed`

### The diff with original PR:

Use `dispatch_async(dispatch_get_main_queue()` to switch to platform thread.
 2023-07-10 16:25:05 +00:00
skia-flutter-autoroll
79f7a85180 Roll Skia from 17686918fa1f to 1c9e2588b577 (3 revisions) (flutter/engine#43513) 
https://skia.googlesource.com/skia.git/+log/17686918fa1f..1c9e2588b577

2023-07-10 johnstiles@google.com Remove -Wc++98-compat-extra-semi.
2023-07-10 kjlubick@google.com Make sure SK_SPI is applied to SkDebugf implementations
2023-07-10 brianosman@google.com Initialize stat structures before calling stat

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 16:13:04 +00:00
skia-flutter-autoroll
535801a4e9 Roll Skia from cf3f3d048122 to 17686918fa1f (1 revision) (flutter/engine#43511) 
https://skia.googlesource.com/skia.git/+log/cf3f3d048122..17686918fa1f

2023-07-10 kjlubick@google.com Fix SkCanvas::flush() with RecordDraw

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 13:29:18 +00:00
skia-flutter-autoroll
0bd53ca078 Roll Fuchsia Linux SDK from eRSQn0XKuI7byK2i_... to 4fmJ_PQoaE2L9vdx0... (flutter/engine#43510) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 11:53:20 +00:00
skia-flutter-autoroll
176273552c Roll Skia from 0a1e7aeb29b5 to cf3f3d048122 (1 revision) (flutter/engine#43509) 
https://skia.googlesource.com/skia.git/+log/0a1e7aeb29b5..cf3f3d048122

2023-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dda88e93be7e to bcff94480451 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 10:41:24 +00:00
skia-flutter-autoroll
1d398518ec Roll Fuchsia Mac SDK from aQqgcKf1EwSoRWDet... to raXixVs2pKxD9ZasB... (flutter/engine#43508) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 10:13:13 +00:00
Robert Ancell
b864ee7e61 Fix leak when switching channels (flutter/engine#41827) 
As noticed in https://github.com/flutter/flutter/issues/126209

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2023-07-10 21:54:21 +12:00
skia-flutter-autoroll
fd019fbb82 Roll Skia from a72649f13420 to 0a1e7aeb29b5 (1 revision) (flutter/engine#43505) 
https://skia.googlesource.com/skia.git/+log/a72649f13420..0a1e7aeb29b5

2023-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 72c269263c2f to 6ee402f6c133 (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 07:33:06 +00:00
skia-flutter-autoroll
37e35140aa Roll Skia from ab7f95f52ea6 to a72649f13420 (3 revisions) (flutter/engine#43504) 
https://skia.googlesource.com/skia.git/+log/ab7f95f52ea6..a72649f13420

2023-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d5207f6cef93 to 03f1674c4d91
2023-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f72770b2c35d to d5207f6cef93 (2 revisions)
2023-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3b9aa123c9d9 to d94b6fd1904f (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-10 06:55:13 +00:00
Dan Ballard
ac192f333c [linux] Allow overriding aot_library_path (flutter/engine#42555) 
Support overriding `aot_library_path` in `FLDartProject` on Linux.

Fixes: https://github.com/flutter/flutter/issues/128213

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-07-10 16:11:53 +12:00
skia-flutter-autoroll
1e288b7243 Roll Fuchsia Linux SDK from E9CEA-wZJ9VgSP80c... to eRSQn0XKuI7byK2i_... (flutter/engine#43498) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-09 23:05:30 +00:00
skia-flutter-autoroll
288a57390c Roll Fuchsia Mac SDK from UKVzvetd5M4SA_ufb... to aQqgcKf1EwSoRWDet... (flutter/engine#43497) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-09 16:03:18 +00:00
skia-flutter-autoroll
7ff2ddb9e9 Roll Skia from 05ce4af04609 to ab7f95f52ea6 (1 revision) (flutter/engine#43496) 
https://skia.googlesource.com/skia.git/+log/05ce4af04609..ab7f95f52ea6

2023-07-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-09 11:01:24 +00:00
skia-flutter-autoroll
da3dd849c5 Roll Fuchsia Linux SDK from 8X61T1htYuHQtWtFv... to E9CEA-wZJ9VgSP80c... (flutter/engine#43495) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-09 10:21:32 +00:00
skia-flutter-autoroll
24b9f680ec Roll Fuchsia Mac SDK from TSpkNWkgR0F7xl8q5... to UKVzvetd5M4SA_ufb... (flutter/engine#43494) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-09 03:09:22 +00:00
skia-flutter-autoroll
70f92e124c Roll Fuchsia Linux SDK from Q4Oq8NRW2yeBrgy4b... to 8X61T1htYuHQtWtFv... (flutter/engine#43492) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-08 21:39:24 +00:00
skia-flutter-autoroll
f28762469c Roll Fuchsia Mac SDK from 8YPOimmJgaAd5SlAT... to TSpkNWkgR0F7xl8q5... (flutter/engine#43490) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-08 14:29:24 +00:00
Jason Simmons
0f179b102a [Impeller] Check for a null command buffer in InlinePassContext::EndPass (flutter/engine#43485) 
This could happen if the pass is immediately ended due to clear color
optimization.

Fixes https://github.com/flutter/flutter/issues/130167
 2023-07-08 07:14:57 -07:00
skia-flutter-autoroll
198f0d9628 Roll Skia from 6d733caa0d3f to 05ce4af04609 (1 revision) (flutter/engine#43489) 
https://skia.googlesource.com/skia.git/+log/6d733caa0d3f..05ce4af04609

2023-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 95bbe1dda9b7 to dda88e93be7e (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-08 12:28:17 +00:00
skia-flutter-autoroll
ac1d1acd5d Roll Fuchsia Linux SDK from vee6hAD_43mq_4FS7... to Q4Oq8NRW2yeBrgy4b... (flutter/engine#43486) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-08 07:30:05 +00:00
Tong Mu
489f9c3d01 Make updating window metrics multi-view (flutter/engine#43366) 
This PR adds multi-view support to various methods that updates the window metrics by adding a `view_id` parameter.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-08 05:54:16 +00:00
Tong Mu
9cd4338940 Rename default views to implicit views (flutter/engine#43364) 
This PR renames a number of internal variables from "default view ID" to
"implicit view ID", as we have pretty much settled on naming this
mechanism. Some docs are also fixed accordingly.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-07-07 20:44:37 -07:00
Ricardo Amador
1e09efb815 Remove unused autosubmit configuration file (flutter/engine#43483) 
Remove autosubmit config files that are no longer being used. This was from a previous design and not longer used.

List which issues are fixed by this PR. You must list at least one issue.
Part of https://github.com/flutter/flutter/issues/130182

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-08 00:34:04 +00:00
skia-flutter-autoroll
c9eb94ad87 Roll Skia from 2885452c3fb1 to 6d733caa0d3f (1 revision) (flutter/engine#43482) 
https://skia.googlesource.com/skia.git/+log/2885452c3fb1..6d733caa0d3f

2023-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 869b279baef4 to 95bbe1dda9b7 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-07 23:47:55 +00:00
David Worsham
b400037017 [fuchsia] Fix tests; remove fuchsia dart SDK deps (flutter/engine#43461) 
Dart is being removed from the Fuchsia SDK, so remove references to it
here.

Also remove references to workstation_eng and replace with terminal.
workstation_eng is no longer a thing.
 2023-07-08 09:37:34 +10:00
skia-flutter-autoroll
ea932582ff Roll Fuchsia Mac SDK from MPy31yjgPV-d_YJq0... to 8YPOimmJgaAd5SlAT... (flutter/engine#43481) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-07 23:21:15 +00:00