firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
32,645 Commits 1 Branch 0 Tags
1dc6423dacedbbf6002249260dcd86d4e60c3d5f
Commit Graph

32645 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Gray Mackall
1dc6423dac [Re-land] Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47839) 
The difference between this PR and the original is the change to the `AndroidManifest.xml`. For context, right before the original PR landed, [a change to upgrade the target sdk](https://github.com/flutter/engine/pull/47683) in the manifest from 31 to 33 landed. It also removed the lint complaining about using an old target sdk version from the baseline lint file. So this change upgrading the sdk, but not the target sdk in the manifest, triggered the lint again.

For the rest of the PR, [see the description of the original PR](https://github.com/flutter/engine/pull/47609).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-09 18:02:18 +00:00
skia-flutter-autoroll
ae1220cfe2 Roll Dart SDK from 6bd98dc2dffd to 33307e78db2b (1 revision) (flutter/engine#47865) 
https://dart.googlesource.com/sdk.git/+log/6bd98dc2dffd..33307e78db2b

2023-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-113.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 17:42:07 +00:00
Victoria Ashworth
5b6fce7cb9 Use specific version of mac_toolchain (flutter/engine#47835) 
Newer versions of mac_toolchain increase Xcode install times by ~2 minutes (https://github.com/flutter/flutter/issues/138109). As a temporary solution, we're using an older version of mac_toolchain.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-09 17:38:49 +00:00
skia-flutter-autoroll
20430cf3e4 Roll Skia from df263765ebc8 to 775da2d297de (2 revisions) (flutter/engine#47861) 
https://skia.googlesource.com/skia.git/+log/df263765ebc8..775da2d297de

2023-11-09 brianosman@google.com Remove unused store_u16_be raster pipeline stage
2023-11-09 johnstiles@google.com Use STArray for MeshGP arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 16:52:18 +00:00
auto-submit[bot]
aa4fb605c3 Reverts "Remove physical geometry" (flutter/engine#47862) 
Reverts flutter/engine#47825
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Looks like this was proactively added in https://github.com/flutter/engine/pull/20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery.

Related framework PR: https://github.com/flutter/flutter/pull/138103 (Checks will fail until that PR is submitted).
 2023-11-09 16:06:19 +00:00
skia-flutter-autoroll
c378306ada Roll Skia from 7d0768083298 to df263765ebc8 (2 revisions) (flutter/engine#47860) 
https://skia.googlesource.com/skia.git/+log/7d0768083298..df263765ebc8

2023-11-09 johnstiles@google.com Remove skcms_internal.h from modules/skcms.
2023-11-09 robertphillips@google.com Add VkTestHelper factory

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 15:45:27 +00:00
Casey Hillers
6ecc6e20b6 Reland "Remove Fuchsia Mac SDK from DEPS" (flutter/engine#47823) 
Reverted as it broke the engine->flutter autoroller as it included this file. It was removed in https://skia-review.googlesource.com/c/skia-autoroll-internal-config/+/775817 and can now be removed from the engine.

https://github.com/flutter/flutter/issues/138087
 2023-11-09 15:07:06 +00:00
skia-flutter-autoroll
c5dfc8c6c6 Roll Skia from 8f8c9a144797 to 7d0768083298 (1 revision) (flutter/engine#47858) 
https://skia.googlesource.com/skia.git/+log/8f8c9a144797..7d0768083298

2023-11-09 robertphillips@google.com [graphite] Start making VkTestHelper support Graphite

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 14:23:34 +00:00
skia-flutter-autoroll
47ed379656 Roll Dart SDK from 6f36eb00cacf to 6bd98dc2dffd (1 revision) (flutter/engine#47857) 
https://dart.googlesource.com/sdk.git/+log/6f36eb00cacf..6bd98dc2dffd

2023-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-112.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 13:56:10 +00:00
skia-flutter-autoroll
bc549a7956 Roll Dart SDK from 14933042494d to 6f36eb00cacf (4 revisions) (flutter/engine#47855) 
https://dart.googlesource.com/sdk.git/+log/14933042494d..6f36eb00cacf

2023-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-111.0.dev
2023-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-110.0.dev
2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-109.0.dev
2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-108.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 10:05:22 +00:00
skia-flutter-autoroll
fbd9f883b7 Roll Skia from b055626ce8c2 to 8f8c9a144797 (1 revision) (flutter/engine#47854) 
https://skia.googlesource.com/skia.git/+log/b055626ce8c2..8f8c9a144797

2023-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6fff5ad7622c to fd7e3d444d59 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 09:47:13 +00:00
skia-flutter-autoroll
d4cc35f53c Roll Skia from b6ce84dc3e53 to b055626ce8c2 (1 revision) (flutter/engine#47850) 
https://skia.googlesource.com/skia.git/+log/b6ce84dc3e53..b055626ce8c2

2023-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a494c1d6c813 to 1bb2c5ece1de (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 05:55:32 +00:00
skia-flutter-autoroll
f89e9b9fd4 Roll Fuchsia Linux SDK from sD8HRA4JmXczujkqO... to 0pD5ceqf-e9y9NTNn... (flutter/engine#47847) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 03:40:39 +00:00
Michael Goderbauer
c273bd8d71 Remove physical geometry (flutter/engine#47825) 
Looks like this was proactively added in https://github.com/flutter/engine/pull/20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery.

Related framework PR: https://github.com/flutter/flutter/pull/138103 (Checks will fail until that PR is submitted).
 2023-11-09 02:18:24 +00:00
skia-flutter-autoroll
1b8017fd16 Roll Skia from f3e4fd80eeeb to b6ce84dc3e53 (1 revision) (flutter/engine#47843) 
https://skia.googlesource.com/skia.git/+log/f3e4fd80eeeb..b6ce84dc3e53

2023-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from acfbe8ab8855 to debc2d5dd36c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 02:08:01 +00:00
skia-flutter-autoroll
01cfddd8cd Roll Skia from d9ec01cf15ff to f3e4fd80eeeb (3 revisions) (flutter/engine#47838) 
https://skia.googlesource.com/skia.git/+log/d9ec01cf15ff..f3e4fd80eeeb

2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from b60ffc00fe5c to 5037b3433fc8 (1 revision)
2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 8449ce1d6518 to b23272a3cb61
2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 65712802736e to 1f5289c9db82

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 00:47:59 +00:00
Loïc Sharma
9aee1bdaff [Windows] Remove global state in keyboard tests (flutter/engine#47829) 
Currently the keyboard tests use global state to track key calls. As a result, a good test can fail if a bad test leaves key calls in the global state. This removes the global state and ensures each test is isolated.

Preparation for https://github.com/flutter/flutter/issues/115611

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-09 00:10:05 +00:00
Mouad Debbar
5f8e18d0f8 [web] Non-singleton implementation of ui.FlutterView (flutter/engine#47806) 
- Provide a non-singleton implementation of `EngineFlutterView`.
- Move all common "view" logic into `EngineFlutterView`.
- Remove the unused `windowConfigurations` map from `EnginePlatformDispatcher`.
 2023-11-08 23:58:02 +00:00
Greg Spencer
68166947cc Move window state update to window realize callback (flutter/engine#47713) 
## Description

This moves the state update to only happen on realizing the window instead of at initialization time, based on [the comment from](https://github.com/flutter/flutter/issues/137262#issuecomment-1792020246) @robert-ancell .

## Related Issues
 - https://github.com/flutter/flutter/issues/137262

## Tests
 - I tried to add tests, but it doesn't seem possible to create a view without an actual display connected (and making a mock of it defeats the purpose of the test). I'm happy to be proven wrong, though.
 2023-11-08 23:56:01 +00:00
skia-flutter-autoroll
65d3c19f04 Roll Skia from 1241a903cd33 to d9ec01cf15ff (1 revision) (flutter/engine#47836) 
https://skia.googlesource.com/skia.git/+log/1241a903cd33..d9ec01cf15ff

2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 78b8bb631267 to 48e35a606e12

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 23:52:42 +00:00
auto-submit[bot]
f5605fa8aa Reverts "Upgrade Android SDK to 34 "UpsideDownCake"" (flutter/engine#47834) 
Reverts flutter/engine#47609
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
~**This should not land until https://github.com/flutter/buildroot/pull/790 (re)lands, and I swap the buildroot url back to the latest commit.**~ ~Reland of PR to update buildroot at https://github.com/flutter/buildroot/pull/792. ~ <- landed, and changed the buildroot commit to the latest in DEPS

Upgrades to android api 34

Also:
1. Upgrades to java 17 in DEPS/ci, because the linter now requires it.
2. Stops running some roboelectric tests on android apis 16-18, because Roboelectric indicated those versions were unsupported and we don't support them either.
3. Applies the four trivial new suggestions from the newer linter.
4. Updates the baseline lint to include the new non-trivial lint ([fixed in a different PR](https://github.com/flutter/engine/pull/47817/files)).
5. Changes some instances where we were hardcoding android apis as numbers (e.g. `sdk = 16') to use version codes (see the [comment below](https://github.com/flutter/engine/pull/47609#issuecomment-1800308658)).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 22:57:25 +00:00
skia-flutter-autoroll
5b184b80e9 Roll Skia from e585bb68893b to 1241a903cd33 (2 revisions) (flutter/engine#47830) 
https://skia.googlesource.com/skia.git/+log/e585bb68893b..1241a903cd33

2023-11-08 nicolettep@google.com [graphite] Add label to YCbCr sampler conversion resource instantiation
2023-11-08 johnstiles@google.com Fix rewrite_includes errors.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 22:17:05 +00:00
Gray Mackall
542d29dedd Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47609) 
~**This should not land until https://github.com/flutter/buildroot/pull/790 (re)lands, and I swap the buildroot url back to the latest commit.**~ ~Reland of PR to update buildroot at https://github.com/flutter/buildroot/pull/792. ~ <- landed, and changed the buildroot commit to the latest in DEPS

Upgrades to android api 34

Also:
1. Upgrades to java 17 in DEPS/ci, because the linter now requires it.
2. Stops running some roboelectric tests on android apis 16-18, because Roboelectric indicated those versions were unsupported and we don't support them either.
3. Applies the four trivial new suggestions from the newer linter.
4. Updates the baseline lint to include the new non-trivial lint ([fixed in a different PR](https://github.com/flutter/engine/pull/47817/files)).
5. Changes some instances where we were hardcoding android apis as numbers (e.g. `sdk = 16') to use version codes (see the [comment below](https://github.com/flutter/engine/pull/47609#issuecomment-1800308658)).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 22:15:17 +00:00
Chris Bracken
c5b1d11b65 [macOS] Allocate textures as unique_ptr earlier (flutter/engine#47786) 
This cleans up several places where instead of allocating a
std::unique_ptr immediately, we were making allocations with the new
operator, then later wrapping in a unique_ptr. The previous code was
correct but there was no reason not to allocate a unique_ptr
immediately.

This code makes no semantic changes; just applies a stylistic
improvement that makes the code very slightly safer.


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-08 13:50:42 -08:00
Jim Graham
4979e236a9 Reland "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" (flutter/engine#47824) 
Reverts flutter/engine#47821

The original PR was reverted because the Vulkan backends couldn't handle the extra tests, but they've since been patched to fix the problem.
 2023-11-08 21:32:49 +00:00
skia-flutter-autoroll
55083d455b Roll Skia from e2b8ebe16203 to e585bb68893b (7 revisions) (flutter/engine#47826) 
https://skia.googlesource.com/skia.git/+log/e2b8ebe16203..e585bb68893b

2023-11-08 michaelludwig@google.com GrBlurUtils: Subset on low-res pixel boundary, not float coords
2023-11-08 jvanverth@google.com Force coloremoji GM to have a small multitexture atlas.
2023-11-08 mike@reedtribe.org Add build-flag to enable smaller/slower mipmap builder
2023-11-08 egdaniel@google.com [Graphite] Add initial support for Resource labels.
2023-11-08 herb@google.com Tighten up image and empty tracking for SkGlyph
2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 4da518531bee to 6a90ad65ed95
2023-11-08 nicolettep@google.com [graphite] Add sampler YCbCr conversion class, info struct; share utilities w/ ganesh

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 21:32:46 +00:00
Jonah Williams
513906fced [Impeller] Add support for specialization constants (III). (flutter/engine#47765) 
Reland of https://github.com/flutter/engine/pull/47432

Also includes:

https://github.com/flutter/engine/pull/47617
https://github.com/flutter/engine/pull/47637

Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation.

Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs.

Fixes https://github.com/flutter/flutter/issues/136210
Fixes https://github.com/flutter/flutter/issues/119357

Investigating: https://github.com/flutter/flutter/issues/138028
 2023-11-08 21:29:42 +00:00
gaaclarke
40a52fcc16 [Impeller] Documented the 2 step in the gaussian blur. (flutter/engine#47822) 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 21:10:47 +00:00
Jason Simmons
61f09f66a5 [Impeller] Create a global Vulkan instance in PlaygroundImplVK to prevent SwiftShader from being unloaded after a test completes (flutter/engine#47781) 
Libcxx is leaking a thread-local storage key each time SwiftShader is
loaded and unloaded. If a test's Vulkan instance is the only one in the
process, then SwiftShader will be unloaded after the test ends. If many
Vulkan playground tests run in a suite, then eventually the leak will
cause the process to exceed its limit of TLS keys and the suite will
fail.

The process can ensure that SwiftShader remains loaded by holding
another Vulkan instance that persists across all tests in the suite.

Fixes https://github.com/flutter/flutter/issues/138028
 2023-11-08 12:36:31 -08:00
auto-submit[bot]
01ff55b358 Reverts "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" (flutter/engine#47821) 
Reverts flutter/engine#47736
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/133793
 2023-11-08 20:35:25 +00:00
skia-flutter-autoroll
d7a5bcba01 Roll Skia from fb69e696dc45 to e2b8ebe16203 (4 revisions) (flutter/engine#47815) 
https://skia.googlesource.com/skia.git/+log/fb69e696dc45..e2b8ebe16203

2023-11-08 nicolettep@google.com [graphite] VulkanResourceProvider findOrCreate method improvements
2023-11-08 johnstiles@google.com Change resizing strategy for empty TArrays.
2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 969da898b476 to 6fff5ad7622c (1 revision)
2023-11-08 brianosman@google.com Remove rgf32 stages from RP

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 19:01:22 +00:00
Jim Graham
0080fdec3c [Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching (flutter/engine#47736) 
Fixes https://github.com/flutter/flutter/issues/133793
 2023-11-08 18:55:22 +00:00
Gray Mackall
81faa02060 Switch to Android 14 for physical device firebase tests (flutter/engine#47016) 
Switch to the latest android version for tests.

Device is high capacity, and [currently in use in flutter/flutter](dbb79e63eb/.ci.yaml (L451)). See [here](https://firebase.google.com/docs/test-lab/android/available-testing-devices) to get the list of devices.

Related to https://github.com/flutter/flutter/pull/136736

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 18:50:05 +00:00
Jonah Williams
3c6f5e10f2 [Impeller] remove capability to read from onscreen. (flutter/engine#47808) 
As discovered by @knopp in https://github.com/flutter/flutter/issues/131567#issuecomment-1678210475, this is actually reducing performance substantially when there are multiple blurs. In the case of https://github.com/flutter/flutter/issues/132735 , removing this capbility improves GPU performance from 400ms per frame to ~100 ms per frame.

Fixes https://github.com/flutter/flutter/issues/131567#issuecomment-1678210475

-----

  | Macrobench | Example App
-- | -- | --
TOT | 250 | 450
W/Out OnScreen | 203-187 | 125-109
W/Out Onscreen and Resolve | 203 | 125
 2023-11-08 18:38:59 +00:00
skia-flutter-autoroll
fa37b61785 Roll Skia from a4cce5236dcf to fb69e696dc45 (1 revision) (flutter/engine#47810) 
https://skia.googlesource.com/skia.git/+log/a4cce5236dcf..fb69e696dc45

2023-11-08 johnstiles@google.com Use STArray for SkMesh child array.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 17:49:03 +00:00
skia-flutter-autoroll
0e9c6facbb Roll Dart SDK from 15c286ed91ea to 14933042494d (5 revisions) (flutter/engine#47805) 
https://dart.googlesource.com/sdk.git/+log/15c286ed91ea..14933042494d

2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-107.0.dev
2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-106.0.dev
2023-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-105.0.dev
2023-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-104.0.dev
2023-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-103.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 17:39:56 +00:00
utzcoz
3382ab50ac Use targetSdkVersion 33 for Android platform AndroidManifest.xml (flutter/engine#47683) 
buildroot has switched to use 33 as default target sdk version.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 17:15:16 +00:00
Jim Graham
46235bbe4c [Impeller] Add EXPECT_OBJ_NEAR macros similar to the ASSERT_OBJ_NEAR versions (flutter/engine#47795) 
Fixes https://github.com/flutter/flutter/issues/137873

The `ASSERT_..._NEAR` macros are used in many places in the Impeller unit tests, but they are "fatal errors" in that they immediately exit the individual unit test. These versions allow testing expectations without ending the unit test early.
 2023-11-08 17:12:56 +00:00
Jonah Williams
5dd5cd253a [Impeller] null check drawable. (flutter/engine#47488) 
Speculative fix for the first crash noted in https://github.com/flutter/flutter/issues/136628#issue-1944779964

nextDrawble can return null if the method times out.

Fixes https://github.com/flutter/flutter/issues/136525
 2023-11-08 16:35:03 +00:00
skia-flutter-autoroll
43cb4100be Roll Skia from fce71a80b0a2 to a4cce5236dcf (1 revision) (flutter/engine#47807) 
https://skia.googlesource.com/skia.git/+log/fce71a80b0a2..a4cce5236dcf

2023-11-08 johnstiles@google.com Remove reference to skcms_internal.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 16:20:22 +00:00
Chris Bracken
c947cfce7e [macOS] Clean up resources in ViewController tests (flutter/engine#47792) 
Wraps all FlutterViewController tests in an autorelease pool to ensure
resources are cleaned up.

Adds a MockFlutterEngineTest subclass of AutoreleasePoolTest that
creates an OCPartialMock FlutterEngine and shuts it down at the end of
the test. Previously we were not shutting down any FlutterEngine
instances we allocated, resulting in potentially thousands of threads
and graphics contexts being allocated.

Prior to this change, running these tests via:

    ../out/host_debug_unopt_arm64/flutter_desktop_darwin_unittests \
        --gtest_filter='FlutterViewController.*' --gtest_repeat=1000

resulted in test failures and sometimes segfaults. This ensures
resources are cleaned up

Eventually all unit tests should configure their FlutterEngine via
either FlutterEngineTest (which should be an AutoreleasePoolTest) or
MockFlutterEngineTest, and the CreateMockFlutterEngine function moved to
a static used in the implementation of these.

Issue: https://github.com/flutter/flutter/issues/104789
Issue: https://github.com/flutter/flutter/issues/127441
Issue: https://github.com/flutter/flutter/issues/124840

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-07 23:50:31 -08:00
skia-flutter-autoroll
18ff9c4877 Roll Skia from f3d250126ba9 to fce71a80b0a2 (1 revision) (flutter/engine#47796) 
https://skia.googlesource.com/skia.git/+log/f3d250126ba9..fce71a80b0a2

2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0584ffd8fbdd to a494c1d6c813 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 07:20:21 +00:00
skia-flutter-autoroll
c23cf773b9 Roll Skia from b4fa927468e6 to f3d250126ba9 (1 revision) (flutter/engine#47793) 
https://skia.googlesource.com/skia.git/+log/b4fa927468e6..f3d250126ba9

2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5c95af798ba4 to 4a62a93e27d9 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 05:57:22 +00:00
Jim Graham
d04690cbe0 [Impeller] Add Rect::GetNormalizingTransform to handle UV coordinate conversion (flutter/engine#47775) 
Three places in the code were manually computing the UV coordinates relative to a texture coverage rectangle while also transforming the points. This change will make it easier both to compute the UV conversion matrix and also to consolidate it with the transform that was already being applied to streamline the total computations.
 2023-11-08 04:37:19 +00:00
auto-submit[bot]
2a216c6b9b Reverts "Remove Fuchsia Mac SDK from DEPS" (flutter/engine#47791) 
Reverts flutter/engine#47700
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Save infra capacity. Fuchsia commits 4 times a day, which can trigger a subsequent framework roll. Removing the Mac roller as it appears to be unused anymore.

Skia config is in https://skia-review.googlesource.com/c/skia-autoroll-internal-config/+/774657
 2023-11-08 04:32:25 +00:00
Yegor
1aecccf6c5 [web] fix clicks on merged semantic nodes (attempt #2) (flutter/engine#47360) 
This relands https://github.com/flutter/engine/pull/43620 with a fix for nested tappable nodes. The first PR introduced this regression: https://github.com/flutter/flutter/issues/134842.

This PR includes the original PR and a fix for the regression. The fix is to call `stopPropagation` on the "click" event so that it is not handled by the ancestor if the child has already decided to send a `SemanticsAction.tap` to the framework. This ensures that there cannot be more than one `SemanticsAction.tap` sent to the framework.

Fixes https://github.com/flutter/flutter/issues/134842
 2023-11-08 04:23:05 +00:00
skia-flutter-autoroll
37d07dd14e Roll Skia from 0f78e5f765d3 to b4fa927468e6 (1 revision) (flutter/engine#47788) 
https://skia.googlesource.com/skia.git/+log/0f78e5f765d3..b4fa927468e6

2023-11-08 sunnyps@chromium.org graphite: Fixes for enabling storage buffers for Dawn backend

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 03:19:12 +00:00
skia-flutter-autoroll
3e36a5d428 Roll Fuchsia Linux SDK from VcFEJiUUTYwkhEAlJ... to sD8HRA4JmXczujkqO... (flutter/engine#47785) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-08 02:40:23 +00:00
Jia Hao
2156a17b9a Fix narrowing conversion lint (flutter/engine#47740) 
Internally we have a lint that surfaces this as a warning. Googlers, please refer to go/al-rule/NarrowingConversion.

Related: b/309552840

When we do:
```
coords.toolMajor = (float) (double) coordsList.get(3) * density;
```

`coordsList.get(3)` is casted to a `double`, then a `float`, before the multiplication happens. 

I don't think this is intentional. The intention of the code here seems to be:

- Cast to a `double`: `coordsList` is a `List<Object>` so the cast narrows the value
- Cast to a `float`: To fit the resulting value into [`coords.toolMajor`](https://developer.android.com/reference/android/view/MotionEvent.PointerCoords#toolMajor), which is a `float`.

As such, add parenthesis to address this.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-08 01:41:25 +00:00
Chris Bracken
7a923cd1d9 [macOS] Bail out of tests if engine not running (flutter/engine#47771) 
In engine tests where we require a running engine to proceed with the
test, immediately fail if the engine isn't running rather than carrying
on with the test. In most cases, the fixture test proceeds to block the
main thread on a latch until it's released from the UI thread, so this
results in quicker test failures.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-07 17:27:14 -08:00