engine-flutter-autoroll
1a76859cd6
Roll Packages from b9718302b30f to 5c6991400e91 (5 revisions) ( #127034 )
...
b9718302b3...5c6991400eflutter/packages#3770 )
2023-05-17 JeroenWeener@users.noreply.github.com [in_app_purchase] Fully migrate to BillingClient V5 (flutter/packages#3752 )
2023-05-17 stuartmorgan@google.com [ci] Re-enable Windows repo tool tests (flutter/packages#4007 )
2023-05-16 stuartmorgan@google.com [ci] Allow simctl shutdown to fail (flutter/packages#4024 )
2023-05-16 stuartmorgan@google.com [ci] Move Linux repo tool tests to LUCI (flutter/packages#4006 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 16:12:53 +00:00
engine-flutter-autoroll
05390851c9
Roll Flutter Engine from ea3f27383acc to 6048360c1837 (2 revisions) ( #127032 )
...
ea3f27383a...6048360c18skia-flutter-autoroll@skia.org Roll Skia from 88d7a68694d9 to c3473c32bb35 (2 revisions) (flutter/engine#42093 )
2023-05-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 2fc9f4dd9623 to 7f6fabbe9fba (1 revision) (flutter/engine#42090 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 16:11:33 +00:00
Taha Tesser
160618b103
Add missing Switch.onFocusChange test ( #126685 )
2023-05-17 08:36:24 -07:00
joshualitt
d021109d93
Remove 'url_launcher' from pubspec.yaml. ( #126939 )
2023-05-17 08:31:37 -07:00
engine-flutter-autoroll
e2aafd4554
Roll Flutter Engine from 4b7c37532ea4 to ea3f27383acc (1 revision) ( #126994 )
...
4b7c37532e...ea3f27383askia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
D_EOM3rJ8AMk3-Wex... to YrEDYUB9NKhirgo5s... (flutter/engine#42086 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from D_EOM3rJ8AMk to YrEDYUB9NKhi
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 07:37:22 -07:00
engine-flutter-autoroll
45e3039a45
Roll Flutter Engine from 170b45bae571 to 4b7c37532ea4 (1 revision) ( #126985 )
...
170b45bae5...4b7c37532eskia-flutter-autoroll@skia.org Roll Dart SDK from dbbb8a6d79a3 to 2fc9f4dd9623 (1 revision) (flutter/engine#42085 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 04:56:25 +00:00
engine-flutter-autoroll
4be65314d5
Roll Flutter Engine from 28b9dc993c30 to 170b45bae571 (1 revision) ( #126981 )
...
28b9dc993c...170b45bae5skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from N4LwCRxg0oIevhQ_O... to dIATtSiPf8KE25MMF... (flutter/engine#42084 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from N4LwCRxg0oIe to dIATtSiPf8KE
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 04:02:29 +00:00
engine-flutter-autoroll
abdf1f463f
Roll Flutter Engine from 87a03e107df7 to 28b9dc993c30 (1 revision) ( #126974 )
...
87a03e107d...28b9dc993cskia-flutter-autoroll@skia.org Roll Dart SDK from d2b2ac829842 to dbbb8a6d79a3 (3 revisions) (flutter/engine#42082 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 01:55:17 +00:00
engine-flutter-autoroll
790897c6a2
Roll Flutter Engine from 1c775e34e2d5 to 87a03e107df7 (3 revisions) ( #126968 )
...
1c775e34e2...87a03e107dbdero@google.com [Impeller] Use 32 bit Gaussian function in the 2-pass blur (flutter/engine#42069 )
2023-05-16 skia-flutter-autoroll@skia.org Roll Skia from 9b0e912a1cb9 to 88d7a68694d9 (13 revisions) (flutter/engine#42081 )
2023-05-16 jacksongardner@google.com Use client ICU data with skwasm. (flutter/engine#42018 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 00:56:41 +00:00
Sigurd Meldgaard
788ceb34a3
Fix style issues ( #122586 )
...
Follow-up to https://github.com/flutter/flutter/pull/121802 resolving some style issues.
2023-05-16 23:56:21 +00:00
engine-flutter-autoroll
5df903a013
Manual roll Flutter Engine from fe2476743b59 to 1c775e34e2d5 (10 revisions) ( #126961 )
...
Manual roll requested by zra@google.com
fe2476743b...1c775e34e2zanderso@users.noreply.github.com Revert "[ios_platform_view]
only recycle maskView when the view is applying mutators"
(flutter/engine#42080 )
2023-05-16 gspencergoog@users.noreply.github.com [macOS] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41753 )
2023-05-16 gspencergoog@users.noreply.github.com [linux] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41782 )
2023-05-16 jacksongardner@google.com Initial support for images in
Skwasm (flutter/engine#42019 )
2023-05-16 jacksongardner@google.com Use new `unresolvedCodePoints` API
from skia. (flutter/engine#41991 )
2023-05-16 jason-simmons@users.noreply.github.com Convert public API
NativeFieldWrapper classes to abstract interfaces (flutter/engine#41945 )
2023-05-16 737941+loic-sharma@users.noreply.github.com [Windows] Add
force redraw to the C++ client wrapper (flutter/engine#42061 )
2023-05-16 godofredoc@google.com Fix drone_dimension
host_engine_builder. (flutter/engine#42068 )
2023-05-16 godofredoc@google.com Add linux_clang_tidy builder.
(flutter/engine#41990 )
2023-05-16 ychris@google.com [ios_platform_view] only recycle maskView
when the view is applying mutators (flutter/engine#41573 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 16:00:08 -07:00
Ian Hickson
027bb84444
Make SlottedMultiChildRenderObjectWidgetMixin a concrete class ( #126108 )
...
This is a proof of concept for renaming SlottedMultiChildRenderObjectWidgetMixin to SlottedMultiChildRenderObjectWidget and making it a concrete class.
I also made SlottedContainerRenderObjectMixin generic instead of being specialized to RenderBox.
I don't think this is something we can easily automigrate, but we may not need to, I don't know how common this is...
2023-05-16 22:28:54 +00:00
Ian Hickson
5235a0f092
Add ScrollMetrics.extentTotal for completeness ( #126607 )
...
When implementing scrollbars, I found that it would be useful and idiomatic to be able to do `m.extentInside / m.extentTotal` to get the scrollbar thumb size.
2023-05-16 22:24:03 +00:00
godofredoc
25a9efe994
Fix drone_dimensions. ( #126953 )
...
Use drone_dimensions instead of dimensions for builds running on dart-internal. This is required for those builders to select the correct drone type.
2023-05-16 22:11:21 +00:00
Mitchell Goodwin
678f40cf04
Add checkmark style to CupertinoRadio ( #126480 )
...
Fixes : #102813
Adds a checkmark style to the Cupertino Radio. Also allows the Radio.adaptive and RadioListTile.adaptive widgets to control whether they use the checkmark style for their Cupertino widgets or not.
This is how it looks in action:
https://github.com/flutter/flutter/assets/58190796/b409b270-42dd-404a-9350-d2c3e1d7fa4e
2023-05-16 21:54:20 +00:00
keyonghan
3f01c7e019
Move Mac_build_test flutter_gallery__transition_perf_e2e_ios to prod ( #126941 )
...
Target `Mac_build_test flutter_gallery__transition_perf_e2e_ios` was enabled in staging: https://github.com/flutter/flutter/pull/111164 , and it has passed more than 50 runs: https://ci.chromium.org/p/flutter/builders/staging/Mac_build_test%20flutter_gallery__transition_perf_e2e_ios?limit=50 .
Manually enabling it in prod and removing the old `Mac_ios flutter_gallery__transition_perf_e2e_ios`.
The `Mac_build_test` one does the same thing as `Mac_ios` one, but separating build and test steps in separate targets.
Context: https://github.com/flutter/flutter/issues/103542
2023-05-16 21:46:06 +00:00
Jason Simmons
e24c64d8ee
Fix DataTableThemeData.copyWith handling of dataRowHeight ( #126943 )
...
Fixes https://github.com/flutter/flutter/issues/126676
2023-05-16 21:44:24 +00:00
Mushaheed Syed
60751ca519
Fix copyWith method of ActionIconThemeData ( #126763 )
...
Fixes copyWith method of ActionIconThemeData, now using blank copyWith on [ActionIconThemeData] object that isn't `const ActionIconThemeData()` returns object with same values.
*List which issues are fixed by this PR.*
Fixes https://github.com/flutter/flutter/issues/126762
2023-05-16 21:38:23 +00:00
Zachary Anderson
99464341f0
Revert "Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions)" ( #126954 )
...
Reverts flutter/flutter#126934
Bad Engine roll.
2023-05-16 21:30:53 +00:00
engine-flutter-autoroll
d0d1feb628
Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions) ( #126934 )
...
fe2476743b...5cf141f7c0godofredoc@google.com Add linux_clang_tidy builder. (flutter/engine#41990 )
2023-05-16 ychris@google.com [ios_platform_view] only recycle maskView when the view is applying mutators (flutter/engine#41573 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 18:44:41 +00:00
Michael Goderbauer
1ca183d55b
Remove outdated comment ( #126927 )
...
Follow-up to https://github.com/flutter/flutter/pull/126647#discussion_r1195417860 .
2023-05-16 17:39:12 +00:00
yaakovschectman
130944e785
Alert engine upon registering ServiceBinding ( #126075 )
...
Send a platform message to the engine when the `ServiceBinding` is
registered. Framework side of
https://github.com/flutter/engine/pull/41733
Addresses https://github.com/flutter/flutter/issues/126033
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com >
2023-05-16 13:37:12 -04:00
engine-flutter-autoroll
cc44359bd0
Roll Flutter Engine from 525a53eb58ed to fe2476743b59 (1 revision) ( #126925 )
...
525a53eb58...fe2476743bskia-flutter-autoroll@skia.org Roll Skia from 24bebce2d9a1 to 9b0e912a1cb9 (12 revisions) (flutter/engine#42072 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 17:02:28 +00:00
Victoria Ashworth
2b3cd7f4d9
Replace rsync when unzipping artifacts on a Mac ( #126703 )
...
Instead of using rsync, which has caused errors in the past (https://github.com/flutter/flutter/issues/99785 ), delete the file/directory/link prior to moving it.
Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files
Part of https://github.com/flutter/flutter/issues/126016 .
2023-05-16 16:58:06 +00:00
Jason Simmons
a3b38aa8f3
Update SemanticsUpdateBuilderSpy for the conversion of SemanticsUpdateBuilder into a base class ( #126570 )
...
See https://github.com/flutter/flutter/issues/123756
2023-05-16 16:41:11 +00:00
st merlhin
6753a852d0
expose CupertinoDatePicker and CupertinoTimerPicker itemExtent … ( #125852 )
...
â¦property
This PR expose `CupertinoDatePicker` and `CupertinoTimerPicker` `itemExtent` property to allow setting custom one depending on `tMediaQuery.of(context).textScaleFactor`.
Fixes : #125127
2023-05-16 16:30:08 +00:00
engine-flutter-autoroll
856fcc304a
Roll Flutter Engine from d7a5de672d1e to 525a53eb58ed (1 revision) ( #126923 )
...
d7a5de672d...525a53eb58skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
38Oyy28qgYCdt7fEV... to D_EOM3rJ8AMk3-Wex... (flutter/engine#42071 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 38Oyy28qgYCd to D_EOM3rJ8AMk
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 09:22:05 -07:00
Michael Goderbauer
5e1ba701ed
enable no_literal_bool_comparisons lint ( #126647 )
2023-05-16 16:14:23 +00:00
engine-flutter-autoroll
b45f9b36e8
Roll Packages from 6608b604b0e7 to b9718302b30f (2 revisions) ( #126921 )
...
6608b604b0...b9718302b3stuartmorgan@google.com [camera] Fix Android lint issues (flutter/packages#3993 )
2023-05-15 stuartmorgan@google.com [various] Update min macOS versions (flutter/packages#3987 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 15:51:46 +00:00
Taha Tesser
2f5ed33912
Updated the Drawer API doc to link to NavigationDrawer ( #126915 )
...
fixes https://github.com/flutter/flutter/issues/124887
2023-05-16 15:45:09 +00:00
engine-flutter-autoroll
e62e5c4191
Roll Flutter Engine from c4d4b40c6596 to d7a5de672d1e (4 revisions) ( #126919 )
...
c4d4b40c65...d7a5de672dskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JCoP2Fekj3MBIqskE... to N4LwCRxg0oIevhQ_O... (flutter/engine#42070 )
2023-05-16 zhangzhijian.123@bytedance.com [Impeller] Fix issue about
saveLayer ignoring opacity of paint with advanced blend mode
(flutter/engine#41972 )
2023-05-16 ychris@google.com [ios_platform_view] Only remove platform
views from flutter view in reset. (flutter/engine#41709 )
2023-05-16 godofredoc@google.com Add drone_dimensions as top level
target property. (flutter/engine#42064 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JCoP2Fekj3MB to N4LwCRxg0oIe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 08:13:28 -07:00
Polina Cherkasova
ea5eddb5a9
Upgrade leak_tracker to 5.0.0 ( #126367 )
...
Fixes https://github.com/flutter/flutter/issues/126259
Updated pubspec:
345f0bffbf/packages/flutter/pubspec.yaml
2023-05-16 04:39:26 +00:00
Ian Hickson
2919572fb3
Minor documentation fixes ( #126609 )
...
Fixes for grammar, tone, and clarity.
2023-05-16 02:01:28 +00:00
engine-flutter-autoroll
6b6c4bdb6b
Roll Flutter Engine from 027ca797985f to c4d4b40c6596 (6 revisions) ( #126894 )
...
027ca79798...c4d4b40c65ychris@google.com Fix upload xcresult script in run_tests.py (flutter/engine#42056 )
2023-05-15 jonahwilliams@google.com [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054 )
2023-05-15 skia-flutter-autoroll@skia.org Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058 )
2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057 )
2023-05-15 bdero@google.com [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055 )
2023-05-15 jacksongardner@google.com Compile skwasm at -Oz. (flutter/engine#42002 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-16 01:05:42 +00:00
gaaclarke
6380075503
Adds drawn image wide gamut test ( #126715 )
...
integration test for https://github.com/flutter/engine/pull/41994
issue https://github.com/flutter/flutter/issues/126620
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-15 15:54:22 -07:00
gmackall
cec4f9c06e
Change testowners for deferred_components_test and android_views ( #126872 )
...
Changing to make @gmackall the owner of these tests.
@reidbaker or @camsim99 let me know if either of you would prefer to take over, but I see both of you are already owners of some of these tests and I'm happy to take these ones on (I've already spent a little time looking into how they work for the ongoing debug signing key flake).
2023-05-15 22:11:17 +00:00
engine-flutter-autoroll
87b2ac5cff
Roll Flutter Engine from 00f20fbab038 to 027ca797985f (5 revisions) ( #126876 )
...
00f20fbab0...027ca79798godofredoc@google.com Use release_build and os dimension consistently. (flutter/engine#42012 )
2023-05-15 bdero@google.com [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031 )
2023-05-15 bdero@google.com [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039 )
2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051 )
2023-05-15 ychris@google.com Upload xcresults to LUCI cloud storage (flutter/engine#41647 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 21:44:07 +00:00
Kate Lovett
27caa7fed9
Add ScrollController.onAttach & onDetach, samples/docs on listening/getting scrolling info ( #124823 )
...
This PR does a couple of things!
https://user-images.githubusercontent.com/16964204/231897483-416287f9-50ce-468d-a714-2a4bc0f2e011.mov
Fixes #20819
Fixes #41910
Fixes #121419
### Adds ScrollController.onAttach and ScrollController.onDetach
This resolves a long held pain point for developers. When using a scroll controller, there is not scroll position until the scrollable widget is built, and almost all methods of notification are only triggered when scrolling happens. Adding these two methods will help developers gain access to the scroll position when it is created. A common workaround for this was using a post frame callback to access controller.position after the first frame, but this is ripe for issues such as having multiple positions attached to the controller, or the scrollable no longer existing after that post frame callback. I think this can also be helpful for folks to debug cases when the scroll controller has multiple positions attached.
In particular, this also resolves this commented case: https://github.com/flutter/flutter/issues/20819#issuecomment-417784218
The isScrollingNotifier is hard for developers to access.
### Docs & samples
I was surprised we did not have samples on scroll notification or scroll controller, so I overhauled it and added a lot of docs on all the different ways to access scrolling information, when it is available and how they differ.
2023-05-15 21:01:06 +00:00
engine-flutter-autoroll
dda7d28d25
Roll Flutter Engine from dffc480a2bbf to 00f20fbab038 (1 revision) ( #126871 )
...
dffc480a2b...00f20fbab030870216+gaaclarke@users.noreply.github.com Include SkRect in rtree. (flutter/engine#42050 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 20:47:09 +00:00
Kate Lovett
76a9f68325
Add more to error message of RestorationScope.of ( #126444 )
...
Fixes https://github.com/flutter/flutter/issues/126443
2023-05-15 19:17:11 +00:00
Jonah Williams
41abe998ee
[devicelab] add drawPoints benchmark ( #126728 )
...
Add a benchmark that measures the improvements from https://github.com/flutter/engine/pull/41803
2023-05-15 19:14:58 +00:00
Zachary Anderson
674b1ad0ae
Remove obsolete iOS benchmark ( #126862 )
...
Fixes https://github.com/flutter/flutter/issues/126861
2023-05-15 19:12:56 +00:00
engine-flutter-autoroll
96580f5017
Roll Packages from 6328cfbd2a46 to 6608b604b0e7 (22 revisions) ( #126865 )
...
6328cfbd2a...6608b604b0stuartmorgan@google.com [ci] Remove unnecessary Linux libraries (flutter/packages#3975 )
2023-05-15 stuartmorgan@google.com [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979 )
2023-05-15 stuartmorgan@google.com [ci] Disable Windows repo tool tests (flutter/packages#3980 )
2023-05-12 stuartmorgan@google.com [ci] Add LUCI repo tool tests (flutter/packages#3964 )
2023-05-12 reidbaker@google.com [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973 )
2023-05-12 reidbaker@google.com Update build.gradle with a comment explaining version (flutter/packages#3972 )
2023-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 8c5a1ea728a76dbe44b9flutter/packages#3958 )
2023-05-12 stuartmorgan@google.com [image_picker] Fix Android lints (flutter/packages#3887 )
2023-05-12 stuartmorgan@google.com [various] Update minimum Flutter version to 3.3 (flutter/packages#3967 )
2023-05-12 stuartmorgan@google.com [tool] Target specific Android unit tests (flutter/packages#3955 )
2023-05-12 34871572+gmackall@users.noreply.github.com [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960 )
2023-05-12 stuartmorgan@google.com [local_auth] Improve iOS test DI (flutter/packages#3959 )
2023-05-12 stuartmorgan@google.com [ci] Ensure scripts fail if a command fails (flutter/packages#3963 )
2023-05-11 stuartmorgan@google.com [ci] Pin the Flutter version for `release` (flutter/packages#3965 )
2023-05-11 tarrinneal@gmail.com [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784 )
2023-05-11 stuartmorgan@google.com [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969 )
2023-05-11 stuartmorgan@google.com [tool] Ensure that publish credential path is available (flutter/packages#3970 )
2023-05-11 63286031+ahmednfwela@users.noreply.github.com [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877 )
2023-05-11 stuartmorgan@google.com [tool] Use new pub cache location for publish (flutter/packages#3962 )
2023-05-10 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f72efea43c30 to 84a1e904f44f (1920 revisions) (flutter/packages#3961 )
2023-05-10 andrelvsousa@gmail.com [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423 )
2023-05-10 43054281+camsim99@users.noreply.github.com [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 19:11:07 +00:00
engine-flutter-autoroll
0526e94028
Roll Flutter Engine from f074fd3b2d7f to dffc480a2bbf (2 revisions) ( #126863 )
...
f074fd3b2d...dffc480a2b30870216+gaaclarke@users.noreply.github.com [Impeller] switches the wide gamut surface to f16 (flutter/engine#41994 )
2023-05-15 kjlubick@users.noreply.github.com Migrate uses of SkSurface factories (flutter/engine#41978 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 18:56:49 +00:00
Reid Baker
159ebf736a
Mark no longer flakey tests as bringup:false ( #126281 )
...
This is a result of auditing the ci.yaml tests marked as bringup true and determining which ones were still flakey.
Each commit markes one tests as non flakey along with a link of proof of the lack of flakes.
- Mark new_gallery_impeller__transition_perf as not flakey, #124699 closed, not recent flakes
- No failures in 500 runs for Staging_build_linux analyze https://ci.chromium.org/p/flutter/builders/staging/Staging_build_linux%20analyze\?cursor\=id%3E8782771663962116337\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Linux%20flutter_packaging_test\?cursor\=id%3E8787892377160059793\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Mac%20flutter_packaging_test\?cursor\=id%3E8787870631931126673\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64%20flutter_packaging_test\?cursor\=id%3E8787809799161254193\&limit\=200
#124699 is the only closed bug that was linked for a test that is no longer flakey. Closed status helps the case that flakes are no longer an issue.
2023-05-15 18:12:52 +00:00
Reid Baker
c5b31e7f1e
Revert "i125138 abstract method smoke agp update ( #125139 )" ( #126274 )
...
This reverts commit 64591356b9#125331
https://ci.chromium.org/p/flutter/builders/staging/Linux%20firebase_abstract_method_smoke_test?cursor=id%3E8783275059678311409&limit=200
- [ x I signed the [CLA].
2023-05-15 18:00:07 +00:00
stuartmorgan
d3c3dde1b6
Remove duplicate plugin tests ( #126582 )
...
Removes two plugin tests that aren't actually doing anything useful.
When they were added they were testing v2-embedding plugins in a v1-embedding app, but support for creating v1-embedding apps--and the environment variable that these tests were using to, in theory, trigger them--was removed several years ago in #61203 . That means that these tests are in practice exact duplicates of the copies just above without the ennvironment variables.
Fixes https://github.com/flutter/flutter/issues/122200
2023-05-15 17:55:55 +00:00
Victoria Ashworth
5d1132561f
Add debugging for Dart VM timeout flake ( #126437 )
...
Check what is available in the device's iOS DeviceSupport folder to check if symbols were properly fetched. Also, add some logging to track what status the debugger is in.
Debugging for https://github.com/flutter/flutter/issues/121231 .
2023-05-15 17:51:05 +00:00
engine-flutter-autoroll
0636f5e035
Roll Flutter Engine from 7bd748207171 to f074fd3b2d7f (2 revisions) ( #126852 )
...
7bd7482071...f074fd3b2dskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from A3thcPNgxVcKzR-da... to JCoP2Fekj3MBIqskE... (flutter/engine#42041 )
2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from c777d54743e1 to c302a0252785 (1 revision) (flutter/engine#42040 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from A3thcPNgxVcK to JCoP2Fekj3MB
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-15 17:46:14 +00:00
gaaclarke
658a1a256a
Adds support for f16 surfaces to wide gamut unit tests. ( #126712 )
...
issue: https://github.com/flutter/flutter/issues/126620
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-15 10:25:03 -07:00
