Brandon DeRosier
1a753d8ca2
[Impeller] Add debug captures and inspector. ( flutter/engine#43764 )
...
Weekend project! Press `C` to capture in the Aiks playground.
Decided to finally give this a go and attempt to relieve some of the print debugging/mindfuck around investigation of coverage-related issues lately. :)
Captures:
* Capture documents from anywhere in Impeller.
* Easily implement inspectors for those documents.
* Replay documents with live editing.
* No overhead when capturing is build time disabled (that's the idea, anyway).
* Low overhead when capturing is runtime disabled.
Aiks inspector:
* Outline passes and rendered entities.
* Identify collapsed passes.
* Visibly highlight coverage.
* Live edit scene properties.
Possible future work:
* Filters!
* Blend mode property.
* Pointer + release proc property.
* Support captures in the DL playground.
* Text atlas visualization.
* Multi-frame capture and scrubbing.
* Menus instead of key bindings?
https://github.com/flutter/engine/assets/919017/a7a63e24-f72f-4140-a21e-6ca02a05fc20
2023-08-24 02:02:06 +00:00
skia-flutter-autoroll
7d82b4742d
Roll Skia from e3ee267859a7 to 02eecda395ba (1 revision) ( flutter/engine#45042 )
...
https://skia.googlesource.com/skia.git/+log/e3ee267859a7..02eecda395ba
2023-08-24 michaelludwig@google.com [skif] Update Blur imagefilter to use new bounds APIs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-24 01:52:04 +00:00
Jason Simmons
bdc7ac47a4
Remove a clang-tidy test that launches a full run of clang-tidy ( flutter/engine#45033 )
...
This can take a lot of time or be overly dependent on configuration details of the local git repository.
2023-08-24 01:24:26 +00:00
skia-flutter-autoroll
d3a13deb0a
Roll Skia from 9d4db3443527 to e3ee267859a7 (1 revision) ( flutter/engine#45036 )
...
https://skia.googlesource.com/skia.git/+log/9d4db3443527..e3ee267859a7
2023-08-23 brianosman@google.com Revert "Disable Graphite SkSL tests on Linux in Release."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-24 01:10:37 +00:00
Dan Field
23f05787e0
[Impeller] Fix stencil buffer format selection on Vulkan backend, add support for D24UnormS8Uint ( flutter/engine#45025 )
...
Vulkan was checking for D24 and using D32. This is part of the problem on the Samsung A02. There is still some other problem.
Fixes https://github.com/flutter/flutter/issues/133188
2023-08-24 01:09:47 +00:00
Jason Simmons
b282036ee6
Fix a clang-tidy error seen in the latest toolchain roll ( flutter/engine#45039 )
2023-08-23 17:34:52 -07:00
skia-flutter-autoroll
91f6db88b9
Roll Skia from a631fefdba37 to 9d4db3443527 (1 revision) ( flutter/engine#45031 )
...
https://skia.googlesource.com/skia.git/+log/a631fefdba37..9d4db3443527
2023-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5cfecc8eccdb to 16e38af9947d (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 22:55:02 +00:00
Zachary Anderson
774441e2c2
Roll clang with fix for ABI change ( flutter/engine#44711 )
...
In the change here b653a2823fb653a2823f/compiler-rt/lib/builtins/os_version_check.c (L89)f9ac557567/compiler-rt/lib/builtins/os_version_check.c (L97)https://github.com/flutter/flutter/issues/132130
2023-08-23 22:37:03 +00:00
Jonah Williams
90acd88d7e
[Impeller] combine uniform metadata and buffer slots. ( flutter/engine#45021 )
...
Follow up from https://github.com/flutter/engine/pull/44990
We're spending a ton of time deallocating mostly empty maps, by reducing the number of maps we reduce the amount of memory used, and reduce map lookups.
2023-08-23 22:18:47 +00:00
skia-flutter-autoroll
acd4195c2a
Roll Skia from 76898dad9fda to a631fefdba37 (2 revisions) ( flutter/engine#45027 )
...
https://skia.googlesource.com/skia.git/+log/76898dad9fda..a631fefdba37
2023-08-23 johnstiles@google.com Disable Graphite SkSL tests on Linux in Release.
2023-08-23 herb@google.com Implement and document intersection
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 22:09:03 +00:00
Zachary Anderson
ad1a04dea2
Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" ( flutter/engine#45023 )
...
Reverts flutter/engine#44996
Analysis failures on rolling to the framework
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62884/overview
2023-08-23 14:36:08 -07:00
Brandon DeRosier
87e5da3ff4
[Impeller] Dat rvalue reference (fix engine head) ( flutter/engine#45024 )
...
Not sure why we didn't catch this on presubmits. I think there was a
merge order problem.
2023-08-23 13:39:01 -07:00
Brandon DeRosier
cf500170ce
Revert "Enable clang-tidy for pre-push (opt-out), exclude performance-unnecessary-value-param" ( flutter/engine#45020 )
...
Reverts flutter/engine#44936
2023-08-23 20:17:13 +00:00
skia-flutter-autoroll
ce517f3b2a
Roll Skia from 4e42b51cfe27 to 76898dad9fda (1 revision) ( flutter/engine#45019 )
...
https://skia.googlesource.com/skia.git/+log/4e42b51cfe27..76898dad9fda
2023-08-23 robertphillips@google.com Add unit test for bitmap-backed SkImage cache key extraction
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 20:10:00 +00:00
Brandon DeRosier
e5c4a38d8b
[Impeller] Add STB text backend. ( flutter/engine#44887 )
...
Pull the STB text backend into the engine from impeller-cmake.
2023-08-23 13:06:50 -07:00
Reid Baker
5b4a05fa89
Followup to https://github.com/flutter/engine/pull/44982 ( flutter/engine#45018 )
...
One change was missing from https://github.com/flutter/engine/pull/44982 when I applied auto submit.
2023-08-23 20:04:17 +00:00
skia-flutter-autoroll
b8ff2574a3
Roll Skia from 5428f147e632 to 4e42b51cfe27 (4 revisions) ( flutter/engine#45016 )
...
https://skia.googlesource.com/skia.git/+log/5428f147e632..4e42b51cfe27
2023-08-23 robertphillips@google.com Add cache key value extraction for LazyPicture Images
2023-08-23 bungeman@google.com Update DWriteCore to 1.4-preview2
2023-08-23 brianosman@google.com Add placeholder GrVkBackendSurface.h
2023-08-23 robertphillips@google.com Add SkImage_Picture::replay method
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 19:33:04 +00:00
Reid Baker
c9b1f6d63c
Eliminate android test log spam ( flutter/engine#44982 )
...
Set gradle to treat warnings as errors and suppress or fix all warnings in engine android tests.
Fixes flutter/flutter/133070
After doing this work I was disappointed to realized that the only lint turned on was deprecration but this is still a step in the right direction.
- Remove usages of deprecated junit.framework and replace with org.junit in KeyboardManagerTest, PlatformViewsControllerTest and SinglePresentationViewTest
- Annotate deprecated usages of Registrar
- Suppress warnings for getSystemWindowInsets and ensure roboletric config consistant with targetApi lint annotation, bump itDescribesTextFieldsWithTextAndHint to 28 because test actually fails on api 26
- Suppress warnings for DartExecutor.send
- Suppress warnings for ClipboardManager.set/hasText
- Suppress warnings for getWindowSystemUiVisibility, setMessageHandler, DartExecutor.send, InputMethodSubtype, and proof of concept migration from Roboletric.setupActivity
- Suppress deprecation warnings, set minsdk on tests that were checking for sdk version
- Suppress deprecation warnings in SpellCheckPluginTest
- Suppress deprecation warnings in MouseCursorPluginTest, set minsdk config to match target api
- Stop calling RuntimeEnvrionment.application and insted a call ApplicationProvider.getApplicationContext() in SingleViewPresentationTest
- Start calling FlutterView(Context, FlutterSurfaceView)
- Suppress deprecation warnings in PlatformPluginTest, getText, Robolectric.setup/buildActivity, system ui flags
- Suppress deprecation warnings in PlayStoreDeferredComponentManagerTest
- Suppress deprecation warnings in KeyboardChannelTest
- Suppress deprecation warnings in SettingsChannelTest
- Suppress deprecation warnings in ApplicationInfoLoaderTest
- Stop calling RuntimeEnvrionment.application and insted a call ApplicationProvider.getApplicationContext() in FlutterEngineGroupCacheTest
- Suppress deprecation warnings in FlutterAndroidComponentTest
- Suppress deprecation warnings in FlutterFragmentTest, more robolectric setup activity calls
- Suppress deprecation warnings in FlutterActivityAndFragmentDelegateTest
- Shadow.directlyOn is incompatible with java 17+, refactor to use reflectors and direct following https://github.com/robolectric/robolectric/pull/6598/files as an example Unsure if SplashShadowResources is used anywhere
- Enable warnings as errors
- Formatting
2023-08-23 19:22:04 +00:00
Mouad Debbar
8dfbed3af4
[web] Remove some unused functions ( flutter/engine#44505 )
2023-08-23 19:18:54 +00:00
Michael Ludwig
9cec508891
Use decal TileMode in blur image_filter_test.dart ( flutter/engine#45004 )
...
The expected color values appear to match the output of Skia's raster
backend's blur. Historically, that doesn't support any tile mode other
than decal, so while the `makeBlur()` function defaulted to clamp
tiling, the output was decal and thus showed the blur fading to
transparent.
The test draws a 1x1 green rectangle in the center of a 3x3 image. Clamp
tiling would actually cause the output of the blur to just copy the
central green color to the remaining 8 pixels. This is the output of
Skia's GPU blur. I am working to land changes in Skia that make the
raster backend handle all tile modes, which then has it match the
existing GPU blur's behavior of a constant output for clamp tiling in
this test (so it then fails).
Decal tiling appears to be more useful for this test case anyways
because it creates per-pixel variations that can be validated against.
This is needed to land Skia-side fixes for skbug.com/40039877 and
skbug.com/40039025
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-23 14:32:50 -04:00
Ian Hickson
190343a2bb
FontVariation.lerp, custom FontVariation constructors, and more documentation ( flutter/engine#44996 )
...
This should aid with implementing the framework side of https://github.com/flutter/flutter/issues/105120 .
This should also address https://github.com/flutter/flutter/issues/28543 .
This is a reland of https://github.com/flutter/engine/pull/43750 with two changes, one to fix a typo mentioned in https://github.com/flutter/engine/pull/43750#issuecomment-1689299114 , and one to fix the analysis error found when rolling this to the framework (https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62845/overview ). The latter change is temporary and can be relaxed when FontVariations is reexported from dart:ui. I plan to do that when fixing https://github.com/flutter/flutter/issues/105120 .
2023-08-23 18:05:53 +00:00
Jonah Williams
def71edad1
[impeller] combine sampler and texture maps. ( flutter/engine#44990 )
...
Simplify command encoding and reduce binding size by placing all texture/sampler data in a single map instead of 3. We don't currently (nor do we plan to) support separate textures and samplers.
The vulkan backend is particularly bad, because there are 3 map lookups to pull all of the texture and sampler data out of the bindings.
Also see [go/impeller-vulkan-cmd-recording-performance](http://goto.google.com/impeller-vulkan-cmd-recording-performance )
2023-08-23 17:13:46 +00:00
Brandon DeRosier
1c861eb04f
[Impeller] Flutter GPU: Add HostBuffer. ( flutter/engine#44696 )
...
Resolves https://github.com/flutter/flutter/issues/132516 .
Add `impeller::HostBuffer` wrapper to Flutter GPU.
* Allows for lazy batch uploads of sparse host data to the GPU.
* Handles platform alignment requirements.
* API returns buffer view handles that will be fed to commands.
2023-08-23 10:09:01 -07:00
skia-flutter-autoroll
1737bdc79b
Roll Skia from 2111e8126c08 to 5428f147e632 (2 revisions) ( flutter/engine#45008 )
...
https://skia.googlesource.com/skia.git/+log/2111e8126c08..5428f147e632
2023-08-23 robertphillips@google.com Make SkImage_Picture::props() thread-safe
2023-08-23 johnstiles@google.com Remove unused dehydrated-SkSL file.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 16:21:56 +00:00
skia-flutter-autoroll
fc5f1c940e
Roll Fuchsia Mac SDK from DoQ8KUxSk-5EU6VQ1... to vJ6oaubpqgRM2nb1e... ( flutter/engine#45005 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 15:38:03 +00:00
skia-flutter-autoroll
26d5ab855a
Roll Skia from d0c369eaa637 to 2111e8126c08 (1 revision) ( flutter/engine#45002 )
...
https://skia.googlesource.com/skia.git/+log/d0c369eaa637..2111e8126c08
2023-08-23 johnstiles@google.com Apply basic dead-code stripping to unoptimized modules.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 15:34:04 +00:00
skia-flutter-autoroll
7403fde1b0
Roll Fuchsia Linux SDK from VSvpNFoFjqXIQTcs6... to -HcyJtxGxUDcqX-jo... ( flutter/engine#44999 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 13:50:03 +00:00
skia-flutter-autoroll
d28f41fa46
Roll Skia from ee7404db8273 to d0c369eaa637 (1 revision) ( flutter/engine#44997 )
...
https://skia.googlesource.com/skia.git/+log/ee7404db8273..d0c369eaa637
2023-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ceb93445a393 to 5cfecc8eccdb (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 09:09:21 +00:00
skia-flutter-autoroll
6a70fb59da
Roll Skia from d0d2b7042bb9 to ee7404db8273 (1 revision) ( flutter/engine#44995 )
...
https://skia.googlesource.com/skia.git/+log/d0d2b7042bb9..ee7404db8273
2023-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from a740f161fcf2 to d5998642c25b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 08:17:54 +00:00
skia-flutter-autoroll
6a8d984c06
Roll Skia from eac8f8ea2660 to d0d2b7042bb9 (1 revision) ( flutter/engine#44994 )
...
https://skia.googlesource.com/skia.git/+log/eac8f8ea2660..d0d2b7042bb9
2023-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 07afc72c35f0 to c33914026731
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 06:22:28 +00:00
Zachary Anderson
c187b9fcfd
Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" ( flutter/engine#44993 )
...
Reverts flutter/engine#43750
Looks like this is having trouble rolling into the framework: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62845/overview
2023-08-23 05:55:13 +00:00
skia-flutter-autoroll
45f3e0b6ab
Roll Skia from aa208c8a2d60 to eac8f8ea2660 (1 revision) ( flutter/engine#44992 )
...
https://skia.googlesource.com/skia.git/+log/aa208c8a2d60..eac8f8ea2660
2023-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from fd820e605b8a to 07afc72c35f0 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 05:45:26 +00:00
Tong Mu
f26ad84d14
Move Rasterizer::Draw's discard_callback to Delegate ( flutter/engine#44813 )
...
This PR `Rasterizer::Draw`'s `discard_callback` parameter, which is
assigned by `Shell`, to `Delegate`, which is also implemented by
`Shell`. This refactory makes the API cleaner.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-22 21:25:30 -07:00
Ian Hickson
2a18cbd604
FontVariation.lerp, custom FontVariation constructors, and more documentation ( flutter/engine#43750 )
...
This should aid with implementing the framework side of https://github.com/flutter/flutter/issues/105120 This should also address https://github.com/flutter/flutter/issues/28543 .
2023-08-23 03:35:20 +00:00
Ian Hickson
9881f4846b
Make web tests start with an empty title ( flutter/engine#43846 )
...
Fixes https://github.com/flutter/flutter/issues/39159
2023-08-23 03:22:59 +00:00
Zachary Anderson
a92054278a
Revert "Roll Dart SDK from ab417bc74bb1 to c162b4979562 (1 revision)" ( flutter/engine#44989 )
...
Reverts flutter/engine#44986
Many new analyzer warnings blocking the roll to the framework:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62841/overview
cc @kallentu for
https://dart.googlesource.com/sdk.git/+/8c2f088481e90949dc04f532af8600b23138ff63
cc @a-siva
2023-08-22 20:19:20 -07:00
skia-flutter-autoroll
8f17bae3d2
Roll Fuchsia Mac SDK from G25oJMO5jbUi-UN4F... to DoQ8KUxSk-5EU6VQ1... ( flutter/engine#44988 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 03:03:07 +00:00
Zachary Anderson
714d884da5
Revert "Make FontWeight an enum, Remove unused text classes" ( flutter/engine#44987 )
...
Reverts flutter/engine#44960
Failing on customer_testing:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20customer_testing/59576/overview
2023-08-22 19:51:45 -07:00
skia-flutter-autoroll
8cf3760eed
Roll Dart SDK from ab417bc74bb1 to c162b4979562 (1 revision) ( flutter/engine#44986 )
...
https://dart.googlesource.com/sdk.git/+log/ab417bc74bb1..c162b4979562
2023-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-98.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 01:53:23 +00:00
skia-flutter-autoroll
245e43913c
Roll Fuchsia Linux SDK from kKI09su99b0AKs8b3... to VSvpNFoFjqXIQTcs6... ( flutter/engine#44984 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-23 01:04:15 +00:00
Matan Lurey
8d8a108d8a
Enable clang-tidy for pre-push (opt-out), exclude performance-unnecessary-value-param ( flutter/engine#44936 )
...
Closes https://github.com/flutter/flutter/issues/132687 .
Zach, this is a pretty naive attempt, so feel free to suggest alternatives. I considered for example just using `--checks=-{{LINT}}` as well, but figured that might be less discoverable (especially for non-core folks) than just a file called `.clang-tidy-for-githooks`.
/cc @jonahwilliams
2023-08-23 01:02:23 +00:00
John McCutchan
fe45ba18f0
Restore old SurfaceTextureExternal drawing code ( flutter/engine#44979 )
...
The simpler version I committed last week doesn't work correctly when
the texture has been transformed. This CL restores the old painting code
that properly handles this case.
Fixes internal b/296916021
2023-08-22 15:57:59 -07:00
skia-flutter-autoroll
ba0faabe73
Roll Skia from d0918de21c1a to aa208c8a2d60 (2 revisions) ( flutter/engine#44981 )
...
https://skia.googlesource.com/skia.git/+log/d0918de21c1a..aa208c8a2d60
2023-08-22 fmalita@chromium.org [skottie] Fix GaussianBlur repeat edge pixels
2023-08-22 brianosman@google.com Stop running two different scales on perf bots
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 22:50:22 +00:00
Jason Simmons
e6ed925c59
Initialize the texture destruction callback in the Metal embedder test harness ( flutter/engine#44973 )
2023-08-22 22:18:26 +00:00
Matan Lurey
258da2f14c
Further filter/clear <SkPaint>.setDither(true), this time in DlSkPaintDispatchHelper ( flutter/engine#44912 )
...
Closes https://github.com/flutter/flutter/issues/132860 .
- If `setDither(true)` is called, and an existing `setColorSource` is a gradient, it is ignored.
- If `setColorSource(...)` is called, and it is a gradient, and dithering was previously set, it is cleared.
I'm not sure this is fool proof.
2023-08-22 22:12:46 +00:00
skia-flutter-autoroll
2914e22dd0
Roll Dart SDK from 3ebf0fedfceb to ab417bc74bb1 (1 revision) ( flutter/engine#44977 )
...
https://dart.googlesource.com/sdk.git/+log/3ebf0fedfceb..ab417bc74bb1
2023-08-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-97.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 22:08:03 +00:00
skia-flutter-autoroll
477abd1918
Roll Skia from bf6019be75ef to d0918de21c1a (3 revisions) ( flutter/engine#44975 )
...
https://skia.googlesource.com/skia.git/+log/bf6019be75ef..d0918de21c1a
2023-08-22 johnstiles@google.com Enable SkSL testing in Graphite.
2023-08-22 lovisolo@google.com Update CPU dimension for NUC11TZi5 tasks: x86-64-avx2 -> x86-64-i5-1135G7.
2023-08-22 johnstiles@google.com Enable validation and user labels in Dawn test contexts.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 22:04:11 +00:00
skia-flutter-autoroll
544867ab52
Roll Skia from c675298ddeda to bf6019be75ef (3 revisions) ( flutter/engine#44974 )
...
https://skia.googlesource.com/skia.git/+log/c675298ddeda..bf6019be75ef
2023-08-22 johnstiles@google.com Remove empty source lists.
2023-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2cb515574109 to ceb93445a393 (3 revisions)
2023-08-22 herb@google.com Define line segment
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 20:54:20 +00:00
LongCatIsLooong
1a3cb621c9
Make FontWeight an enum, Remove unused text classes ( flutter/engine#44960 )
...
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-22 20:25:18 +00:00
skia-flutter-autoroll
5b344620e7
Roll Skia from 9f4b81aac175 to c675298ddeda (2 revisions) ( flutter/engine#44971 )
...
https://skia.googlesource.com/skia.git/+log/9f4b81aac175..c675298ddeda
2023-08-22 brianosman@google.com Remove logic for obsolete devices from nano_flags
2023-08-22 johnstiles@google.com Add support for Graphite unit tests that modify context options.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,lovisolo@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-22 20:07:08 +00:00
