firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
31,467 Commits 1 Branch 0 Tags
191e0417efe2c0affaa4ecc7594a87a5d3d7897f
Commit Graph

31467 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Zachary Anderson
191e0417ef Adds a --quiet flag to run_tests.py (flutter/engine#45880) 
This PR changes run_tests.py to use the python logging library to report
results instead of direct prints or writes to stdout/stderr. This change
simplifies adding a `--quiet` flag that causes the script to only
generate output if a log is emitted at WARNING or above.

Overall this is a bit of progress toward landing something like
https://github.com/flutter/engine/pull/45595
 2023-09-15 09:31:55 -07:00
Reid Baker
a43cae2515 Update AGP and Kotlin for scenario app (flutter/engine#45549) 
flutter/flutter/#134220

Command required to update lock files required not using the custom task and required matching the version of gradle in ci and passing a custom version of java. 
`~/.gradle/wrapper/dists/gradle-7.5.1-bin/7jzzequgds1hbszbhq3npc5ng/gradle-7.5.1/bin/gradle -D=org.gradle.java.home=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home  app:dependencies --write-locks` for app:dependencies and dependencies.
 2023-09-15 15:54:04 +00:00
Kevin Lubick
7da278b05b Migrate GrMipmapped->skgpu::Mipmapped (flutter/engine#45881) 
Skia's Graphite and Ganesh backend coalesced two enums regarding mipmaps
into one and deprecated the public Ganesh version. This migrates Flutter
to use the preferred type.

No functional changes expected. See also
https://skia-review.googlesource.com/c/skia/+/753567

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-15 11:48:20 -04:00
gaaclarke
30d0cf868d [Impeller] Introduce mock vulkan context builder (flutter/engine#45834) 
This allows us to have better control over the mock context and allows us to test situations like having the validations available, versus not available.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-15 15:42:03 +00:00
skia-flutter-autoroll
56b19ab7ec Roll Fuchsia Linux SDK from ES0r-mYplPOBYHvUQ... to wWzXsy6kx1sp8Km34... (flutter/engine#45879) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 15:22:18 +00:00
skia-flutter-autoroll
184c377ce5 Roll Skia from 3492fc567816 to de56f293eb41 (1 revision) (flutter/engine#45878) 
https://skia.googlesource.com/skia.git/+log/3492fc567816..de56f293eb41

2023-09-15 johnstiles@google.com Optimize 'expr ? 1 : 0' into 'cast(expr)'.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 14:34:27 +00:00
skia-flutter-autoroll
2f2be4de8d Roll Skia from 6e286034109e to 3492fc567816 (1 revision) (flutter/engine#45876) 
https://skia.googlesource.com/skia.git/+log/6e286034109e..3492fc567816

2023-09-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 786b5d99590b to 1ab98511aaae (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 13:46:52 +00:00
skia-flutter-autoroll
511bbec42d Roll Skia from 824b1973703d to 6e286034109e (1 revision) (flutter/engine#45875) 
https://skia.googlesource.com/skia.git/+log/824b1973703d..6e286034109e

2023-09-15 cmumford@google.com Disable use of DXC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 13:09:38 +00:00
skia-flutter-autoroll
04587d6383 Roll Skia from 4f7aafd0c853 to 824b1973703d (1 revision) (flutter/engine#45871) 
https://skia.googlesource.com/skia.git/+log/4f7aafd0c853..824b1973703d

2023-09-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e1b80fac8bd3 to b4852ef95ec1 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 08:57:04 +00:00
skia-flutter-autoroll
fa05b7cc00 Roll Skia from c0cabb0f93c9 to 4f7aafd0c853 (1 revision) (flutter/engine#45868) 
https://skia.googlesource.com/skia.git/+log/c0cabb0f93c9..4f7aafd0c853

2023-09-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 5f6a13cae14e to 18fd0925a396 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 05:27:12 +00:00
skia-flutter-autoroll
340a5b8b22 Roll Dart SDK from c0a505f9d1dd to 65117290c3b0 (1 revision) (flutter/engine#45867) 
https://dart.googlesource.com/sdk.git/+log/c0a505f9d1dd..65117290c3b0

2023-09-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-167.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 05:23:07 +00:00
skia-flutter-autoroll
aa07670756 Roll Fuchsia Mac SDK from FF4r9-tqhioBbRG9f... to --OUw__L3ekVTG-5c... (flutter/engine#45866) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 04:17:22 +00:00
skia-flutter-autoroll
63536433cf Roll Fuchsia Linux SDK from MzLcTzBiWJ7o3Q2_Z... to ES0r-mYplPOBYHvUQ... (flutter/engine#45865) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 02:37:26 +00:00
skia-flutter-autoroll
5147e816ba Roll Dart SDK from 7e4d9f4d8e52 to c0a505f9d1dd (1 revision) (flutter/engine#45864) 
https://dart.googlesource.com/sdk.git/+log/7e4d9f4d8e52..c0a505f9d1dd

2023-09-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-166.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 01:37:38 +00:00
skia-flutter-autoroll
96b00476d6 Roll Skia from 7aa8bfaa63fc to c0cabb0f93c9 (1 revision) (flutter/engine#45863) 
https://skia.googlesource.com/skia.git/+log/7aa8bfaa63fc..c0cabb0f93c9

2023-09-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 5f6a13cae14e to 18fd0925a396

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 01:14:01 +00:00
skia-flutter-autoroll
ae6ff66c06 Roll Skia from 37ea783440ea to 7aa8bfaa63fc (1 revision) (flutter/engine#45861) 
https://skia.googlesource.com/skia.git/+log/37ea783440ea..7aa8bfaa63fc

2023-09-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 27be2a276618 to 786b5d99590b (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 00:36:23 +00:00
skia-flutter-autoroll
24a609ad03 Roll Skia from 8c9e378c4902 to 37ea783440ea (1 revision) (flutter/engine#45859) 
https://skia.googlesource.com/skia.git/+log/8c9e378c4902..37ea783440ea

2023-09-14 kjlubick@google.com Remove some unused path effects

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 23:28:12 +00:00
XuanTung95
f95e3baebc Reduce unnecessary Dart_TimelineGetMicros call (flutter/engine#45637) 
Minor changes that reduce unnecessary Dart_TimelineGetMicros calls.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-14 22:46:56 +00:00
skia-flutter-autoroll
f6891113bc Roll Skia from 9b7c116ed6c2 to 8c9e378c4902 (3 revisions) (flutter/engine#45858) 
https://skia.googlesource.com/skia.git/+log/9b7c116ed6c2..8c9e378c4902

2023-09-14 brianosman@google.com Clamp alpha after doing CPU color filtering
2023-09-14 johnstiles@google.com Add support for mesh programs to sksl-minify.
2023-09-14 jamesgk@google.com [graphite] Be more defensive in attempting dst samples

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 22:41:23 +00:00
Victoria Ashworth
855ec2065c Set tests to run on macOS 12 (flutter/engine#45855) 
We recently upgraded a bot in the try pool to macOS 13 and I noticed a couple of tests have leaked through to it and we're not ready for tests to run on macOS 13 yet.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-14 22:19:57 +00:00
skia-flutter-autoroll
5567466854 Roll Dart SDK from d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854) 
https://dart.googlesource.com/sdk.git/+log/d25e8d682c8f..7e4d9f4d8e52

2023-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-165.0.dev
2023-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-164.0.dev
2023-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-163.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 21:40:13 +00:00
Martin Kustermann
c6be35d532 Remove @pragma('vm:entry-point') annotations on members that aren't accessed from C++ (flutter/engine#45697) 
The `@pragma('vm:entry-point')` annotation serves as an annotation
telling our AOT compiler that the member is needed and cannot be
tree-shaken because it may be accessed from the outside (i.e. C++).

There are seemingly entry-point annotations on members that aren't
actually used from C++.
=> We remove the annotation from those members in this CL.
 2023-09-14 23:33:29 +02:00
skia-flutter-autoroll
26262a8b47 Roll Skia from 6bc9f5886ddf to 9b7c116ed6c2 (1 revision) (flutter/engine#45853) 
https://skia.googlesource.com/skia.git/+log/6bc9f5886ddf..9b7c116ed6c2

2023-09-14 michaelludwig@google.com [skif] FilterResult::draw() operates on SkDevice instead of SkSpecialSurface+SkCanvas

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 21:32:11 +00:00
keyonghan
e7ac9ff327 Switch linux_android_debug_engine from goma to reclient (flutter/engine#45345) 
Part of https://github.com/flutter/flutter/issues/132701.
 2023-09-14 21:30:00 +00:00
keyonghan
cbb1d3dc41 Switch goma to reclient fro standalone targets (flutter/engine#45804) 
Part of https://github.com/flutter/flutter/issues/132701.
 2023-09-14 21:28:02 +00:00
yaakovschectman
52ce8f488d Handle external window's WM_CLOSE in lifecycle manager (flutter/engine#45840) 
Handle the close messages from non-Flutter windows similarly to how we
handle our own, for graceful app exit purposes.

https://github.com/flutter/flutter/issues/131497

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-14 17:07:14 -04:00
Michael Goderbauer
efc22ee283 Enable private field promotion (flutter/engine#45722) 
New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020. Feature is enabled by bumping the min SDK version to 3.2.

Part of https://github.com/flutter/flutter/issues/134476.
 2023-09-14 21:02:03 +00:00
Brandon DeRosier
563857b00e [Impeller] Add Entity::RenderingMode enum. (flutter/engine#45845) 
Resolves https://github.com/flutter/flutter/issues/134681.

For the various places where we track if a rendered entity is a subpass or not. After landing this, I think the next winning move is to make this an Entity field and remove the `SetRenderingMode` junk from the filter graph. That refactor is a bit more risky, so I plan to do that separately.
 2023-09-14 20:56:33 +00:00
Brandon DeRosier
5b5853f4dc [Impeller] Assert IMPELLER_ENABLE_3D when importing scene_contents.h. (flutter/engine#45848) 
Noticed we had a residual unguarded import of scene_contents.h while investigating https://github.com/flutter/flutter/issues/134745.
 2023-09-14 20:21:05 +00:00
skia-flutter-autoroll
6ae781812f Roll Skia from 0f003d5748bc to 6bc9f5886ddf (2 revisions) (flutter/engine#45847) 
https://skia.googlesource.com/skia.git/+log/0f003d5748bc..6bc9f5886ddf

2023-09-14 rmistry@google.com Fix webpages_playback.py instructions
2023-09-14 cmumford@google.com [infra] Delete the PushBazelAppsFromWASM build task

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 20:06:40 +00:00
Brandon DeRosier
8b53654118 [Impeller] Add AbsorbOpacity enum. (flutter/engine#45838) 
Part of https://github.com/flutter/flutter/issues/134681.
 2023-09-14 20:01:17 +00:00
skia-flutter-autoroll
ff8e6854db Roll Skia from 9bdf01416042 to 0f003d5748bc (4 revisions) (flutter/engine#45841) 
https://skia.googlesource.com/skia.git/+log/9bdf01416042..0f003d5748bc

2023-09-14 michaelludwig@google.com Reland "Reland "Add epsilon to texture effect clamping at pixel centers""
2023-09-14 cmumford@google.com [infra] Stop building legacy Skottie Docker image
2023-09-14 robertphillips@google.com [graphite] Expand usage of Blend helper
2023-09-14 lovisolo@google.com [bazel] Add "bazel clean" step to all Bazel task drivers.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 19:26:19 +00:00
Jackson Gardner
67ce410bd6 Declare the js context as nullable in skwasm surface callback (flutter/engine#45810) 
Declaring this as non-nullable causes breakage with an incoming JS interop change from the SDK. Marking this as nullable fixes the issue.

This doesn't actually change any behavior. The breakages were in `test/ui/image_golden_test.dart`. No changes to the test are required (they did catch the issue when the dart roll happened).
 2023-09-14 18:50:48 +00:00
Matan Lurey
6211b68cff [Impeller] Release a texture during Playground teardown (flutter/engine#45832) 
Closes https://github.com/flutter/flutter/issues/134678.

Partial work towards https://github.com/flutter/flutter/issues/133708, https://github.com/flutter/flutter/issues/133506.

This gets us closer to being able to run `aiks_unittests` with validations enabled, removing a VMA allocation error:

## Before

```txt
Note: Google Test filter = Play/AiksTest.ReleasesTextureOnTeardown/Vulkan
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Play/AiksTest
[ RUN      ] Play/AiksTest.ReleasesTextureOnTeardown/Vulkan
[INFO:capabilities_vk.cc(50)] Vulkan validations are enabled.
[FATAL:third_party/vulkan_memory_allocator/include/vk_mem_alloc.h(6179)] Check failed: (false && "Unfreed dedicated allocations found!"). Vulkan Memory Allocator Failure!
```

## After

```txt
Note: Google Test filter = Play/AiksTest.ReleasesTextureOnTeardown/Vulkan
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Play/AiksTest
[ RUN      ] Play/AiksTest.ReleasesTextureOnTeardown/Vulkan
[INFO:capabilities_vk.cc(50)] Vulkan validations are enabled.
[       OK ] Play/AiksTest.ReleasesTextureOnTeardown/Vulkan (1192 ms)
[----------] 1 test from Play/AiksTest (1192 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (1192 ms total)
[  PASSED  ] 1 test.
```

---

Added a test that will catch regressions.
 2023-09-14 18:39:01 +00:00
skia-flutter-autoroll
ab141ac13c Roll Skia from 87025d1e162c to 9bdf01416042 (1 revision) (flutter/engine#45835) 
https://skia.googlesource.com/skia.git/+log/87025d1e162c..9bdf01416042

2023-09-14 kjlubick@google.com Make SkJpegConstants.h visible when just encoding JPEG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 18:37:52 +00:00
Matan Lurey
0f4cb0b4c8 Make fml::ScopedCleanupClosure std::move-able and add unit tests. (flutter/engine#45772) 
Fixes https://github.com/flutter/flutter/issues/134568.
 2023-09-14 18:37:49 +00:00
skia-flutter-autoroll
53bcc75ea6 Manual roll Dart SDK from 1ee7ef8bbc65 to d25e8d682c8f (22 revisions) (flutter/engine#45836) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/1ee7ef8bbc65..d25e8d682c8f

2023-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-162.0.dev
2023-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-161.0.dev
2023-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-160.0.dev
2023-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-159.0.dev
2023-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-158.0.dev
2023-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-157.0.dev
2023-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-156.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-155.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-154.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-153.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-152.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-151.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-150.0.dev
2023-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-149.0.dev
2023-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-148.0.dev
2023-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-147.0.dev
2023-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-146.0.dev
2023-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-145.0.dev
2023-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-144.0.dev
2023-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-143.0.dev
2023-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-142.0.dev
2023-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-141.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 18:36:05 +00:00
godofredoc
c9ce9f7fd5 Update webdriver imports. (flutter/engine#45816) 
This is to be able to update the webdriver dependency.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-14 18:26:42 +00:00
skia-flutter-autoroll
0941b57131 Roll Skia from 54253f58533d to 87025d1e162c (1 revision) (flutter/engine#45833) 
https://skia.googlesource.com/skia.git/+log/54253f58533d..87025d1e162c

2023-09-14 robertphillips@google.com [graphite] Add Blend method to assist paint key creation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 17:31:43 +00:00
Brandon DeRosier
9294f00715 [Impeller] Incorporate filters in subpass coverage. (flutter/engine#45778) 
I adjusted the size of the matrix filtered circle in both SaveLayer
Matrix filter test variants (post-filter and backdrop filter) to move
the transformed circle outside the coverage area that would be computed
if subpass filters aren't being accounted for. Further, we need to avoid
intersecting with the pass coverage hint when the transformation being
applied by the paint's filter graph causes the Entity's space basis to
deviate from the parent pass basis. We're still able to apply it for
simple translations, though.
 2023-09-14 10:07:19 -07:00
skia-flutter-autoroll
75caba9561 Roll Skia from 91d5a781ebaf to 54253f58533d (2 revisions) (flutter/engine#45829) 
https://skia.googlesource.com/skia.git/+log/91d5a781ebaf..54253f58533d

2023-09-14 johnstiles@google.com Add gcloud login step to ASAN documentation.
2023-09-14 johnstiles@google.com Initialize 'fIsWrappedOnly' member variable.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 16:12:06 +00:00
skia-flutter-autoroll
d9123e52f1 Roll Skia from 08fb9768d1b8 to 91d5a781ebaf (3 revisions) (flutter/engine#45828) 
https://skia.googlesource.com/skia.git/+log/08fb9768d1b8..91d5a781ebaf

2023-09-14 brianosman@google.com Fully remove legacy SK_VULKAN code from GrBackendSurface.h
2023-09-14 jvanverth@google.com [graphite] Rename AtlasShapeRenderStep to CoverageMaskRenderStep
2023-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from b4c3435d2fba to 27be2a276618 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 15:26:22 +00:00
skia-flutter-autoroll
6ee7bee453 Roll Fuchsia Mac SDK from f4jtyOMeNSKGqqI4y... to FF4r9-tqhioBbRG9f... (flutter/engine#45827) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 15:14:05 +00:00
skia-flutter-autoroll
850034b037 Roll Skia from 45ba26fae9cd to 08fb9768d1b8 (2 revisions) (flutter/engine#45825) 
https://skia.googlesource.com/skia.git/+log/45ba26fae9cd..08fb9768d1b8

2023-09-14 egdaniel@google.com Reland "Add option for clients to set default gpu staging buffer size."
2023-09-14 johnstiles@google.com Clarify build documentation.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 14:43:19 +00:00
godofredoc
bdea863e39 Fix script (flutter/engine#45598) 
Makes mac framework readable and executable by all.

Bug: https://github.com/flutter/flutter/issues/132725

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-14 14:15:11 +00:00
skia-flutter-autoroll
cd6a4d4b72 Roll Fuchsia Linux SDK from 5aKvHj_QcSHJkbWjr... to MzLcTzBiWJ7o3Q2_Z... (flutter/engine#45823) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 13:49:24 +00:00
skia-flutter-autoroll
cb76fa1378 Roll Skia from 4bb29f80ed43 to 45ba26fae9cd (1 revision) (flutter/engine#45821) 
https://skia.googlesource.com/skia.git/+log/4bb29f80ed43..45ba26fae9cd

2023-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 61dbf7960649 to b4c3435d2fba (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 11:54:27 +00:00
dependabot[bot]
2d9f35348b Bump html from 0.15.0 to 0.15.4 in /lib/web_ui (flutter/engine#45819) 
Bumps [html](https://github.com/dart-lang/html) from 0.15.0 to 0.15.4.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/dart-lang/html/blob/main/CHANGELOG.md">html's changelog</a>.</em></p>
<blockquote>
<h2>0.15.4</h2>
<ul>
<li>Widen the dependency on <code>package:csslib</code>.</li>
<li>Require Dart <code>2.19</code>.</li>
</ul>
<h2>0.15.3</h2>
<ul>
<li>Added package topics to the pubspec file.</li>
</ul>
<h2>0.15.2</h2>
<ul>
<li>Add additional types at the API boundary (in <code>lib/parser.dart</code> and others).</li>
<li>Adopted the <code>package:dart_flutter_team_lints</code> linting rules.</li>
<li>Fixed an issue with <code>querySelector</code> where it would fail in some cases with
descendant or sibling combinators (<a href="https://redirect.github.com/dart-lang/html/issues/157">#157</a>).</li>
<li>Add an API example in <code>example/</code>.</li>
</ul>
<h2>0.15.1</h2>
<ul>
<li>Move <code>htmlSerializeEscape</code> to its own library,
<code>package:html/html_escape.dart</code>, which is exported from
<code>package:html/dom_parsing.dart</code>.</li>
<li>Use more non-growable lists, and type annotations on List literals.</li>
<li>Switch analysis option <code>implicit-casts: false</code> to <code>strict-casts: true</code>.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b3b820bc36"><code>b3b820b</code></a> widen the dependency on 'package:csslib' (<a href="https://redirect.github.com/dart-lang/html/issues/217">#217</a>)</li>
<li><a href="92eacabadf"><code>92eacab</code></a> blast_repo fixes (<a href="https://redirect.github.com/dart-lang/html/issues/216">#216</a>)</li>
<li><a href="593d6f67ef"><code>593d6f6</code></a> Bump actions/checkout from 3.5.0 to 3.5.2 (<a href="https://redirect.github.com/dart-lang/html/issues/214">#214</a>)</li>
<li><a href="5d87dc8a06"><code>5d87dc8</code></a> added package topics to the pubspec file (<a href="https://redirect.github.com/dart-lang/html/issues/215">#215</a>)</li>
<li><a href="0438b26b90"><code>0438b26</code></a> Dart 3 compatibility: turn classes into mixins (<a href="https://redirect.github.com/dart-lang/html/issues/208">#208</a>)</li>
<li><a href="57b747d705"><code>57b747d</code></a> Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (<a href="https://redirect.github.com/dart-lang/html/issues/209">#209</a>)</li>
<li><a href="51c9910bec"><code>51c9910</code></a> Bump actions/checkout from 3.3.0 to 3.5.0 (<a href="https://redirect.github.com/dart-lang/html/issues/210">#210</a>)</li>
<li><a href="08643e9e2b"><code>08643e9</code></a> prep for publishing 0.15.2 (<a href="https://redirect.github.com/dart-lang/html/issues/205">#205</a>)</li>
<li><a href="0b8025c16e"><code>0b8025c</code></a> add an api example (<a href="https://redirect.github.com/dart-lang/html/issues/204">#204</a>)</li>
<li><a href="f118e004df"><code>f118e00</code></a> lint with dart_flutter_team_lints (<a href="https://redirect.github.com/dart-lang/html/issues/201">#201</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/dart-lang/html/compare/0.15.0...v0.15.4">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=html&package-manager=pub&previous-version=0.15.0&new-version=0.15.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2023-09-14 09:02:21 +00:00
skia-flutter-autoroll
1ec711cb48 Roll Skia from 5ff47ea11c13 to 4bb29f80ed43 (1 revision) (flutter/engine#45818) 
https://skia.googlesource.com/skia.git/+log/5ff47ea11c13..4bb29f80ed43

2023-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 19ec9904dd95 to 5f6a13cae14e (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 08:46:36 +00:00
skia-flutter-autoroll
eae5f35333 Roll Skia from 5f18d2ead8c8 to 5ff47ea11c13 (1 revision) (flutter/engine#45815) 
https://skia.googlesource.com/skia.git/+log/5f18d2ead8c8..5ff47ea11c13

2023-09-14 johnstiles@google.com Enable SkSL testing in Graphite + Vulkan.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 04:11:28 +00:00