firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
33,667 Commits 1 Branch 0 Tags
166fda272568c1ea968cedfd7bedfaad77ad6301
Commit Graph

33667 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
166fda2725 Roll Fuchsia Linux SDK from geXIwPzzJiSXrZEEb... to kOnlSGX_aTAK7vvLc... (flutter/engine#49919) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-20 13:23:16 +00:00
skia-flutter-autoroll
4261f97cac Manual roll Dart SDK from 8d697eaa395c to 7a91ef52d200 (5 revisions) (flutter/engine#49917) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/8d697eaa395c..7a91ef52d200

2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-52.0.dev
2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-51.0.dev
2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-50.0.dev
2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-49.0.dev
2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-48.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-20 07:04:56 +00:00
skia-flutter-autoroll
ae953c6562 Roll Skia from 61a2dcff4194 to 3cac1efbdd7a (4 revisions) (flutter/engine#49916) 
https://skia.googlesource.com/skia.git/+log/61a2dcff4194..3cac1efbdd7a

2024-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e86bcb0b8781 to e82e36a84a08
2024-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d7516437eaf9 to f5416720c542 (2 revisions)
2024-01-19 jvanverth@google.com Fix post-GrFence removal comments.
2024-01-19 brianosman@google.com Revert "Add Bazel rules for Ganesh GL backend and webp encoder"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-20 04:00:23 +00:00
Jonah Williams
1d85ce2e41 [Impeller] Encode directly to command buffer for Metal. (flutter/engine#49785) 
Part of https://github.com/flutter/flutter/issues/140804

Rather than using impeller::Command, the impeller::RenderPass records most state directly into the Vulkan command buffer. This should remove allocation/free overhead of the intermediary structures and make further improvements to the backend even easier.

This completely removes the background worker threads used for encoding, which should lower overall CPU usage without decreasing performance by much (though it may be a tad slower or a tad faster).
 2024-01-20 02:57:02 +00:00
Jonah Williams
d6d9d8547e [Impeller] use string view for labels in more places to defer allocatons. (flutter/engine#49905) 
This improves the performance of command encoding when there is no debugger attached. most labels are const char*, and so by accepting a string_view we can avoid actually creating a string if validations are disabled.
 2024-01-20 01:48:29 +00:00
Jonah Williams
99cfd9db3f [Impeller] null check vertex buffer. (flutter/engine#49915) 
Tested: currently broken test!
 2024-01-19 17:26:40 -08:00
gaaclarke
cbcce599fc [Impeller] adds vulkan golden images (flutter/engine#49849) 
fixes https://github.com/flutter/flutter/issues/141705

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-19 22:44:38 +00:00
auto-submit[bot]
07034d9f1d Reverts "[Fuchsia] Redo - Use chromium test-scripts to download images and execute tests" (flutter/engine#49908) 
Reverts flutter/engine#49847
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
This change is a redo of https://github.com/flutter/engine/pull/49650.

https://github.com/zijiehe-google-com/engine/compare/de5c713..main should show the diff between this and the original change.

Following paragraph is copied from the original change.

This change requires https://github.com/flutter/buildroot/pull/811, and can be executed from buildroot by

```
python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py
```

Bug: https://github.com/flutter/flutter/issues/140179

- [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [V] I listed at least one issue that this PR fixes in the description above.
- [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
- [V] I updated/added relevant documentation (doc comments with `///`).
- [V] I signed the [CLA].
- [V] All existing and new tests are passing.
 2024-01-19 22:22:25 +00:00
Loïc Sharma
78728e1649 [Windows] Refactor EGL initialization (flutter/engine#49895) 
This is a refactoring with no semantic changes:

1. Fixes incorrect style in `AngleSurfaceManager`
2. Cleans `AngleSurfaceManager`'s initialization logic

Next pull request: https://github.com/flutter/engine/pull/49900

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-19 21:32:27 +00:00
skia-flutter-autoroll
1f4256f319 Roll Skia from fabb71dcf9b7 to 61a2dcff4194 (1 revision) (flutter/engine#49904) 
https://skia.googlesource.com/skia.git/+log/fabb71dcf9b7..61a2dcff4194

2024-01-19 lovisolo@google.com [bazel] adb_test_runner.go: Remove obsolete comments about GPU scaling.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 21:22:05 +00:00
skia-flutter-autoroll
6f782fe334 Roll Skia from c09908c48f14 to fabb71dcf9b7 (3 revisions) (flutter/engine#49902) 
https://skia.googlesource.com/skia.git/+log/c09908c48f14..fabb71dcf9b7

2024-01-19 lovisolo@google.com [bazel] adb_test_runner.go: Scale devices according to the test type.
2024-01-19 kjlubick@google.com Add Bazel rules for Ganesh GL backend and webp encoder
2024-01-19 kjlubick@google.com Add refactors/deprecations to support Ganesh modules

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 20:16:54 +00:00
Jonah Williams
e7be989feb Reland: Encode directly to command buffer. (flutter/engine#49821) 
The original change was reverted as it broke the GPU tracer reset logic. The previous logic assumed that the first started command buffer would also be the first submitted command buffer. With the direct encoding, this is no longer the case - so we shift the logic so that we reset query pools once at startup and then after the queries are finished being recorded.

This might actually be better in general since we should be doing less work in the frame workload.
 2024-01-19 19:21:47 +00:00
skia-flutter-autoroll
35c5cc4bc7 Roll Skia from 2536dc6fef1d to c09908c48f14 (6 revisions) (flutter/engine#49899) 
https://skia.googlesource.com/skia.git/+log/2536dc6fef1d..c09908c48f14

2024-01-19 brianosman@google.com Revert "Added AVX512 support for SkRasterPipeline_opts.h"
2024-01-19 robertphillips@google.com [graphite] Update SkEmptyShader to be a no-op
2024-01-19 egdaniel@google.com Fix checking for memoryless support in Vulkan
2024-01-19 ping.wang@amd.com Added AVX512 support for SkRasterPipeline_opts.h
2024-01-19 jvanverth@google.com Remove GrFence support.
2024-01-19 bungeman@google.com Sanitize and extra_flags target only

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 19:17:49 +00:00
Dan Field
c451232db5 [Impeller] Documentation for SurfaceContextVK (flutter/engine#49882) 
See #44171
 2024-01-19 19:08:09 +00:00
Ricardo Amador
4e8fee2701 Adding ignore paths to cache test (flutter/engine#49874) 
Adding exclusion paths to the Mac builder_cache target to avoid archiving symlinks in the SDKs or other unwanted packages. Symlinks cause issues with the CAS archiving functionality. We have opened a bug for the LUCI team regarding this as well.

Companion CL in recipes is here: https://flutter-review.googlesource.com/c/recipes/+/54110

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/141688

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-19 18:58:23 +00:00
Jim Graham
64e292e6e1 [Impeller] switch Rect fields to LTRB implementation (flutter/engine#49816) 
Switches the Rect class implementation to an LTRB (Left, Top, Right, Bottom) set of fields for efficiency in performing rectangle operations. Additionally, the methods have been somewhat hardened to the following issues:

- NaN values should always act as if the rect is empty
  - Helps with https://github.com/flutter/flutter/issues/132770
- Saturated math methods are added to avoid overflow for integer rects
- Normalized treatment of empty rectangles in rect/rect operations
  - empty.Union(anything) == anything
  - empty.Intersection(anything) == empty
  - empty.IntersectsWith(anything) == false
  - empty.Contains(anything) == false
  - non-empty.Contains(empty) == true
- MakeMaximum now returns finite rectangles which should produce non-nan values from all getters
- A lot more testing of all of these behaviors within the unit tests

In addition, the new rectangle is closer to what DisplayList and the Skia backend have been using all along so we might be able to switch to using Impeller geometry inside DisplayList to reduce overhead for both backends.
 2024-01-19 18:27:04 +00:00
zijiehe@
0f1211b660 [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49847) 
This change is a redo of https://github.com/flutter/engine/pull/49650.

https://github.com/zijiehe-google-com/engine/compare/de5c713..main
should show the diff between this and the original change.

Following paragraph is copied from the original change.

This change requires https://github.com/flutter/buildroot/pull/811, and
can be executed from buildroot by

```
python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py
```

Bug: https://github.com/flutter/flutter/issues/140179

## Pre-launch Checklist

- [V] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [V] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [V] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [V] I listed at least one issue that this PR fixes in the description
above.
- [V] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [V] I updated/added relevant documentation (doc comments with `///`).
- [V] I signed the [CLA].
- [V] All existing and new tests are passing.
 2024-01-19 09:36:56 -08:00
skia-flutter-autoroll
5269a7172d Roll Skia from fb3f61d932e6 to 2536dc6fef1d (2 revisions) (flutter/engine#49892) 
https://skia.googlesource.com/skia.git/+log/fb3f61d932e6..2536dc6fef1d

2024-01-19 johnstiles@google.com Report an error if variables are scoped incorrectly.
2024-01-19 johnstiles@google.com Add no-op TRACE_EVENT_OBJECT macros.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 16:48:58 +00:00
skia-flutter-autoroll
55d04cae13 Roll Skia from 0a78d1f0ef48 to fb3f61d932e6 (1 revision) (flutter/engine#49891) 
https://skia.googlesource.com/skia.git/+log/0a78d1f0ef48..fb3f61d932e6

2024-01-19 jvanverth@google.com Add a typeface to the HelloWorld example.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 15:57:38 +00:00
skia-flutter-autoroll
267f2c9e01 Roll Skia from 961ad2c3fcf5 to 0a78d1f0ef48 (1 revision) (flutter/engine#49890) 
https://skia.googlesource.com/skia.git/+log/961ad2c3fcf5..0a78d1f0ef48

2024-01-19 johnstiles@google.com Revert "Disable TRACE_EVENT macros when optimizing for size."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 15:18:22 +00:00
Jesse Seales
8352fd8dc3 Re-enable osv-scanner on pushes to main (flutter/engine#49729) 
The osv-scanner workflow was disabled on pushes to main while testing the PR patching workflow. This change re-enables the scanner to run on pushes to main (excluding forks).

Successful run of the current vulnerability workflow here: https://github.com/flutter/engine/actions/runs/7561640856/job/20590736333

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-19 15:09:45 +00:00
skia-flutter-autoroll
a7274ef77e Roll Skia from 273b0628a969 to 961ad2c3fcf5 (1 revision) (flutter/engine#49889) 
https://skia.googlesource.com/skia.git/+log/273b0628a969..961ad2c3fcf5

2024-01-19 johnstiles@google.com Disable TRACE_EVENT macros when optimizing for size.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 14:10:15 +00:00
skia-flutter-autoroll
c30b22d0fa Roll Fuchsia Linux SDK from dTy8CK4YxnUsW305O... to geXIwPzzJiSXrZEEb... (flutter/engine#49888) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 12:33:05 +00:00
skia-flutter-autoroll
8db297fcc6 Roll Skia from b6fa819eb54c to 273b0628a969 (1 revision) (flutter/engine#49887) 
https://skia.googlesource.com/skia.git/+log/b6fa819eb54c..273b0628a969

2024-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c00c99b8e979 to d7516437eaf9 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 12:05:04 +00:00
skia-flutter-autoroll
a48b44f551 Roll Skia from e073a4fad57a to b6fa819eb54c (1 revision) (flutter/engine#49886) 
https://skia.googlesource.com/skia.git/+log/e073a4fad57a..b6fa819eb54c

2024-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d093c3d3c22c to 0da652252424 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 10:23:05 +00:00
Bruno Leroux
7001e5cc63 [Android] Fix KeyEmbedderResponder throws a NullPointerException (flutter/engine#49860) 
## Description

This PR fixes a `NullPointerException` thrown from `KeyEmbedderResponder` when pressing a key during a hot restart (at this time the framework might not be ready and null reply is sent back).

## Related Issue

Fixes https://github.com/flutter/flutter/issues/141662.

## Tests

Adds 1 test.
 2024-01-19 09:17:06 +00:00
skia-flutter-autoroll
f8b699a88b Roll Skia from dd24bd11d79e to e073a4fad57a (1 revision) (flutter/engine#49881) 
https://skia.googlesource.com/skia.git/+log/dd24bd11d79e..e073a4fad57a

2024-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 5c0a2d3ef3af to e86bcb0b8781

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 02:20:04 +00:00
skia-flutter-autoroll
d3f399d655 Manual roll Dart SDK from d6c08fa9bb54 to 8d697eaa395c (23 revisions) (flutter/engine#49880) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/d6c08fa9bb54..8d697eaa395c

2024-01-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-47.0.dev
2024-01-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-46.0.dev
2024-01-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-45.0.dev
2024-01-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-44.0.dev
2024-01-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-43.0.dev
2024-01-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-42.0.dev
2024-01-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-41.0.dev
2024-01-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-40.0.dev
2024-01-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-39.0.dev
2024-01-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-38.0.dev
2024-01-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-37.0.dev
2024-01-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-36.0.dev
2024-01-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-35.0.dev
2024-01-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-34.0.dev
2024-01-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-33.0.dev
2024-01-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-32.0.dev
2024-01-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-31.0.dev
2024-01-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-30.0.dev
2024-01-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-29.0.dev
2024-01-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-28.0.dev
2024-01-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-27.0.dev
2024-01-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-26.0.dev
2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-25.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 02:10:38 +00:00
skia-flutter-autoroll
755bb2c450 Roll Skia from c71519e854d1 to dd24bd11d79e (1 revision) (flutter/engine#49878) 
https://skia.googlesource.com/skia.git/+log/c71519e854d1..dd24bd11d79e

2024-01-18 fmalita@chromium.org [mesh2d demo] Updated to latest API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-19 00:26:08 +00:00
skia-flutter-autoroll
cd87fb07e7 Roll Skia from da3bfb25fb84 to c71519e854d1 (1 revision) (flutter/engine#49875) 
https://skia.googlesource.com/skia.git/+log/da3bfb25fb84..c71519e854d1

2024-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 483d7b1561b5 to c00c99b8e979 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-18 22:51:16 +00:00
Loïc Sharma
e47107cf38 [Windows] Refactor logic when window resize completes (flutter/engine#49872) 
Changes:

1. Moves surface buffer swapping from `FlutterWindowsView` to `CompositorOpenGL`
1. Renames `FlutterWindowsView::SwapBuffers` to `FlutterWindowsView::OnFramePresented`
2. Previously, if a resize was pending and the window was not visible Windows would unblock the platform thread before swapping buffers. This trick aimed to reduce the time the platform thread was blocked as swapping buffers previously waited until the v-blank. This logic was removed as swapping buffers no longer waits until the v-blank.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-18 22:11:16 +00:00
skia-flutter-autoroll
0d54fa3c36 Roll Skia from 40200ceca00e to da3bfb25fb84 (1 revision) (flutter/engine#49873) 
https://skia.googlesource.com/skia.git/+log/40200ceca00e..da3bfb25fb84

2024-01-18 johnstiles@google.com Fix for-loop variable scoping.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-18 22:05:23 +00:00
Filip Filmar
a53f140211 [fuchsia] Wire through the tzdata-icu capability (flutter/engine#48907) 
The `tzdata-icu` capability is a directory containing
ICU time zone resource files. These are requried for
correct computation of local times.

Issue: https://github.com/flutter/flutter/issues/139952

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-01-18 13:18:14 -08:00
skia-flutter-autoroll
adf794ea69 Roll Skia from 31fae9f0cdd1 to 40200ceca00e (1 revision) (flutter/engine#49871) 
https://skia.googlesource.com/skia.git/+log/31fae9f0cdd1..40200ceca00e

2024-01-18 jlavrova@google.com Removing FreeType references for Chrome

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-18 21:16:15 +00:00
skia-flutter-autoroll
7d6886b7ec Roll Skia from 1064eeedac09 to 31fae9f0cdd1 (1 revision) (flutter/engine#49869) 
https://skia.googlesource.com/skia.git/+log/1064eeedac09..31fae9f0cdd1

2024-01-18 michaelludwig@google.com [graphite] Use SIMD half conversion in UniformManager

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-18 19:41:49 +00:00
Harry Terkelsen
de6ec5b77e [canvaskit] Fall back to multi-context rendering on Firefox and Safari (flutter/engine#49572) 
This PR refactors rasterization to support two different modes, single
GL context mode backed by a single OffscreenCanvas (Chrome), and
multi-context mode which uses many GL contexts and canvases.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-01-18 11:22:09 -08:00
godofredoc
1798b687d8 Use any mac machine available for orchestrator run. (flutter/engine#49845) 
This will remove some of the stress on x64 machines and will help to get faster builds on dart-internal.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-18 18:56:35 +00:00
Jesse Seales
eb29ac8bbc Simplify osv-scanner workflow (flutter/engine#49807) 
This change simplifies the osv-scanner workflow by extracting dependencies from the DEPS file and then finding their common ancestor commit with upstream in one script.

Fixes: https://github.com/flutter/flutter/issues/141184

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-18 18:48:00 +00:00
skia-flutter-autoroll
cc2dbc4ce1 Roll Skia from b1611add5939 to 1064eeedac09 (6 revisions) (flutter/engine#49867) 
https://skia.googlesource.com/skia.git/+log/b1611add5939..1064eeedac09

2024-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 7c236cb7a5a2 to f4b64e5c220e
2024-01-18 drott@chromium.org [Fontations-backend] Add nested COLRv1 PaintGlyph tests
2024-01-18 bungeman@google.com Re-add FreeType include to Fontations test and gm
2024-01-18 johnstiles@google.com Hoist variables properly when rewriting for-loop initializers.
2024-01-18 johnstiles@google.com Fix fuzzer-discovered error with sk_LastFragColor.
2024-01-18 egdaniel@google.com Remove old intel workaround to avoid non-coherent memory.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-18 18:13:17 +00:00
Dan Field
5113cf4282 [Impeller] Eliminate some shared_ptr copying from EntityPass::Render (flutter/engine#49855) 
Every drop counts right?
 2024-01-18 17:43:01 +00:00
Victoria Ashworth
0c7d05da12 Update tests to Xcode 15 and iOS 17 simulator (flutter/engine#49833) 
Engine part of https://github.com/flutter/flutter/issues/132237.

Also, fixes https://github.com/flutter/flutter/issues/125227.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-18 16:07:54 +00:00
skia-flutter-autoroll
7d992ddb79 Roll Skia from 7b3d788ba978 to b1611add5939 (1 revision) (flutter/engine#49863) 
https://skia.googlesource.com/skia.git/+log/7b3d788ba978..b1611add5939

2024-01-18 kjlubick@google.com Add missing include

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-18 15:45:09 +00:00
skia-flutter-autoroll
f9a60e9a68 Roll Skia from 1b2909f1eac7 to 7b3d788ba978 (1 revision) (flutter/engine#49861) 
https://skia.googlesource.com/skia.git/+log/1b2909f1eac7..7b3d788ba978

2024-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from afab4ff4f0df to 483d7b1561b5 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-18 10:04:31 +00:00
skia-flutter-autoroll
d7b542b200 Roll Fuchsia Linux SDK from GuU0e5WxJCi92Scz8... to dTy8CK4YxnUsW305O... (flutter/engine#49859) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-18 08:58:13 +00:00
skia-flutter-autoroll
b6e0e6543a Roll Skia from ea70dd235e9f to 1b2909f1eac7 (1 revision) (flutter/engine#49858) 
https://skia.googlesource.com/skia.git/+log/ea70dd235e9f..1b2909f1eac7

2024-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2e167e092239 to d093c3d3c22c (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-18 07:45:21 +00:00
Bruno Leroux
d925ac1a53 [Android] Reset IME state in TextInputPlugin.clearTextInputClient (flutter/engine#49829) 
## Description

This PR calls Android API `InputMethodManager.restartInput` to reset IMEs internal states. Otherwise some IMEs (Gboard for instance) keep reacting based on the previous input configuration until a new configuration is set.

- On Android native, `restartInput` is called in several places, for instance in f219798774/android/widget/TextView.java (L2458).
- On Compose, https://github.com/flutter/flutter/issues/70546#issuecomment-1088345561 pointed out where it is called.
- On Flutter, it is called at some point but mainly when another `TextField` is focused (it is mainly called in `setTextInputEditingState`).

## Related Issue

Fixes https://github.com/flutter/flutter/issues/70546.

## Tests

Adds 1 test.
 2024-01-18 06:38:34 +00:00
skia-flutter-autoroll
cd3aff45f8 Roll Skia from 31f275e8fcc7 to ea70dd235e9f (2 revisions) (flutter/engine#49856) 
https://skia.googlesource.com/skia.git/+log/31f275e8fcc7..ea70dd235e9f

2024-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f4819d2276b7 to 328e794f0c8b (1 revision)
2024-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 86b1c514ac18 to 59f21e604859

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-18 05:47:34 +00:00
Dan Field
55a6cc2dca Delete trace event from DeviceBufferVK (flutter/engine#49854) 
We don't have this in the GLES or MTL backends, and it's showing up in profiling.
 2024-01-18 05:22:02 +00:00
Jonah Williams
c380791070 [Impeller] remove shared_ptr copies during text contents rendering. (flutter/engine#49837) 
We copied the shared ptr to make it easy to return nullptr, but instead we could use a static const assigned to nullptr
 2024-01-18 05:21:59 +00:00
Yegor
eb33bab677 [web] fix ==/hashCode/toString for several classes across renderers (flutter/engine#49786) 
Fix equality and hash code in `ParagraphStyle` and `StrutStyle` across renderers. Since those classes transitively rely on `Paint` and other classes, also fix those at least to a point that they pass the `test/painting/text_style_test.dart` test on the framework side.
 2024-01-18 04:01:28 +00:00