firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES (flutter/engine#50982)

Browse Source 
Currently the GLES backend may claim the framebuffer fetch capability but its implementation does not support the multisample subpass input used in this test.  Do not run this on GLES until there is clarification of the level of framebuffer fetch support intended for the GLES backend.
This commit is contained in:
Jason Simmons
2024-02-28 12:54:06 -08:00
committed by GitHub
parent 037e853355
commit f6f7230917
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
engine/src/flutter/impeller/renderer/renderer_unittests.cc
View File

@@ -1328,6 +1328,13 @@ std::shared_ptr<Pipeline<PipelineDescriptor>> CreateDefaultPipeline(
}
TEST_P(RendererTest, CanSepiaToneWithSubpasses) {
// The GLES framebuffer fetch implementation currently does not support this.
// TODO(chinmaygarde): revisit after the GLES framebuffer fetch capabilities
// are clarified.
if (GetParam() == PlaygroundBackend::kOpenGLES) {
GTEST_SKIP_("Not supported on GLES.");
}
// Define shader types
using TextureVS = TextureVertexShader;
using TextureFS = TextureFragmentShader;
@@ -1416,6 +1423,13 @@ TEST_P(RendererTest, CanSepiaToneWithSubpasses) {
}
TEST_P(RendererTest, CanSepiaToneThenSwizzleWithSubpasses) {
// The GLES framebuffer fetch implementation currently does not support this.
// TODO(chinmaygarde): revisit after the GLES framebuffer fetch capabilities
// are clarified.
if (GetParam() == PlaygroundBackend::kOpenGLES) {
GTEST_SKIP_("Not supported on GLES.");
}
// Define shader types
using TextureVS = TextureVertexShader;
using TextureFS = TextureFragmentShader;