firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Include symbol maps in CanvasKit and Skwasm builds. (flutter/engine#46973)

Browse Source 
This should help with https://github.com/flutter/flutter/issues/122834

Emitting DWARF data or source maps actually significantly changes the size of the build, since some binaryen optimizations must actually be skipped when producing either of those. So we can emit symbol maps for now, which don't affect the size of the actual wasm output. With these, we can at least manually deobfuscate stack traces.
This commit is contained in:
Jackson Gardner
2023-10-17 09:24:18 -07:00
committed by GitHub
parent b2ee7de62a
commit ef900554cb
3 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
DEPS
View File

@@ -262,7 +262,7 @@ allowed_hosts = [
]
deps = {
'src': 'https://github.com/flutter/buildroot.git' + '@' + '1d2965f9b0f784abea8ddbeb54827afa9ed196b9',
'src': 'https://github.com/flutter/buildroot.git' + '@' + '60415e4cb48742a60ba3859d92bbdcb7d14841b0',
# Fuchsia compatibility
#

3
engine/src/flutter/third_party/canvaskit/BUILD.gn vendored
View File

@@ -27,6 +27,7 @@ copy("canvaskit_group") {
sources = [
"$root_out_dir/canvaskit/canvaskit.js",
"$root_out_dir/canvaskit/canvaskit.js.symbols",
"$root_out_dir/canvaskit/canvaskit.wasm",
]
outputs = [ "$root_out_dir/flutter_web_sdk/canvaskit/{{source_file_part}}" ]
@@ -61,6 +62,7 @@ copy("canvaskit_chromium_group") {
sources = [
"$root_out_dir/canvaskit_chromium/canvaskit.js",
"$root_out_dir/canvaskit_chromium/canvaskit.js.symbols",
"$root_out_dir/canvaskit_chromium/canvaskit.wasm",
]
outputs = [
@@ -97,6 +99,7 @@ copy("skwasm_group") {
sources = [
"$root_out_dir/skwasm/skwasm.js",
"$root_out_dir/skwasm/skwasm.js.symbols",
"$root_out_dir/skwasm/skwasm.wasm",
"$root_out_dir/skwasm/skwasm.worker.js",
]

3
engine/src/flutter/web_sdk/BUILD.gn
View File

@@ -546,10 +546,13 @@ if (!is_fuchsia) {
if (is_wasm) {
sources += [
"$root_out_dir/flutter_web_sdk/canvaskit/canvaskit.js",
"$root_out_dir/flutter_web_sdk/canvaskit/canvaskit.js.symbols",
"$root_out_dir/flutter_web_sdk/canvaskit/canvaskit.wasm",
"$root_out_dir/flutter_web_sdk/canvaskit/chromium/canvaskit.js",
"$root_out_dir/flutter_web_sdk/canvaskit/chromium/canvaskit.js.symbols",
"$root_out_dir/flutter_web_sdk/canvaskit/chromium/canvaskit.wasm",
"$root_out_dir/flutter_web_sdk/canvaskit/skwasm.js",
"$root_out_dir/flutter_web_sdk/canvaskit/skwasm.js.symbols",
"$root_out_dir/flutter_web_sdk/canvaskit/skwasm.wasm",
"$root_out_dir/flutter_web_sdk/canvaskit/skwasm.worker.js",
]