firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Impeller] dont inc shared_ptr count for every command/pipeline in render_pass_vk (flutter/engine#51874)

Browse Source 
We have to pay to inc/dec the shared_ptr, but all pipelines are persisted indefinitely so we shouldn't need to worry about dangling ptrs.
This commit is contained in:
Jonah Williams
2024-04-03 19:45:35 -07:00
committed by GitHub
parent b030a5fb23
commit e8b33af103
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_vk.cc
View File

@@ -24,7 +24,6 @@
#include "impeller/renderer/backend/vulkan/sampler_vk.h"
#include "impeller/renderer/backend/vulkan/shared_object_vk.h"
#include "impeller/renderer/backend/vulkan/texture_vk.h"
#include "impeller/renderer/backend/vulkan/vk.h"
#include "vulkan/vulkan_handles.hpp"
namespace impeller {
@@ -298,8 +297,7 @@ SharedHandleVK<vk::Framebuffer> RenderPassVK::CreateVKFramebuffer(
// |RenderPass|
void RenderPassVK::SetPipeline(
const std::shared_ptr<Pipeline<PipelineDescriptor>>& pipeline) {
pipeline_ = pipeline;
pipeline_ = pipeline.get();
if (!pipeline_) {
return;
}
@@ -456,7 +454,7 @@ fml::Status RenderPassVK::Draw() {
fml::StatusCode::kAborted,
"Could not create pipeline variant with immutable sampler.");
}
pipeline_ = std::move(pipeline_variant);
pipeline_ = pipeline_variant.get();
}
const auto& context_vk = ContextVK::Cast(*context_);

2
engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_vk.h
View File

@@ -49,7 +49,7 @@ class RenderPassVK final : public RenderPass {
size_t vertex_count_ = 0u;
bool has_index_buffer_ = false;
bool has_label_ = false;
std::shared_ptr<Pipeline<PipelineDescriptor>> pipeline_;
const Pipeline<PipelineDescriptor>* pipeline_;
bool pipeline_uses_input_attachments_ = false;
std::shared_ptr<SamplerVK> immutable_sampler_;