firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Temporarily remove the runs of the engine Dart tests with Impeller enabled (flutter/engine#46854)

Browse Source 
These tests are sometimes hanging when the flutter_tester deletes the ContextVK and ConcurrentMessageLoop during shutdown.
This commit is contained in:
Jason Simmons
2023-10-12 16:47:08 -07:00
committed by GitHub
parent 9d63adb09b
commit e7da0b1c5a
1 changed files with 16 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
engine/src/flutter/testing/run_tests.py
View File

@@ -867,38 +867,15 @@ def gather_dart_tests(build_dir, test_filter):
logger.info(
"Gathering dart test '%s' with observatory enabled", dart_test_file
)
yield gather_dart_test(
build_dir, dart_test_file,
FlutterTesterOptions(
multithreaded=True,
enable_impeller=False,
enable_observatory=True
)
)
yield gather_dart_test(
build_dir, dart_test_file,
FlutterTesterOptions(
multithreaded=True,
enable_impeller=True,
enable_observatory=True
)
)
yield gather_dart_test(
build_dir, dart_test_file,
FlutterTesterOptions(
multithreaded=False,
enable_impeller=False,
enable_observatory=True
)
)
yield gather_dart_test(
build_dir, dart_test_file,
FlutterTesterOptions(
multithreaded=False,
enable_impeller=True,
enable_observatory=True
)
)
for multithreaded, enable_impeller in [(True, False), (False, False)]:
yield gather_dart_test(
build_dir, dart_test_file,
FlutterTesterOptions(
multithreaded=multithreaded,
enable_impeller=enable_impeller,
enable_observatory=True
)
)
for dart_test_file in dart_tests:
if test_filter is not None and os.path.basename(dart_test_file
@@ -906,22 +883,13 @@ def gather_dart_tests(build_dir, test_filter):
logger.info("Skipping '%s' due to filter.", dart_test_file)
else:
logger.info("Gathering dart test '%s'", dart_test_file)
yield gather_dart_test(
build_dir, dart_test_file,
FlutterTesterOptions(multithreaded=True, enable_impeller=False)
)
yield gather_dart_test(
build_dir, dart_test_file,
FlutterTesterOptions(multithreaded=True, enable_impeller=True)
)
yield gather_dart_test(
build_dir, dart_test_file,
FlutterTesterOptions(multithreaded=False, enable_impeller=False)
)
yield gather_dart_test(
build_dir, dart_test_file,
FlutterTesterOptions(multithreaded=False, enable_impeller=True)
)
for multithreaded, enable_impeller in [(True, False), (False, False)]:
yield gather_dart_test(
build_dir, dart_test_file,
FlutterTesterOptions(
multithreaded=multithreaded, enable_impeller=enable_impeller
)
)
def gather_dart_smoke_test(build_dir, test_filter):