firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use identical instead of '==' in a constant expression. (#30921)

Browse Source 
* Use identical instead of '==' in a constant expression.

* Fix analyzer warnings.

* Fix analyzer warnings.
This commit is contained in:
Siva
2019-04-11 13:08:00 -07:00
committed by GitHub
parent cadde2459b
commit e7c7a58d5d
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/painting/flutter_logo.dart
View File

@@ -53,7 +53,7 @@ class FlutterLogoDecoration extends Decoration {
assert(textColor != null),
assert(style != null),
assert(margin != null),
_position = style == FlutterLogoStyle.markOnly ? 0.0 : style == FlutterLogoStyle.horizontal ? 1.0 : -1.0, // ignore: CONST_EVAL_TYPE_BOOL_NUM_STRING
_position = identical(style, FlutterLogoStyle.markOnly) ? 0.0 : identical(style, FlutterLogoStyle.horizontal) ? 1.0 : -1.0,
// (see https://github.com/dart-lang/sdk/issues/26980 for details about that ignore statement)
_opacity = 1.0;

20
packages/flutter/test/painting/flutter_logo_test.dart
View File

@@ -7,20 +7,20 @@ import 'package:flutter/painting.dart';
void main() {
// Here and below, see: https://github.com/dart-lang/sdk/issues/26980
final FlutterLogoDecoration start = FlutterLogoDecoration(
lightColor: const Color(0xFF000000),
darkColor: const Color(0xFFFFFFFF),
textColor: const Color(0xFFD4F144),
const FlutterLogoDecoration start = FlutterLogoDecoration(
lightColor: Color(0xFF000000),
darkColor: Color(0xFFFFFFFF),
textColor: Color(0xFFD4F144),
style: FlutterLogoStyle.stacked,
margin: const EdgeInsets.all(10.0),
margin: EdgeInsets.all(10.0),
);
final FlutterLogoDecoration end = FlutterLogoDecoration(
lightColor: const Color(0xFFFFFFFF),
darkColor: const Color(0xFF000000),
textColor: const Color(0xFF81D4FA),
const FlutterLogoDecoration end = FlutterLogoDecoration(
lightColor: Color(0xFFFFFFFF),
darkColor: Color(0xFF000000),
textColor: Color(0xFF81D4FA),
style: FlutterLogoStyle.stacked,
margin: const EdgeInsets.all(10.0),
margin: EdgeInsets.all(10.0),
);
test('FlutterLogoDecoration lerp from null to null is null', () {