firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add debug asserts to using SkVertices::Builder (flutter/engine#5292)

Browse Source 
Fixes flutter/flutter#9226
This commit is contained in:
liyuqian
2018-05-18 10:32:56 -07:00
committed by GitHub
parent 6351200ae7
commit d2b0840de3
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
engine/src/flutter/lib/ui/painting/vertices.cc
View File

@@ -60,12 +60,23 @@ void Vertices::init(SkVertices::VertexMode vertex_mode,
SkVertices::Builder builder(vertex_mode, positions.num_elements() / 2,
indices.num_elements(), builderFlags);
// positions are required for SkVertices::Builder
FXL_DCHECK(positions.data());
if (positions.data())
DecodePoints(positions, builder.positions());
if (texture_coordinates.data())
if (texture_coordinates.data()) {
// SkVertices::Builder assumes equal numbers of elements
FXL_DCHECK(positions.num_elements() == texture_coordinates.num_elements());
DecodePoints(texture_coordinates, builder.texCoords());
if (colors.data())
}
if (colors.data()) {
// SkVertices::Builder assumes equal numbers of elements
FXL_DCHECK(positions.num_elements() == colors.num_elements());
DecodeInts<SkColor>(colors, builder.colors());
}
if (indices.data())
DecodeInts<uint16_t>(indices, builder.indices());