cleanup test logger usage (#6560)

This commit is contained in:
Dan Rubel
2016-10-27 22:52:59 +01:00
committed by GitHub
parent 311d371a97
commit abba2ebc4e
2 changed files with 2 additions and 10 deletions

View File

@@ -3,7 +3,6 @@
// found in the LICENSE file.
import 'package:flutter_tools/src/android/android_device.dart';
import 'package:flutter_tools/src/base/logger.dart';
import 'package:test/test.dart';
import 'src/context.dart';
@@ -49,7 +48,6 @@ ZX1G22JJWR device usb:3-3 product:shamu model:Nexus_6 device:shamu f
expect(devices.first.name, 'Nexus 6');
});
BufferLogger logger = new BufferLogger();
testUsingContext('adb error message', () {
List<AndroidDevice> devices = getAdbDevices(mockAdbOutput: '''
It appears you do not have 'Android SDK Platform-tools' installed.
@@ -57,9 +55,7 @@ Use the 'android' tool to install them:
android update sdk --no-ui --filter 'platform-tools'
''');
expect(devices, hasLength(0));
expect(logger.errorText, contains('you do not have'));
}, overrides: <Type, dynamic>{
Logger : logger,
expect(testLogger.errorText, contains('you do not have'));
});
});

View File

@@ -7,7 +7,6 @@ import 'dart:convert';
import 'dart:io';
import 'package:args/command_runner.dart';
import 'package:flutter_tools/src/base/logger.dart';
import 'package:flutter_tools/src/cache.dart';
import 'package:flutter_tools/src/commands/create.dart';
import 'package:flutter_tools/src/dart/sdk.dart';
@@ -84,7 +83,6 @@ void main() {
});
// Verify that we help the user correct an option ordering issue
BufferLogger logger = new BufferLogger();
testUsingContext('produces sensible error message', () async {
Cache.flutterRoot = '../..';
@@ -93,9 +91,7 @@ void main() {
int code = await runner.run(<String>['create', temp.path, '--pub']);
expect(code, 2);
expect(logger.errorText, contains('Try moving --pub'));
}, overrides: <Type, dynamic>{
Logger: logger,
expect(testLogger.errorText, contains('Try moving --pub'));
});
// Verify that we fail with an error code when the file exists.