firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix race condition in test

Browse Source 
The |done| function comes from |it| not |describe|. Previously, we were just
ending the test right away.

R=rafaelw@chromium.org

Review URL: https://codereview.chromium.org/754463003
This commit is contained in:
Adam Barth
2014-11-21 16:08:31 -08:00
parent 96eb53d4ef
commit a1b7d730ce
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/tests/editing/delete_block_contents.sky
View File

@@ -4,8 +4,8 @@
This test verifies that the height of an editable block remains the same after adding block elements and removing them.
<div contenteditable="true" style="border: solid blue" id="test"></div>
<script>
describe("height of an editable block", function(done) {
it("remains the same after adding block elements and removing them", function() {
describe("height of an editable block", function() {
it("remains the same after adding block elements and removing them", function(done) {
var elem = document.getElementById("test");
var originalHeight = elem.offsetHeight;
var d = elem.appendChild(document.createElement('div'));