firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rebuild SliverAppBar when forceElevated changes (#59162)

Browse Source
This commit is contained in:
Per Classon
2020-06-10 23:15:02 +02:00
committed by GitHub
parent 319a61fd81
commit 8cf15ee2aa
2 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter/lib/src/material/app_bar.dart
View File

@@ -860,7 +860,8 @@ class _SliverAppBarDelegate extends SliverPersistentHeaderDelegate {
|| pinned != oldDelegate.pinned
|| floating != oldDelegate.floating
|| snapConfiguration != oldDelegate.snapConfiguration
|| stretchConfiguration != oldDelegate.stretchConfiguration;
|| stretchConfiguration != oldDelegate.stretchConfiguration
|| forceElevated != oldDelegate.forceElevated;
}
@override

25
packages/flutter/test/material/app_bar_test.dart
View File

@@ -891,6 +891,31 @@ void main() {
expect(tabBarHeight(tester), initialTabBarHeight);
});
testWidgets('SliverAppBar rebuilds when forceElevated changes', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/59158.
Widget buildSliverAppBar(bool forceElevated) {
return MaterialApp(
home: CustomScrollView(
slivers: <Widget>[
SliverAppBar(
title: const Text('Title'),
forceElevated: forceElevated,
),
],
),
);
}
final Finder appBarFinder = find.byType(AppBar);
AppBar getAppBarWidget(Finder finder) => tester.widget<AppBar>(finder);
await tester.pumpWidget(buildSliverAppBar(false));
expect(getAppBarWidget(appBarFinder).elevation, 0.0);
await tester.pumpWidget(buildSliverAppBar(true));
expect(getAppBarWidget(appBarFinder).elevation, 4.0);
});
testWidgets('AppBar dimensions, with and without bottom, primary', (WidgetTester tester) async {
const MediaQueryData topPadding100 = MediaQueryData(padding: EdgeInsets.only(top: 100.0));