firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify change notifier toString and handle nulls (#9368)

Browse Source
This commit is contained in:
xster
2017-04-12 23:09:40 -07:00
committed by GitHub
parent 819bb539f1
commit 8aacc288ce
2 changed files with 30 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/flutter/lib/src/foundation/change_notifier.dart
View File

@@ -161,15 +161,7 @@ class _MergingListenable extends ChangeNotifier {
@override
String toString() {
final StringBuffer buffer = new StringBuffer();
buffer.write('Listenable.merge([');
for (int i = 0; i < _children.length; ++i) {
buffer.write(_children[i].toString());
if (i < _children.length - 1)
buffer.write(', ');
}
buffer.write('])');
return buffer.toString();
return 'Listenable.merge([${_children.join(", ")}])';
}
}

29
packages/flutter/test/foundation/change_notifier_test.dart
View File

@@ -206,4 +206,33 @@ void main() {
notifier.value = 3.0;
expect(log, isEmpty);
});
test('Listenable.merge toString', () {
final TestNotifier source1 = new TestNotifier();
final TestNotifier source2 = new TestNotifier();
ChangeNotifier listenableUnderTest = new Listenable.merge(<Listenable>[]);
expect(listenableUnderTest.toString(), 'Listenable.merge([])');
listenableUnderTest = new Listenable.merge(<Listenable>[null]);
expect(listenableUnderTest.toString(), 'Listenable.merge([null])');
listenableUnderTest = new Listenable.merge(<Listenable>[source1]);
expect(
listenableUnderTest.toString(),
"Listenable.merge([Instance of 'TestNotifier'])",
);
listenableUnderTest = new Listenable.merge(<Listenable>[source1, source2]);
expect(
listenableUnderTest.toString(),
"Listenable.merge([Instance of 'TestNotifier', Instance of 'TestNotifier'])",
);
listenableUnderTest = new Listenable.merge(<Listenable>[null, source2]);
expect(
listenableUnderTest.toString(),
"Listenable.merge([null, Instance of 'TestNotifier'])",
);
});
}