firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Impeller] Don't override user specification on Vulkan validation in unopt. (flutter/engine#54816)

Browse Source 
This overrides the documented behavior silently but only in unopt. Make opt and unopt modes behave the same. Disabling validation is frequently necessary to test behavior on simulators or when connecting to Renderdoc.
This commit is contained in:
Chinmay Garde
2024-08-27 16:04:17 -07:00
committed by GitHub
parent 17cb4979af
commit 8856d9840c
1 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
engine/src/flutter/impeller/renderer/backend/vulkan/context_vk.cc
View File

@@ -157,18 +157,8 @@ void ContextVK::Setup(Settings settings) {
auto& dispatcher = VULKAN_HPP_DEFAULT_DISPATCHER;
dispatcher.init(settings.proc_address_callback);
// Enable Vulkan validation if either:
// 1. The user has explicitly enabled it.
// 2. We are in a combination of debug mode, and running on Android.
// (It's possible 2 is overly conservative and we can simplify this)
auto enable_validation = settings.enable_validation;
#if defined(FML_OS_ANDROID) && !defined(NDEBUG)
enable_validation = true;
#endif
auto caps = std::shared_ptr<CapabilitiesVK>(new CapabilitiesVK(
enable_validation, settings.fatal_missing_validations));
settings.enable_validation, settings.fatal_missing_validations));
if (!caps->IsValid()) {
VALIDATION_LOG << "Could not determine device capabilities.";