firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Border.symmetric: phase 2 (#61666)

Browse Source 
This updates the default value of the `invertMeaningOfVerticalAndHorizontal`
argument from true to false.

https://github.com/flutter/flutter/issues/61470
This commit is contained in:
Todd Volkert
2020-07-16 23:14:44 -07:00
committed by GitHub
parent b0c146c51b
commit 7ea710c56e
2 changed files with 16 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/flutter/lib/src/painting/box_border.dart
View File

@@ -332,20 +332,16 @@ class Border extends BoxBorder {
///
/// All arguments default to [BorderSide.none] and must not be null.
///
/// Currently, the `vertical` argument will apply to the top and bottom
/// borders, and the `horizontal` argument will apply to the left and right
/// borders. This is not consistent with the use of "vertical" and
/// "horizontal" elsewhere in the framework, so the
/// `invertMeaningOfVerticalAndHorizontal` argument exists to facilitate
/// the transition of this constructor to using the correct semantics of
/// these arguments. Callers are encouraged to pass false to that argument
/// to get the correct semantics. In a future change, the default value of
/// the argument will be changed to false, followed by the removal of the
/// argument altogether.
/// If the `invertMeaningOfVerticalAndHorizontal` argument is set to true,
/// then the `vertical` argument will apply to the top and bottom borders, and
/// the `horizontal` argument will apply to the left and right borders. This
/// is not consistent with the use of "vertical" and "horizontal" elsewhere in
/// the framework, so callers are discouraged from overriding the default
/// value of that argument. In a future change, the argument will be removed.
const Border.symmetric({
BorderSide vertical = BorderSide.none,
BorderSide horizontal = BorderSide.none,
bool invertMeaningOfVerticalAndHorizontal = true,
bool invertMeaningOfVerticalAndHorizontal = false,
}) : assert(vertical != null),
assert(horizontal != null),
assert(invertMeaningOfVerticalAndHorizontal != null),

18
packages/flutter/test/painting/border_test.dart
View File

@@ -31,19 +31,19 @@ void main() {
const BorderSide side1 = BorderSide(color: Color(0xFFFFFFFF));
const BorderSide side2 = BorderSide(color: Color(0xFF000000));
const Border border = Border.symmetric(vertical: side1, horizontal: side2);
expect(border.left, same(side2));
expect(border.top, same(side1));
expect(border.right, same(side2));
expect(border.bottom, same(side1));
expect(border.left, same(side1));
expect(border.top, same(side2));
expect(border.right, same(side1));
expect(border.bottom, same(side2));
const Border border2 = Border.symmetric(
vertical: side1,
horizontal: side2,
invertMeaningOfVerticalAndHorizontal: false,
invertMeaningOfVerticalAndHorizontal: true,
);
expect(border2.left, same(side1));
expect(border2.top, same(side2));
expect(border2.right, same(side1));
expect(border2.bottom, same(side2));
expect(border2.left, same(side2));
expect(border2.top, same(side1));
expect(border2.right, same(side2));
expect(border2.bottom, same(side1));
});
test('Border.merge', () {