firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix clang_tidy lints (flutter/engine#44740)

Browse Source
This commit is contained in:
John McCutchan
2023-08-15 16:40:32 -07:00
committed by GitHub
parent fdd3eaf715
commit 7bf371d161
4 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/shell/platform/android/surface_texture_external_texture.cc
View File

@@ -24,9 +24,9 @@ namespace flutter {
SurfaceTextureExternalTexture::SurfaceTextureExternalTexture(
int64_t id,
const fml::jni::ScopedJavaGlobalRef<jobject>& surface_texture,
std::shared_ptr<PlatformViewAndroidJNI> jni_facade)
const std::shared_ptr<PlatformViewAndroidJNI>& jni_facade)
: Texture(id),
jni_facade_(std::move(jni_facade)),
jni_facade_(jni_facade),
surface_texture_(surface_texture),
transform_(SkMatrix::I()) {}

2
engine/src/flutter/shell/platform/android/surface_texture_external_texture.h
View File

@@ -18,7 +18,7 @@ class SurfaceTextureExternalTexture : public flutter::Texture {
SurfaceTextureExternalTexture(
int64_t id,
const fml::jni::ScopedJavaGlobalRef<jobject>& surface_texture,
std::shared_ptr<PlatformViewAndroidJNI> jni_facade);
const std::shared_ptr<PlatformViewAndroidJNI>& jni_facade);
~SurfaceTextureExternalTexture() override;

12
engine/src/flutter/shell/platform/android/surface_texture_external_texture_gl.cc
View File

@@ -24,11 +24,13 @@ namespace flutter {
SurfaceTextureExternalTextureGL::SurfaceTextureExternalTextureGL(
int64_t id,
const fml::jni::ScopedJavaGlobalRef<jobject>& surface_texture,
std::shared_ptr<PlatformViewAndroidJNI> jni_facade)
const std::shared_ptr<PlatformViewAndroidJNI>& jni_facade)
: SurfaceTextureExternalTexture(id, surface_texture, jni_facade) {}
SurfaceTextureExternalTextureGL::~SurfaceTextureExternalTextureGL() {
Detach();
if (texture_name_ != 0) {
glDeleteTextures(1, &texture_name_);
}
}
void SurfaceTextureExternalTextureGL::ProcessFrame(PaintContext& context,
@@ -66,14 +68,12 @@ SurfaceTextureExternalTextureImpellerGL::
const std::shared_ptr<impeller::ContextGLES>& context,
int64_t id,
const fml::jni::ScopedJavaGlobalRef<jobject>& surface_texture,
std::shared_ptr<PlatformViewAndroidJNI> jni_facade)
const std::shared_ptr<PlatformViewAndroidJNI>& jni_facade)
: SurfaceTextureExternalTexture(id, surface_texture, jni_facade),
impeller_context_(context) {}
SurfaceTextureExternalTextureImpellerGL::
~SurfaceTextureExternalTextureImpellerGL() {
Detach();
}
~SurfaceTextureExternalTextureImpellerGL() {}
void SurfaceTextureExternalTextureImpellerGL::ProcessFrame(
PaintContext& context,

4
engine/src/flutter/shell/platform/android/surface_texture_external_texture_gl.h
View File

@@ -23,7 +23,7 @@ class SurfaceTextureExternalTextureGL : public SurfaceTextureExternalTexture {
SurfaceTextureExternalTextureGL(
int64_t id,
const fml::jni::ScopedJavaGlobalRef<jobject>& surface_texture,
std::shared_ptr<PlatformViewAndroidJNI> jni_facade);
const std::shared_ptr<PlatformViewAndroidJNI>& jni_facade);
~SurfaceTextureExternalTextureGL() override;
@@ -44,7 +44,7 @@ class SurfaceTextureExternalTextureImpellerGL
const std::shared_ptr<impeller::ContextGLES>& context,
int64_t id,
const fml::jni::ScopedJavaGlobalRef<jobject>& surface_texture,
std::shared_ptr<PlatformViewAndroidJNI> jni_facade);
const std::shared_ptr<PlatformViewAndroidJNI>& jni_facade);
~SurfaceTextureExternalTextureImpellerGL() override;