firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure vsync callback completes before resetting the engine. (flutter/engine#29488)

Browse Source 
Fixes: https://github.com/flutter/flutter/issues/92934
This commit is contained in:
Kaushik Iska
2021-11-02 18:38:42 -04:00
committed by GitHub
parent 0dd03a073c
commit 6a3b2c0194
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
engine/src/flutter/shell/platform/embedder/tests/embedder_unittests.cc
View File

@@ -1592,6 +1592,7 @@ TEST_F(EmbedderTest, BackToBackKeyEventResponsesCorrectlyInvoked) {
TEST_F(EmbedderTest, VsyncCallbackPostedIntoFuture) {
UniqueEngine engine;
fml::AutoResetWaitableEvent present_latch;
fml::AutoResetWaitableEvent vsync_latch;
// One of the threads that the callback (FlutterEngineOnVsync) will be posted
// to is the platform thread. So we cannot wait for assertions to complete on
@@ -1604,9 +1605,10 @@ TEST_F(EmbedderTest, VsyncCallbackPostedIntoFuture) {
GetEmbedderContext(EmbedderTestContextType::kSoftwareContext);
context.SetVsyncCallback([&](intptr_t baton) {
platform_task_runner->PostTask([baton = baton, engine = engine.get()]() {
FlutterEngineOnVsync(engine, baton, NanosFromEpoch(16),
platform_task_runner->PostTask([baton = baton, &engine, &vsync_latch]() {
FlutterEngineOnVsync(engine.get(), baton, NanosFromEpoch(16),
NanosFromEpoch(32));
vsync_latch.Signal();
});
});
context.AddNativeCallback(
@@ -1632,6 +1634,7 @@ TEST_F(EmbedderTest, VsyncCallbackPostedIntoFuture) {
kSuccess);
});
vsync_latch.Wait();
present_latch.Wait();
fml::AutoResetWaitableEvent shutdown_latch;