firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[iOS] Fixes key press related memory leaks (flutter/engine#29127)

Browse Source
This commit is contained in:
Wu Zhong
2021-10-22 04:14:33 +08:00
committed by GitHub
parent 30bcce9a86
commit 69b26c89ec
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEmbedderKeyResponder.mm
View File

@@ -158,7 +158,7 @@ static uint64_t GetLogicalKeyForEvent(FlutterUIPressProxy* press, uint64_t physi
const char* characters =
getEventCharacters(press.key.charactersIgnoringModifiers, press.key.keyCode);
NSString* keyLabel =
characters == nullptr ? nil : [[NSString alloc] initWithUTF8String:characters];
characters == nullptr ? nil : [[[NSString alloc] initWithUTF8String:characters] autorelease];
NSUInteger keyLabelLength = [keyLabel length];
// If this key is printable, generate the logical key from its Unicode
// value. Control keys such as ESC, CTRL, and SHIFT are not printable. HOME,
@@ -514,11 +514,11 @@ void HandleResponse(bool handled, void* user_data);
FlutterKeyCallbackGuard* guardedCallback = nil;
switch (press.phase) {
case UIPressPhaseBegan:
guardedCallback = [[FlutterKeyCallbackGuard alloc] initWithCallback:callback];
guardedCallback = [[[FlutterKeyCallbackGuard alloc] initWithCallback:callback] autorelease];
[self handlePressBegin:press callback:guardedCallback];
break;
case UIPressPhaseEnded:
guardedCallback = [[FlutterKeyCallbackGuard alloc] initWithCallback:callback];
guardedCallback = [[[FlutterKeyCallbackGuard alloc] initWithCallback:callback] autorelease];
[self handlePressEnd:press callback:guardedCallback];
break;
case UIPressPhaseChanged:
@@ -623,7 +623,7 @@ void HandleResponse(bool handled, void* user_data);
_responseId += 1;
uint64_t responseId = _responseId;
FlutterKeyPendingResponse* pending =
[[FlutterKeyPendingResponse alloc] initWithHandler:self responseId:responseId];
[[[FlutterKeyPendingResponse alloc] initWithHandler:self responseId:responseId] autorelease];
[callback pendTo:_pendingResponses withId:responseId];
_sendEvent(event, HandleResponse, pending);
}