Revert "[macos] Move TextInputPlugin outside of visible area (#39031)" (flutter/engine#39176)

This reverts commit d06ef7a5bf.
This commit is contained in:
Zachary Anderson
2023-01-26 13:47:58 -08:00
committed by GitHub
parent d06ef7a5bf
commit 56a4d347ae
2 changed files with 2 additions and 19 deletions

View File

@@ -245,9 +245,8 @@ static char markerKey;
}
- (instancetype)initWithViewController:(FlutterViewController*)viewController {
// The view needs an empty frame otherwise it is visible on dark background.
// https://github.com/flutter/flutter/issues/118504
self = [super initWithFrame:NSZeroRect];
// The view needs a non-zero frame.
self = [super initWithFrame:NSMakeRect(0, 0, 1, 1)];
if (self != nil) {
_flutterViewController = viewController;
_channel = [FlutterMethodChannel methodChannelWithName:kTextInputChannel

View File

@@ -1532,20 +1532,4 @@ TEST(FlutterTextInputPluginTest, IsAddedAndRemovedFromViewHierarchy) {
ASSERT_FALSE(window.firstResponder == viewController.textInputPlugin);
}
TEST(FlutterTextInputPluginTest, HasZeroSize) {
id engineMock = OCMClassMock([FlutterEngine class]);
id binaryMessengerMock = OCMProtocolMock(@protocol(FlutterBinaryMessenger));
OCMStub( // NOLINT(google-objc-avoid-throwing-exception)
[engineMock binaryMessenger])
.andReturn(binaryMessengerMock);
FlutterViewController* viewController = [[FlutterViewController alloc] initWithEngine:engineMock
nibName:@""
bundle:nil];
FlutterTextInputPlugin* plugin =
[[FlutterTextInputPlugin alloc] initWithViewController:viewController];
ASSERT_TRUE(NSIsEmptyRect(plugin.frame));
}
} // namespace flutter::testing