Remove --trace-gn from ./flutter/tools/gn (flutter/engine#52964)
This flag as originally introduced to see if it made the GN step slower. It did not do so in any measurable manner and the default was flipped to true. AFAICT, no one disables and its good to have tracelogs to debug GN slowdowns. Remove the flag.
This commit is contained in:
@@ -1195,14 +1195,6 @@ def parse_args(args):
|
||||
help='Whether the -fstack-protector flag should be passed unconditionally.'
|
||||
)
|
||||
|
||||
parser.add_argument(
|
||||
'--trace-gn',
|
||||
default=True,
|
||||
action='store_true',
|
||||
help='Write a GN trace log (gn_trace.json) in the Chromium tracing '
|
||||
'format in the build directory.'
|
||||
)
|
||||
|
||||
parser.add_argument(
|
||||
'--darwin-extension-safe',
|
||||
default=False,
|
||||
@@ -1287,9 +1279,7 @@ def main(argv):
|
||||
out_dir = get_out_dir(args)
|
||||
command.append(out_dir)
|
||||
command.append('--args=%s' % ' '.join(gn_args))
|
||||
|
||||
if args.trace_gn:
|
||||
command.append('--tracelog=%s/gn_trace.json' % out_dir)
|
||||
command.append('--tracelog=%s/gn_trace.json' % out_dir)
|
||||
|
||||
if args.verbose:
|
||||
command.append('-v')
|
||||
|
||||
Reference in New Issue
Block a user