Related to https://github.com/flutter/flutter/issues/137177

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This commit is contained in:
Kate Lovett
2023-10-31 11:45:14 -05:00
committed by GitHub
parent 3a12ca33cd
commit 285a6acf76
5 changed files with 38 additions and 38 deletions

View File

@@ -441,7 +441,7 @@ targets:
config_name: mac_host_engine
dependencies: >-
[
{"dependency": "goldctl", "version": "git_revision:f808dcff91b221ae313e540c09d79696cd08b8de"}
{"dependency": "goldctl", "version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"}
]
$flutter/osx_sdk : >-
{

View File

@@ -351,7 +351,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -387,7 +387,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -423,7 +423,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -459,7 +459,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -495,7 +495,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -531,7 +531,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -567,7 +567,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -603,7 +603,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -639,7 +639,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "firefox",
@@ -675,7 +675,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "firefox",
@@ -711,7 +711,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "firefox",
@@ -747,7 +747,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "firefox",
@@ -783,7 +783,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "firefox",
@@ -819,7 +819,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -855,7 +855,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -891,7 +891,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -927,7 +927,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -963,7 +963,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -999,7 +999,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -1035,7 +1035,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -1071,7 +1071,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -1107,7 +1107,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
}
],
"tasks": [
@@ -1139,7 +1139,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
}
],
"tasks": [
@@ -1171,7 +1171,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
}
],
"tasks": [
@@ -1203,7 +1203,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
}
],
"tasks": [
@@ -1235,7 +1235,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
}
],
"tasks": [
@@ -1267,7 +1267,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -1303,7 +1303,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -1339,7 +1339,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -1375,7 +1375,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -1411,7 +1411,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -1447,7 +1447,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -1483,7 +1483,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",
@@ -1519,7 +1519,7 @@
"test_dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
},
{
"dependency": "chrome_and_driver",

View File

@@ -146,7 +146,7 @@
"dependencies": [
{
"dependency": "goldctl",
"version": "git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09"
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
}
],
"gclient_variables": {

View File

@@ -206,7 +206,7 @@ After rolling Chrome and/or Firefox, also update the CI dependencies in
[
{"dependency": "chrome_and_driver", "version": "version:107.0"},
{"dependency": "firefox", "version": "version:83.0"},
{"dependency": "goldctl", "version": "git_revision:3a77d0b12c697a840ca0c7705208e8622dc94603"}
{"dependency": "goldctl", "version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"}
]
```

View File

@@ -154,7 +154,7 @@ Iterable<dynamic> _getTestStepsForPlatform(
'test_dependencies': <dynamic>[
<String, dynamic>{
'dependency': 'goldctl',
'version': 'git_revision:dddc0623e63150cbbafdcb273d4048f329e1dd09',
'version': 'git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd',
},
if (suite.runConfig.browser == BrowserName.chrome)
<String, dynamic>{