firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correct typos, adopt US spellings (flutter/engine#9081)

Browse Source 
Corects a bnuch of typeos throughout teh engien codebsae. Also makes
a couple minor Commonwealth -> US spelling adjustments for consistency
with the rest of Flutter's codebase.

Made use of `misspell` tool:
https://github.com/client9/misspell
This commit is contained in:
Chris Bracken
2019-05-25 13:14:46 -07:00
committed by GitHub
parent 03d5bb8f53
commit 21fd6fb32a
37 changed files with 57 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/ci/licenses.sh
View File

@@ -36,7 +36,7 @@ then
echo "changed, no diffs are typically expected in the output of the"
echo "script. Verify the output, and if it looks correct, update the"
echo "license tool signature golden file:"
echo " ci/licences_golden/tool_signature"
echo " ci/licenses_golden/tool_signature"
echo "For more information, see the script in:"
echo " https://github.com/flutter/engine/tree/master/tools/licenses"
echo ""

2
engine/src/flutter/ci/licenses_golden/tool_signature
View File

@@ -1,2 +1,2 @@
Signature: ab4f82ed4f38f0d3821073855c220992
Signature: ad6590b867473860a1e6b08bf9e98667

2
engine/src/flutter/fml/platform/linux/timerfd.cc
View File

@@ -46,7 +46,7 @@ bool TimerRearm(int fd, fml::TimePoint time_point) {
}
bool TimerDrain(int fd) {
// 8 bytes must be read from a signalled timer file descriptor when signalled.
// 8 bytes must be read from a signaled timer file descriptor when signaled.
uint64_t fire_count = 0;
ssize_t size = FML_HANDLE_EINTR(::read(fd, &fire_count, sizeof(uint64_t)));
if (size != sizeof(uint64_t)) {

2
engine/src/flutter/fml/platform/linux/timerfd.h
View File

@@ -46,7 +46,7 @@ namespace fml {
/// Rearms the timer to expire at the given time point.
bool TimerRearm(int fd, fml::TimePoint time_point);
/// Drains the timer FD and retuns true if it has expired. This may be false in
/// Drains the timer FD and returns true if it has expired. This may be false in
/// case the timer read is non-blocking and this routine was called before the
/// timer expiry.
bool TimerDrain(int fd);

2
engine/src/flutter/lib/ui/text.dart
View File

@@ -381,7 +381,7 @@ bool _listEquals<T>(List<T> a, List<T> b) {
//
// The encoded array buffer has 8 elements.
//
// - Element 0: A bit field where the ith bit indicates wheter the ith element
// - Element 0: A bit field where the ith bit indicates whether the ith element
// has a non-null value. Bits 8 to 12 indicate whether |fontFamily|,
// |fontSize|, |letterSpacing|, |wordSpacing|, and |height| are non-null,
// respectively. Bit 0 is unused.

2
engine/src/flutter/runtime/runtime_controller.cc
View File

@@ -100,7 +100,7 @@ RuntimeController::RuntimeController(
tonic::DartState::Scope scope(strong_root_isolate);
window->DidCreateIsolate();
if (!FlushRuntimeStateToIsolate()) {
FML_DLOG(ERROR) << "Could not setup intial isolate state.";
FML_DLOG(ERROR) << "Could not setup initial isolate state.";
}
} else {
FML_DCHECK(false) << "RuntimeController created without window binding.";

4
engine/src/flutter/shell/common/shell.cc
View File

@@ -452,7 +452,7 @@ void Shell::OnPlatformViewCreated(std::unique_ptr<Surface> surface) {
latch.Signal();
});
// The normal flow exectued by this method is that the platform thread is
// The normal flow executed by this method is that the platform thread is
// starting the sequence and waiting on the latch. Later the UI thread posts
// gpu_task to the GPU thread which signals the latch. If the GPU the and
// platform threads are the same this results in a deadlock as the gpu_task
@@ -545,7 +545,7 @@ void Shell::OnPlatformViewDestroyed() {
fml::TaskRunner::RunNowOrPostTask(io_task_runner, io_task);
};
// The normal flow exectued by this method is that the platform thread is
// The normal flow executed by this method is that the platform thread is
// starting the sequence and waiting on the latch. Later the UI thread posts
// gpu_task to the GPU thread triggers signaling the latch(on the IO thread).
// If the GPU the and platform threads are the same this results in a deadlock

2
engine/src/flutter/shell/common/vsync_waiter.h
View File

@@ -27,7 +27,7 @@ class VsyncWaiter : public std::enable_shared_from_this<VsyncWaiter> {
static constexpr float kUnknownRefreshRateFPS = 0.0;
// Get the display's maximum refresh rate in the unit of frame per second.
// Return kUnknownRefreshRateFPS if the refresh rate is unkonwn.
// Return kUnknownRefreshRateFPS if the refresh rate is unknown.
virtual float GetDisplayRefreshRate() const;
protected:

2
engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java
View File

@@ -225,7 +225,7 @@ public class PlatformPlugin implements ActivityLifecycleListener {
}
}
if (systemChromeStyle.systemNavigationBarDividerColor != null) {
// Not availible until Android P.
// Not available until Android P.
// window.setNavigationBarDividerColor(systemNavigationBarDividerColor);
}
view.setSystemUiVisibility(flags);

2
engine/src/flutter/shell/platform/android/io/flutter/view/VsyncWaiter.java
View File

@@ -11,7 +11,7 @@ public class VsyncWaiter {
public static long refreshPeriodNanos = 1000000000 / 60;
// This should also be updated by FlutterView when it is attached to a Display.
// The initial value of 0.0 indicates unkonwn refresh rate.
// The initial value of 0.0 indicates unknown refresh rate.
public static float refreshRateFPS = 0.0f;
public static void asyncWaitForVsync(final long cookie) {

2
engine/src/flutter/shell/platform/common/cpp/client_wrapper/README
View File

@@ -2,7 +2,7 @@ This code is intended to be built into plugins and applications to provide
higher-level, C++ abstractions for interacting with the Flutter library.
Over time, the goal is to move more of this code into the library in a way that
provides a usable ABI (e.g., does not use standard libary in the interfaces).
provides a usable ABI (e.g., does not use standard library in the interfaces).
Note that this wrapper is still in early stages. Expect significant churn in
both the APIs and the structure of the wrapper (e.g., the exact set of files

2
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterPlugin.h
View File

@@ -246,7 +246,7 @@ typedef void (*FlutterPluginRegistrantCallback)(NSObject<FlutterPluginRegistry>*
- (NSObject<FlutterTextureRegistry>*)textures;
/**
* Registers a `FlutterPlatformViewFactory` for creation of platfrom views.
* Registers a `FlutterPlatformViewFactory` for creation of platform views.
*
* Plugins expose `UIView` for embedding in Flutter apps by registering a view factory.
*

2
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterViewController.h
View File

@@ -119,7 +119,7 @@ FLUTTER_EXPORT
/**
* Instructs the Flutter Navigator (if any) to push a route on to the navigation
* stack. The setInitialRoute method should be prefered if this is called before the
* stack. The setInitialRoute method should be preferred if this is called before the
* FlutterViewController has come into view.
*
* @param route The name of the route to push to the navigation stack.

2
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterObservatoryPublisher.mm
View File

@@ -12,7 +12,7 @@
#if TARGET_IPHONE_SIMULATOR
#include <dns_sd.h> // nogncheck
#include <net/if.h> // nogncheck
#endif // TARGET_IPHONE_SIMLUATOR
#endif // TARGET_IPHONE_SIMULATOR
#import "FlutterObservatoryPublisher.h"

2
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm
View File

@@ -44,7 +44,7 @@ void FlutterPlatformViewsController::OnMethodCall(FlutterMethodCall* call, Flutt
void FlutterPlatformViewsController::OnCreate(FlutterMethodCall* call, FlutterResult& result) {
if (!flutter_view_.get()) {
// Right now we assume we have a reference to FlutterView when creating a new view.
// TODO(amirh): support this by setting the refernce to FlutterView when it becomes available.
// TODO(amirh): support this by setting the reference to FlutterView when it becomes available.
// https://github.com/flutter/flutter/issues/23787
result([FlutterError errorWithCode:@"create_failed"
message:@"can't create a view on a headless engine"

2
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm
View File

@@ -629,7 +629,7 @@ static UIReturnKeyType ToUIReturnKeyType(NSString* inputType) {
// https://github.com/flutter/flutter/issues/21745
//
// This is needed for correct handling of the deletion of Thai vowel input.
// TODO(cbracken): Get a good understanding of expected behaviour of Thai
// TODO(cbracken): Get a good understanding of expected behavior of Thai
// input and ensure that this is the correct solution.
// https://github.com/flutter/flutter/issues/28962
if (_selectedTextRange.isEmpty && [self hasText]) {

2
engine/src/flutter/shell/platform/darwin/macos/framework/Source/FLETextInputModel.mm
View File

@@ -21,7 +21,7 @@ static NSString* const kTextKey = @"text";
/**
* These three static methods are necessary because Cocoa and Flutter have different idioms for
* signalling an empty range: Flutter uses {-1, -1} while Cocoa uses {NSNotFound, 0}. Also,
* signaling an empty range: Flutter uses {-1, -1} while Cocoa uses {NSNotFound, 0}. Also,
* despite the name, the "extent" fields are actually end indices, not lengths.
*/

2
engine/src/flutter/shell/platform/embedder/embedder.cc
View File

@@ -771,7 +771,7 @@ FlutterEngineResult FlutterEngineSendPointerEvent(
pointer_data.scroll_delta_x = SAFE_ACCESS(current, scroll_delta_x, 0.0);
pointer_data.scroll_delta_y = SAFE_ACCESS(current, scroll_delta_y, 0.0);
FlutterPointerDeviceKind device_kind = SAFE_ACCESS(current, device_kind, 0);
// For backwards compatibilty with embedders written before the device kind
// For backwards compatibility with embedders written before the device kind
// and buttons were exposed, if the device kind is not set treat it as a
// mouse, with a synthesized primary button state based on the phase.
if (device_kind == 0) {

2
engine/src/flutter/shell/platform/embedder/embedder.h
View File

@@ -483,7 +483,7 @@ typedef struct {
size_t struct_size;
// The unique custom action or action override ID.
int32_t id;
// For overriden standard actions, corresponds to the
// For overridden standard actions, corresponds to the
// |FlutterSemanticsAction| to override.
FlutterSemanticsAction override_action;
// The user-readable name of this custom semantics action.

10
engine/src/flutter/shell/platform/embedder/tests/embedder_unittests.cc
View File

@@ -151,12 +151,12 @@ TEST_F(EmbedderTest, CanSpecifyCustomTaskRunner) {
// pump its event loop while we wait for all the conditions to be checked.
fml::Thread thread;
UniqueEngine engine;
bool signalled = false;
bool signaled = false;
EmbedderTestTaskRunner runner([&](FlutterTask task) {
// There may be multiple tasks posted but we only need to check assertions
// once.
if (signalled) {
if (signaled) {
// Since we have the baton, return it back to the engine. We don't care
// about the return value because the engine could be shutting down an it
// may not actually be able to accept the same.
@@ -164,7 +164,7 @@ TEST_F(EmbedderTest, CanSpecifyCustomTaskRunner) {
return;
}
signalled = true;
signaled = true;
FML_LOG(INFO) << "Checking assertions.";
ASSERT_TRUE(engine.is_valid());
ASSERT_EQ(FlutterEngineRunTask(engine.get(), &task), kSuccess);
@@ -182,7 +182,7 @@ TEST_F(EmbedderTest, CanSpecifyCustomTaskRunner) {
ASSERT_TRUE(engine.is_valid());
});
// Signalled when all the assertions are checked.
// Signaled when all the assertions are checked.
latch.Wait();
FML_LOG(INFO) << "Assertions checked. Killing engine.";
ASSERT_TRUE(engine.is_valid());
@@ -198,7 +198,7 @@ TEST_F(EmbedderTest, CanSpecifyCustomTaskRunner) {
}));
kill_latch.Wait();
ASSERT_TRUE(signalled);
ASSERT_TRUE(signaled);
}
TEST(EmbedderTestNoFixture, CanGetCurrentTimeInNanoseconds) {

2
engine/src/flutter/shell/platform/fuchsia/flutter/README.md
View File

@@ -1,4 +1,4 @@
Flutter Application Runner
==========================
Implements the `fuchsia::sys::Runner` FIDL interface to launch and run mutliple Flutter applications within the same process.
Implements the `fuchsia::sys::Runner` FIDL interface to launch and run multiple Flutter applications within the same process.

4
engine/src/flutter/shell/platform/fuchsia/flutter/engine.cc
View File

@@ -80,8 +80,8 @@ Engine::Engine(Delegate& delegate,
environment->GetServices(parent_environment_service_provider.NewRequest());
environment.Unbind();
// Grab the accessibilty context writer that can understand the semantics tree
// on the platform view.
// Grab the accessibility context writer that can understand the semantics
// tree on the platform view.
fidl::InterfaceHandle<fuchsia::modular::ContextWriter>
accessibility_context_writer;
svc->Connect(accessibility_context_writer.NewRequest());

4
engine/src/flutter/shell/platform/fuchsia/flutter/platform_view.cc
View File

@@ -583,8 +583,8 @@ void PlatformView::HandlePlatformMessage(
if (found == platform_message_handlers_.end()) {
FML_LOG(ERROR)
<< "Platform view received message on channel '" << message->channel()
<< "' with no registed handler. And empty response will be generated. "
"Please implement the native message handler.";
<< "' with no registered handler. And empty response will be "
"generated. Please implement the native message handler.";
flutter::PlatformView::HandlePlatformMessage(std::move(message));
return;
}

2
engine/src/flutter/shell/platform/fuchsia/flutter/runner.cc
View File

@@ -156,7 +156,7 @@ void Runner::StartComponent(
auto thread_application_pair = Application::Create(
std::move(termination_callback), // termination callback
std::move(package), // application pacakge
std::move(package), // application package
std::move(startup_info), // startup info
runner_context_->svc(), // runner incoming services
std::move(controller) // controller request

2
engine/src/flutter/third_party/txt/src/minikin/FontCollection.cpp vendored
View File

@@ -235,7 +235,7 @@ uint32_t FontCollection::calcCoverageScore(
}
// Calculate font scores based on the script matching, subtag matching and
// primary langauge matching.
// primary language matching.
//
// 1. If only the font's language matches or there is no matches between
// requested font and

2
engine/src/flutter/third_party/txt/src/txt/paint_record.h vendored
View File

@@ -26,7 +26,7 @@
namespace txt {
// PaintRecord holds the layout data after Paragraph::Layout() is called. This
// stores all nessecary offsets, blobs, metrics, and more for Skia to draw the
// stores all necessary offsets, blobs, metrics, and more for Skia to draw the
// text.
class PaintRecord {
public:

4
engine/src/flutter/third_party/txt/src/txt/paragraph.h vendored
View File

@@ -39,8 +39,8 @@ namespace txt {
using GlyphID = uint32_t;
// Paragraph provides Layout, metrics, and painting capabilites for text. Once a
// Paragraph is constructed with ParagraphBuilder::Build(), an example basic
// Paragraph provides Layout, metrics, and painting capabilities for text. Once
// a Paragraph is constructed with ParagraphBuilder::Build(), an example basic
// workflow can be this:
//
// std::unique_ptr<Paragraph> paragraph = paragraph_builder.Build();

2
engine/src/flutter/third_party/txt/src/txt/paragraph_style.h vendored
View File

@@ -72,7 +72,7 @@ class ParagraphStyle {
std::string locale;
// Default strategy is kBreakStrategy_Greedy. Sometimes,
// kBreakStrategy_HighQuality will produce more desireable layouts (eg, very
// kBreakStrategy_HighQuality will produce more desirable layouts (e.g., very
// long words are more likely to be reasonably placed).
// kBreakStrategy_Balanced will balance between the two.
minikin::BreakStrategy break_strategy =

4
engine/src/flutter/third_party/txt/tests/CmapCoverageTest.cpp vendored
View File

@@ -59,7 +59,7 @@ static std::vector<uint8_t> buildCmapFormat4Table(
size_t head = 0;
head = writeU16(4, out.data(), head); // format
head = writeU16(finalLength, out.data(), head); // length
head = writeU16(0, out.data(), head); // langauge
head = writeU16(0, out.data(), head); // language
const uint16_t searchRange =
2 * (1 << static_cast<int>(floor(log2(segmentCount))));
@@ -120,7 +120,7 @@ static std::vector<uint8_t> buildCmapFormat12Table(
head = writeU16(12, out.data(), head); // format
head = writeU16(0, out.data(), head); // reserved
head = writeU32(finalLength, out.data(), head); // length
head = writeU32(0, out.data(), head); // langauge
head = writeU32(0, out.data(), head); // language
head = writeU32(numGroups, out.data(), head); // numGroups
for (uint32_t i = 0; i < numGroups; ++i) {

4
engine/src/flutter/third_party/txt/tests/FontCollectionItemizeTest.cpp vendored
View File

@@ -1311,12 +1311,12 @@ TEST_F(FontCollectionItemizeTest, itemize_emojiSelection_withFE0F) {
const FontStyle kDefaultFontStyle;
// U+00A9 is a text default emoji which is available only in
// TextEmojiFont.ttf. TextEmojiFont.ttf shoudl be selected.
// TextEmojiFont.ttf. TextEmojiFont.ttf should be selected.
itemize(collection, "U+00A9 U+FE0F", kDefaultFontStyle, &runs);
ASSERT_EQ(1U, runs.size());
EXPECT_EQ(0, runs[0].start);
EXPECT_EQ(2, runs[0].end);
// Color emoji is specified but it is not available. Use text representaion
// Color emoji is specified but it is not available. Use text representation
// instead.
EXPECT_EQ(kTextEmojiFont, getFontPath(runs[0]));

10
engine/src/flutter/third_party/txt/tests/GraphemeBreakTests.cpp vendored
View File

@@ -289,7 +289,7 @@ TEST(GraphemeBreak, DISABLED_emojiModifiers) {
EXPECT_FALSE(IsBreak("U+1F466 | U+1F3FF")); // boy + modifier
EXPECT_FALSE(IsBreak("U+1F918 | U+1F3FF")); // sign of the horns + modifier
EXPECT_FALSE(IsBreak("U+1F933 | U+1F3FF")); // selfie (Unicode 9) + modifier
// Reptition of the tests above, with the knowledge that they are ligated.
// Repetition of the tests above, with the knowledge that they are ligated.
const float ligated1_2[] = {1.0, 0.0, 0.0};
const float ligated2_2[] = {1.0, 0.0, 0.0, 0.0};
EXPECT_FALSE(IsBreakWithAdvances(ligated1_2, "U+261D | U+1F3FB"));
@@ -301,7 +301,8 @@ TEST(GraphemeBreak, DISABLED_emojiModifiers) {
EXPECT_FALSE(IsBreakWithAdvances(ligated2_2, "U+1F466 | U+1F3FF"));
EXPECT_FALSE(IsBreakWithAdvances(ligated2_2, "U+1F918 | U+1F3FF"));
EXPECT_FALSE(IsBreakWithAdvances(ligated2_2, "U+1F933 | U+1F3FF"));
// Reptition of the tests above, with the knowledge that they are not ligated.
// Repetition of the tests above, with the knowledge that they are not
// ligated.
const float unligated1_2[] = {1.0, 1.0, 0.0};
const float unligated2_2[] = {1.0, 0.0, 1.0, 0.0};
EXPECT_TRUE(IsBreakWithAdvances(unligated1_2, "U+261D | U+1F3FB"));
@@ -320,11 +321,12 @@ TEST(GraphemeBreak, DISABLED_emojiModifiers) {
"U+270C U+FE0E | U+1F3FB")); // victory hand + text style + modifier
EXPECT_FALSE(
IsBreak("U+270C U+FE0F | U+1F3FB")); // heart + emoji style + modifier
// Reptition of the two tests above, with the knowledge that they are ligated.
// Repetition of the two tests above, with the knowledge that they are
// ligated.
const float ligated1_1_2[] = {1.0, 0.0, 0.0, 0.0};
EXPECT_FALSE(IsBreakWithAdvances(ligated1_1_2, "U+270C U+FE0E | U+1F3FB"));
EXPECT_FALSE(IsBreakWithAdvances(ligated1_1_2, "U+270C U+FE0F | U+1F3FB"));
// Reptition of the first two tests, with the knowledge that they are not
// Repetition of the first two tests, with the knowledge that they are not
// ligated.
const float unligated1_1_2[] = {1.0, 0.0, 1.0, 0.0};
EXPECT_TRUE(IsBreakWithAdvances(unligated1_1_2, "U+270C U+FE0E | U+1F3FB"));

2
engine/src/flutter/third_party/txt/tests/old/perftests/GraphemeBreak.cpp vendored
View File

@@ -43,7 +43,7 @@ static void BM_GraphemeBreak_Ascii(benchmark::State& state) {
}
}
BENCHMARK(BM_GraphemeBreak_Ascii)
->Arg(0) // Begining of the text.
->Arg(0) // Beginning of the text.
->Arg(1) // Middle of the text.
->Arg(12); // End of the text.

12
engine/src/flutter/third_party/txt/tests/paragraph_unittests.cc vendored
View File

@@ -283,7 +283,7 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(LeftAlignParagraph)) {
const char* text =
"This is a very long sentence to test if the text will properly wrap "
"around and go to the next line. Sometimes, short sentence. Longer "
"sentences are okay too because they are nessecary. Very short. "
"sentences are okay too because they are necessary. Very short. "
"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod "
"tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim "
"veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea "
@@ -380,7 +380,7 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(RightAlignParagraph)) {
const char* text =
"This is a very long sentence to test if the text will properly wrap "
"around and go to the next line. Sometimes, short sentence. Longer "
"sentences are okay too because they are nessecary. Very short. "
"sentences are okay too because they are necessary. Very short. "
"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod "
"tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim "
"veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea "
@@ -499,7 +499,7 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(CenterAlignParagraph)) {
const char* text =
"This is a very long sentence to test if the text will properly wrap "
"around and go to the next line. Sometimes, short sentence. Longer "
"sentences are okay too because they are nessecary. Very short. "
"sentences are okay too because they are necessary. Very short. "
"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod "
"tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim "
"veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea "
@@ -610,7 +610,7 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(JustifyAlignParagraph)) {
const char* text =
"This is a very long sentence to test if the text will properly wrap "
"around and go to the next line. Sometimes, short sentence. Longer "
"sentences are okay too because they are nessecary. Very short. "
"sentences are okay too because they are necessary. Very short. "
"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod "
"tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim "
"veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea "
@@ -1224,7 +1224,7 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(GetRectsForRangeParagraph)) {
EXPECT_FLOAT_EQ(boxes[0].rect.right(), 463.61719);
EXPECT_FLOAT_EQ(boxes[0].rect.bottom(), 118);
// TODO(garyq): The following set of vals are definetly wrong and
// TODO(garyq): The following set of vals are definitely wrong and
// end of paragraph handling needs to be fixed in a later patch.
EXPECT_FLOAT_EQ(boxes[3].rect.left(), 0);
EXPECT_FLOAT_EQ(boxes[3].rect.top(), 236.40625);
@@ -2775,7 +2775,7 @@ TEST_F(ParagraphTest, Ellipsize) {
const char* text =
"This is a very long sentence to test if the text will properly wrap "
"around and go to the next line. Sometimes, short sentence. Longer "
"sentences are okay too because they are nessecary. Very short. ";
"sentences are okay too because they are necessary. Very short. ";
auto icu_text = icu::UnicodeString::fromUTF8(text);
std::u16string u16_text(icu_text.getBuffer(),
icu_text.getBuffer() + icu_text.length());

2
engine/src/flutter/third_party/txt/third_party/fonts/NoCmapFormat14.ttx vendored
View File

@@ -144,7 +144,7 @@
<cmap_format_4 platformID="3" platEncID="10" language="0">
<map code="0x5380" name="defaultGlyph" />
</cmap_format_4>
<!-- Do not add cmap_format_14 here since this font is desinged for testing purpose. -->
<!-- Do not add cmap_format_14 here since this font is designed for testing purpose. -->
</cmap>
<loca>

2
engine/src/flutter/tools/gn
View File

@@ -86,7 +86,7 @@ def to_gn_args(args):
# Skia GN args.
gn_args['skia_enable_flutter_defines'] = True # Enable Flutter API guards in Skia.
gn_args['skia_use_dng_sdk'] = False # RAW image handling.
gn_args['skia_use_sfntly'] = False # PDF handling depedency.
gn_args['skia_use_sfntly'] = False # PDF handling dependency.
gn_args['skia_enable_pdf'] = False # PDF handling.
gn_args['skia_use_x11'] = False # Never add the X11 dependency (only takes effect on Linux).
gn_args['skia_use_expat'] = args.target_os == 'android'

2
engine/src/flutter/tools/gn_test.py
View File

@@ -27,7 +27,7 @@ class GNTestCase(unittest.TestCase):
return gn.to_gn_args(args)
def test_to_gn_args(self):
# This would not necesarily be true on a 32-bit machine?
# This would not necessarily be true on a 32-bit machine?
self.assertEquals(self._gn_args(['--ios', '--simulator'])['target_cpu'], 'x64')
self.assertEquals(self._gn_args(['--ios'])['target_cpu'], 'arm')

2
engine/src/flutter/tools/licenses/lib/main.dart
View File

@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// See README in this directory for information on how this code is organised.
// See README in this directory for information on how this code is organized.
import 'dart:async';
import 'dart:collection';