firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement on clauses (#152706)

Browse Source 
This pull request removes an `// ignore: avoid_catches_without_on_clauses` comment.

> [!NOTE]
> Diffs are super tiny if you do "hide whitespace"!
This commit is contained in:
Nate Wilson
2024-08-05 19:54:52 -06:00
committed by GitHub
parent 756aa5a258
commit 0397e890be
4 changed files with 22 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
examples/api/lib/material/autocomplete/autocomplete.3.dart
View File

@@ -132,11 +132,8 @@ _Debounceable<S, T> _debounce<S, T>(_Debounceable<S?, T> function) {
debounceTimer = _DebounceTimer();
try {
await debounceTimer!.future;
} catch (error) {
if (error is _CancelException) {
return null;
}
rethrow;
} on _CancelException {
return null;
}
return function(parameter);
};

14
examples/api/lib/material/autocomplete/autocomplete.4.dart
View File

@@ -71,14 +71,13 @@ class _AsyncAutocompleteState extends State<_AsyncAutocomplete > {
late final Iterable<String> options;
try {
options = await _FakeAPI.search(_currentQuery!, _networkEnabled);
} catch (error) {
if (error is _NetworkException) {
} on _NetworkException {
if (mounted) {
setState(() {
_networkError = true;
});
return <String>[];
}
rethrow;
return <String>[];
}
// If another search happened after this one, throw away these options.
@@ -189,11 +188,8 @@ _Debounceable<S, T> _debounce<S, T>(_Debounceable<S?, T> function) {
debounceTimer = _DebounceTimer();
try {
await debounceTimer!.future;
} catch (error) {
if (error is _CancelException) {
return null;
}
rethrow;
} on _CancelException {
return null;
}
return function(parameter);
};

7
examples/api/lib/material/search_anchor/search_anchor.4.dart
View File

@@ -139,11 +139,8 @@ _Debounceable<S, T> _debounce<S, T>(_Debounceable<S?, T> function) {
debounceTimer = _DebounceTimer();
try {
await debounceTimer!.future;
} catch (error) {
if (error is _CancelException) {
return null;
}
rethrow;
} on _CancelException {
return null;
}
return function(parameter);
};

30
packages/flutter_tools/lib/src/dart/pub.dart
View File

@@ -411,23 +411,19 @@ class _DefaultPub implements Pub {
exitCode = result.exitCode;
}
// The exception is rethrown, so don't catch only Exceptions.
} catch (exception) { // ignore: avoid_catches_without_on_clauses
if (exception is io.ProcessException) {
final StringBuffer buffer = StringBuffer('${exception.message}\n');
final String directoryExistsMessage = _fileSystem.directory(directory).existsSync()
? 'exists'
: 'does not exist';
buffer.writeln('Working directory: "$directory" ($directoryExistsMessage)');
buffer.write(_stringifyPubEnv(pubEnvironment));
throw io.ProcessException(
exception.executable,
exception.arguments,
buffer.toString(),
exception.errorCode,
);
}
rethrow;
} on io.ProcessException catch (exception) {
final StringBuffer buffer = StringBuffer('${exception.message}\n');
final String directoryExistsMessage = _fileSystem.directory(directory).existsSync()
? 'exists'
: 'does not exist';
buffer.writeln('Working directory: "$directory" ($directoryExistsMessage)');
buffer.write(_stringifyPubEnv(pubEnvironment));
throw io.ProcessException(
exception.executable,
exception.arguments,
buffer.toString(),
exception.errorCode,
);
}
final int code = exitCode;