balint1414/firka
1
0
Fork 0
forked from firka/firka
Code Pull Requests Activity

fix: null-safe percentage detection

Browse Source
This commit is contained in:
zypherift
2026-03-05 00:01:38 +01:00
committed by Armand
parent 01e7e559ba
commit f953dbd49f
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
firka/lib/core/average_helper.dart
View File

@@ -1,7 +1,7 @@
import 'package:kreta_api/kreta_api.dart';
bool _isPercentageGrade(Grade grade) {
final name = grade.valueType.name.toLowerCase();
final name = grade.valueType.name?.toLowerCase() ?? '';
return name.contains('szazalek') || name.contains('percent');
}

2
firka/lib/data/widget.dart
View File

@@ -322,7 +322,7 @@ class WidgetCacheHelper {
var sum = 0.0;
for (var grade in grades) {
final name = grade.valueType.name.toLowerCase();
final name = grade.valueType.name?.toLowerCase() ?? '';
final isPercentage =
name.contains('szazalek') || name.contains('percent');
if (isPercentage) continue;

2
firka/lib/ui/phone/widgets/grade_chart.dart
View File

@@ -33,7 +33,7 @@ class _GradeChartState extends State<GradeChart> {
double totalWeight = 0;
for (final g in grades) {
if (g.subject.uid != subjectUid) continue;
final name = g.valueType.name.toLowerCase();
final name = g.valueType.name?.toLowerCase() ?? '';
final isPercentage =
name.contains('szazalek') || name.contains('percent');
if (isPercentage) continue;

2
firka_common/lib/ui/components/grade_helpers.dart
View File

@@ -86,7 +86,7 @@ extension GradeListExtension on List<Grade> {
for (var grade in this) {
if (grade.subject.uid == subject.uid) {
final name = grade.valueType.name.toLowerCase();
final name = grade.valueType.name?.toLowerCase() ?? '';
final isPercentage =
name.contains('szazalek') || name.contains('percent');