Commit Graph

9785 Commits

Author SHA1 Message Date
Justin McCandless
ed9509697c Docs explaining how to avoid the problem of height toggling with error (#29811)
Documentation that explains a common use case seen in Github issues where users were surprised by TextFormField growth to accommodate validation messages.
2019-03-27 09:52:23 -07:00
LongCatIsLooong
673e989230 Remove unwanted gap between navigation bar and safe area's child (#29943)
Remove the additional top padding from CupertinoPageScaffold's MediaQuery when the navigation bar is opaque (as the padding was already consumed by the navigation bar).

Related Issue: #29136
2019-03-27 12:30:46 -04:00
Dwayne Slater
393521defe Allow PointerEnterEvent and PointerExitEvents to be created from any PointerEvent (#28602)
Avoids an implicit downcast + crash in MouseTracker, since the last
pointer event can be a Move or Down event, in addition to Hover.
2019-03-27 09:26:28 -07:00
rami-a
64a28e3685 Fix issue with account drawer header arrow rotating when setState is called (#29980)
The UserAccountsDrawerHeader had a bug with the arrow rotating whenever setState was called on its parent. This change makes sure that we check that the state actually changed before allowing the animation to trigger.

Fixes #25801
2019-03-27 11:19:22 -04:00
Jonah Williams
bafe7cbbb4 Watch wildcard directories in addition to asset bundle (#29883) 2019-03-26 21:40:53 -07:00
Jonah Williams
141f87b327 ensure that fe server is always built with tool (#29768) 2019-03-26 17:11:04 -07:00
Kate Lovett
204eceea93 Linking Higher & Lower Class Docs (#29758)
* Adding linking between higher and lower level classes in the API Docs. ref:#22859

* Fixed links between classes.
2019-03-26 10:05:30 -07:00
Jonah Williams
164dae3bf1 Revert "Lazy cache 4 (#29785)" (#29985) 2019-03-26 10:01:22 -07:00
Amir Hardon
f652f01890 Limit the semantic nodes ID range to 2^16 (#29928)
This PR limits the framework generated semantic node IDs to be smaller than 2^16, this allows to safely generate semantic node in the engine with IDs >= 2^16 avoiding ID collision (which is done in flutter/engine#8250).
2019-03-26 09:37:27 -07:00
Zachary Anderson
7ea7d8d003 [fuchsia] Fix flutter_tool BUILD.gn deps (#29942) 2019-03-26 08:57:40 -07:00
Jonah Williams
d71f324e48 Lazy cache 4 (#29785) 2019-03-26 08:45:29 -07:00
hyjfine
6e50ccc803 Let CupertinoTextField's clear button also call onChanged (#29474) 2019-03-26 00:26:13 -07:00
Jonah Williams
44b22c7b04 Fix cache location, artifacts, and re-enable dart2js test (#29783) 2019-03-25 18:47:37 -07:00
liyuqian
42443f6631 Remove tranparent paint hack from BackdropFilter (#29929)
We can remove the hack because https://github.com/flutter/engine/pull/8183
has been rolled into the framework.
2019-03-25 17:09:39 -07:00
Jonah Williams
9bc85d7e54 wrap Timeline calls in assert (#29861) 2019-03-25 09:42:57 -07:00
Jonah Williams
beaf7e28fa Update upgrade to reset off of hotfix branches (#29786) 2019-03-25 09:42:28 -07:00
Jonah Williams
377dfbd90d dont fail build if codegen fails (#29818) 2019-03-25 08:43:13 -07:00
Mouad Debbar
7675a6ea94 Add support for text selection via mouse to Cupertino text fields (#29769) 2019-03-22 16:04:55 -07:00
Alexandre Ardhuin
bfa1d25bf9 some formatting of map, parameters and spaces (#29760) 2019-03-23 00:02:21 +01:00
Luka Knezic
fa2fd11275 Update CupertinoTextField (#29008) 2019-03-22 11:21:06 -07:00
Abhijeeth Padarthi
475d93a172 Removes unnecessary "new" in documentation (#29779) 2019-03-21 22:59:05 -07:00
Amir Hardon
e2cd5931a7 Revert "Update upgrade to rebase and stash local changes. (#29192)" (#29780)
This reverts commit e38be671a7.
2019-03-21 20:34:07 -07:00
Jonah Williams
6701bbc528 update fuchsia-attach (#29764) 2019-03-21 16:13:04 -07:00
Jonah Williams
40cbdd11cd Use Dart version in script cache check (#29721) 2019-03-21 15:56:13 -07:00
xster
8e7e435706 Add heart shapes to CupertinoIcons (#29630) 2019-03-21 15:31:46 -07:00
Rubens de Melo
a8c1960fc2 Include brackets on OutlineButton doc (#29654) 2019-03-21 15:28:51 -07:00
Jonah Williams
e38be671a7 Update upgrade to rebase and stash local changes. (#29192) 2019-03-21 14:32:52 -07:00
Jonah Williams
fc9f7dea1a Allowing adding/updating packages during hot reload (#29747) 2019-03-21 13:59:38 -07:00
Mouad Debbar
c80366a160 Avoid flickering while dragging to select text (#29563) 2019-03-21 13:25:29 -07:00
Jonah Williams
469a859c72 Enable code generation features in tool (#29399) 2019-03-21 13:12:10 -07:00
Shayne Kelly II
db096cdfd8 Update DropdownButton underline to be customizable (#29138) 2019-03-21 10:32:43 -07:00
Christopher Fujino
a4b9ef2e79 Fix more tests for ANSI terminals (#29699)
* have tests that log error messages use a FakePlatform that does not support Ansi color, to fix tests started from color terminals
* add the override to the other tests too, in case someone copy & pastes them in the future for a test involving an error message
2019-03-21 09:11:58 -07:00
Jonah Williams
377f4451ca fix asset reloading (#29469) 2019-03-21 09:03:28 -07:00
Alexander Aprelev
12c4e050be Use source list from the compiler to track invalidated files for hot reload. (#29693)
* Use source list from the compiler to track invalidated files.

* Revert accidental change

* Fix first-time-seen-the-file logic

* Fix/simplify invalidate logic now that we can rely on compiler to let us know what is the cut-off point for invalidation.

* Update devfs mock to accommodate for new fields

* Fix deleted files case

* Analyzer found missing final
2019-03-20 21:58:15 -07:00
Dan Field
5c258366d4 Reland composite physical layers for all platforms (#29701)
* Composite physical layers even if elevation is 0
2019-03-20 17:37:47 -07:00
Anthony
bdf582fd15 [Material] Create a FloatingActionButton ThemeData and honor it within the FloatingActionButton (#28735)
Adds a FloatingActionButtonThemeData so that FABs can be themed at the Theme level and independently. The properties that are now on the theme must be defaulted at the build level, in order to respect any contributing theme properties. Because of this, some tests had to be modified to look at properties after they are built. Also, since default behaviors are now tested in the FAB Theme test, some default tests in the FAB test no longer applied and were removed.

The themable properties are:
-backgroundColor
-foregroundColor
-elevation
-disabledElevation
-highlightElevation
-shape
2019-03-20 19:43:56 -04:00
Jonah Williams
5f727126ca Download secondary SDK (#29633) 2019-03-20 15:41:45 -07:00
Jonah Williams
c72f18fcd5 Add builders and engine hash to fingerprint (#29434) 2019-03-20 15:40:37 -07:00
Alexandre Ardhuin
a6af422874 some spaces formatting (#29452)
* some space formattings

* always use blocks in if-else if a block is used

* format spaces in for and while

* allow multiline if conditions

* fix missing space
2019-03-20 23:23:31 +01:00
Marco Scannadinari
4418ec467b Adjust remaining Cupertino route animations to match native (#28597) 2019-03-20 14:53:22 -07:00
Lau Ching Jun
c33d263830 Fix typo (#29625) 2019-03-20 14:22:10 -07:00
Jonah Williams
b123846cb0 Improve flutter test startup time (#29404) 2019-03-20 13:58:57 -07:00
Shi-Hao Hong
cf12c31465 DropdownButton Icon customizability (#29572) 2019-03-20 13:38:40 -07:00
Ben Konyi
e8b98f9648 Manual engine roll for 2019-03-19 (#29627)
* Manual engine roll for 2019-03-19
* Applying patch for Dart SDK changes (see PR #29004)
2019-03-19 20:01:03 -07:00
Jonah Williams
edd4c6207a prevent stream notifications from interfering with reload (#29467) 2019-03-19 16:19:45 -07:00
Dan Field
5764aee67c Revert "Reland composite physical layers on all platforms (#29532)" (#29623)
This reverts commit 803b15e0db.
2019-03-19 15:17:05 -07:00
Shi-Hao Hong
dffbfebbf1 added friendlier error for invalid AndroidManifest.xml (#29604) 2019-03-19 14:44:22 -07:00
Phil Quitslund
8707f1f335 make literals const for @immutable constructors (#29619) 2019-03-19 14:17:37 -07:00
Hans Muller
b3046a6c67 Update progress indicator API docs (#29564) 2019-03-19 14:13:11 -07:00
Jonah Williams
f8f2b043e1 remove explicit frame schedule (#29461) 2019-03-19 10:24:55 -07:00