skia-flutter-autoroll
d2d1e39ffa
Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) ( flutter/engine#6688 )
...
https://skia.googlesource.com/skia.git/+log/68825776f4b4..ab18c8e6cc20
Created with:
gclient setdep -r src/third_party/skia@ab18c8e6cc20
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-29 14:14:57 -04:00
Amir Hardon
35836958a7
Don't populate the external view embedder in PaintContext. ( flutter/engine#6686 )
...
The platform views embedding is still WIP, and until we dynamically
merge the gpu and platform threads based on the presence of an embedded
view in the scene fetching the view embedder is not thread safe.
This PR essentially disables iOS platform views embedding, we will
re-enable once dynamic thread merging is supported.
2018-10-29 10:38:04 -07:00
skia-flutter-autoroll
4b5652a44c
Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) ( flutter/engine#6685 )
...
https://skia.googlesource.com/skia.git/+log/1de48d8040aa..68825776f4b4
Created with:
gclient setdep -r src/third_party/skia@68825776f4b4
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-29 10:49:57 -04:00
skia-flutter-autoroll
9a7ba0d289
Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) ( flutter/engine#6684 )
...
https://skia.googlesource.com/skia.git/+log/797197a772b8..1de48d8040aa
Created with:
gclient setdep -r src/third_party/skia@1de48d8040aa
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-29 07:24:01 -04:00
skia-flutter-autoroll
d5f55d7042
Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) ( flutter/engine#6683 )
...
https://skia.googlesource.com/skia.git/+log/79c96811863f..797197a772b8
Created with:
gclient setdep -r src/third_party/skia@797197a772b8
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-29 03:59:56 -04:00
skia-flutter-autoroll
08ca9d88d7
Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) ( flutter/engine#6682 )
...
https://skia.googlesource.com/skia.git/+log/38e4fd0c5654..79c96811863f
Created with:
gclient setdep -r src/third_party/skia@79c96811863f
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-29 00:35:56 -04:00
skia-flutter-autoroll
b0f8ac9e0d
Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) ( flutter/engine#6681 )
...
https://skia.googlesource.com/skia.git/+log/b53f1f46982d..38e4fd0c5654
Created with:
gclient setdep -r src/third_party/skia@38e4fd0c5654
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-28 16:20:56 -04:00
Mehmet Fidanboylu
ecd09173be
Fix inconsistent include syntax ( flutter/engine#6680 )
2018-10-28 11:40:26 -07:00
skia-flutter-autoroll
926bbab242
Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) ( flutter/engine#6679 )
...
https://skia.googlesource.com/skia.git/+log/3b79aa3a5ad0..b53f1f46982d
Created with:
gclient setdep -r src/third_party/skia@b53f1f46982d
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-28 10:47:56 -04:00
Chinmay Garde
ddd0b8887a
Handle Windows headers defining ERROR to 0 in log levels. ( flutter/engine#6677 )
2018-10-26 16:47:14 -07:00
Amir Hardon
b45990d8d5
Undefine ERROR in platform_view_layer.cc ( flutter/engine#6675 )
...
On Windows the ERROR macro is defined by some headers which breaks the
FML_LOG(ERROR).
2018-10-26 16:06:39 -07:00
Dan Field
285dab47c3
Update FlutterPlugin.h docs, suppress warning for older API ( flutter/engine#6672 )
...
* Update FlutterPlugin.h docs, suppress warning for older API
2018-10-26 14:54:33 -07:00
Amir Hardon
3c150f1c20
Attach and position embedded UIVIews ( flutter/engine#6614 )
2018-10-26 14:45:17 -07:00
Amir Hardon
3e93cdffaa
Plumb the iOS PlatformViewsController into flow. ( flutter/engine#6603 )
...
For flow to manipulate the embedded UIViews during the paint traversal
it needs some hook in PaintContext.
This PR introduces a ViewEmbeder interface that is implemented by the
iOS PlatformViewsController and plumbs it into PaintContext.
The ViewEmbedder interface is mainly a place holder at this point, as
this PR is focused on just the plumbing.
2018-10-26 14:26:59 -07:00
Dan Field
849687c1f0
iOS Embedding Refactor ( flutter/engine#6447 )
...
* Create FlutterEngine to manage a Shell to support maintaining execution state across instances of FlutterViewControllers
* Refactor PlatformViewIOS to support adding or removing a FlutterViewController dynamically
* Refactor FlutterDartHeadlessCodeRunner to implement FlutterEngine
* Refactor FlutterViewController to accept a FlutterEngine at initialization or to create one for backwards compatibility; any Shell related responsibilities are now passed through to the Engine instance
* Remove FlutterNavigationController (unused)
* Update all public Objective C doc comments to be consistent and formatable
* Add public documentation to all public headers
2018-10-26 13:00:12 -07:00
skia-flutter-autoroll
65e883a140
Roll src/third_party/skia a944142412cd..3b79aa3a5ad0 (15 commits) ( flutter/engine#6671 )
...
https://skia.googlesource.com/skia.git/+log/a944142412cd..3b79aa3a5ad0
Created with:
gclient setdep -r src/third_party/skia@3b79aa3a5ad0
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-26 15:52:56 -04:00
Mehmet Fidanboylu
98ef33a4a3
Add missing includes ( flutter/engine#6670 )
2018-10-26 10:16:56 -07:00
Stanislav Baranov
098f31c86f
Propagate pointer size from Android MotionEvent ( flutter/engine#6662 )
2018-10-26 09:39:10 -07:00
skia-flutter-autoroll
e6f570de16
Roll src/third_party/skia e2fd74b48f6f..a944142412cd (9 commits) ( flutter/engine#6669 )
...
https://skia.googlesource.com/skia.git/+log/e2fd74b48f6f..a944142412cd
Created with:
gclient setdep -r src/third_party/skia@a944142412cd
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-26 12:29:03 -04:00
skia-flutter-autoroll
0c92b6ecff
Roll src/third_party/skia 603c5da17491..e2fd74b48f6f (1 commits) ( flutter/engine#6668 )
...
https://skia.googlesource.com/skia.git/+log/603c5da17491..e2fd74b48f6f
Created with:
gclient setdep -r src/third_party/skia@e2fd74b48f6f
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-26 09:09:56 -04:00
skia-flutter-autoroll
373cb07ea3
Roll src/third_party/skia f5eaee917bb7..3f5b4ee4adfd (1 commits) ( flutter/engine#6666 )
...
https://skia.googlesource.com/skia.git/+log/f5eaee917bb7..3f5b4ee4adfd
Created with:
gclient setdep -r src/third_party/skia@3f5b4ee4adfd
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-26 01:22:56 -04:00
skia-flutter-autoroll
ed4ed64c30
Roll src/third_party/skia 2cf29ce4dbbf..f5eaee917bb7 (4 commits) ( flutter/engine#6664 )
...
https://skia.googlesource.com/skia.git/+log/2cf29ce4dbbf..f5eaee917bb7
Created with:
gclient setdep -r src/third_party/skia@f5eaee917bb7
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-25 21:58:30 -04:00
skia-flutter-autoroll
28643bb1df
Roll src/third_party/skia a2272ef92640..2cf29ce4dbbf (8 commits) ( flutter/engine#6661 )
...
https://skia.googlesource.com/skia.git/+log/a2272ef92640..2cf29ce4dbbf
Created with:
gclient setdep -r src/third_party/skia@2cf29ce4dbbf
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-25 15:55:57 -04:00
Dan Field
b089d88a94
Update contributing.md for xcode_backend refactor notes ( flutter/engine#6642 )
...
* Update contributing.md for xcode_backend refactor notes
2018-10-25 11:29:55 -07:00
skia-flutter-autoroll
08b7b9762c
Roll src/third_party/skia dfca8f6adb6b..a2272ef92640 (4 commits) ( flutter/engine#6659 )
...
https://skia.googlesource.com/skia.git/+log/dfca8f6adb6b..a2272ef92640
Created with:
gclient setdep -r src/third_party/skia@a2272ef92640
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-25 12:31:57 -04:00
Jonah Williams
d1479e8892
TextField is only a live region when it has input focus ( flutter/engine#6649 )
2018-10-25 08:37:49 -07:00
skia-flutter-autoroll
ddf6d24879
Roll src/third_party/skia 4f598e8c829a..dfca8f6adb6b (7 commits) ( flutter/engine#6658 )
...
https://skia.googlesource.com/skia.git/+log/4f598e8c829a..dfca8f6adb6b
Created with:
gclient setdep -r src/third_party/skia@dfca8f6adb6b
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-25 09:06:57 -04:00
sjindel-google
f13048235d
Add missing entry-points. ( flutter/engine#6634 )
...
* Add missing entry-points.
* Fix lint
2018-10-25 13:12:05 +02:00
Gary Qian
147c93ad54
Add/expose API for Paragraph.getBoxesForRange BoxHeightStyle and BoxWidthStyle. ( flutter/engine#6644 )
2018-10-24 15:22:32 -07:00
Amir Hardon
0373b5e512
Add an iOS PlatformViewsController for creating/disposing UIViews. ( flutter/engine#6569 )
...
Adds a FlutterPlatformViewFactory protocol - a simple factory protocol to be implemented by plugins
that exposes a UIView for embedding in Flutter apps.
* Adds a FlutterPlatformView protocol, which is used to associate a
dispose callback with a `UIView` created by a FlutterPlatformViewFactory.
* Exposes a registerViewFactory method in FlutterPluginRegistrar.
* Implements the `flutter/platform_views` system channel on iOS, allowing
Dart code to ask for creation/destruction of UIViews.
2018-10-24 15:07:05 -07:00
Dan Field
c29c7af19a
fix setter for viewOpaque ( flutter/engine#6653 )
2018-10-24 12:31:44 -07:00
skia-flutter-autoroll
600446dfef
Roll src/third_party/skia a7682c8c73e4..4f598e8c829a (8 commits) ( flutter/engine#6654 )
...
https://skia.googlesource.com/skia.git/+log/a7682c8c73e4..4f598e8c829a
Created with:
gclient setdep -r src/third_party/skia@4f598e8c829a
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-24 14:52:57 -04:00
Chinmay Garde
68887916e2
Realize kernel asset mappings on a worker thread if one is available. ( flutter/engine#6648 )
2018-10-24 11:33:46 -07:00
skia-flutter-autoroll
4f3e232de7
Roll src/third_party/skia 3b57279fd65a..a7682c8c73e4 (9 commits) ( flutter/engine#6652 )
...
https://skia.googlesource.com/skia.git/+log/3b57279fd65a..a7682c8c73e4
Created with:
gclient setdep -r src/third_party/skia@a7682c8c73e4
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-24 11:27:53 -04:00
skia-flutter-autoroll
f969398901
Roll src/third_party/skia 8429c7930291..3b57279fd65a (2 commits) ( flutter/engine#6650 )
...
https://skia.googlesource.com/skia.git/+log/8429c7930291..3b57279fd65a
Created with:
gclient setdep -r src/third_party/skia@3b57279fd65a
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-24 10:42:57 -04:00
skia-flutter-autoroll
697befd51d
Roll src/third_party/skia 3aca39df7b22..8429c7930291 (5 commits) ( flutter/engine#6647 )
...
https://skia.googlesource.com/skia.git/+log/3aca39df7b22..8429c7930291
Created with:
gclient setdep -r src/third_party/skia@8429c7930291
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-23 18:56:34 -04:00
skia-flutter-autoroll
bf65388497
Roll src/third_party/skia b46c4d0925ad..3aca39df7b22 (12 commits) ( flutter/engine#6643 )
...
https://skia.googlesource.com/skia.git/+log/b46c4d0925ad..3aca39df7b22
Created with:
gclient setdep -r src/third_party/skia@3aca39df7b22
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-23 15:31:34 -04:00
Gary Qian
a61e92e241
Support all combinations of GetRectsForRange styles ( flutter/engine#6591 )
2018-10-23 11:06:21 -07:00
Chinmay Garde
967db4ff80
Fix mac builds. Only Linux and Windows require default GL proc resolvers. ( flutter/engine#6641 )
2018-10-23 10:46:14 -07:00
James Clarke
a378ba2223
Fix Windows embedding. Appears that #6523 or #6525 introduced a bug for embedder scenarios causing the window native library to be incorrectly initialized and thus incapable of correctly resolving GL functions. This change fixes that. ( flutter/engine#6624 )
2018-10-23 09:47:53 -07:00
skia-flutter-autoroll
98d0e06b68
Roll src/third_party/skia 25837bf17019..b46c4d0925ad (6 commits) ( flutter/engine#6640 )
...
https://skia.googlesource.com/skia.git/+log/25837bf17019..b46c4d0925ad
Created with:
gclient setdep -r src/third_party/skia@b46c4d0925ad
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-23 12:05:35 -04:00
skia-flutter-autoroll
398a35938c
Roll src/third_party/skia 1b07dffd979d..25837bf17019 (1 commits) ( flutter/engine#6639 )
...
https://skia.googlesource.com/skia.git/+log/1b07dffd979d..25837bf17019
Created with:
gclient setdep -r src/third_party/skia@25837bf17019
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-23 08:40:34 -04:00
skia-flutter-autoroll
6614a5c1f1
Roll src/third_party/skia e023ae7c5540..1b07dffd979d (1 commits) ( flutter/engine#6638 )
...
https://skia.googlesource.com/skia.git/+log/e023ae7c5540..1b07dffd979d
Created with:
gclient setdep -r src/third_party/skia@1b07dffd979d
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-23 03:02:34 -04:00
skia-flutter-autoroll
e4b09a489b
Roll src/third_party/skia ff1aeb953faf..e023ae7c5540 (1 commits) ( flutter/engine#6637 )
...
https://skia.googlesource.com/skia.git/+log/ff1aeb953faf..e023ae7c5540
Created with:
gclient setdep -r src/third_party/skia@e023ae7c5540
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-22 23:38:02 -04:00
Dan Field
bf8709d7dc
Allow FlutterViewController to specify whether its FlutterView is opaque ( flutter/engine#6570 )
...
* Allow FlutterViewController to specify whether its FlutterView is opaque
2018-10-22 19:53:04 -07:00
Chinmay Garde
e52ba8b257
Ensure that Scene::toImage renders texture backed images. ( flutter/engine#6636 )
...
TL;DR: Offscreen surface is created on the render thread and device to host
transfer performed there before task completion on the UI thread.
While attempting to snapshot layer trees, the engine was attempting to use the
IO thread context. The reasoning was that this would be safe to do because any
textures uploaded to the GPU as a result of async texture upload would have
originated from this context and hence the handles would be valid in either
context. As it turns out, while the handles are valid, Skia does not support
this use-case because cross-context images transfer ownership of the image from
one context to another. So, when we made the hop from the UI thread to the IO
thread (for snapshotting), if either the UI or GPU threads released the last
reference to the texture backed image, the image would be invalid. This led to
such images being absent from the layer tree snapshot.
Simply referencing the images as they are being used on the IO thread is not
sufficient because accessing images on one context after their ownership has
already been transferred to another is not safe behavior (from Skia's
perspective, the handles are still valid in the sharegroup).
To work around these issues, it was decided that an offscreen render target
would be created on the render thread. The color attachment of this render
target could then be transferred as a cross context image to the IO thread for
the device to host tranfer.
Again, this is currently not quite possible because the only way to create
cross context images is from encoded data. Till Skia exposes the functionality
to create cross-context images from textures in one context, we do a device to
host transfer on the GPU thread. The side effect of this is that this is now
part of the frame workload (image compression, which dominate the wall time,
is still done of the IO thread).
A minor side effect of this patch is that the GPU latch needs to be waited on
before the UI thread tasks can be completed before shell initialization.
2018-10-22 17:40:24 -07:00
skia-flutter-autoroll
03ed085548
Roll src/third_party/skia 327955b1ba19..ff1aeb953faf (13 commits) ( flutter/engine#6635 )
...
https://skia.googlesource.com/skia.git/+log/327955b1ba19..ff1aeb953faf
Created with:
gclient setdep -r src/third_party/skia@ff1aeb953faf
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-22 19:04:34 -04:00
Gary Qian
0e6caa1edc
Reland 'Pass null instead of 'none' locale' ( flutter/engine#6632 )
2018-10-22 15:21:04 -07:00
skia-flutter-autoroll
a74ef142fe
Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) ( flutter/engine#6631 )
...
https://skia.googlesource.com/skia.git/+log/b1a002e850e1..327955b1ba19
Created with:
gclient setdep -r src/third_party/skia@327955b1ba19
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-22 15:39:43 -04:00
Matthew Smith
437e15e3f5
13771 - iOS dictation bug ( flutter/engine#6607 )
...
According to the iOS docs, implementing
`- (id)insertDictationResultPlaceholder`
```Implementation of this method is optional but can be done when you want to provide a specific rectangle for the placeholder animation while the dictation results are being processed. ```
If you do not implement this method, UIKit will insert a default placeholder of 10 whitespace characters. By overriding this, no placeholder text will be inserted. If you implement the `insertDictationResultPlaceholder`, you must implement
`- (void)removeDictationResultPlaceholder:(id)placeholder willInsertResult:(BOOL)willInsertResult`
2018-10-22 10:28:39 -07:00
