zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity
32,242 Commits 2 Branches 0 Tags
bb2bf2d17623d011bef17737487a0f7deb8ef01a
Commit Graph

24457 Commits

Author SHA1 Message Date
skia-flutter-autoroll
3785908d82 Roll Skia from 90658830b8ce to 47c408712efd (1 revision) (flutter/engine#47221) 
https://skia.googlesource.com/skia.git/+log/90658830b8ce..47c408712efd

2023-10-23 johnstiles@google.com Fix fuzzer-discovered assertion with atomic arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 15:14:59 +00:00
skia-flutter-autoroll
41efbaeb1b Roll Skia from bce627e38d25 to 90658830b8ce (3 revisions) (flutter/engine#47220) 
https://skia.googlesource.com/skia.git/+log/bce627e38d25..90658830b8ce

2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 4ebfec0b5f53 to d01276172017 (7 revisions)
2023-10-23 ccameron@chromium.org SkCodec: Consolidate Tiff parsing functions
2023-10-23 egdaniel@google.com Reland "When waiting on client provided semaphores, only block fragment stage work."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 14:29:39 +00:00
skia-flutter-autoroll
1491dfc214 Roll Skia from a0515f94dfee to 3f7302e44c94 (3 revisions) (flutter/engine#47214) 
https://skia.googlesource.com/skia.git/+log/a0515f94dfee..3f7302e44c94

2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7923feb1aa82 to 1d90f548f72f
2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 68aac47724f2 to e7c82ebc0260 (15 revisions)
2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from acdd164d51ed to 7923feb1aa82 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 06:10:00 +00:00
skia-flutter-autoroll
99d3c2488f Roll Fuchsia Linux SDK from 00DU5P-zlAl6661kG... to V4q-PLgyTbkCdf8Zo... (flutter/engine#47202) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-22 14:16:11 +00:00
skia-flutter-autoroll
15a28705f7 Roll Fuchsia Linux SDK from 2vdBWAlJ_jVZXn8sK... to 00DU5P-zlAl6661kG... (flutter/engine#47198) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-22 01:30:41 +00:00
skia-flutter-autoroll
c5f6bb1de3 Roll Fuchsia Linux SDK from vlmJ760j9c7Ng4Psy... to 2vdBWAlJ_jVZXn8sK... (flutter/engine#47196) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-21 12:40:04 +00:00
Jonah Williams
afe55da595 [Impeller] Fix cmd pool reset from background thread. (flutter/engine#47184) 
Make sure to clear the buffers before assigning to the recycler, as the dtor was racing with the raster thread usage.
 2023-10-21 00:19:24 +00:00
skia-flutter-autoroll
a6be8601ec Roll Fuchsia Linux SDK from tcVA-iW-vOHPnwh_P... to vlmJ760j9c7Ng4Psy... (flutter/engine#47181) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 23:52:35 +00:00
gaaclarke
2cb41967e7 [Impeller] increased padding for blurs (flutter/engine#47176) 
fixes https://github.com/flutter/flutter/issues/119974

This duplicates the math found in skia at
https://skia.googlesource.com/skia/+/cf2131f85d57f938472e50b6643c3c2348709a55/gm/blurrect.cpp#484

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-20 16:40:06 -07:00
skia-flutter-autoroll
9d7b5e8bb9 Roll Skia from ca69b04f7dd2 to cf2131f85d57 (2 revisions) (flutter/engine#47173) 
https://skia.googlesource.com/skia.git/+log/ca69b04f7dd2..cf2131f85d57

2023-10-20 nicolettep@google.com [graphite] Add transfer dst buffer usage flag for gpu-only buffers
2023-10-20 jvanverth@google.com [graphite] Don't try to draw empty paths.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 21:21:42 +00:00
auto-submit[bot]
47c3403c39 Reverts "Multiview pipeline" (flutter/engine#47174) 
Reverts flutter/engine#44473
Initiated by: dkwingsmt
This change reverts the following previous change:
Original Description:
This PR makes `Animator` able to handle multiple views, and updates unit tests accordingly.

Before:
<img width="543" alt="image" src="https://github.com/flutter/engine/assets/1596656/f7d0e0e4-cc85-4a6e-b516-1896ac3c1b35">

After:
<img width="614" alt="image" src="https://github.com/flutter/engine/assets/1596656/68106301-66ef-4cd1-aeaf-d9c6127ccec2">

Now `Animator::Render` must be called during `Animator::BeginFrame`, which is split into `BeginFrame` and `EndFrame`. This requirement is made possible by https://github.com/flutter/engine/pull/45555. The reason to split is to allow `ShellTest::PumpOneFrame` to insert a render from C++ code.

`ShellTest::PumpOneFrame` is also refactored to allow pumping a frame without any views.

A few unit tests are tweaked to resolve racing condition.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-20 20:57:08 +00:00
Tong Mu
1cfde62821 Multiview pipeline (flutter/engine#44473) 
This PR makes `Animator` able to handle multiple views, and updates unit tests accordingly.

Before:
<img width="543" alt="image" src="https://github.com/flutter/engine/assets/1596656/f7d0e0e4-cc85-4a6e-b516-1896ac3c1b35">

After:
<img width="614" alt="image" src="https://github.com/flutter/engine/assets/1596656/68106301-66ef-4cd1-aeaf-d9c6127ccec2">

Now `Animator::Render` must be called during `Animator::BeginFrame`, which is split into `BeginFrame` and `EndFrame`. This requirement is made possible by https://github.com/flutter/engine/pull/45555. The reason to split is to allow `ShellTest::PumpOneFrame` to insert a render from C++ code.

`ShellTest::PumpOneFrame` is also refactored to allow pumping a frame without any views.

A few unit tests are tweaked to resolve racing condition.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-20 20:38:23 +00:00
skia-flutter-autoroll
1109abdf2e Roll Skia from 9ffd5ef9a9ed to ca69b04f7dd2 (1 revision) (flutter/engine#47171) 
https://skia.googlesource.com/skia.git/+log/9ffd5ef9a9ed..ca69b04f7dd2

2023-10-20 johnstiles@google.com Fix fuzzer-discovered assertion with WGSL interface-block arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 20:22:28 +00:00
John McCutchan
5f0a787cdf Lower the severity of a log message (flutter/engine#47172) 
This log message can print on the first frame of a platform view and is
not an error.
 2023-10-20 13:11:59 -07:00
Mouad Debbar
e55aecc152 [web] Remove workaround for safely removing slots on Safari (flutter/engine#47169) 
Now that we want to support multi-view, we need to either:
1. Remove the workaround to safely remove slot elements in Safari, or
2. Fix it to support multi-view (can't use `flutterViewEmbedder.glassPaneShadow` anymore).

According to [this comment](https://github.com/flutter/flutter/issues/85816#issuecomment-1122638147), this is the right time to remove the workaround 😄 I tested on Desktop Safari and iOS Safari and wasn't able to reproduce the crash reported in https://github.com/flutter/flutter/issues/84832.

Fixes https://github.com/flutter/flutter/issues/85816
Part of https://github.com/flutter/flutter/issues/134443
 2023-10-20 19:51:22 +00:00
chunhtai
bcbf0887b9 Add link support in web accessibility (flutter/engine#46117) 
fixes https://github.com/flutter/flutter/issues/134795

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-20 12:20:08 -07:00
Mouad Debbar
92eac4f833 [web] Support flutterViewId in platform view messages (flutter/engine#46891) 
- Accept a new `flutterViewId` field in platform view messages.
- Keep transitory support for legacy platform view messages that don't contain `flutterViewId`.
- Default view factories set `width:100%` and `height:100%`.
 2023-10-20 19:17:36 +00:00
Jackson Gardner
38b42c9f14 Fix async image loading issues in skwasm. (flutter/engine#47117) 
This fixes https://github.com/flutter/flutter/issues/134045

There were a few different issues here:
* We need to do our own message passing for rendering pictures. The async methods provided by emscripten have their own queue that can drain synchronously, so basically it's not guaranteed to be FIFO with other messages sent to the web worker or main thread.
* When we drop frames, we should only drop intermediate frames, so that when the rendering flurry stops that the frame that is displayed is the last one that was actually requested.
* We need to reset the GL context after lazy image creation, otherwise skia's renderer gets into a bad state for that frame.
 2023-10-20 18:30:33 +00:00
Jim Graham
076895a3e6 Add option to save Impeller failure images in rendertests (flutter/engine#47142) 
The rendering tests currently always save the impeller failure images into a temporary directory in /tmp which is out of the way and might accumulate over time.

The images are now only saved when `--save-impeller-failures` is specified on the command line and they are now saved into a local sub-directory with multiple runs saving into new sub-directories to keep the failure images from getting confused with each other over time. The new image directories are named `./impeller_failure_images/NNNN/*.png`
 2023-10-20 18:27:19 +00:00
skia-flutter-autoroll
ea20e39ff4 Roll Skia from b960e9140f56 to 9ffd5ef9a9ed (3 revisions) (flutter/engine#47167) 
https://skia.googlesource.com/skia.git/+log/b960e9140f56..9ffd5ef9a9ed

2023-10-20 lehoangquyen@chromium.org GraphiteDawn: don't set active render encoder if BlitWithDraw fails.
2023-10-20 briansalomon@gmail.com [graphite] Make RecorderOptions::kDefaultRecorderBudget a static member
2023-10-20 johnstiles@google.com Remove staging flag SK_IMPROVE_RASTER_PIPELINE_PRECISION.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 17:57:18 +00:00
Chris Bracken
acdd5bb936 [macOS] Eliminate extraneous loadView calls (flutter/engine#47166) 
Eliminate unnecessary calls to [NSViewController loadView]. To quote the [documentation][loadview] for this method: "Do not call this method. If you require this method to be called, access the view property."

In several of the existing tests, we do read viewController.view, and the other tests pass without this line regardless.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-20 17:30:16 +00:00
skia-flutter-autoroll
698ad78ecd Roll Dart SDK from ba96a157a8eb to 53fee35b299f (1 revision) (flutter/engine#47165) 
https://dart.googlesource.com/sdk.git/+log/ba96a157a8eb..53fee35b299f

2023-10-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-48.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 17:26:15 +00:00
Jonah Williams
8031a09e17 [Impeller] GPU Tracer for GLES. (flutter/engine#47080) 
Trace GPU execution time on GLES using GL_EXT_disjoint_timer_query. This requires a per-app opt in from the Android Manifest with the key `"io.flutter.embedding.android.EnableOpenGLGPUTracing` set to true.
 2023-10-20 17:20:43 +00:00
skia-flutter-autoroll
3d9bc06e13 Roll Skia from de628929015d to b960e9140f56 (2 revisions) (flutter/engine#47164) 
https://skia.googlesource.com/skia.git/+log/de628929015d..b960e9140f56

2023-10-20 armansito@google.com Add Graphite Vello Test jobs to CQ
2023-10-20 herb@google.com Add point_less_than_segment_in_x

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 17:12:17 +00:00
skia-flutter-autoroll
7c32d09946 Roll Skia from 461218cee44c to de628929015d (1 revision) (flutter/engine#47161) 
https://skia.googlesource.com/skia.git/+log/461218cee44c..de628929015d

2023-10-20 lehoangquyen@chromium.org GraphiteDawn: return error when BlitWithDrawn pipeline creation fails.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 16:31:19 +00:00
Mouad Debbar
b743fa9f2e [web] Make HotRestartCacheHandler standalone (flutter/engine#46906) 
- `EmbeddingStrategy` shouldn't own the creation of `HotRestartCacheHandler`.
- Simplify `HotRestartCacheHandler`'s JS-interop by using a `JSArray` directly instead of going through a Dart `List`.
 2023-10-20 16:05:14 +00:00
Mouad Debbar
d11e7434ff [web] Attach pointer event listeners in the bubble phase (flutter/engine#47121) 
There's no reason (that we know of) to listen to pointer events during the capture phase, so let's listen on the bubble phase.

I couldn't find a reason for listening to pointer events during the capture phase. So let's listen on the bubble phase which is more natural and allows platform views to `stopPropagation` in order to prevent Flutter from receiving an event.
 2023-10-20 16:03:15 +00:00
skia-flutter-autoroll
01e977bdb9 Roll Skia from 04a9f72abd87 to 461218cee44c (1 revision) (flutter/engine#47160) 
https://skia.googlesource.com/skia.git/+log/04a9f72abd87..461218cee44c

2023-10-20 egdaniel@google.com Add swiftshader workaround to resolve full MSAA image in dmsaa RenderPass.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 15:47:15 +00:00
skia-flutter-autoroll
0f03937049 Roll Skia from 24abc105675c to 04a9f72abd87 (1 revision) (flutter/engine#47159) 
https://skia.googlesource.com/skia.git/+log/24abc105675c..04a9f72abd87

2023-10-20 johnstiles@google.com Fix ClangTidy `performance-unnecessary-value-param` findings.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 15:06:27 +00:00
skia-flutter-autoroll
588d90e2b1 Roll Skia from e836c3aa2b98 to 24abc105675c (1 revision) (flutter/engine#47156) 
https://skia.googlesource.com/skia.git/+log/e836c3aa2b98..24abc105675c

2023-10-20 michaelludwig@google.com Revert "Re-enable invsqrt usage for normalize() in SkRP."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 14:21:14 +00:00
skia-flutter-autoroll
2c0dd1e18a Roll Skia from 17f05db514c3 to e836c3aa2b98 (1 revision) (flutter/engine#47154) 
https://skia.googlesource.com/skia.git/+log/17f05db514c3..e836c3aa2b98

2023-10-20 kjlubick@google.com Move font/typeface related functions out of ToolUtils.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 12:26:17 +00:00
skia-flutter-autoroll
d0de142f4f Roll Skia from 5291f485514f to 17f05db514c3 (4 revisions) (flutter/engine#47151) 
https://skia.googlesource.com/skia.git/+log/5291f485514f..17f05db514c3

2023-10-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bc2808e733a8 to e244f69ab982 (11 revisions)
2023-10-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 889b01efcbf6 to d2de74510c4f (10 revisions)
2023-10-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 37332ece3fb7 to acdd164d51ed (5 revisions)
2023-10-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 4759145c009e to 68aac47724f2 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 11:25:16 +00:00
skia-flutter-autoroll
dec5070219 Roll Fuchsia Linux SDK from eKYGl_wBcnT-n0J8n... to tcVA-iW-vOHPnwh_P... (flutter/engine#47149) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 11:09:20 +00:00
skia-flutter-autoroll
13f6054fc4 Roll Skia from 1d63da5da8e8 to 5291f485514f (3 revisions) (flutter/engine#47143) 
https://skia.googlesource.com/skia.git/+log/1d63da5da8e8..5291f485514f

2023-10-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 37332ece3fb7 to 8a3b2b2a289e
2023-10-20 michaelludwig@google.com Define initial draft of SkBlurEngine API
2023-10-20 johnstiles@google.com Re-enable invsqrt usage for normalize() in SkRP.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 10:34:31 +00:00
skia-flutter-autoroll
82347cbf32 Roll Dart SDK from f71ddbe0a500 to aadeeb497dbe (1 revision) (flutter/engine#47141) 
https://dart.googlesource.com/sdk.git/+log/f71ddbe0a500..aadeeb497dbe

2023-10-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-46.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 04:38:24 +00:00
Matan Lurey
3d54f07596 Remove unused fbo parameter in GLES SetAsFramebufferAttachment(). (flutter/engine#47133) 
Trivial change that removes an unused parameter.
 2023-10-19 22:46:13 +00:00
skia-flutter-autoroll
308a6be420 Roll Skia from b540ed3ba8e7 to e5c37860c792 (2 revisions) (flutter/engine#47126) 
https://skia.googlesource.com/skia.git/+log/b540ed3ba8e7..e5c37860c792

2023-10-19 kjlubick@google.com Remove refTypefaceOrDefault and getTypefaceOrDefault from SkFont API
2023-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3d986ea7a169 to bc2808e733a8 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 22:14:31 +00:00
Chris Bracken
2eae74883a [macOS] Fail early when no a11y notification (flutter/engine#47129) 
In the SendsAccessibilityCreateNotificationToWindowOfFlutterView test in AccessibilityBridgeMacTest, we look for an accessibility notification by name in a map stored in the test accessibility bridge. If there is no such notification, bail out immediately.

Previously we got a crash since we called `second` to retrieve the value associated with the map entry we find, without actually checking that we'd actually found an entry.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-19 21:52:20 +00:00
skia-flutter-autoroll
ab1cafa36c Roll Fuchsia Linux SDK from Z2mOZ5cuPJWvKn22P... to eKYGl_wBcnT-n0J8n... (flutter/engine#47128) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 21:44:16 +00:00
Tong Mu
dfc7b21ade Reland 2 (part 2): Enforce the rule of calling FlutterView.Render (flutter/engine#47095) 
This PR relands part of https://github.com/flutter/engine/pull/45300, which was reverted in https://github.com/flutter/engine/pull/46919 due to performance regression.

Due to how little and trivial production code the original PR touches, I really couldn't figure out the exact line that caused it except through experimentation, which requires changes to be officially landed on the main branch. After this PR lands, I'll immediately fire a performance test.

This PR contains the render rule check performed by `PlatformDispatcher` of the original PR, the remaining changes to production code besides [the part 1](https://github.com/flutter/engine/pull/47062). Since part 1 shows no regression, the changes of this PR is highly likely to be the culprit. Therefore I made some changes: The rule enforcement is no longer performed in release mode, but only in debug mode. This will cause behavior deviation between builds, but since the developer should be able to notice violation in debug mode anyway, I think this design is acceptable.

It is intentional to not contain any unit tests or other changes of the original PR. They will be landed shortly after this PR.

Part of https://github.com/flutter/flutter/issues/136826.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-19 21:31:14 +00:00
Jason Simmons
fa02835346 [Impeller] Use a weak pointer factory in GPUSurfaceGLImpeller that supports the raster thread merger (flutter/engine#47081) 
This is required for platform view scenarios that merge the raster task runner into the platform thread.
 2023-10-19 20:22:04 +00:00
skia-flutter-autoroll
448d15dd85 Roll Dart SDK from ea86103e06b1 to f71ddbe0a500 (1 revision) (flutter/engine#47124) 
https://dart.googlesource.com/sdk.git/+log/ea86103e06b1..f71ddbe0a500

2023-10-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-45.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 19:57:23 +00:00
skia-flutter-autoroll
9844d5c903 Roll Skia from 04449cda5a0a to b540ed3ba8e7 (4 revisions) (flutter/engine#47118) 
https://skia.googlesource.com/skia.git/+log/04449cda5a0a..b540ed3ba8e7

2023-10-19 kjlubick@google.com Add index.d.ts to debugger and jsfiddle images
2023-10-19 kjlubick@google.com Fix IWYU
2023-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 7317f665cc52 to 4759145c009e (8 revisions)
2023-10-19 johnstiles@google.com Fix ClangTidy `performance-unnecessary-value-param` findings.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 19:14:13 +00:00
Jia Hao
0e87f9611e Fix use of nested designators (flutter/engine#45869) 
There was an internal global change which turned `-Wc99-designator`. This causes the following error:

```
error: nested designators are a C99 extension [-Werror,-Wc99-designator]
   65 |       .metal.struct_size = sizeof(FlutterMetalRendererConfig),
      |       ^~~~~~~~~~~~~~~~~~
```

This seems like a trivial (?) fix, so perhaps we can fix it properly and possibly remove b9fbd310d6/build/config/compiler/BUILD.gn (L667) after this PR lands.

*List which issues are fixed by this PR. You must list at least one issue.*

b/300573112

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-19 18:37:32 +00:00
Chris Yang
e559ceb0ac [iOS] Load additional Cupertino system fonts (flutter/engine#46857) 
Manually loads darwin system fonts. Darwin system fonts returns different typeface in different sizes. This PR loads the font in different sizes then register them as different fonts. These new fonts can be access through the framework.

Fixes https://github.com/flutter/flutter/issues/63507

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-19 17:52:31 +00:00
Jia Hao
ff7829558f Add missing import (flutter/engine#47083) 
Fixes the following:

c8aa0844f2 results in the following error appearing internally when compiling for Android:

```
In file included from fml/synchronization/sync_switch.cc:5:
./fml/synchronization/sync_switch.h:74:34: error: implicit instantiation of undefined template 'std::vector<fml::SyncSwitch::Observer *>'
  mutable std::vector<Observer*> observers_;
                                 ^
<...>: note: template is declared here
class _LIBCPP_TEMPLATE_VIS vector;
                           ^
1 error generated.
```

*List which issues are fixed by this PR. You must list at least one issue.*
b/306266542

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-19 16:47:20 +00:00
skia-flutter-autoroll
cd7298b69d Roll Skia from b31b189be018 to 04449cda5a0a (1 revision) (flutter/engine#47105) 
https://skia.googlesource.com/skia.git/+log/b31b189be018..04449cda5a0a

2023-10-19 kjlubick@google.com Remove SkTypeface::UniqueID

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 16:17:24 +00:00
skia-flutter-autoroll
5dda282b51 Roll Dart SDK from 1b425a25a6dd to ea86103e06b1 (1 revision) (flutter/engine#47101) 
https://dart.googlesource.com/sdk.git/+log/1b425a25a6dd..ea86103e06b1

2023-10-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-44.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 13:38:25 +00:00
Jim Graham
5bcbd59138 Revert "[web] Ensure handled key event is not propagated to IME" (flutter/engine#47086) 
Reverts flutter/engine#46829

Fixes https://github.com/flutter/flutter/issues/136857

Speculative fix for The builds breaking on the web text tests as seen
here: https://github.com/flutter/flutter/runs/17840697842
 2023-10-19 09:40:27 +03:00
skia-flutter-autoroll
8a98010f73 Roll Fuchsia Linux SDK from 2HSBpWikGWvPJlHOP... to Z2mOZ5cuPJWvKn22P... (flutter/engine#47094) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 06:16:00 +00:00